31 Commits

Author SHA1 Message Date
Samuel Sledzieski
1bed6a048a Claude/expand test coverage (#91)
* Expand test coverage with comprehensive test suites

Add extensive test coverage for previously untested modules:

- test_utils.py: Comprehensive tests for utility functions (setup_logger, log, RBF,
  parse_device, load_hdf5_parallel, PairedDataset, collate_paired_sequences)

- test_glider.py: Complete test suite for graph-based link prediction module
  (get_dim, densify, compute_X_normalized, scoring functions, GLIDE algorithms)

- test_loading.py: Tests for parallel HDF5 data loading with LoadingPool,
  including edge cases, error handling, and integration tests

- test_language_model.py: Expanded from 2 to 13 test methods, adding coverage
  for lm_embed, embed_from_fasta with various edge cases and validations

These additions significantly improve test coverage for:
- dscript/utils.py (167 lines, previously untested)
- dscript/glider.py (346 lines, previously untested)
- dscript/loading.py (92 lines, previously untested)
- dscript/language_model.py (minimal coverage expanded)

Total new test methods: ~200+ assertions across 4 test modules

* Add comprehensive tests for command modules and worker functions

Create four new test modules to expand coverage of previously untested code:

1. test_extract_3di.py (19 test methods, ~370 lines)
   - Tests for 3Di sequence extraction from PDB/CIF files
   - Argument parsing, file filtering, FASTA output validation
   - Integration tests for full workflow
   - Covers dscript/commands/extract_3di.py (~58 lines)

2. test_par_writer.py (24 test methods, ~400 lines)
   - Tests for parallel prediction writer process
   - TSV output writing, threshold filtering, contact map storage
   - HDF5 contact map dataset handling
   - Progress tracking and data type validation
   - Covers dscript/commands/par_writer.py (~40 lines)

3. test_main.py (24 test methods, ~320 lines)
   - Tests for CLI entry point and argument parsing
   - CitationAction class testing
   - All subcommand registration and invocation
   - Version and help flag handling
   - Integration tests for command dispatch
   - Covers dscript/__main__.py (~87 lines, increasing from ~85% to ~95%)

4. test_load_worker.py (23 test methods, ~330 lines)
   - Direct unit tests for HDF5 loading worker function
   - Queue handling, data type conversion, memory sharing
   - Error handling for corrupted/missing files
   - Multi-dimensional array support
   - Covers dscript/load_worker.py (~25 lines, previously only indirect coverage)

Total additions:
- ~1,420 lines of new test code
- 90+ test methods with comprehensive assertions
- ~210 lines of source code now directly tested
- Addresses high-priority gaps identified in coverage analysis

These tests complement the existing suite and focus on command-line
interface components and parallel processing infrastructure.

* Fix linting issues and apply code formatting

- Remove unused variables flagged by ruff
- Apply ruff formatting to all test files
- Ensure all pre-commit hooks pass

Changes:
- test_loading.py: Remove unused 'f' variable
- test_main.py: Remove unused 'fake_out' and 'output' variables
- test_utils.py: Remove unused 'log_file' variable and tmp_path param
- Applied ruff formatting to maintain code style consistency

* Fix test_load_worker.py hanging issue in CI

Rewrote test_load_worker.py to prevent CI hangs that occurred when
tests called the blocking worker function directly. The worker function
_hdf5_load_partial_func runs in an infinite loop waiting on a queue,
which caused tests to hang indefinitely.

Changes:
- Created run_worker_with_timeout() helper that wraps worker execution
  in a daemon thread with configurable timeout (default 5 seconds)
- Modified all tests to use this helper and assert successful completion
- Changed queue operations from blocking get() to non-blocking get_nowait()
- Reduced test count from 23 to 16 focused tests
- Added documentation noting worker is primarily tested via LoadingPool

This should resolve the CI timeout issue where tests hung at 43% completion.

* Rewrite test_language_model.py to use mocks instead of real model

The original tests were calling the real language model which:
- Downloads/loads pretrained model weights (slow, can fail)
- Runs actual neural network inference (resource intensive)
- Causes test failures when model files aren't available

Changes:
- Rewrote unit tests to mock get_pretrained() function
- Mock model returns realistic tensor shapes but doesn't load weights
- Tests are now fast, reliable, and don't require model files
- Moved real model tests to TestLanguageModelIntegration class
- Marked integration tests with @pytest.mark.slow so they can be skipped
- Removed unnecessary loguru import that caused import errors
- Removed problematic setup.py install step from setup_class

This should fix the 4 failing tests reported by CI.

* fix failing tests

* Update .github/workflows/autorun-tests.yml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update .github/workflows/autorun-tests.yml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-12-16 10:24:04 -05:00
Samuel Sledzieski
fa467edd40 formatting and cleaning device code 2025-07-22 10:00:20 -04:00
Daniel E. Schaffer
92f1582719 Extend CPU support to bipartite 2025-07-21 19:28:52 -04:00
Samuel Sledzieski
50f3d9750e ruff formatting and linting 2025-07-21 15:09:08 -04:00
Samuel Sledzieski
faad88d684 Merge branch 'main' into parallel 2025-07-21 14:52:13 -04:00
Samuel Sledzieski
e80af9d123 formatting 2025-07-21 14:44:37 -04:00
Samuel Sledzieski
f4bfcd824f migrate to loguru while maintaining lecacy interface 2025-07-21 14:31:12 -04:00
Samuel Sledzieski
8cbf288b86 massively increase test coverage and continuous integration 2025-07-21 14:21:48 -04:00
Daniel E. Schaffer
c1caa49094 Further change loading behavior to default to returning a list 2025-04-24 00:16:25 -04:00
Daniel E. Schaffer
d3ef9503ee Revise embedding loading to allow the calling process more control 2025-04-23 19:39:58 -04:00
Daniel E. Schaffer
58bcf9f7d2 Add parallel multiprocess inference 2025-02-23 21:48:12 -05:00
Daniel E. Schaffer
bb2ccb0b02 Switch to torch.mp 2025-02-20 13:35:19 -05:00
Daniel E. Schaffer
91a90c8d90 IO-efficient loading 2025-02-20 13:30:34 -05:00
samsledje
e148390f7f load embeddings in parallel 2022-06-23 16:06:22 -04:00
samsledje
1b63b008fd testing embed, evaluate, predict 2022-06-23 11:58:23 -04:00
samsledje
a82dd7d6b8 code style updated with black 2022-02-08 12:00:11 -05:00
samsledje
8afe6f1959 updated main and cleaned utils 2022-02-02 11:34:02 -05:00
samsledje
45d693bc2d updated docstrings from legacy code 2021-12-07 12:18:38 -05:00
samsledje
df4e1bf729 0.1.7-dev7 -- training fixed but code extremely messy 2021-12-07 11:46:13 -05:00
Samuel Sledzieski
894edfeaa5 fixed logging code to flush file and to not write # at beginning 2021-02-17 10:23:25 -05:00
Samuel Sledzieski
6918c98239 added logging functionality and use it to report skips in predict.py 2021-02-17 10:02:08 -05:00
Sam Sledzieski
27c029bd4f Documentation version 1 2020-11-16 21:53:26 -05:00
Samuel Sledzieski
4e4083b530 black code formatting 2020-11-16 18:54:37 -05:00
Sam Sledzieski
0e912f5dd0 Clean docs 2020-11-16 18:26:57 -05:00
Sam Sledzieski
38354c1127 Merge branch 'main' of https://github.com/samsledje/D-SCRIPT into main 2020-11-16 17:40:15 -05:00
Sam Sledzieski
499497adc7 Saving documentation progress 2020-11-16 17:39:59 -05:00
Samuel Sledzieski
6112a0c59a redirect github sites to docs 2020-11-16 14:38:07 -05:00
Samuel Sledzieski
9d2dd08289 updated api docs 2020-11-16 11:26:50 -05:00
Samuel Sledzieski
dbeb17bacb cleaned up old functions 2020-11-16 11:00:50 -05:00
Samuel Sledzieski
1cfeb6f0a3 updated data loading in train and reformatted everything 2020-11-09 15:37:11 -05:00
Samuel Sledzieski
a97f232db2 restructured so dscript is a module and can be installed 2020-11-09 15:21:37 -05:00