mirror of
https://github.com/Tencent/WeKnora.git
synced 2026-06-04 21:34:31 +08:00
733bb3aaa1
Re-introduce the agent-first symmetric envelope deleted in commite623e820(2026-05-15). Under the v0.7 constraint that AI agents are primary consumers, the bare-JSON shape can't carry protocol channels (_notice / risk / meta / request_id / profile) that agents need. Errors-on-stderr and typed exit codes frome623e820are preserved; the envelope wraps the success/error payloads on top. - cli/internal/output/envelope.go (new): Envelope / ErrorEnvelope / Meta / ErrDetail / RiskDetail structs; WriteEnvelope + WriteErrorEnvelope writers; PendingNotice plumbing for the open-map _notice channel (reserved infra; producer wiring planned for v0.8). - cli/internal/output/envelope_test.go (new): 7 tests covering success / error / TTY indent / Notice / Risk shapes. - cmdutil.Error extended with RetryCommand (directly-executable argv distinct from prose Hint), RetryAfterSeconds (HTTP Retry-After), *RiskInfo (nested level+action; ErrInternalServer- vs-NotFound distinction), Detail (open structured payload), Silent (suppress stderr emit while preserving Code for ExitCode). - ErrorToDetail single source of envelope.error construction; reused by stderr PrintError, MCP StructuredContent, and batch per-item error path. - WithHint / WithRetryCommand / WithRetryAfter / WithDetail / WithRisk builders. IsCancelled helper. AsError unwrap helper. - defaultHint covers ~21 codes; defaultRetryCommand symmetric counterpart for 6 keyway codes. DefaultHint / DefaultRetryCommand exported wrappers for cross-package callers. - ClassifyHTTPError tightened: rescues HTTP 500 with structured server-side code 1003 (ErrNotFound) into resource.not_found. Server's generic 1007 (ErrInternalServer) bucket stays as server.error — including it would mis-route validation failures (e.g. SQLSTATE 22001) as not-found. - PrintError dual-mode: text/human → prose with code:msg / hint / retry lines; json/ndjson → envelope on stderr. Mode pinned by root PersistentPreRunE via SetFormatMode. resolveFormatEarly() scans argv before cobra dispatch so cobra-side validators (unknown flag, arg-count) still surface as envelope when --format json is in effect. Silent typed errors short-circuit the stderr emit. FlagError mapped to input.invalid_argument for the envelope (exit code stays 2 via FlagError class). - Unknown-subcommand guard installed recursively at the root: parents with subcommands but no Run/RunE get a typed RunE that emits input.unknown_subcommand envelope with detail.{unknown, command_path, available[]} and retry_command "<parent> --help". cobra.ArbitraryArgs bypasses legacyArgs validation so the guard receives unmatched argv. - cmdutil.Error.Error() returns "<code>: <message>[: <cause>]" for chain debugging; ErrorToDetail strips the code prefix from envelope.message since the separate type field carries it (prevents the doubled-prefix "code: code: ..." that agents would see). Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §0 / §4
55 lines
1.6 KiB
Go
55 lines
1.6 KiB
Go
package cmd
|
|
|
|
import (
|
|
"bytes"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
)
|
|
|
|
// TestAgentInvoke_NowReturnsUnknownSubcommand verifies the deleted v0.6
|
|
// command emits a typed envelope rather than cobra's free-form exit-2 prose.
|
|
func TestAgentInvoke_NowReturnsUnknownSubcommand(t *testing.T) {
|
|
root := NewRootCmd(cmdutil.New())
|
|
root.SetArgs([]string{"agent", "invoke", "ag_x", "q"})
|
|
root.SetOut(&bytes.Buffer{})
|
|
root.SetErr(&bytes.Buffer{})
|
|
err := root.Execute()
|
|
ce := cmdutil.AsError(err)
|
|
if ce == nil || ce.Code != cmdutil.CodeInputUnknownSubcommand {
|
|
t.Errorf("expected CodeInputUnknownSubcommand, got %v", err)
|
|
}
|
|
}
|
|
|
|
func TestUnknownSubcommand_EmitsTypedEnvelope(t *testing.T) {
|
|
t.Cleanup(func() { cmdutil.SetFormatMode("") })
|
|
|
|
root := NewRootCmd(cmdutil.New())
|
|
var stderr bytes.Buffer
|
|
root.SetErr(&stderr)
|
|
root.SetArgs([]string{"fooo"})
|
|
|
|
err := root.Execute()
|
|
if err == nil {
|
|
t.Fatal("expected unknown-subcommand error, got nil")
|
|
}
|
|
|
|
// Force JSON mode for PrintError regardless of how PersistentPreRunE
|
|
// resolved it during the test invocation (no TTY in test buffer).
|
|
cmdutil.SetFormatMode("json")
|
|
mapped := MapCobraError(err)
|
|
cmdutil.PrintError(&stderr, mapped)
|
|
|
|
got := stderr.String()
|
|
if !strings.Contains(got, `"type":"input.unknown_subcommand"`) {
|
|
t.Errorf("expected typed code; got %q", got)
|
|
}
|
|
if !strings.Contains(got, `"available":[`) {
|
|
t.Errorf("expected detail.available[]; got %q", got)
|
|
}
|
|
if !strings.Contains(got, `"retry_command":"weknora --help"`) {
|
|
t.Errorf("expected retry_command; got %q", got)
|
|
}
|
|
}
|