diff --git a/absl/random/benchmarks.cc b/absl/random/benchmarks.cc index 26bc95e8..170589f6 100644 --- a/absl/random/benchmarks.cc +++ b/absl/random/benchmarks.cc @@ -359,7 +359,7 @@ void BM_Thread(benchmark::State& state) { // ABSL Recommended interfaces. BM_BASIC(absl::InsecureBitGen); // === pcg64_2018_engine -BM_BASIC(absl::BitGen); // === randen_engine. +BM_BASIC(absl::BitGen); // === randen_engine. BM_THREAD(absl::BitGen); BM_EXTENDED(absl::BitGen); diff --git a/absl/random/distributions_test.cc b/absl/random/distributions_test.cc index ea321839..850796e6 100644 --- a/absl/random/distributions_test.cc +++ b/absl/random/distributions_test.cc @@ -97,17 +97,16 @@ void CheckArgsInferType() { template auto ExplicitUniformReturnT(int) -> decltype(absl::Uniform( - std::declval(), - std::declval(), std::declval())); + std::declval(), std::declval(), + std::declval())); template Invalid ExplicitUniformReturnT(...); template -auto ExplicitTaggedUniformReturnT(int) - -> decltype(absl::Uniform( - std::declval(), std::declval(), - std::declval(), std::declval())); +auto ExplicitTaggedUniformReturnT(int) -> decltype(absl::Uniform( + std::declval(), std::declval(), + std::declval(), std::declval())); template Invalid ExplicitTaggedUniformReturnT(...); diff --git a/absl/random/examples_test.cc b/absl/random/examples_test.cc index 1dcb5146..29c27f19 100644 --- a/absl/random/examples_test.cc +++ b/absl/random/examples_test.cc @@ -96,4 +96,3 @@ TEST(Examples, CreateingCorrelatedVariateSequences) { EXPECT_EQ(absl::Uniform(gen_1), absl::Uniform(gen_2)); } } - diff --git a/absl/random/gaussian_distribution.h b/absl/random/gaussian_distribution.h index 4b07a5c0..c24dd838 100644 --- a/absl/random/gaussian_distribution.h +++ b/absl/random/gaussian_distribution.h @@ -57,7 +57,7 @@ class ABSL_DLL gaussian_distribution_base { bool neg); // Constants used for the gaussian distribution. - static constexpr double kR = 3.442619855899; // Start of the tail. + static constexpr double kR = 3.442619855899; // Start of the tail. static constexpr double kRInv = 0.29047645161474317; // ~= (1.0 / kR) . static constexpr double kV = 9.91256303526217e-3; static constexpr uint64_t kMask = 0x07f; diff --git a/absl/random/generators_test.cc b/absl/random/generators_test.cc index 20091309..c3675674 100644 --- a/absl/random/generators_test.cc +++ b/absl/random/generators_test.cc @@ -117,7 +117,6 @@ void TestBernoulli(URBG* gen) { absl::Bernoulli(*gen, 0.5); } - template void TestZipf(URBG* gen) { absl::Zipf(*gen, 100); diff --git a/absl/random/internal/chi_square.cc b/absl/random/internal/chi_square.cc index fbe01732..4cfc4d7c 100644 --- a/absl/random/internal/chi_square.cc +++ b/absl/random/internal/chi_square.cc @@ -25,9 +25,7 @@ namespace { #if defined(__EMSCRIPTEN__) // Workaround __EMSCRIPTEN__ error: llvm_fma_f64 not found. -inline double fma(double x, double y, double z) { - return (x * y) + z; -} +inline double fma(double x, double y, double z) { return (x * y) + z; } #endif // Use Horner's method to evaluate a polynomial. @@ -105,9 +103,8 @@ double normal_survival(double z) { // p-value, usually using bisection. Also known by the name CRITCHI. double ChiSquareValue(int dof, double p) { static constexpr double kChiEpsilon = - 0.000001; // Accuracy of the approximation. - static constexpr double kChiMax = - 99999.0; // Maximum chi-squared value. + 0.000001; // Accuracy of the approximation. + static constexpr double kChiMax = 99999.0; // Maximum chi-squared value. const double p_value = 1.0 - p; if (dof < 1 || p_value > 1.0) { diff --git a/absl/random/internal/chi_square_test.cc b/absl/random/internal/chi_square_test.cc index 5025defa..29fd988d 100644 --- a/absl/random/internal/chi_square_test.cc +++ b/absl/random/internal/chi_square_test.cc @@ -291,8 +291,7 @@ TEST(ChiSquareTest, TableData) { /*97*/ {115.223, 120.990, 126.141, 132.309, 145.789}, /*98*/ {116.315, 122.108, 127.282, 133.476, 147.010}, /*99*/ {117.407, 123.225, 128.422, 134.642, 148.230}, - /*100*/ {118.498, 124.342, 129.561, 135.807, 149.449} - /**/}; + /*100*/ {118.498, 124.342, 129.561, 135.807, 149.449} /**/}; // 0.90 0.95 0.975 0.99 0.999 for (int i = 0; i < ABSL_ARRAYSIZE(data); i++) { diff --git a/absl/random/internal/distribution_caller.h b/absl/random/internal/distribution_caller.h index 0f162a4e..196b7e4b 100644 --- a/absl/random/internal/distribution_caller.h +++ b/absl/random/internal/distribution_caller.h @@ -17,8 +17,8 @@ #ifndef ABSL_RANDOM_INTERNAL_DISTRIBUTION_CALLER_H_ #define ABSL_RANDOM_INTERNAL_DISTRIBUTION_CALLER_H_ -#include #include +#include #include "absl/base/config.h" #include "absl/base/internal/fast_type_id.h" diff --git a/absl/random/internal/explicit_seed_seq_test.cc b/absl/random/internal/explicit_seed_seq_test.cc index e36d5fa0..68c9ab2f 100644 --- a/absl/random/internal/explicit_seed_seq_test.cc +++ b/absl/random/internal/explicit_seed_seq_test.cc @@ -29,14 +29,18 @@ using ::absl::random_internal::ExplicitSeedSeq; template bool ConformsToInterface() { // Check that the SeedSequence can be default-constructed. - { Sseq default_constructed_seq; } + { + Sseq default_constructed_seq; + } // Check that the SeedSequence can be constructed with two iterators. { uint32_t init_array[] = {1, 3, 5, 7, 9}; Sseq iterator_constructed_seq(init_array, &init_array[5]); } // Check that the SeedSequence can be std::initializer_list-constructed. - { Sseq list_constructed_seq = {1, 3, 5, 7, 9, 11, 13}; } + { + Sseq list_constructed_seq = {1, 3, 5, 7, 9, 11, 13}; + } // Check that param() and size() return state provided to constructor. { uint32_t init_array[] = {1, 2, 3, 4, 5}; diff --git a/absl/random/internal/gaussian_distribution_gentables.cc b/absl/random/internal/gaussian_distribution_gentables.cc index a95333d5..3561251d 100644 --- a/absl/random/internal/gaussian_distribution_gentables.cc +++ b/absl/random/internal/gaussian_distribution_gentables.cc @@ -16,8 +16,6 @@ // // $ blaze run :gaussian_distribution_gentables > gaussian_distribution.cc // -#include "absl/random/gaussian_distribution.h" - #include #include #include @@ -25,6 +23,7 @@ #include #include "absl/base/macros.h" +#include "absl/random/gaussian_distribution.h" namespace absl { ABSL_NAMESPACE_BEGIN diff --git a/absl/random/internal/randen_benchmarks.cc b/absl/random/internal/randen_benchmarks.cc index ec086cea..237c95bc 100644 --- a/absl/random/internal/randen_benchmarks.cc +++ b/absl/random/internal/randen_benchmarks.cc @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. // -#include "absl/random/internal/randen.h" - #include #include #include @@ -21,6 +19,7 @@ #include "absl/base/internal/raw_logging.h" #include "absl/random/internal/nanobenchmark.h" #include "absl/random/internal/platform.h" +#include "absl/random/internal/randen.h" #include "absl/random/internal/randen_engine.h" #include "absl/random/internal/randen_hwaes.h" #include "absl/random/internal/randen_slow.h" diff --git a/absl/random/internal/salted_seed_seq_test.cc b/absl/random/internal/salted_seed_seq_test.cc index 0bf19a63..6f48c619 100644 --- a/absl/random/internal/salted_seed_seq_test.cc +++ b/absl/random/internal/salted_seed_seq_test.cc @@ -33,14 +33,18 @@ namespace { template void ConformsToInterface() { // Check that the SeedSequence can be default-constructed. - { Sseq default_constructed_seq; } + { + Sseq default_constructed_seq; + } // Check that the SeedSequence can be constructed with two iterators. { uint32_t init_array[] = {1, 3, 5, 7, 9}; Sseq iterator_constructed_seq(std::begin(init_array), std::end(init_array)); } // Check that the SeedSequence can be std::initializer_list-constructed. - { Sseq list_constructed_seq = {1, 3, 5, 7, 9, 11, 13}; } + { + Sseq list_constructed_seq = {1, 3, 5, 7, 9, 11, 13}; + } // Check that param() and size() return state provided to constructor. { uint32_t init_array[] = {1, 2, 3, 4, 5}; diff --git a/absl/random/internal/traits_test.cc b/absl/random/internal/traits_test.cc index a844887d..21645821 100644 --- a/absl/random/internal/traits_test.cc +++ b/absl/random/internal/traits_test.cc @@ -104,14 +104,11 @@ void CheckWideningConvertsTo() { TEST(TraitsTest, IsWideningConvertibleTest) { constexpr bool kInvalid = false; - CheckWideningConvertsToSelf< - uint8_t, uint16_t, uint32_t, uint64_t, - int8_t, int16_t, int32_t, int64_t, - float, double>(); - CheckNotWideningConvertibleWithSigned< - uint8_t, uint16_t, uint32_t, uint64_t>(); - CheckWideningConvertsToLargerTypes< - uint8_t, uint16_t, uint32_t, uint64_t>(); + CheckWideningConvertsToSelf(); + CheckNotWideningConvertibleWithSigned(); + CheckWideningConvertsToLargerTypes(); CheckWideningConvertsTo(); CheckWideningConvertsTo(); diff --git a/absl/random/internal/uniform_helper.h b/absl/random/internal/uniform_helper.h index db737e13..d2300738 100644 --- a/absl/random/internal/uniform_helper.h +++ b/absl/random/internal/uniform_helper.h @@ -201,8 +201,8 @@ is_uniform_range_valid(FloatType a, FloatType b) { } template -absl::enable_if_t::value, bool> -is_uniform_range_valid(IntType a, IntType b) { +absl::enable_if_t::value, bool> is_uniform_range_valid( + IntType a, IntType b) { return a <= b; } diff --git a/absl/random/internal/wide_multiply.h b/absl/random/internal/wide_multiply.h index 891e3630..b1256813 100644 --- a/absl/random/internal/wide_multiply.h +++ b/absl/random/internal/wide_multiply.h @@ -75,7 +75,6 @@ inline U256 MultiplyU128ToU256(uint128 a, uint128 b) { c00 + (c64a << 64) + (c64b << 64)}; } - template <> struct wide_multiply { using input_type = uint128; diff --git a/absl/random/log_uniform_int_distribution_test.cc b/absl/random/log_uniform_int_distribution_test.cc index 5df3edac..2530c9ed 100644 --- a/absl/random/log_uniform_int_distribution_test.cc +++ b/absl/random/log_uniform_int_distribution_test.cc @@ -148,8 +148,8 @@ double LogUniformIntChiSquaredTest::ChiSquaredTestImpl() { const auto bucket_index = [base_log, is_2, ¶m](int32_t x) { uint64_t y = static_cast(x) - param.min(); return (y == 0) ? 0 - : is_2 ? static_cast(1 + std::log2(y)) - : static_cast(1 + std::log(y) * base_log); + : is_2 ? static_cast(1 + std::log2(y)) + : static_cast(1 + std::log(y) * base_log); }; const int max_bucket = bucket_index(param.max()); // inclusive const size_t trials = 15 + (max_bucket + 1) * 10; diff --git a/absl/random/poisson_distribution_test.cc b/absl/random/poisson_distribution_test.cc index 54755960..3a1d238e 100644 --- a/absl/random/poisson_distribution_test.cc +++ b/absl/random/poisson_distribution_test.cc @@ -106,7 +106,6 @@ TYPED_TEST(PoissonDistributionInterfaceTest, SerializeTest) { 0.0), // denorm_max }; - constexpr int kCount = 1000; absl::InsecureBitGen gen; for (const double m : kParams) { diff --git a/absl/random/seed_sequences.h b/absl/random/seed_sequences.h index 33970be5..dacc5b90 100644 --- a/absl/random/seed_sequences.h +++ b/absl/random/seed_sequences.h @@ -80,8 +80,7 @@ using SeedSeq = random_internal::SaltedSeedSeq; // template SeedSeq CreateSeedSeqFrom(URBG* urbg) { - SeedSeq::result_type - seed_material[random_internal::kEntropyBlocksNeeded]; + SeedSeq::result_type seed_material[random_internal::kEntropyBlocksNeeded]; if (!random_internal::ReadSeedMaterialFromURBG( urbg, absl::MakeSpan(seed_material))) { diff --git a/absl/random/uniform_int_distribution_test.cc b/absl/random/uniform_int_distribution_test.cc index b40d6185..8134ab6f 100644 --- a/absl/random/uniform_int_distribution_test.cc +++ b/absl/random/uniform_int_distribution_test.cc @@ -114,8 +114,8 @@ TYPED_TEST(UniformIntDistributionTest, ParamSerializeTest) { TYPED_TEST(UniformIntDistributionTest, ViolatesPreconditionsDeathTest) { #if GTEST_HAS_DEATH_TEST // Hi < Lo - EXPECT_DEBUG_DEATH({ absl::uniform_int_distribution dist(10, 1); }, - ""); + EXPECT_DEBUG_DEATH( + { absl::uniform_int_distribution dist(10, 1); }, ""); #endif // GTEST_HAS_DEATH_TEST #if defined(NDEBUG) // opt-mode, for invalid parameters, will generate a garbage value, diff --git a/absl/random/uniform_real_distribution_test.cc b/absl/random/uniform_real_distribution_test.cc index 260aac96..4d544cac 100644 --- a/absl/random/uniform_real_distribution_test.cc +++ b/absl/random/uniform_real_distribution_test.cc @@ -190,7 +190,7 @@ TYPED_TEST(UniformRealDistributionTest, ParamSerializeTest) { #ifdef _MSC_VER #pragma warning(push) -#pragma warning(disable:4756) // Constant arithmetic overflow. +#pragma warning(disable : 4756) // Constant arithmetic overflow. #endif TYPED_TEST(UniformRealDistributionTest, ViolatesPreconditionsDeathTest) { using DistributionType = absl::uniform_real_distribution; diff --git a/absl/random/zipf_distribution.h b/absl/random/zipf_distribution.h index 03497b1b..0600cfc6 100644 --- a/absl/random/zipf_distribution.h +++ b/absl/random/zipf_distribution.h @@ -221,7 +221,7 @@ zipf_distribution::operator()( const double v = uniform_double(g); const double u = p.hxm_ + v * p.hx0_minus_hxm_; const double x = p.hinv(u); - k = rint(x); // std::floor(x + 0.5); + k = rint(x); // std::floor(x + 0.5); if (k > static_cast(p.k())) continue; // reject k > max_k if (k - x <= p.s_) break; const double h = p.h(k + 0.5); diff --git a/absl/random/zipf_distribution_test.cc b/absl/random/zipf_distribution_test.cc index 801ec4f6..71548cad 100644 --- a/absl/random/zipf_distribution_test.cc +++ b/absl/random/zipf_distribution_test.cc @@ -176,15 +176,15 @@ class ZipfModel { const double x = v_ + i; // H(n, q-1) - const double hnqm1 = - (q_ == 2.0) ? (1.0 / x) - : (q_ == 3.0) ? (1.0 / (x * x)) : std::pow(x, -qm1); + const double hnqm1 = (q_ == 2.0) ? (1.0 / x) + : (q_ == 3.0) ? (1.0 / (x * x)) + : std::pow(x, -qm1); sum_hnq_m1 += hnqm1; // H(n, q) - const double hnq = - (q_ == 2.0) ? (1.0 / (x * x)) - : (q_ == 3.0) ? (1.0 / (x * x * x)) : std::pow(x, -q_); + const double hnq = (q_ == 2.0) ? (1.0 / (x * x)) + : (q_ == 3.0) ? (1.0 / (x * x * x)) + : std::pow(x, -q_); sum_hnq_ += hnq; hnq_.push_back(hnq); if (i > 1000 && hnq <= 1e-10) {