From 6725fe31f587744f1ce3eb370c2ae3371654f106 Mon Sep 17 00:00:00 2001 From: Evan Brown Date: Thu, 16 Oct 2025 09:47:07 -0700 Subject: [PATCH] Skip the ShortStringCollision test on WASM. We see collisions due to no ASLR and 32-bit size_t. PiperOrigin-RevId: 820276001 Change-Id: I6f3e0d8ade2152fed9759285b7f92a133c6bff14 --- absl/hash/BUILD.bazel | 3 --- absl/hash/hash_test.cc | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/absl/hash/BUILD.bazel b/absl/hash/BUILD.bazel index 271a18f8..187689f8 100644 --- a/absl/hash/BUILD.bazel +++ b/absl/hash/BUILD.bazel @@ -86,9 +86,6 @@ cc_test( ], copts = ABSL_TEST_COPTS, linkopts = ABSL_DEFAULT_LINKOPTS, - tags = [ - "no_test_wasm", # b/452379654 - ], deps = [ ":hash", ":hash_testing", diff --git a/absl/hash/hash_test.cc b/absl/hash/hash_test.cc index a9282961..d0a0e551 100644 --- a/absl/hash/hash_test.cc +++ b/absl/hash/hash_test.cc @@ -1242,6 +1242,9 @@ TEST(HashOf, DoubleSignCollision) { // Test for collisions in short strings if PrecombineLengthMix is low quality. TEST(PrecombineLengthMix, ShortStringCollision) { +#if defined(__wasm__) + GTEST_SKIP() << "Fails flakily on wasm due to no ASLR and 32-bit size_t."; +#endif std::string s1 = "00"; std::string s2 = "000"; constexpr char kMinChar = 0;