diff --git a/absl/hash/hash_test.cc b/absl/hash/hash_test.cc index 71bd9ddc..b751a16c 100644 --- a/absl/hash/hash_test.cc +++ b/absl/hash/hash_test.cc @@ -708,7 +708,9 @@ TEST(HashValueTest, CombinePiecewiseBuffer) { // // This test is run on a buffer that is a multiple of the stride size, and one // that isn't. - for (size_t big_buffer_size : {1024u * 2 + 512u, 1024u * 3}) { + const size_t kChunkSize = absl::hash_internal::PiecewiseChunkSize(); + for (size_t big_buffer_size : + {2 * kChunkSize + kChunkSize / 2, 3 * kChunkSize}) { SCOPED_TRACE(big_buffer_size); std::string big_buffer; for (size_t i = 0; i < big_buffer_size; ++i) { @@ -718,8 +720,15 @@ TEST(HashValueTest, CombinePiecewiseBuffer) { auto big_buffer_hash = hash(PiecewiseHashTester(big_buffer)); const int possible_breaks = 9; - size_t breaks[possible_breaks] = {1, 512, 1023, 1024, 1025, - 1536, 2047, 2048, 2049}; + size_t breaks[possible_breaks] = {1, + kChunkSize / 2, + kChunkSize - 1, + kChunkSize, + kChunkSize + 1, + kChunkSize + kChunkSize / 2, + 2 * kChunkSize - 1, + 2 * kChunkSize, + 2 * kChunkSize + 1}; for (unsigned test_mask = 0; test_mask < (1u << possible_breaks); ++test_mask) { SCOPED_TRACE(test_mask); @@ -729,7 +738,7 @@ TEST(HashValueTest, CombinePiecewiseBuffer) { break_locations.insert(breaks[j]); } } - EXPECT_EQ( + ASSERT_EQ( hash(PiecewiseHashTester(big_buffer, std::move(break_locations))), big_buffer_hash); }