From 1d615eeff1fb2595d0b6b67bbc196d2ec88722e5 Mon Sep 17 00:00:00 2001 From: "Maarten L. Hekkelman" Date: Mon, 23 Mar 2026 17:36:35 +0100 Subject: [PATCH] fast float for macOS (and FreeBSD?) --- .github/workflows/cmake-multi-platform.yml | 2 +- CMakeLists.txt | 7 +++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/workflows/cmake-multi-platform.yml b/.github/workflows/cmake-multi-platform.yml index 412e607..b31ad8f 100644 --- a/.github/workflows/cmake-multi-platform.yml +++ b/.github/workflows/cmake-multi-platform.yml @@ -43,7 +43,7 @@ jobs: - name: Install Catch2 macOS if: matrix.os == 'macos-latest' run: > - brew install catch2 + brew install catch2 fast_float - name: Configure CMake run: > diff --git a/CMakeLists.txt b/CMakeLists.txt index 1b0dd44..93d69b5 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -185,14 +185,14 @@ try_compile(STD_CHARCONV_COMPILING if(NOT STD_CHARCONV_COMPILING) message(NOTICE "libcifpp: Using fast_float for std::from_chars") - find_package(FastFloat 8.0 QUIET CONFIG) + find_package(FastFloat 8.0 REQUIRED CONFIG) if(NOT FastFloat_FOUND) message(STATUS "FastFloat not found in system, fetching from GitHub") - FetchContent_Declare(fastfloat + FetchContent_Declare(FastFloat GIT_REPOSITORY "https://github.com/fastfloat/fast_float" GIT_TAG v8.0.2 EXCLUDE_FROM_ALL) - FetchContent_MakeAvailable(fastfloat) + FetchContent_MakeAvailable(FastFloat) endif() endif() @@ -375,7 +375,6 @@ else() endif() if(NOT STD_CHARCONV_COMPILING) -# target_link_libraries(cifpp PRIVATE FastFloat::fast_float) target_include_directories(cifpp PRIVATE ${FastFloat_INCLUDE_DIRS}) endif()