Commit Graph

171 Commits

Author SHA1 Message Date
Alyssa Travitz
098c0a8a84 updating syntax for click 8.2 (#1276) 2025-05-27 18:35:44 +00:00
Alyssa Travitz
0bd14c7b79 add retries for flaky notebooks (#1278) 2025-05-21 17:11:16 +00:00
Alyssa Travitz
3dc10653d1 require -o option for CLI charge generation (#1255)
* require -o option for charge generator

* adding a test for missing -o
2025-04-24 14:08:12 -07:00
Alyssa Travitz
e42432d5b0 pretty print tables with rich (#1246)
* add pandas construction

* removing csv writer

* replicating original behavior

* add rich table

* split into function

* make names clearer

* adding adjustments from rebase

* put it in a box

* adding tsv flag

* update tests to use tsv flag

* add smoke test for pretty print

* adding file creation test

* adding news item

---------

Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
Co-authored-by: Mike Henry <11765982+mikemhenry@users.noreply.github.com>
2025-04-24 10:02:26 -07:00
Alyssa Travitz
aedc719aa5 Single repeat error handling (#1243)
* fail on first leg with too few repeats

* pass through all failed edges

* adding news entry

* improve error message

* fix test
2025-04-23 17:58:21 +00:00
Alyssa Travitz
38f0c6a3ef print message to stderr when no valid results files are found (#1245)
* print message to stderr when no valid results files are found

* fix check

* move check into main function to keep single responsibility

* fix cmet test bug

* adding test
2025-04-23 17:33:52 +00:00
Alyssa Travitz
d811614e8c fixing test's allow partial test (#1247) 2025-04-23 07:44:10 -07:00
Alyssa Travitz
e640424817 Pass through failed simulations to output (#1227)
* reorg for clarity

* moving try/except into function for clarity

* reorg data parsing for clarity

* remove unused function

* add try/except to pass through info about failed edges

* updating tests for new expected failed simulation checking behavior

* pass through for raw and ddg

* pass through failures for dgs

* remove unused import

* adding a missing check

* docstrings

* cleaning up logic

* cleaning up logic

* docstrings and formatting

* fixing conditionals bug

* more docstrings

* make 'name' a tuple for consistency

* make functions private

* updating output statement for clarity (hopefully)

* remove unused dg raw expected output

* adding comment description

* updating tests

* cleaning up test to not use tmp dir

* only use non-None legs for deciding whether to do rbfe/rhfe

* fix typo

* pass empty list instead of None through to ddg

* add cmet data

* add assert success tests - still need output validation

* light reordering for clarity

* adding pytest regressions

* don't include stderr in file regression

* making output more legible

* switch from runtime error to exit(1)

* add missing complex legs test

* adding regressoin tsvs  to manifest

* reordering functions for clarity

* updating tests

* adding test for disconnected network

* updating warning message, not throwing error for now

* updating tests for missing runs

* add disconnected network check

* switch from NaN to Error

* removing unused regression files

* fixing typo

* adding test coverage

* fix typo

* adding news entry
2025-04-22 07:24:31 -07:00
Alyssa Travitz
8cc3c4f291 cli gather should allow lists of filepaths (#1212)
* allowing multiple paths

* first pass at allowing filepaths and wildcards

* updating docstring

* adding missing /

* add tests and sorting

* add news

* updating docstring

* updating docs

* fixing whitespace diff

---------

Co-authored-by: Mike Henry <11765982+mikemhenry@users.noreply.github.com>
2025-04-07 07:13:08 -07:00
Alyssa Travitz
cd219bc002 only show --allow-partial suggestion if user hasn't used it (#1208)
* only show --allow-partial suggestion if user hasn't used it

* adding a test
2025-03-27 13:31:16 -07:00
Alyssa Travitz
01c3b5601e 1002: improve missing data error handling (#1199)
* add check for missing protocol result data

* renaming vars for  clarity

---------

Co-authored-by: Mike Henry <11765982+mikemhenry@users.noreply.github.com>
2025-03-27 07:18:30 -07:00
Alyssa Travitz
e044ec4a61 pooch - add triplicate retries (#1213)
* add triplicate retries

* use openfe cache

* add internet check to openfe

* isort as a treat

* whitespace :(

* remove unused pytest.mark.download
2025-03-26 14:54:27 -07:00
Alyssa Travitz
66ac2bdc64 migrate json loading to new gufe syntax (#1177)
* updates to cli from_json

* replacing dump instances with to_json

* Remove unnecessary imports of JSON_HANDLER

* addressing review

---------

Co-authored-by: Mike Henry <11765982+mikemhenry@users.noreply.github.com>
Co-authored-by: David L. Dotson <dotsdl@gmail.com>
2025-03-25 23:32:26 +00:00
Alyssa Travitz
b798454425 1104 gather check json files (#1112)
* adding output for failed edges

* adding print statements, tests don't pass yet because of extra output

* remove straggler

* Update openfecli/commands/gather.py

Co-authored-by: Josh Horton <Josh.Horton@newcastle.ac.uk>

* comment out exception check temporarily

* adding exception check back (test data was wrong)

* adding tests in progress

* trying different mocking

* adding unit tests

* cleaning up

* updating zenodo doi to use correct parallel rbfe dataset

---------

Co-authored-by: Josh Horton <Josh.Horton@newcastle.ac.uk>
2025-03-19 17:53:00 +00:00
Alyssa Travitz
a823546bab fix rbfe parallel results dataset (#1196)
* placeholder

* move to new zenodo community
2025-03-18 13:54:15 -07:00
Alyssa Travitz
984ba90116 Fix breaking tests from gufe updates (#1107)
* switch to assert_click_success to make debugging easier

* fixing tests to look for logger.INFO instead of warnings (due to gufe change)

* updating expected output due to gufe changes

* updating expected transformations

* remove easy prefix, passing 2fe7741b9448

* define _settings_cls, tests pass against g3c6d5f9

* update string match for partial charge logging
2025-03-04 06:57:27 -08:00
Alyssa Travitz
b5eb3e227e move test data to zenodo (#1148)
* test out pooch

* adding zenodo dois

* remove unused import

* delete rbfe_result data from local storage

* move into a fixture factory

* updating missing legs tests

* Revert "delete rbfe_result data from local storage"

This reverts commit 1211200947e38ad17df50ebc3e67eb801e0bf0a4.

* updating failed edges tests

* updating test names to rbfe

* adding zenodo fetchable

* splitting out docs func

* move data out of fixture

* Revert "adding zenodo fetchable"

This reverts commit 5c72321e0e60d09339aee726c06bcda1190a6beb.

* add check for data cache

* cleaning up straggling changes

* remove data that's now on zenodo

* adding correctly compressed results data
2025-02-21 10:19:15 -08:00
Alyssa Travitz
d0427382fb adding unzipped cdk8 data (#1151)
* adding unzipped cdk8 data

* removing cdk zip from manifest

* updating fixture to not look for zip file
2025-02-20 13:57:44 -08:00
Mike Henry
ebb3a7ee43 Fix issue 1128 & 1129 (#1135)
* be able to manually trigger package tests

* run package tests on each pr, no reason not to

* we should be installing from conda forge

* skip some openfecli tests if we don't have nagl installed

* plz lets use conda-forge
2025-02-14 15:37:36 -07:00
Alyssa Travitz
f7b11d45b1 remove "easy_" prefix from cli output (#1121)
* easy_rbfe -> rbfe

* remove addressed TODO

* adding news item

* easy_rhfe -> rhfe prefix
2025-02-11 14:43:21 -08:00
Alyssa Travitz
5b2b6334c3 Add lomap network generator (#1082)
* add lomap_network_generator

* add news item

* switching to lomap as custom yaml test

* renaming var for clarity

* switch to cdk8 data
2025-01-31 12:23:35 -08:00
Alyssa Travitz
1c2d40d4aa Merge branch 'main' into cli-partial-charges 2025-01-30 08:31:59 -08:00
Alyssa Travitz
01417442c2 gather - show all failed edges in error message (#1095)
* add type annotations

* use assert_click_success

* rename set_vals to leg_types for clarity

* formatting stdout whitespace for clarity

* formatting output to handle multiple legs in a clearer way

* docstring

* adding news item

* updating test match strings

* simplify legs error message

* updating tests for new error handling
2025-01-30 08:29:54 -08:00
Josh Horton
fe5de586ef Merge branch 'main' into cli-partial-charges
# Conflicts:
#	openfecli/commands/plan_rbfe_network.py
#	openfecli/commands/plan_rhfe_network.py
#	openfecli/parameters/__init__.py
#	openfecli/parameters/misc.py
#	openfecli/tests/commands/test_plan_rbfe_network.py
#	openfecli/tests/commands/test_plan_rhfe_network.py
2025-01-30 11:07:09 +00:00
Alyssa Travitz
00445dcf5c add support for one repeat per json (#1076)
* add n_protocol_repeats as cli parameter

* add news item

* update tests

* add docstrings

* adding n_repeats test

* switch test to use full --n-protocol-repeats flag

* updating help msg

* updating news entry

* Update openfecli/parameters/misc.py

Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>

---------

Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
2025-01-29 14:23:15 -08:00
Josh Horton
1da6c5a641 Merge branch 'main' into cli-partial-charges 2025-01-29 16:36:12 +00:00
Josh Horton
4c9a1f0b6f xfail openeye nagl tests, update CLI ref docs 2025-01-29 16:31:35 +00:00
Alyssa Travitz
e45b34e81c 1089 fix tests for missing gather data (#1090)
* add assert_click_success helper

* fixing xfail tests so they pass

* add type annotations

* organize into a class

* update docstring

* adding no-cov for test utils

* removing failing pooch test
2025-01-28 21:48:12 +00:00
Josh Horton
6ab8e9f305 fix test 2025-01-24 11:52:17 +00:00
Josh Horton
c46e7c1e5a add charges to cofactor sdf, fix docs, expose overwrite charges to plan CLI 2025-01-24 11:39:39 +00:00
Josh Horton
99a891f63b set threads to 1, undo tutorial file changes 2025-01-23 14:12:53 +00:00
Josh Horton
b3ef278f99 fix mypy, pre-charge ligands for reproducible tests 2025-01-21 13:23:21 +00:00
Josh Horton
c350c19106 fix edge sort dependent tests, fix mypy 2025-01-20 17:25:56 +00:00
Josh Horton
8602a39aa6 move ncores cli flag, fix tests, add tests for charge generation 2025-01-20 15:53:43 +00:00
Josh Horton
838371875b update flag name, fix tests to use nagl for CI speed 2025-01-17 12:10:20 +00:00
Alyssa Travitz
915d11022c Support outdir created at runtime (#1072)
* adding test

* create directories

* fixing a word

* update news

* update news
2025-01-14 16:50:37 +00:00
Josh Horton
a69f129fde Test cofactor networks generated with the CLI (#1048)
* make sure the cofactor is in the transformation

* fix cofactor name

* use value in enum, add cofactor chemical system generator test
2025-01-07 08:07:03 -08:00
Alyssa Travitz
66476fda8a Add gather support for parallel dir structure (#1044)
* add docstrings

* Revert "add docstrings"

This reverts commit 6ae5d1d33492c78a95ace4dcc0ef3890c03e2318.

* adding fixture

* whitespace fixes

* added (failing) test for parallel results data

* add back all report types into testing

* include serial and paralell in paramterize

* adding support for raw output type

* expose uncertainty and estimate functions to gather

* pass dGs through - works but isn't pretty

* remove todo

* updating changelog

* updating changelog

* Update openfe/protocols/openmm_rfe/equil_rfe_methods.py

Co-authored-by: Hannah Baumann <43765638+hannahbaumann@users.noreply.github.com>

* fix type hint

---------

Co-authored-by: Hannah Baumann <43765638+hannahbaumann@users.noreply.github.com>
2024-12-20 09:05:14 -08:00
Josh Horton
983dce809a remove print, test network with charge change and neutral transforms 2024-12-19 10:45:35 +00:00
Josh Horton
789a9f90a6 zip new test files 2024-12-18 17:07:38 +00:00
Josh Horton
38edee6435 clean up imports and copied code 2024-12-17 11:32:37 +00:00
Josh Horton
ab17f07bcf Merge branch 'main' into cli_charge_changes 2024-12-17 11:31:53 +00:00
Alyssa Travitz
8374172479 add warning for unsupported settings yaml parameters (#1051)
* adding warning and test

* be more precise about allowed fields handling

* using more explicit set notation

* add rever file
2024-12-13 12:49:09 -07:00
Josh Horton
18ae9733b9 adapt settings for charge change transformations 2024-12-13 12:57:37 +00:00
Josh Horton
401ae3d5af fix tyk2 example test (#1047) 2024-12-12 10:43:14 -08:00
Alyssa Travitz
55c992405e create test data for quickrun submitted in parallel (#1040) 2024-12-09 08:51:44 -08:00
Alyssa Travitz
c2e4ee9bda 986 input validation for directory names (#1024) 2024-12-06 16:40:31 -08:00
Alyssa Travitz
e174a6d152 remove index column from -raw output 2024-10-22 09:18:14 -07:00
Francho Nerín Fonz
cf4eb72782 updated test_gather raw to new output 2024-07-05 12:51:01 +01:00
Mike Henry
dd7c4a8d84 update tests to match new std output 2024-04-17 07:56:29 -07:00