diff --git a/Code/GraphMol/Substruct/catch_tests.cpp b/Code/GraphMol/Substruct/catch_tests.cpp index 3faf1787b..11cbd19fe 100644 --- a/Code/GraphMol/Substruct/catch_tests.cpp +++ b/Code/GraphMol/Substruct/catch_tests.cpp @@ -315,9 +315,9 @@ TEST_CASE("Github #4138: empty query produces non-empty results", TEST_CASE("Github #4558: GetSubstructMatches() loops at 43690 iterations", "[substruct][bug]") { // We need LOTS of water molecules here. - auto num_mols = 22000; + auto num_mols = 22000u; std::stringstream smi; - for (int i = 1; i < num_mols; ++i) { + for (auto i = 1u; i < num_mols; ++i) { smi << "[H]O[H]."; } smi << "[H]O[H]"; // last one (notice we started at 1) diff --git a/External/AvalonTools/CMakeLists.txt b/External/AvalonTools/CMakeLists.txt index 770189c82..3e31195fc 100644 --- a/External/AvalonTools/CMakeLists.txt +++ b/External/AvalonTools/CMakeLists.txt @@ -84,8 +84,12 @@ if(CMAKE_SYSTEM_NAME STREQUAL "Linux") endif() if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang") - set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wno-parentheses -Wno-logical-op-parentheses -Wno-dangling-else -Wno-format") + set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wno-return-type -Wno-implicit-function-declaration -Wno-absolute-value -Wno-parentheses -Wno-logical-op-parentheses -Wno-dangling-else -Wno-format") endif() +if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU") + set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wno-unused-result -Wformat-overflow=0 -Wformat=0 -Wno-format-security -Wno-implicit-function-declaration") +endif() + rdkit_library(avalon_clib ${avalon_clib_srcs}) diff --git a/External/CoordGen/CMakeLists.txt b/External/CoordGen/CMakeLists.txt index 88530c04d..39e634ece 100644 --- a/External/CoordGen/CMakeLists.txt +++ b/External/CoordGen/CMakeLists.txt @@ -51,10 +51,15 @@ if(RDK_BUILD_MAEPARSER_SUPPORT) CACHE STRING "MaeParser Include Dir" FORCE) file(GLOB MAESOURCES "${MAEPARSER_DIR}/*.cpp") + if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU") + set(CMAKE_CXX_FLAGS "${CMAKE_C_FLAGS} -Wno-deprecated-copy") + endif() + rdkit_library(maeparser ${MAESOURCES} LINK_LIBRARIES ${Boost_LIBRARIES} ${ZLIB_LIBRARIES} SHARED) install(TARGETS maeparser DESTINATION ${RDKit_LibDir}) set(maeparser_LIBRARIES maeparser ${ZLIB_LIBRARIES}) + endif(MAEPARSER_FORCE_BUILD OR (NOT maeparser_FOUND)) include_directories(${maeparser_INCLUDE_DIRS}) diff --git a/External/INCHI-API/CMakeLists.txt b/External/INCHI-API/CMakeLists.txt index c02761851..8792b08d7 100644 --- a/External/INCHI-API/CMakeLists.txt +++ b/External/INCHI-API/CMakeLists.txt @@ -71,8 +71,14 @@ if(RDK_BUILD_INCHI_SUPPORT) endif() if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang") - set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wno-parentheses -Wno-logical-op-parentheses") + set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wno-comment -Wno-parentheses -Wno-logical-op-parentheses -Wno-pointer-bool-conversion -Wno-unused-value -Wno-unsequenced -Wno-constant-logical-operand") endif() + if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU") + set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wformat-overflow=0 -Wformat=0 -Wno-format-security") + endif() + + + rdkit_library(RDInchiLib inchi.cpp SHARED LINK_LIBRARIES ${INCHI_LIBRARIES} GraphMol RDGeneral Depictor SubstructMatch SmilesParse ) target_compile_definitions(RDInchiLib PRIVATE RDKIT_RDINCHILIB_BUILD)