pub_soft/rdkit
3
0
Fork 0
mirror of https://github.com/rdkit/rdkit.git synced 2026-06-04 21:54:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

cleanup a bunch of compiler warnings (#3849)

Browse Source 
* cleanup a bunch of g++ warnings

* make it work with clang

* remove some additional warnings based on CI builds

* fix that version number

* stop being verbose when building
This commit is contained in:
Greg Landrum
2021-02-26 05:10:02 +01:00
committed by GitHub
parent 4776203249
commit 0e89b2dbea
22 changed files with 82 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Code/GraphMol/QueryOps.cpp
View File

@@ -695,7 +695,7 @@ bool isAtomListQuery(const Atom *a) {
return false;
}
if (a->getQuery()->getDescription() == "AtomOr") {
for (const auto child : boost::make_iterator_range(
for (const auto &child : boost::make_iterator_range(
a->getQuery()->beginChildren(), a->getQuery()->endChildren())) {
if (!_atomListQueryHelper(child)) {
return false;
@@ -713,7 +713,7 @@ void getAtomListQueryVals(const Atom::QUERYATOM_QUERY *q,
auto descr = q->getDescription();
PRECONDITION(descr == "AtomOr", "bad query");
if (descr == "AtomOr") {
for (const auto child :
for (const auto &child :
boost::make_iterator_range(q->beginChildren(), q->endChildren())) {
auto descr = child->getDescription();
if (child->getNegation() ||