pub_soft/rdkit
3
0
Fork 0
mirror of https://github.com/rdkit/rdkit.git synced 2026-06-03 21:44:30 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add suppresions for AppleClang and ChemDraw (#9147)

Browse Source
This commit is contained in:
Brian Kelley
2026-03-04 02:27:30 -05:00
committed by GitHub
parent 46a4f59048
commit 22be7245df
2 changed files with 18 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
External/ChemDraw/CMakeLists.txt vendored
View File

@@ -25,6 +25,21 @@ if(RDK_BUILD_CHEMDRAW_SUPPORT)
message("-- Looking for endianess")
test_big_endian(WORDS_BIGENDIAN)
include(CheckCXXCompilerFlag)
if (CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang")
include(CheckCXXCompilerFlag)
# This is a pretty heavy hammer for AppleClang automatically
# adding -Wundef-prefix=TARGET_OS_ ...
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-reorder-ctor -Wno-unused-parameter -Wno-comment -Wno-parentheses -Wno-logical-op-parentheses -Wno-pointer-bool-conversion -Wno-unused-value -Wno-unsequenced -Wno-constant-logical-operand")
# turn off EVERYTHING
check_cxx_compiler_flag("-Wno-undef-prefix" HAVE_UNDEF_PREFIX)
if(HAVE_UNDEF_PREFIX)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-undef-prefix")
endif(HAVE_UNDEF_PREFIX)
endif()
# /* 1234 = LIL_ENDIAN, 4321 = BIGENDIAN */
if(WORDS_BIGENDIAN)
message("-- CHEDRAW BIGENDIAN PLATFORM")
@@ -61,6 +76,7 @@ if(RDK_BUILD_CHEMDRAW_SUPPORT)
# On Linux/macOS, hide all symbols by default and expose only our API
if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang" OR
CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang" OR
CMAKE_CXX_COMPILER_ID STREQUAL "GNU" OR
CMAKE_CXX_COMPILER_ID STREQUAL "Emscripten")
# Require -fvisibility=hidden
@@ -118,7 +134,7 @@ if(RDK_BUILD_CHEMDRAW_SUPPORT)
install(TARGETS expat EXPORT ${RDKit_EXPORTED_TARGETS} DESTINATION ${RDKit_LibDir} COMPONENT dev)
endif()
if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang" )
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-comment -Wno-parentheses -Wno-logical-op-parentheses -Wno-pointer-bool-conversion -Wno-unused-value -Wno-unsequenced -Wno-constant-logical-operand")
endif()

2
External/ChemDraw/test_6k.cpp vendored
View File

@@ -356,7 +356,7 @@ TEST_CASE("Round TRIP") {
}
}
std::cerr << "Total:" << total << std::endl;
std::cerr << "Parseable (has chemscript output):" << total << std::endl;
std::cerr << "Parseable (has chemscript output):" << parseable << std::endl;
std::cerr << "Success:" << success + smimatches << std::endl;
std::cerr << "skipped (non supported features):" << nonSupported
<< std::endl;