Implement the two deprecations that were planned for the 2020.09 release cycle (#3047)

* Deprecation: planned removal of .message() and .getMessage() methods

* Deprecation: planned removal of old MolHash code

* document deprecations

* output the diffs when the psql tests fail

* remove .message() from SWIG wrappers

note that the KeyError doesn't work properly. We should clean up the the exceptions here anyway

* typo
This commit is contained in:
Greg Landrum
2020-04-01 14:30:07 +02:00
committed by GitHub
parent cf031c2f7e
commit 5712176605
126 changed files with 1172 additions and 22492 deletions

View File

@@ -93,32 +93,32 @@
}
catch (RDKit::ChemicalReactionException &e) {
std::string err="ChemicalReactionException: ";
err+=e.message();
err+=e.what();
SWIG_CSharpSetPendingException(SWIG_CSharpApplicationException, err.c_str());
}
catch (RDKit::ChemicalReactionParserException &e) {
std::string err="ChemicalReactionParserException: ";
err+=e.message();
err+=e.what();
SWIG_CSharpSetPendingException(SWIG_CSharpApplicationException, err.c_str());
}
catch (RDKit::ConformerException &e) {
std::string err="ConformerException: ";
err+=e.message();
err+=e.what();
SWIG_CSharpSetPendingException(SWIG_CSharpApplicationException, err.c_str());
}
catch (RDKit::MolPicklerException &e) {
std::string err="MolPicklerException: ";
err+=e.message();
err+=e.what();
SWIG_CSharpSetPendingException(SWIG_CSharpApplicationException, err.c_str());
}
catch (RDKit::MolSanitizeException &e) {
std::string err="MolSanitizeException: ";
err+=e.message();
err+=e.what();
SWIG_CSharpSetPendingException(SWIG_CSharpApplicationException, err.c_str());
}
catch (RDKit::SmilesParseException e) {
std::string err="SmilesParseException: ";
err+=e.message();
err+=e.what();
SWIG_CSharpSetPendingException(SWIG_CSharpApplicationException, err.c_str());
}
catch (KeyErrorException e) {