pub_soft/rdkit
3
0
Fork 0
mirror of https://github.com/rdkit/rdkit.git synced 2026-06-04 21:54:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

Implement the two deprecations that were planned for the 2020.09 release cycle (#3047)

Browse Source 
* Deprecation: planned removal of .message() and .getMessage() methods

* Deprecation: planned removal of old MolHash code

* document deprecations

* output the diffs when the psql tests fail

* remove .message() from SWIG wrappers

note that the KeyError doesn't work properly. We should clean up the the exceptions here anyway

* typo
This commit is contained in:
Greg Landrum
2020-04-01 14:30:07 +02:00
committed by GitHub
parent cf031c2f7e
commit 5712176605
126 changed files with 1172 additions and 22492 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Code/JavaWrappers/gmwrapper/src-test/org/RDKit/ErrorHandlingTests.java
View File

@@ -58,8 +58,8 @@ public class ErrorHandlingTests extends GraphMolTest {
e.getClass().toString());
String what = ((KeyErrorException) e).key();
assertEquals("monkey", what);
what = ((KeyErrorException) e).message();
assertEquals("Unknown key: monkey", what);
// what = ((KeyErrorException) e).what();
// assertEquals("Unknown key: monkey", what);
}
}
@@ -81,7 +81,7 @@ public class ErrorHandlingTests extends GraphMolTest {
}
catch (GenericRDKitException e)
{
String what = e.message();
String what = e.what();
assertEquals("Unknown exception", what);
String where = e.getStackTrace()[0].getMethodName();
assertEquals("ROMol_getAtomWithIdx", where);
@@ -111,7 +111,7 @@ public class ErrorHandlingTests extends GraphMolTest {
{
assertEquals("class org.RDKit.GenericRDKitException",
e.getClass().toString());
String msg = e.message();
String msg = e.what();
assertEquals("Unknown exception", msg);
StackTraceElement[] st = e.getStackTrace();
assertEquals("ErrorGenerator_badAlloc_1",