pub_soft/rdkit
3
0
Fork 0
mirror of https://github.com/rdkit/rdkit.git synced 2026-06-03 21:44:30 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix leaks in MIF wrappers (#8143)

Browse Source 
* fix leaks in wrappers

* decref on not-sequence obj or bad seq size

* PySequence in DistGeom wrappers
This commit is contained in:
Ricardo Rodriguez
2025-01-09 01:30:20 -05:00
committed by GitHub
parent 1185a4da2b
commit 847b0d19e0
2 changed files with 52 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
Code/DistGeom/Wrap/DistGeom.cpp
View File

@@ -131,11 +131,24 @@ PyObject *embedBoundsMatrix(python::object boundsMatArg, int maxIters = 10,
for (unsigned int entryIdx = 0; entryIdx < nElems; entryIdx++) {
PyObject *entry = PySequence_GetItem(weights.ptr(), entryIdx);
if (!PySequence_Check(entry) || PySequence_Size(entry) != 3) {
Py_DecRef(entry);
throw_value_error("weights argument must be a sequence of 3-sequences");
}
int idx1 = PyInt_AsLong(PySequence_GetItem(entry, 0));
int idx2 = PyInt_AsLong(PySequence_GetItem(entry, 1));
double w = PyFloat_AsDouble(PySequence_GetItem(entry, 2));
PyObject *obj = PySequence_GetItem(entry, 0);
int idx1 = PyInt_AsLong(obj);
Py_DecRef(obj);
obj = PySequence_GetItem(entry, 1);
int idx2 = PyInt_AsLong(obj);
Py_DecRef(obj);
obj = PySequence_GetItem(entry, 2);
double w = PyFloat_AsDouble(obj);
Py_DecRef(obj);
Py_DecRef(entry);
weightMap[std::make_pair(idx1, idx2)] = w;
}
DistGeom::VECT_CHIRALSET csets;