Commit Graph

54 Commits

Author SHA1 Message Date
Greg Landrum
853d9137c8 Fixes #3197 and #3206 (#3208)
* add tests

* Fixes #3197

* Fixes #3206
2020-06-04 13:27:29 -04:00
Greg Landrum
d41752d558 run clang-tidy with readability-braces-around-statements (#2899)
* run clang-tidy with readability-braces-around-statements
clang-format the results
clean up all the parts that clang-tidy-8 broke

* fix problem on windows
2020-01-25 14:19:32 +01:00
Eisuke Kawashima
5cd27a242f Fix typo (#2862)
* Fix typo

* Reflect the comments

* Fix more typos
2019-12-31 06:43:27 +01:00
Ric
6224a42516 Build warnings revisited (#2318)
* unused vars in bison parser cleanup

* initialization order in TopologicalTorsionGenerator

* unused params in SLN bison

* sln flex unused params

* throwing destructor in TDTWriter

* signed comparison in substructmethods

* unused input param in smiles/smarts bison

* unused ms param in sln bison

* signed comparison in FingerprintGenerator

* store return of fscanf in StructCheckerOptions

* unreferenced var in catch

* uninitialized value in FileParserUtils

* avoid override overload warning in MolDraw2DSVG

* non-final overrides in Validate.h

* unused static var in Avalon

* unused vars in catch blocks

* make AvalonTools avalonSimilarityBits & avalonSSSBits const int

* assert fscanf result in StructCheckerOptions
2019-03-08 16:42:54 +01:00
Ric
a6b26253ff Fix (most of) mem problems (#2123)
* do not use new on loggers

* del pointers in testDistGeom

* Update Dict hasNonPOD status on bulk update

* delete new Dicts in memtest1.cpp

* fixes in MolSuppliers and testFMCS

* PeriodicTable singleton as unique_ptr

* fix EEM_arrays leak

* fix leaks in testPBF

* fix ParamCollection leak in test UFF

* fix leaks in MMFF

* clear prop dict before read in in pickler

* fix leaks in testFreeSASA

* fix leaks in test3D

* modernize Dict.h & SmilesParse.cpp

* fix leaks in testQuery

* fix leaks in testCrystalFF

* fix leaks in cxsmilesTest

* fix leaks in Catalog & mol cat test

* fix leaks in ShapeUtils & tests

* fix leaks in testSubgraphs1

* fix leaks testFingerprintGenerators

* fix leaks in Catalog/FilterCatalog

* fix leaks in graphmolqueryTest

* these changes reduce bison parse leaks

* fixed leaks in testChirality.cpp

* fix leaks + 2 tests in testMolWriter

* fix 4m leaks in substructLibraryTest

* small improvements to molTautomerTest; still leaks

* fix leaks in testRGroupDecomp

* fix leaks in test; parser still leaks

* fix leaks in itertest

* fix 4m leaks in testDepictor

* fixes in smatest; still leaking due to parser

* fixes in testSLNParse; still leaking due to parser

* flex/bison: always add atoms with ownership; smarts error cleanup

* fix leaks in testReaction

* fix leaks in testSubstructMatch

* fix leaks in resMolSupplierTest

* fix leaks in testChemTransforms + bug in ChemTransforms

* fix leaks in testPickler

* fix leaks in testMolTransform

* fix leaks in testFragCatalog

* fix leak in testSLNParse. Still leaks due to Smiles

* fixed most leaks in testMolSupplier

* pre bison fix

* fix some atom & bond parse problems; others still fail

* bison smiles & smarts, atoms & bonds more or less fixed

* fix leaks in molopstest.cpp

* fix leaks in testFingerprints, MACCS.cpp & AtomPairs.cpp

* fix leaks in moldraw2Dtest1

* fix leaks in testDescriptors

* fix leaks in testInchi

* fix leaks in testUFFForceFieldHelpers

* fix leaks in hanoiTest & new_canon.h

* fix leaks in testMMFFForceField

* fix leaks in graphmolTest1

* fix leaks in testMMFFForceFieldHelpers

* fix leaks in testDistGeomHelpers

* fix leaks in testMolAlign

* initialize occupancy & temp facto with default values

* fix leak in TautomerTransform

* updated suppressions

* fix testStructChecker

* fix logging & py tests

* fix TautomerTransform class/struct issue

* remove misplaced delete in testSLNParse

* deinit in testAvalonLib1

* fix Avalon-triggered(?) bug in StructChecker/Pattern.cpp

* fix random testMolWriter/Supplier fails

- diversify output file names to avoid clashing.
- unify Writers close/destruct behavior.
- flushing/closing in tests.

* use reset in FFs Params.cpp

* comments on testMMFFForceField

* unrequired 'if's added to mol suppliers

* correct cast in FilterCatalog.h

* use unique_ptr in MACCS Patterns

* remove unrequred if in new_canon

* update & move suppressions
2018-10-29 14:33:26 +00:00
Paolo Tosco
f7c888844d moved test.h from RDBoost to RDGeneral for consistency with export.h (#2074) 2018-10-11 17:35:23 -04:00
Paolo Tosco
c08ea49bda - enable building DLLs on Windows (#1861)
* - enable building DLLs on Windows

* - export.h and test.h are now auto-generated by CMake
2018-05-16 08:42:41 +02:00
Greg Landrum
3f136946e3 Start using "*" instead of "[*]" in SMILES (#1788) 2018-03-23 15:52:52 -04:00
Greg Landrum
f6bbba411d Fix github1734 (#1741)
* Fixes #1734
still want some additional testing though

* formatting

* typo

* add python tests

* response to review
re-enable some forgotten tests
2018-02-15 20:24:40 -05:00
Brian Kelley
5fe9bbb780 Adds ability to read and parse marvin smarts in mol blocks 2017-12-22 08:20:31 -05:00
Greg Landrum
915cf08faa run clang-format with c++-11 style over that 2017-04-22 17:19:10 +02:00
Greg Landrum
7c0bb0b743 clang-tidy output 2017-04-22 17:09:24 +02:00
Brian Kelley
71a0ae32b2 Adds replaceCore function that takes a matchVect (#1013)
* Adds replaceCore function that takes a matchVect

* Fixes error reporting, adds tests

* Switches PRECONDITION to ValueError exceptions

* Fixes MatchVectType annoyance in swig.  Don't know why this is necessary.

* Silences warnings

* Adds working doctests and better explanations.
2016-08-17 04:40:59 +02:00
Brian Kelley
fe7d4fefb3 Dev/chemtransforms chirality (#1006)
* Adds useChirality to replaceCore, fixes atom ordering
  n.b. when replaceDummies==False and labelByIndex==True
   the indices used are the indices of the dummy atom,
   previously they were the atoms the dummy was connected
   to.

* Adds useChirality to the remaining functions in ChemTransforms

* Adds a mess o tests

* Fixes labelByIndex=false ordering for dummies

* Removes debugging statements
2016-08-09 04:41:36 +02:00
Greg Landrum
b0f140a55c Fixes #511 2016-03-29 16:56:15 +02:00
Greg Landrum
e08e0d16d8 first pass, using google style 2015-11-14 14:58:11 +01:00
Nadine Schneider
5d963846b8 merge 2015-04-10 09:44:18 +02:00
Nadine Schneider
7e59908121 SmilesWrite: introduce new function for fragments 2015-03-20 16:38:23 +01:00
Riccardo Vianello
7c346d7c2e Code/RDBoost/Exceptions.h moved to Code/RDGeneral 2015-03-16 22:31:48 +01:00
Greg Landrum
7fa02f748b Fixes #430 2015-02-04 13:45:47 +01:00
Greg Landrum
2fbea33612 Fixes #429 2015-02-04 10:20:13 +01:00
Greg Landrum
3f23c91eba did not have the version for breakSomeBonds() quite right 2014-11-22 10:42:17 +01:00
Greg Landrum
1725e22cca allow tracking the number of cuts made by the fragmentation code on a per-atom basis 2014-11-22 07:57:39 +01:00
Greg Landrum
288feb7a8a support partial fragmentation on bonds;
Fixes #288
2014-07-02 05:47:02 +02:00
Greg Landrum
d7971cc40c Fixes #171 2013-12-06 06:54:31 +01:00
Greg Landrum
4ace62f019 remove more clang warnings 2013-12-02 05:10:23 +01:00
Greg Landrum
ea42bf5465 BRICS-related bug fixes 2013-02-05 04:56:10 +00:00
Greg Landrum
89398a10c2 make sure computed props get cleared 2013-01-31 04:54:28 +00:00
Greg Landrum
84d6ddb3f3 add fragmentOnBRICSBonds() 2013-01-30 06:31:06 +00:00
Greg Landrum
fa2b82b606 breaking all BRICS bonds now works 2013-01-29 16:22:27 +00:00
Greg Landrum
00655e7bd6 backup commit; may not build 2013-01-29 06:28:31 +00:00
Greg Landrum
052b87564c add one more test for issue 275 2013-01-09 13:12:27 +00:00
Greg Landrum
03ef0e6f1b Add support for merging recursive queries on the C++ side
(contribution from Sereina Riniker)

A pure Python version of this was in the tutorial material from the RDKit UGM.
2013-01-08 15:13:01 +00:00
Greg Landrum
68e370d581 initial pass at a fix for sf.net issu275 2012-12-18 17:16:06 +00:00
Greg Landrum
bef74c1c81 initial support for reading query files. Python wrapper still needs to be done. 2012-12-17 10:28:35 +00:00
Greg Landrum
57572918de add initial support for addRecursiveQueries to ChemTransforms.
active and tested in C++ and python, in the SWIG wrapper but untested.
still needs linux and windows builds.
2012-12-17 09:06:02 +00:00
Greg Landrum
93f6445e01 minor cleanup to RWMol::insertMol; add combineMols to ChemTransforms 2012-07-10 04:00:46 +00:00
Greg Landrum
2e5b33e2fd fix and test issue 3537675 2012-07-02 03:07:02 +00:00
Greg Landrum
a3dc23c43c more canonicalization improvements
there are still some problems with double bonds
2012-06-11 03:21:30 +00:00
Greg Landrum
3b751bad46 fix and test issue 3453144 2011-12-13 04:56:56 +00:00
Greg Landrum
3ba11316b2 initial pass at requiring core-dummy matches in replaceCore; remove an extra header import from MolOps.cpp 2011-03-28 06:13:48 +00:00
Greg Landrum
633be739b0 - fix an edge case with disconnected molecules in the MurckoDecompose code.
- test that empty results are handled properly in MurckoDecompose.
2011-03-04 06:37:26 +00:00
Greg Landrum
e1e1e5929d fix assignment of dummy positions in replaceCore 2011-03-03 05:02:13 +00:00
Greg Landrum
e2521dccbc add murcko decomposition;
be sure pathToSubmol copies over coordinates
2011-02-21 06:43:53 +00:00
Greg Landrum
f3fbef45c5 update copyright statements 2010-09-26 17:04:37 +00:00
Greg Landrum
76297b0fff builds and passes tests on linux 2009-09-28 11:02:18 +00:00
Greg Landrum
57cd641e50 in replaceCore: support labelling dummies with the index of the corresponding atom in the core 2008-11-06 09:10:38 +00:00
Greg Landrum
b36e6a911f fix a drawing bug
update release notes and docs
implement the new dummy atom stuff in ChemTransforms
expose lists of atom rings and bond rings from RingInfo
2008-05-14 20:20:52 +00:00
Greg Landrum
1d40302dcb This builds and tests correctly with msvc8. Linux and msvc7 tests are still required.
The primary changes consist of cleaning up edge cases that lead to memory errors (under VC8 with debugging turned out)
2008-02-16 05:25:53 +00:00
Greg Landrum
a788e29511 merge the changes from the CanonicalizerRework30Nov branch in.
The changes are revs 451:498.
2008-01-30 14:53:04 +00:00