Commit Graph

4380 Commits

Author SHA1 Message Date
greg landrum
67c1047449 Fixes #4486 2021-09-13 13:57:18 +02:00
greg landrum
4ded91b123 adjustment to fix for #4345 2021-08-24 07:00:29 +02:00
Ric
ad9a58ab58 Addresses #4434 (#4435)
* add index property to v2000 sgroups

* add a simple test

* update old test
2021-08-24 06:38:49 +02:00
Ric
9f75e1d3ad Fixes #4410 (#4414)
* consider reversed bonds

* add test

* check smiles
2021-08-24 06:37:05 +02:00
Greg Landrum
2d7b9a2b47 Fixes #4382 and #4381: two Enumeration related bugs (#4383)
* Fixes #4382

* Fixes #4381
2021-08-24 06:34:54 +02:00
Greg Landrum
c7d50f5ba8 fixes #4345 (#4376)
* fixes #4345
some tests still failing

* changes in response to review
2021-08-24 06:34:21 +02:00
Paolo Tosco
1023a1225e Three more Windows build fixes (#4356)
* - fixes MinGW build
- make sure that supplier istream is opened in binary mode or istream::tellg() will
  report wrong offsets on MinGW builds (MSVC will make no difference)
- avoid that in MSVC conda DLL builds the libboost_*.lib static
  libraries are picked by cmake instead of the boost_*.lib import libraries
  by defining BOOST_ALL_DYN_LINK

* - make sure that C# wrappers build with MinGW compilers
- make sure that static builds work under Windows with both MSVC and
  MinGW

* - disable building static libraries on Windows also when using MinGW compilers
- fix the C# wrapper build on Windows under both MSVC and MinGW

* reverted -DSWIGWORDSIZE64 as it was originally

* reverted -DSWIGWORDSIZE64 definition

Co-authored-by: Paolo Tosco <paolo.tosco@novartis.com>
2021-08-24 06:31:24 +02:00
Greg Landrum
58e0b213a4 Fixes #4364 (#4365) 2021-08-24 06:30:09 +02:00
Greg Landrum
f23fa85b55 Fixes #4346 : trans bonds are now properly honored in macrocycles (#4355)
* remove some compile warnings

* Fixes #4346
2021-08-24 06:23:59 +02:00
Paolo Tosco
235c355fb5 - fixes MinGW build (#4347)
- make sure that supplier istream is opened in binary mode or istream::tellg() will
  report wrong offsets on MinGW builds (MSVC will make no difference)
- avoid that in MSVC conda DLL builds the libboost_*.lib static
  libraries are picked by cmake instead of the boost_*.lib import libraries
  by defining BOOST_ALL_DYN_LINK
2021-08-24 06:22:33 +02:00
Paolo Tosco
c1e582acb1 Fixes RDK_BUILD_THREADSAFE_SSS=OFF build (#4349)
* - fix non-threaded *nix builds that currently fail because
  boost flyweight introduces a dependency on pthreads
- make sure that mutexes and futures are only used when
  RDK_BUILD_THREADSAFE_SSS is ON
- fix SubstructMatch failing test when RDK_BUILD_THREADSAFE_SSS is OFF
  due to misplaced #ifdef's
- rename RDK_TEST_MULTITHREADED to RDK_THREADSAFE_SSS in inchi.cpp
  (which is not a test)

* - the limitexternal Linux build is now single-threaded so we make
  sure single-threaded builds do not break in the future
  (suggestion from Greg)

* reverted unnecessary change to Code/GraphMol/FileParsers/testMultithreadedMolSupplier.cpp

Co-authored-by: Paolo Tosco <paolo.tosco@novartis.com>
2021-08-24 06:20:50 +02:00
Greg Landrum
3ea1157828 Fixes github #4311 (#4312)
* a bit of simple refactoring

* Fixes #4311

- adds getValenceContrib() to QueryBond
- adds hasBondTypeQuery() and hasComplexBondTypeQuery() to QueryOps namespace
- atoms with complex bond type queries now have explict and implicit valences of 0
- adds tests for the above

* add a test
2021-07-09 15:38:02 +02:00
Greg Landrum
d154287300 Fix some problems with perception of ring chirality in spiro-linked systems (#4280)
* add the tests

* backup

* cleanup

* Fixes #4279

* additional testing

* revert the changes to Chirality.cpp
they didn't solve the problem anyway
2021-07-09 15:36:05 +02:00
Greg Landrum
56093132e4 Fixes #4266 (#4270) 2021-07-09 15:34:03 +02:00
Greg Landrum
f1992c2813 Fixes #4256 (#4269)
* Fixes #4256

* the V2000 part of the fix
2021-07-09 15:33:38 +02:00
Paolo Tosco
32dc126316 fixes #4281 (#4282)
Co-authored-by: Paolo Tosco <paolo.tosco@novartis.com>
2021-07-09 15:33:02 +02:00
Greg Landrum
7fbb3085e2 Linux CI modernization (#4285)
* linux CI modernization
- remove 16.04 python builds
- switch 16.04 java build to 20.04

* update

* update

* use dynamic libs
-fPIC never ceases to amuse

* specify swig version

* force swig3

* force swig3

* re-enable the other tests
2021-07-09 15:30:45 +02:00
Matt Swain
b4dfd5fb13 Fix EnumerateStereoisomers for EITHERDOUBLE cis/trans bonds (#4272)
* Fix logic in findPotentialStereoBonds

* Strip EITHERDOUBLE bonds in EnumerateStereoisomers

* Add test for EITHERDOUBLE EnumerateStereoisomers
2021-07-09 15:30:10 +02:00
Greg Landrum
73dc3b742b Fixes #4260 (#4267) 2021-07-09 15:28:13 +02:00
Greg Landrum
c307415284 Fixes #3998 (#4248)
* add KekulizeFragment()

more testing wouldn't be bad

* oversight

* Fixes #3998
2021-07-09 15:27:06 +02:00
Greg Landrum
b56e0bf295 Fix a couple of problems with fingerprint count simulation (#4228)
* Fixes a variety of problems with simulating counts using the FingerprintGenerators from Python

1. the countBounds arguments were not working
2. the GetXXXGenerator() functions used inconsistent naming for the countSimulation argument
3. there were no tests to make sure that the changing countBounds actually did something

* typo
2021-07-09 15:26:30 +02:00
jungb-basf
e46dbeddc9 Update MDLParser.cpp (#4218)
* Update MDLParser.cpp

Fix length of expected strings "BEGIN AGENT" and "END AGENT"

* Add files via upload

* Delete v3k_with_agents.rxn

* fixes #4183

* Update testReaction.cpp

added testcase fixes #4183
2021-07-09 15:24:42 +02:00
Kazuya Ujihara
a0e0f80873 Fix CMakeLists for FileParsers (#4240)
* Fix CMakeLists for FileParsers

* Move find_package place
2021-07-09 15:24:09 +02:00
Greg Landrum
105cbe41a5 double bonds now have EITHER stereo if no coordinates are present (#4239)
speedup for Point3D::angleTo
patch from Roger Sayle
2021-07-09 15:23:04 +02:00
Dan N
569b955dee Issue 4232: MolFromSmiles shouldn't throw (#4235)
MolFromSmiles shouldn't throw even when using SmilesParserParams.
See attached test which failed before this commit.
2021-07-09 15:21:37 +02:00
Greg Landrum
5b73a2a850 allow more recoverable SGroup errors when strictParsing=false (#4210) 2021-07-09 15:21:06 +02:00
Greg Landrum
9338bede74 make a test more permissive (#4197)
* make a test more permissive

* only do that if freetype is installed
2021-06-09 08:04:18 +02:00
Ric
978c3a7c2e fix + test (#4223) 2021-06-09 06:33:17 +02:00
Greg Landrum
5e609a1ba4 Fixes #4212 (#4213) 2021-06-09 06:32:48 +02:00
Ric
6a92cabec8 Fixes #4114 (#4207)
* copy props for reactant/null query bonds

* add test
2021-06-09 06:32:25 +02:00
Greg Landrum
62b382d05a Fixes #4155 (#4192)
removes the shared-bond restriction for potential chiral centers
add support for chiral bridgehead nitrogens
2021-06-09 06:30:30 +02:00
David Cosgrove
094dac0f6c Fix incorrect scaling in grid drawing with radicals. (#4163)
Co-authored-by: David Cosgrove <david@cozchemix.co.uk>
2021-06-09 06:29:52 +02:00
Paolo Tosco
eb171492f5 fixes #4162 (#4171)
Co-authored-by: Paolo Tosco <paolo.tosco@novartis.com>
2021-06-09 06:28:38 +02:00
Greg Landrum
0ea6439fec fixes #4128 (#4178) 2021-06-09 06:28:12 +02:00
Greg Landrum
02779dab73 Fixes #4144 (#4175)
* Fixes #4144

* update the call in EnumerateSteroisomers
2021-06-09 06:23:39 +02:00
Greg Landrum
337282519b Fixes #4167 (#4174) 2021-06-09 06:23:12 +02:00
Greg Landrum
baf3dc87a0 Fixes #4127 (#4129)
Also adds fixes for some related problems I noticed while fixing this one.
2021-06-09 06:22:48 +02:00
Greg Landrum
82aa249744 Fixes #4138 (#4145)
adds a short-circuit test to the substructure matching so that it immediately returns an empty result set if either the molecule or the query is empty
2021-06-09 06:21:30 +02:00
Greg Landrum
7447c1c5f6 Fixes #4099 (#4132)
Fixes #4131
2021-06-09 06:20:30 +02:00
Greg Landrum
9a7ab8d20d Fixes #4099 (#4132)
Fixes #4131
2021-06-09 06:17:57 +02:00
Greg Landrum
92dd624777 Fix #4071 (#4080)
* add test

* Fixes #4071
2021-06-09 06:12:52 +02:00
jfkonecn
435a6b64b5 fixes #3967 (#4190)
* fixes #3967

* modernize test

Co-authored-by: greg landrum <greg.landrum@gmail.com>
2021-06-09 06:12:31 +02:00
Paolo Tosco
50902a3252 Avoid that MolStandardizer segfaults on empty mols (#4119)
* Avoid that MolStandardizer segfaults on empty mols

* changes in response to review

* added missing not operator

Co-authored-by: Paolo Tosco <paolo.tosco@novartis.com>
2021-05-12 09:43:57 +02:00
Greg Landrum
6bbb677a74 Fixes #4122 (#4123) 2021-05-12 09:43:36 +02:00
Greg Landrum
11c68829d2 Fixes #4115 (#4117) 2021-05-12 09:43:15 +02:00
Greg Landrum
4f43abe639 update boost download location in Dockerfile (#4094) 2021-05-12 09:42:55 +02:00
Paolo Tosco
a8c7d86394 avoid that lone atoms which are part of a ring in one of the molecules become part of the MCS (#4065)
Co-authored-by: Paolo Tosco <paolo.tosco@novartis.com>
2021-05-12 09:42:31 +02:00
Paolo Tosco
5fb09e2278 fixes #4019 (#4022)
Co-authored-by: Paolo Tosco <paolo.tosco@novartis.com>
2021-05-12 09:42:05 +02:00
Greg Landrum
1dd03d99f0 Cleanup some problems found during an ASAN build (#4054)
* MolFragmenter: fix a leak when exceptions are thrown

* DistGeomHelpers: fix leaks when exceptions are thrown

* SubstructLibrary: fix usage of invalid memory

* clear up leaks found during ASAN testing
2021-05-12 08:48:15 +02:00
Greg Landrum
56e498e02f Fixes #3944 (#4049) 2021-05-12 08:45:11 +02:00