Commit Graph

16 Commits

Author SHA1 Message Date
sriniker
534a5293ef Improved regression test for ETKDG version 2 (#1640)
* version 2 of ETKDG

* setting default and changing to unsigned int

* ETversion 2 only via EmbedParams available

* Some refactoring so that the DG functions that take the parameter object are the primaries.
This should allow new parameters to be added without having to modify the API

* test and wrapper changes to go along with that

* update cookbook to use etkdg

* regression test for ETKDG version 2 improved
2017-11-15 06:51:05 +01:00
Greg Landrum
cb710340a1 Support ETKDG from within the SWIG wrappers (#1010)
* add test files

* add seed to the mol name so that it is obvious

* add support (and tests) for ETKDG to Java
2016-08-08 11:08:55 +02:00
Greg Landrum
2afeb3b086 Dev/cleanup bad confs (#973)
* passes all tests, but is still not 100 percent there

* generalize _centerInVolume for possible future use

* better testing of tetrahedral centers
update tests

* only test ring atoms

* handle 4-coordinate n too

* add a volume check; not all tests pass

* turn off debug printing

* rearrange the order of tests.
if this is not done, we get a seg fault when the github55 test runs.
the whole thing needs to be run under valgrind to track this down

* clear up a memory leak

* a bit more documentation
add a constant for one of the threshold values

* get more permissive on the energy tests.
Only do the extra tetrahedral tests for atoms in at least two rings.

* add a DEBUG_EMBEDDING option to make tracking down failures easier

* enable better debugging when the flag is set

* remove a FIX

* remove some debug printing from the tests
2016-07-25 14:26:19 -04:00
ptosco
dbf04ca926 The only relevant changes to implement Marcus Martin corrections
to original Rappe' UFF equations are in Code/ForceField/UFF/AngleBend.cpp
and Code/ForceField/UFF/BondStretch.cpp; the changes in
Code/ForceField/UFF/TorsionAngle.cpp are purely cosmetic.

Tests modified according to the small differences in geometries
and energies following the implementation of those corrections:
- Code/ForceField/UFF/testUFFForceField.cpp,
- Code/GraphMol/DistGeomHelpers/Wrap/testDistGeom.py,
- Code/GraphMol/DistGeomHelpers/testDgeomHelpers.cpp,
- Code/GraphMol/MolChemicalFeatures/Wrap/testChemicalFeatures.py,
- rdkit/Chem/Pharm3D/UnitTestEmbed.py

Coordinate files modified according to the small differences in
geometries following the implementation of those corrections:
- Code/GraphMol/DistGeomHelpers/test_data/initCoords.random.sdf
2013-09-24 11:29:33 +02:00
Greg Landrum
3afbb41cfb fix and test issue 3483968 2012-02-05 07:27:40 +00:00
Greg Landrum
37e9a09b77 fix and tests issue 3238580 2011-03-30 02:33:18 +00:00
Greg Landrum
3e0d9a75d0 fix and test sf.net issue 3019283 2010-06-22 05:08:00 +00:00
Greg Landrum
ec192d981e changes to robustify (and somewhat speed up) the optimizer. These will change results 2010-02-28 13:11:34 +00:00
Greg Landrum
74d4dba964 fix and test sf.net issue 2835784;
this should make embedded geometries of fused rings (and around rings)
much better
2009-10-02 04:58:50 +00:00
Greg Landrum
0a99a0155e merge revs 840:846 of Release_Q32008_1RC1 branch back to trunk 2008-09-30 16:29:53 +00:00
Greg Landrum
bdd617e81e convert this to an actual test 2008-09-29 12:42:56 +00:00
Greg Landrum
4d2132c120 merge in changes from uBLAS_8July2008 branch revs 747:760
This switches the rdkit default from using lapack++ to using boost.bindings
2008-09-27 06:59:17 +00:00
Greg Landrum
2620dcba2f first pass at constrained conformation generation 2008-07-15 05:31:45 +00:00
Greg Landrum
d8dfc1191a get more resistant to small roundoff-related problems 2008-01-15 17:16:26 +00:00
Greg Landrum
1bca002c97 fix a minor coordinate problem in the regressions (connected to new chirality handling) 2006-11-22 04:25:24 +00:00
Greg Landrum
75a79b6327 initial import 2006-05-06 22:20:08 +00:00