Commit Graph

36 Commits

Author SHA1 Message Date
Greg Landrum
afe7e3492a Fixes #2027 (#2028)
Also includes a bit of modernization.
2018-09-08 15:31:48 -04:00
Greg Landrum
e396e35b4d Fixes #1691 (#1718)
* add the relevant tests

* Fixes #1691
2018-01-12 11:21:52 -05:00
Greg Landrum
ba12d98ad0 Removes ATOM/BOND_SPTR in boost::graph in favor of raw pointers (#1713)
* Removes ATOM/BOND_SPTR in boost::graph in favor of raw pointers

* Actually delete atoms and bonds...

* RWMol::clear now calls destroy to handle atom/bond deletion

* Changes broken Atom lookup for windows/gcc

* Adds tests for running with valgrind

* Adds test designed for valgrind and molecule deletions

* Removes RNG, actually tests bond deletions

* update swig wrappers

* deal with most recent changes on the main branch
2018-01-07 14:19:47 -05:00
Greg Landrum
636a0f6e69 Cleanup a bunch of compiler warnings (#1697)
* remove a bunch of compiler warnings

* remove some more warnings on windows (there are still plenty to go...)
2017-12-22 12:59:52 +01:00
Greg Landrum
915cf08faa run clang-format with c++-11 style over that 2017-04-22 17:19:10 +02:00
Greg Landrum
7c0bb0b743 clang-tidy output 2017-04-22 17:09:24 +02:00
Greg Landrum
e52cf5c666 Fix/github1286 (#1307)
* clean up the header a bit
clang-format

* clang-format

* add test for #1286

* backup

* fixes the specific failure, but needs more looking

* add an additional test

* update the inchi code to explicitly include queue

* fix a typo identified during the review
2017-03-04 12:35:26 -05:00
Greg Landrum
e625c58bab Add cis/trans tags to double bonds (#1316)
* add cis and trans to bond stereo

* compiles, does not work

* tests all pass

* Whitespace cleanup to recent changes.

* C++ test case for Bond::setStereo using Bond::STEREOCIS and Bond::STEREOTRANS

* Adding a PRECONDITION to Bond::setStereo to make sure the stereo atoms
are already specified if CIS or TRANS is being specified.

E/Z is technically defined by the topology of the molecule so the
stereo atoms are redundant (easier to understand and use!), but
ultimately redundant with the graph. However, CIS and TRANS is _only_
defined in this usage as the orientation of the atoms in the
getStereoAtoms vector.

* Exposing Bond::setStereo to Python and adding test cases to make sure
it can be used to set CIS/TRANS stereochemistry.

* verify substructure matching works

* Adding Bond::setStereoAtoms to C++ Bond class.

This allows setting the atoms to be considered for CIS or TRANS
directly without a much more costly determination of ranking that E/Z
requires.

* Wrap Bond::SetStereoAtoms into python with a new type of test case.

* docs
2017-02-26 08:15:44 -05:00
Greg Landrum
844ca32b70 Fixes #1112 (#1136) 2016-11-01 19:06:55 -04:00
Greg Landrum
126788e473 Fix/github910 (#913)
* A big step towards solving #910

1) Rank atoms by inverse atomic number (ensures Hs go last)
2) Use heavy-atom degree when doing layout (ensures Hs do not change gross geometry)

* basic testing

* take degree into account with ranks too

* further improvements of relative ranking.
definitely need some cleanup of this now

* some cleanup

* add an explicit test
2016-05-20 05:23:12 +01:00
Greg Landrum
e08e0d16d8 first pass, using google style 2015-11-14 14:58:11 +01:00
Greg Landrum
f5cf3322fe code cleanup: removing compiler warnings 2014-05-08 06:06:07 +02:00
Greg Landrum
60a68669da remove more clang warnings 2013-12-02 04:46:46 +01:00
ptosco
ec8eb5a1bf - Changed all occurrences of RDKit::PI into M_PI
- added #ifdef M_PI (...) #endif in all relevant places
- made length() and sqLength() method consistent
  with respect to usage of pow(x, 2) vs x*x in
  Code/Geometry/point.h
- removed gzip-related boost.iostreams dependency and
  replaced with portable "cmake -E tar xzf" command
  in Code/ForceField/MMFF/CMakeLists.txt
2013-09-20 17:45:41 +02:00
Greg Landrum
ab12207777 Fixes #78
This does not address the non-canonical rendering piece -- that will
be considerably more work -- but it does take care of the
epoxides being rendered inside the ring.
2013-08-15 05:52:34 +02:00
Greg Landrum
695ce7de2c fix some depictor cases; make testing a bit smarter 2012-07-02 09:47:45 +00:00
Greg Landrum
3b3d44db16 remove exe property from source files 2011-01-13 04:22:56 +00:00
Greg Landrum
681a30bd61 provisional fix for issue 3135833 2010-12-12 12:05:59 +00:00
Greg Landrum
981840980a fix and test bug 3122141 2010-11-29 11:24:20 +00:00
Greg Landrum
f3fbef45c5 update copyright statements 2010-09-26 17:04:37 +00:00
Greg Landrum
6c2a126f0a fix and test issue 2995724 2010-05-03 05:39:24 +00:00
Greg Landrum
d54a343066 fix issue 2822883 2009-07-17 04:13:01 +00:00
Greg Landrum
dec22b5cfd fix and test sf.net issue 2821647 2009-07-16 05:56:17 +00:00
Greg Landrum
e05580e495 This is a sizeable one: change the way BGL is used so that atoms and bonds are stored as bundled properties
instead of using the property map interface.
A nice side-effect is that the wart of having to use property maps to loop over bonds or atom neighbors
is now gone.
This potentially breaks lots of client C++ code.
2009-02-11 20:19:25 +00:00
Greg Landrum
7043949308 fix and test issue 2303566 2008-11-17 06:51:15 +00:00
Greg Landrum
753099aacb Fix and test sf.net issue 2219400
This includes a change to the behavior of MolOps::getShortestPaths()
2008-11-03 20:11:42 +00:00
Greg Landrum
5088d7fcb4 fix and test issue 2091304 2008-09-23 11:42:36 +00:00
Greg Landrum
e8f3536845 remove a bunch of compiler warnings 2008-05-26 20:05:57 +00:00
Greg Landrum
e201ba2b9e code cleanups 2008-02-19 07:25:39 +00:00
Greg Landrum
1d40302dcb This builds and tests correctly with msvc8. Linux and msvc7 tests are still required.
The primary changes consist of cleaning up edge cases that lead to memory errors (under VC8 with debugging turned out)
2008-02-16 05:25:53 +00:00
Greg Landrum
3c57caabfb partially tested fix for sf.net bug 1894348 2008-02-15 16:13:12 +00:00
Greg Landrum
1ff93384bb fix a susceptibility to round-off error 2007-10-23 05:51:37 +00:00
Santosh Putta
5cf8958732 Functionality to sample rotatable bonds and bond flips at degree 4 nodes to either spread the drawing more or mimic a specified distance matrix 2007-03-13 02:46:15 +00:00
Santosh Putta
6473f5fb97 All typedefs based on points move to point.h - depencies updated here 2006-10-19 23:29:08 +00:00
Greg Landrum
5d03333c22 setup svn keywords (should have done this before import... grn) 2006-05-06 22:54:39 +00:00
Greg Landrum
75a79b6327 initial import 2006-05-06 22:20:08 +00:00