Commit Graph

100 Commits

Author SHA1 Message Date
Greg Landrum
b5595611a6 Fixes Issue 1614 (#1781)
* This makes assignStereochemistry cleanIt=True not remove CIS/TRANS
bond stereo chemistry that was manually added as described in issue #1614.

Incorrect CIS/TRANS stereochemistry will still be removed by
'cleanIt=true' if symmetry is detected. However, this symmetry
detection doesn't work in more complex pseudo-stereo chemistry cases:
bond stereo that depends on other bond stereo to break symmetry; and
bond stereo that depends on other atom stereo centers to break
symmetry. Test cases for these cases have been added ifdef'd in based
on USE_NEW_STEREOCHEMISTRY.

However, getting USE_NEW_STEREOCHEMISTRY to work in a copacetic way is
not trivial, I tried a little bit here to no avail. I'm leaving the
test cases checked in as they should be useful when we decide to make
the plunge into using Canon::chiralRankMolAtoms for symmetry detection
instead of the CIP ranks.

So this fixes at least the glaring issue of STEREOCIS and STEREOTRANS
being incorrectly removed by 'cleanIt=true' when it is indeed valid
stereo. The checks made for symmetry are rudimentary, but don't feel
complete.

* add another test; make what's being tested explicit

* test smiles generation and function when Hs have been added

* add a test that fails

* I think that it's ok to remove this

* backup

* At this point all tests pass.
Bond wedging is now handled even if sanitization is turned off when mol files are read

* adjust to code changes

* fix a couple problems caused by rebase

* update docs
2018-04-01 17:26:09 +02:00
Maciej Wójcikowski
dac6504905 [MRG] Fix PDB reader + add argument to toggle proximity bonding (#1629)
* Add parameter to skip proximity bonding during PDB reading

* Test proximityBonding flag

* Remove multivalent Hs and bonds to metals in PDB

* Add tests for multivalent Hs and metal unbinding

* Remove covalent bonds to waters

* Test unbinding of HOHs

* Refactor funxtions

* Rename flag for cosistency

* Include flavor in double bond perception

* Add metalorganic test (APW ligand)

* Validate input foe IsBlacklistedPair and minor changes.
2017-11-14 03:49:50 +01:00
Greg Landrum
adad6e55c2 Fix two problems with the PDB parsing (#1341)
* Fixes #1029

* Fixes #1340

* add test files
2017-03-04 12:34:27 -05:00
Greg Landrum
7ee348feb3 Fixes #1251 (#1252) 2017-01-09 16:29:06 -05:00
Jan Holst Jensen
5616dc2597 Add support for dative bonds. (#1190)
* Add support for dative bonds to molfile reader plus writer and to SMILES reader (SMILES writer already supports it).
Initial V3000 molfile reader and writer dative bond support by Esben Jannik Bjerrum.

* first pass at adding -> as dative bond in smiles/smarts
more testing required

* all tests pass

* update .cmake files for lex
2016-12-14 09:44:18 +01:00
Greg Landrum
f4a02f5f13 Expanded sequence support (#1140)
* patch from Roger Sayle to support nucleic acids as well as amino acids

* add some tests which do not yet pass

* fix a bug I introduced in residue name parsing

* basic sequence testing

* add some more tests
2016-11-04 04:29:26 +01:00
Greg Landrum
9f9f2cd2d2 support additional trans-uranic elements (#1134)
* support additional trans-uranic elements
- update the atomic data and isotope lists
- update the SMILES and SMARTS parsers

* rebreak an input file
2016-11-03 11:48:31 -04:00
Greg Landrum
f0bb85dfdb Fixes #1049 (#1050)
* fixes #1049
That was almost too easy

* elaborate the test a bit
2016-09-01 09:22:17 +02:00
Greg Landrum
8009b867b5 Fixes #1034: squiggle bonds are now preserved if no sanitization is done (#1043)
* backup commit

* typo

* forgot the test file

* also test that atom chirality is handled properly
2016-08-30 16:02:31 +02:00
Greg Landrum
7a49dd3bb9 fixes #1023 (#1027) 2016-08-18 16:29:29 -04:00
Paolo Tosco
63b6bdef46 - RCSB SDF files which feature right-justified element names can now be parsed (#994)
- added a relevant test
2016-07-27 14:49:52 +02:00
Greg Landrum
d30bf4a6df the fix for #188 also
fixes #192
2016-03-29 13:19:10 +02:00
Greg Landrum
53b6e52765 ok, this time it is a proper fix 2016-03-29 13:09:22 +02:00
Greg Landrum
9a13afba24 Fixes #188 2016-03-29 10:58:56 +02:00
Greg Landrum
2ca85c775f Fixes #741 2016-02-13 05:38:03 +01:00
Greg Landrum
d3bf352940 add test for #611 2015-09-10 16:01:15 +02:00
Paolo Tosco
6551488dcd - changed SDMolSupplier to be tolerant of spurious lines after
a blank line in a property when strictParsing = false; properties
  are truncated after the first blank line. Also spurious lines
  before the first property are tolerated (and ignored)
- added the strictParsing parameter to the setData() method in C++
  and to the SetData method in Python. Previously, when the setData()
  method was invoked, the strictParsing flag could not be set.
  Moreover, df_strictParsing was not initialised , which might result
  in undefined behaviour
- added relevant C++ and Python tests
2015-05-10 22:30:11 +01:00
Greg Landrum
8846f4dbee Fixes #438 2015-02-21 14:20:47 +01:00
Greg Landrum
c6dd83a47c Fixes #360 2014-10-25 12:13:01 +02:00
Greg Landrum
cd03d877fb Fixes #337 2014-10-04 14:44:42 +02:00
Greg Landrum
6b26036f6a Fixes #269 2014-05-23 08:26:26 +02:00
Greg Landrum
684f451352 Fixes #266 2014-05-22 17:34:06 +02:00
Greg Landrum
196c2278fb Fixes #234 2014-03-17 08:33:07 +01:00
Greg Landrum
601c21f19d Fixes #189 2014-03-13 05:23:56 +01:00
Greg Landrum
75be63fd6b merge with trunk 2014-02-09 05:00:18 +01:00
Greg Landrum
0839cf41ad Fixes #210 2014-02-03 05:25:27 +01:00
Greg Landrum
deed4a9acf Merge branch 'Issue194_V3000MolWriter'
Conflicts:
	Code/GraphMol/Chirality.cpp
	Code/GraphMol/FileParsers/test1.cpp
2014-01-22 07:07:27 +01:00
Greg Landrum
aab11535e8 Fixes #196 2014-01-16 02:07:03 -05:00
Greg Landrum
c13a643e06 Fixes #191 2014-01-12 05:42:50 +01:00
Greg Landrum
e38e60d283 Fixes #186 2014-01-11 06:01:30 +01:00
Greg Landrum
5dca39e2f7 Fixes #187 2014-01-11 05:38:11 +01:00
Greg Landrum
f653e9e961 more isotope fixing 2014-01-08 06:51:48 +01:00
Greg Landrum
4b72d1b153 add (non-standard) handling of R groups to v3k mol parser 2014-01-08 05:22:15 +01:00
Greg Landrum
3f90cecd9c Fixes #164 2013-12-31 08:27:09 +01:00
Greg Landrum
ae14fa3bd9 add support for the ZCH and HYD elements in mol files 2013-12-07 17:40:04 +01:00
Greg Landrum
3b0c72c4bf initial pass at ZBO support.
does not yet handle the HYD and ZCH lines
2013-11-30 06:58:03 +01:00
Greg Landrum
1501af51a5 PDB reader/writer fixes;
add MolToMolFile() to python API
2013-10-25 05:02:09 +02:00
Greg Landrum
e0e741bd49 very minimal testing of pdb reading/writing 2013-10-11 16:58:20 +02:00
Greg Landrum
e51d2c1020 Fixes #118 2013-10-05 16:19:02 +02:00
malteseunderdog
83ada4c9ce Fixed GitHub Issue #114
https://github.com/rdkit/rdkit/issues/114
2013-10-05 11:10:32 +01:00
Greg Landrum
cc154d03ee handle isotopic H better from ctabs 2013-08-23 12:59:09 +02:00
Greg Landrum
2546ea0d7a Fixes #82 2013-08-23 09:18:04 +02:00
Greg Landrum
8c70417690 Fixes #88 2013-08-21 20:45:54 +02:00
Greg Landrum
d80ab78f70 initial pass at this 2013-07-15 17:04:15 +02:00
Greg Landrum
6157ec6547 Fix #64 2013-07-09 07:19:24 +02:00
Greg Landrum
8462195001 fix and test GitHub issue 19 2013-04-21 05:22:57 +00:00
Greg Landrum
3aa651d167 fix and test sf.net issue 269 2012-11-23 06:52:30 +00:00
Greg Landrum
33d571850d support skip lines in ctabs;
get sdf property lines that contain only white space working
2012-10-10 10:16:13 +00:00
Greg Landrum
4a3933ed00 fix and test Issue 3557675 2012-08-15 04:21:33 +00:00
Greg Landrum
cfc14230e1 fix issues 3525799 and 3526810
this changes some canonical SMILES
and removes support for "[Xa]" dummy atoms in SMILES
2012-05-18 05:56:45 +00:00