12 Commits

Author SHA1 Message Date
Paolo Tosco
71c4103475 Suppress large amounts of 'BOOST_NO_CXX98_FUNCTION_BASE macro redefined' warnings in clang/emcc builds (#7747) 2025-03-29 20:04:58 +01:00
Greg Landrum
b1890ccf2b remove a bunch of std::endls (#7233) 2024-03-17 06:03:37 +01:00
Ric
bb9dcb92ba fix + test (#4478) 2021-09-04 14:01:56 +02:00
Ric
d8ea75b945 Fixes #4471 (#4472)
* add test

* restore space in continuation lines
2021-09-03 04:47:17 +02:00
Greg Landrum
85078f12c4 Improved sgroup output (#4343)
* write multi-line SGroups more cleanly

* edge cases and more testing

* changes in response to review
2021-07-23 14:22:01 +02:00
Greg Landrum
be77462ba0 Fixes #3768 (#3770)
* Fixes #3768

* changes in response to review

* re-enable a test
2021-02-01 16:45:39 +01:00
Greg Landrum
c7e7614568 Fix #3312 (#3313)
* additional testing: ensure we can delete SubstanceGroups

* fixes #3312

* stupid test mistake

* Fixes #3315
2020-08-01 04:36:34 +02:00
Greg Landrum
83a1e75597 basic handling of XBCORR and XBHEAD (#3242) 2020-06-22 16:54:57 +02:00
Greg Landrum
95613b6279 Allow SubstanceGroups to survive molecule edits (#3170)
* Progress on #3168

* Fixes #3167

* Fixes #3169

* deal with CBONDS too

* test PATOMS

* Fixes #3175

* a bit of code simplification and test updates

still needs more testing

* more testing

* handle s-group hierarchy
also a couple of other changes in response to the review

* add forgotten test file

* changes in response to review
2020-05-19 17:35:08 +02:00
Greg Landrum
5a79190261 rename SGroup -> SubstanceGroup (#2375)
We leave the names of the bit connected with Mol files as SGroups, since that is
appropriate there, but the more generic pieces are renamed
2019-03-30 14:53:24 -04:00
Greg Landrum
b52ad644b2 Robustify parsing of CTABs and SGROUPs (#2283)
* Fixes #2277

* changes in response to review
the big one is to move the PXA parser into the normal mol file parsing

* move the PXA changes to the writer as well

* SCN actually only needs 7 characters

* add test

* fixes in response to review

* handle blanks (instead of zeros) in the counts line.
The ctfile.pdf doc says we should do this

* Make the SGroup reader more robust w.r.t. bad data
The current behavior leads to uncaught exceptions when a line is too short.
This should clear that up so that we always throw the usual FileParseException

* make error messages a bit easier to read
2019-02-21 17:39:39 +01:00
Ric
d26d4b076e Support for parsing/writing SGroups in SD Mol files. (#2138)
* Implementation of SGroups

* remove sample files test

* update gitignore with test outputs

* fix RevisionModifier

* re-enable tests

* backup commit; things seem to work so far

* some refactoring; obvious s group tests pass now

* more refactoring

* everything now out of the public API

* not sure why this was still in there

* rename functions; all tests now pass

* remove getNextFreeSGroupId; readd comment in copy SGroups

* clang-format

* squash-merge current master

* squash merge master

* Address comments on PR

- Update to current master.
- Move SGroup parse time checks to SGroupChecks namespace.
- Store SGroups in ROMOl as vector<SGroups>.
- SGroup methods return referenes instead of pointers.
- Use atom/bond/sgroup indexes for properties instead of pointers.
- Have SGroups inherit from RDProps; move properties to RDProps.
- Remove trivial/unused methods.
- Add a link to the SD specification atop SGroup.h
2019-01-22 15:42:27 +01:00