3 Commits

Author SHA1 Message Date
Paolo Tosco
14ccb65731 Add missing GetRow method and fix Python parameter names (#7575)
* add missing GetRow method and fix Python parameter names

* - return type of getRow() should be unsigned int, not double, since atomicData.Row() returns unsigned int
- added missing overloads

* fix compilation error in test

---------

Co-authored-by: ptosco <paolo.tosco@novartis.com>
2024-06-28 12:47:34 +02:00
Greg Landrum
724716b2c6 Switch to isoelectronic valence model (#7491)
* change valence model to use isolobal analogy

Remove support for five-coordinate C+ and, by analogy, five-coordinate N+2

Removes support for charge states that take atoms past the end of the periodic table
  i.e. [Lv-4] is no longer supported

* update the tests for that

* remove valence state of 6 for Al

* fix representation of phosphate in the mol2 parser

this is a correction of what was done during #5973

* cleanup the exceptions for P, S, As, and Se

* drop valence states:

Si 6, P 7, As 7

* a couple of additional changes from #7397

* update java tests

* fix an inconsistency: Rb now supports valence -1

* documentation

* - replace operator[] with at() for bounds check
- extract some code into a function to avoid duplication
- use TAB as separator throughout in the periodic table data for consistency

* removing the .at() usage

We know that these vectors aren't empty, so there's no need for the bounds check.

---------

Co-authored-by: ptosco <paolo.tosco@novartis.com>
2024-06-25 15:38:49 +02:00
Greg Landrum
029b1e3789 Fixes #7162 (#7220) 2024-03-09 15:40:51 -05:00