Commit Graph

126 Commits

Author SHA1 Message Date
David Cosgrove
9249ca5cc8 Make reaction drawings deal with padding properly. (#6686)
* Make reaction drawings deal with padding properly.

* Move large lambdas into anonymous namespace.
Correct totWidth after scaling plusWidth.

* Update some hashcodes.

* Take out debugging setting.  Bugger.

* Padding on height as well.

* Hash codes.

* Delay padding use in flexiCanvas.

* More centring.

* Light grey background in side_by_side table.

* Tweak agents layout for testReactionCoords.

* Fully ignore missing reagents and products.

* Hash codes.

* Const references.

---------

Co-authored-by: David Cosgrove <david@cozchemix.co.uk>
2023-09-09 06:46:35 +02:00
David Cosgrove
e4419675c1 Catch meanBondLen of 0.0 (#6699)
* Catch meanBondLen of 0.0

* Change PRECONDITION to ValueErrorExecption.

---------

Co-authored-by: David Cosgrove <david@cozchemix.co.uk>
2023-09-08 14:18:26 +02:00
Ric
8176f5c962 Fail CI builds on compiler warnings + some fixes (#6675)
* enable Werror on Mac and Linux

* do not fail on boost multiprecision pessimizing move

* fix eigen array_bounds warning

* Fix unused arg in Rascal MCS

* fix range-loop-construct warning in Rascal MCES

* fix sign mismatched comparison

* drop unused lambda capture

* allow FMCS timeout test more time under Debug (not a warning!)

* fix fwd declaration of struct RascalClusterOptions

* fix deallocator mismatch

* fix two minor leaks

* fix a real leak

* more minor leaks

* fix another real leak, plus some potential ones

* fix std::move preventing copy ellision

* allow longer run time for debug builds

* make maxBondMatchPairs and getLargestFragSize unsigned int

* make snake case camel case

* update to current master, fix new warnings

* update again and more fixes

* add #include <optional>

* fix char array deallocation

* update and fixes in Marvin writer

* unsigned int

* more copy ellision fixes

* more copy ellision fixes, and typos

* and some more
2023-09-02 04:38:45 +02:00
David Cosgrove
6fcd3b2798 Lasso highlights (#6653)
* First working lasso.

* Adjust lasso radii in non-overlapping sets of atoms.

* Move MultiColourHighlightStyle enum out of MolDrawOptions class.
Add Python wrappers.

* Update copyright notices.

* Fix bug where order of lines off arc wasn't clockwise, so circle wasn't trimmed properly.

* Use highlight_bond_map in lassos.

* Fix bug in colour selection for multi-coloured lasso bonds.

* Response to review.

* Attempt to add new option to JSON input.

* Fix bug with larger radii.

* Fix yet another bug with the arc tidying.

* Remove separate colouring of bond highlights in Lasso.

* Fix intersection between line and arc not on end of line.

* Another pernickety fix.

* Tidy.

* I should know better than to use the web editor

---------

Co-authored-by: David Cosgrove <david@cozchemix.co.uk>
Co-authored-by: Greg Landrum <greg.landrum@gmail.com>
2023-08-31 14:50:49 +02:00
David Cosgrove
6f70dc2a7d Github6400 (#6553)
* Fix bug where large padding gave a legend font size of 0.
The padding is now implemented by making a smaller, offset drawing area within the width_ and height_, dimensions drawWidth_, drawHeight_.  The previous drawHeight_ has been replaced by molHeight_.

* Update test results.

* Update hash codes.

* Update test results.

* Update test results for no freetype.

* Update hash codes for no freetype.

* Update hash codes for freetype.

* Update hash codes for no freetype.

* Update hash codes for freetype.

* Update expected test results.

* Update hash codes.

* Fix contour plots not being lined up with atoms.

* Fix shrinkToFit.

* Update expected test result.

* Fix typo in test name.

* Update expected test result.

* Update expected test result.

---------

Co-authored-by: David Cosgrove <david@cozchemix.co.uk>
Co-authored-by: Greg Landrum <greg.landrum@gmail.com>
2023-08-30 12:35:33 +02:00
David Cosgrove
64550f0a26 Check for very close atoms and act accordingly. (#6583)
Co-authored-by: David Cosgrove <david@cozchemix.co.uk>
2023-08-03 18:53:00 +02:00
Ric
d033aee043 Optionally forward Enhanced Stereo Group ids (#6560)
* add id members to StereoGroup class

* add optional read id argument to StereoGroup constructors

* add functions forward Stereo Group Ids and assign the missing ones

* update ops updating stereogroups to forward read id

* update CX Smiles to parse/write stereogroup ids

* Add test cases for stereo group id forwarding/canonicalization

* update mol block (V3K only) to parse/write stereogroup ids

* update pickling to parse/write stereogroup ids

* update cdxml parser to store stereogroup ids

* update mol interchange to parse/write stereogroup ids

* update draw code with new stere group ids

* update test

* add some tests

* Update Code/GraphMol/Wrap/rdmolfiles.cpp

Co-authored-by: Greg Landrum <greg.landrum@gmail.com>

* Update Code/GraphMol/Wrap/rdmolfiles.cpp

Co-authored-by: Greg Landrum <greg.landrum@gmail.com>

* Update Code/GraphMol/Canon.cpp

Co-authored-by: Greg Landrum <greg.landrum@gmail.com>

* Update Code/GraphMol/SmilesParse/CXSmilesOps.cpp

Co-authored-by: Greg Landrum <greg.landrum@gmail.com>

* review

---------

Co-authored-by: Greg Landrum <greg.landrum@gmail.com>
2023-07-27 18:53:40 +02:00
David Cosgrove
a8d9e6de9c Don't call bondNonRing with a 2-label double bond. (#6571) 2023-07-23 06:48:40 +02:00
David Cosgrove
1e16a86648 Fix clash of molecule note with molecule. (Github 6397). (#6444)
Co-authored-by: David Cosgrove <david@cozchemix.co.uk>
2023-06-17 06:00:27 +02:00
Paolo Tosco
a11a9ce607 fixes #6416 (#6425)
Co-authored-by: Tosco, Paolo <paolo.tosco@novartis.com>
2023-06-02 09:33:07 +02:00
Greg Landrum
3b3f613830 Fix #6336 (#6389)
* fixes #6336

* apply the same fix to MolDraw2DJS (it is a no-op at the moment, but still)
2023-05-23 17:38:59 +02:00
Paolo Tosco
fb878bdbe4 exposed queryColour in MolDrawOptions (#6282)
Co-authored-by: Tosco, Paolo <paolo.tosco@novartis.com>
2023-04-14 04:52:59 +02:00
Greg Landrum
93428d5048 Do not include dative bonds in ring finding by default (#6231)
* change default behavior so that dative bonds are not included in ring finding

* make sure that generating 2D coords does not lose the rings

* cleanup some leftover problems
2023-03-30 18:09:24 +02:00
David Cosgrove
0eacf48248 Github6200 (#6213)
* Multi-coloured highlights are polylines.

* Better explanation.

---------

Co-authored-by: David Cosgrove <david@cozchemix.co.uk>
Co-authored-by: Greg Landrum <greg.landrum@gmail.com>
2023-03-23 10:57:25 +01:00
Greg Landrum
cde573d621 add features to allow drawing molecules in arbitrary positions on a large canvas (#6210)
* drawMolecule and drawMolecules should not be virtual

* clarity

* add getMolSize() and flexiMode

* changes in response to review
2023-03-22 17:27:10 +01:00
David Cosgrove
187814e77b Uncross accidentally crossed bonds. (#6187)
Co-authored-by: David Cosgrove <david@cozchemix.co.uk>
2023-03-14 06:39:58 +01:00
David Cosgrove
8d859469c5 Fix drawing of Aminosulfimine Take 2 (#6169)
* Test for Github6160

* Basic fix.  Problem caused by 4 coordinate sulfur.

* Get the test right.

* Fix truncation of double bonds to atom symbols.

* Fix double bond lines if both ends have atomic symbol.

* Tidy.
Add hash codes.

* Response to review.

---------

Co-authored-by: David Cosgrove <david@cozchemix.co.uk>
2023-03-06 17:37:29 +01:00
David Cosgrove
ec5d922eee Github6112 (#6113)
* drawMolACS1996 should not throw with no coords.

* Only calculate coords once.

* Scrub the last bit, it loses the coords again when changing back to ROMol *.

* Hash code check.

* Doh!

* Only generate coords once.

* Always generate 2D coords if needed.

---------

Co-authored-by: David Cosgrove <david@cozchemix.co.uk>
2023-03-01 04:52:34 +01:00
David Cosgrove
cf52e537cb Fix small ACS1996 drawing being cropped. (#6114) 2023-02-20 23:08:45 +01:00
Greg Landrum
ac8cb939d8 Fixes #6106 (#6107) 2023-02-19 10:46:07 -05:00
Paolo Tosco
5a9a79c787 set the useComplexQueryAtomSymbols default value to true (#6102)
Co-authored-by: Tosco, Paolo <paolo.tosco@novartis.com>
2023-02-18 13:15:16 +01:00
Paolo Tosco
53800c616c Enable optional visualization of complex query atoms in a more compact form (#6056)
* enable optional visualization of complex query atoms in a more compact form

* disable alpha channel support on legacy browsers

* - changes in response to review
- added metal queries
- fixed a docstring

* fix Windows build

* gave up and tested indirectly as I really do not want to export internal functions

---------

Co-authored-by: Tosco, Paolo <paolo.tosco@novartis.com>
2023-02-16 12:34:05 +01:00
David Cosgrove
d4085c6e84 Draw at least 3 dashes for a dashed wedge. (#6043)
Co-authored-by: David Cosgrove <david@cozchemix.co.uk>
Co-authored-by: Greg Landrum <greg.landrum@gmail.com>
2023-02-06 21:21:53 +01:00
Paolo Tosco
90c7d3c5d2 fixes #6054 (#6055)
Co-authored-by: Tosco, Paolo <paolo.tosco@novartis.com>
2023-02-05 08:14:56 +01:00
David Cosgrove
e4ece1b0f7 Bad double bond in linear group (#6028)
* Adapt allene drawing code to cope with other linear groups.

* Remove stray debugging write.

* Over-eager tidying remove key aspect of the fix.  Doh.

* Changes after review.

* Better solution that doesn't change the public API.

---------

Co-authored-by: David Cosgrove <david@cozchemix.co.uk>
2023-02-02 04:51:37 +01:00
David Cosgrove
085e20eda8 Fix bug drawing double bond on very small canvas. (#6026)
* Fix bug drawing double bond on very small canvas.

* Changes after review.

---------

Co-authored-by: David Cosgrove <david@cozchemix.co.uk>
2023-01-31 17:33:05 +01:00
Greg Landrum
aa1735705d Swap MolDraw2D from KekulizeMol() to KekulizeIfPossible() (#5976)
* Fixes #5974
Fixes #2164
Fixes #5971

* change in response to review
plus switch off the logging while kekulizing
2023-01-16 09:31:51 +01:00
David Cosgrove
dee548eacb Github5963 (#5978)
* Setup tests.

* Fix bug.

Co-authored-by: David Cosgrove <david@cozchemix.co.uk>
2023-01-15 08:10:49 +01:00
David Cosgrove
6df3da0966 Fixes Github 5949 (#5950)
* Make arrowhead of dative bond a consistent number of pixels in size, based on doubleBondOffset.

* Improve test.

* Clang noticed incorrect order of panelWidth, panelHeight for some tests.

* Fix some hash codes.

* Give correct github issue number.

* Update hash codes.

Co-authored-by: David Cosgrove <david@cozchemix.co.uk>
2023-01-11 09:37:47 +01:00
David Cosgrove
3e2af9309d Fix ellipse extremes calculation. (#5948)
* Fix ellipse extremes calculation.

* Fix tests.

* fix a typo I made during the merge

Co-authored-by: David Cosgrove <david@cozchemix.co.uk>
Co-authored-by: Greg Landrum <greg.landrum@gmail.com>
2023-01-10 12:19:44 +01:00
David Cosgrove
4903b8ea06 Fix drawing of circles in extractVariableBonds. (#5946)
* Fix drawing of circles in extractVariableBonds.

* Prefer absolute test over relative.

Co-authored-by: David Cosgrove <david@cozchemix.co.uk>
2023-01-09 17:41:42 +01:00
David Cosgrove
9657cc6d53 Draw type of SGroups (STY) in picture. (#5775)
* Draw type of SGroups (STY) in picture.

* Move drawBottomLabel from lambda to anonymous namespace.

Co-authored-by: David Cosgrove <david@cozchemix.co.uk>
2022-11-26 17:30:00 +01:00
David Cosgrove
4b0a61de27 Fix right-pointing last bracket in SGroup. (#5776)
Co-authored-by: David Cosgrove <david@cozchemix.co.uk>
2022-11-24 16:52:12 +01:00
Greg Landrum
cfe512ea47 Fixes #5704 (#5705)
* Fixes #5704

* update expected java results
2022-11-14 16:59:26 +01:00
David Cosgrove
eca3f4e67f Github5592 (#5596)
* Use convex hull to order points in bond highlights polygon.

* Extra comment after review.

Co-authored-by: David Cosgrove <david@cozchemix.co.uk>
2022-09-26 10:58:12 +02:00
David Cosgrove
58cdf03097 Fix 5534 (#5535)
* Fix crash in brackets extraction.

* Add hashcode, tidy.

* Remove unused variable.

Co-authored-by: David Cosgrove <david@cozchemix.co.uk>
Co-authored-by: Greg Landrum <greg.landrum@gmail.com>
2022-09-13 15:41:52 +02:00
David Cosgrove
cbdec52048 Fixed scale (#5519)
* Make ACS mode work properly in fixed size drawers.

* Extra comment.

* Update hash codes.

* Export doLinesIntersect.

Co-authored-by: David Cosgrove <david@cozchemix.co.uk>
Co-authored-by: Greg Landrum <greg.landrum@gmail.com>
2022-09-13 12:18:20 +02:00
David Cosgrove
40e27a65bd Fixed drawing of O in aldehydes. (#5515)
* Fixed drawing of O in aldehydes.

* Added DrawColour::operator!=.

* Remove unused variable.

* Export doLinesIntersect for test.

Co-authored-by: David Cosgrove <david@cozchemix.co.uk>
Co-authored-by: Greg Landrum <greg.landrum@gmail.com>
2022-09-12 04:23:38 +02:00
David Cosgrove
383af8895c Fix trans double bonds in large rings. (#5493) 2022-09-06 15:54:56 +02:00
Paolo Tosco
22e99f5e6e MolDraw2D::drawMolecules() should not crash on null molecules (#5503)
* MolDraw2D::drawMolecules() should not crash on null molecules

* changes in response to review

Co-authored-by: Tosco, Paolo <paolo.tosco@novartis.com>
2022-09-06 14:42:47 +02:00
David Cosgrove
d209cbd196 Improved bond highlights (#5484)
* First draft.
Polyline round bond joins is smaller.
Continuous highlight bonds mitre.

* Remove historical and now misleading comment.

* Mitre the continuous bond highlights.

* Better bond highlighting with not continuous highlighting.

* Updated hash codes.  Extra test.

* Updated hash codes.

* Script to update hash codes automatically.

* Fix test.

* Fix test.

* Remove debugging file write.

* Removed redundant code.

* More auto.

* Removed newly redundant function.

* More explanation and an extra example/test.

Co-authored-by: David Cosgrove <david@cozchemix.co.uk>
2022-09-06 12:55:38 +02:00
David Cosgrove
d32cf91c2c Fix bug in bond joins (#5482)
* Fix bug in smoothBondJoins caused by not clearing singleBondLines_ in resetEverything.
Updated test results.

* Changes as result of review.

Co-authored-by: David Cosgrove <david@cozchemix.co.uk>
2022-08-03 13:16:49 +02:00
David Cosgrove
226ac9eab3 Draws a hydrogen atom light blue if not drawing labels. (#5454)
* Draws a hydrogen atom light blue if not drawing labels.

* Newline at end of file.

* Changes requested from review.

Co-authored-by: David Cosgrove <david@cozchemix.co.uk>
2022-08-03 04:47:55 +02:00
Greg Landrum
222e55485d Fixes #5156 (#5412)
* make 2D coord gen more robust w.r.t. sanitization

* Fixes #5156

prepareMolForDrawing() was being called for mols without coords even if the option was disabled
This resolves that

* update expected hashes
2022-07-27 08:21:28 +02:00
David Cosgrove
36a345a3cd Fix poor join between wedge and double bond. (#5452)
Co-authored-by: David Cosgrove <david@cozchemix.co.uk>
2022-07-24 06:45:58 +02:00
David Cosgrove
f9b47d907f Add ACS1996 drawing style (#5425)
* Started on ACS 1996 drawing mode.
Significant change (not by itself, sadly) is that MolDrawOptions::lineWidth has changed from int to double to allow for ACS requirement of 0.6px bond widths.

* Wavy lines and dashed wedges.

* Better dashed wedges.

* Rounder wavy bonds, same as SVG.

* Added FreeSans font for ACS1996 mode.

* Add help functions to write enum classes to ostream.

* Dashed wedge separation now 2.5px between line edges rather than line middles.  Therefore wider gap between lines.

* Increase offset for wavy bond.  Get classes for atoms and bonds in wavy bond correct.

* For SMILES input, option to force wavy and crossed bonds for unspecified stereochem.

* Tidy debugging.

* Extra space round atom labels.

* Extra space between chars in freetype string.

* Reformats.

* Change double bond offset.

* Improve ring double bonds.

* Simple non-ring double bonds all working.

* Tidy.

* All double bonds seem good.

* Remove redundant function.
Move calcTripleBondLines into DrawMol for consistency with calcDoubleBondLines.
Use doubleBondOffset for wavy lines.

* Correct spacing between FT chars.

* Tidying.

* Use MolBlock wedging if there is any.  Needs to be made an option.

* If dashed wedge thick end has bonds of it, stop one dash short.

* Adjust solid wedge ends to line with attached bonds.

* Width of wedge ends now based on double bond separation.

* Change catch_tests.cpp

* Rounder waves in wavy lines.

* Dashed wedges same width even if one dash less..

* Embedded Roboto-Regular font in code.

* Fix docstrings.

* doubleBondTerminal swapped ends.
Deal with O2 - 2 terminal atoms of degree 1.

* Fix terminal double bonds.

* Slightly fatter truncated wedge bonds.

* Fix crash on complicated double bonds.

* Control more assert tests with DO_TEST_ASSERT.

* Fix 2 colour solid wedges.
Fix slanted wedge for morphine (test1_5).

* Change definittion of multipleBondOffset to fraction of mean bond length.

* Don't slant end of solid wedge to atom symbol.

* Fix wiggle separation.

* Fix 2-colour terminal double bonds.

* Fix colours on triple bonds.

* Don't attempt to draw non-existent points in triangle..

* Symmetric bond for P=O and like.

* Fix query bonds.

* Reformatting.

* Tidy up use of font.

* Add FreeSans font and license to $RDBASE/Data/Fonts.

* Draw unspecified stereo as unknown.

* Add check_file_hash.

* Tidying.

* Tidying.

* Start Python wrappers.

* Fix solid wedges for 3-connected atoms.

* Docstrings.

* Tidying.

* Alter width of bond highlights in ACS 1996 mode.

* Expose setACS1996Options and mean BondLength in Python.

* Expose drawMolACS1996Cairo in Python.
Docstrings.

* Extra padding between legend and picture in flexicanvas.

* Python tests.

* Tidy catch tests.

* Tidying.

* Fix catch tests.

* Fix no Freetype tests.

* Draw solid wedge more sensibly..

* Fix bond end at solid wedge.

* Tidy.

* Fix Python Cairo build issues.

* Fix wedge end shape for terminal double bonds.

* Hide the joins at the bond ends.

* Fix gcc pickiness.

* Extra test for no atom labels.

* Change where it looks for FreeSans.ttf for ACS1996 drawings.

* Same number of waves for wavy bonds in SVG and Cairo.

* Same number of waves for wavy bonds in SVG and Cairo.

* rename unspecifiedStereoIsUnknown to markUnspecifiedStereoAsUnknown and move to MolFileStereochem.h

* refactor use of iterators

* py docs update

* undo a bunch of bad formatting changes

* remove FreeSans

* get windows builds working

* Fix problem with Windows build.

* Changes in response to review.

* Align description of unspecifiedStereoIsUnknown in C++ to match Python.

* Still working on file open modes.

* Took out extraneous functions for drawing in ACS1996 mode, including the one that was breaking the windows build.

* Add RDKIT_MOLDRAW2D_EXPORT.

* Fix expected test results.

* Clarified warning.

* RDKIT_MOLDRAW2D_EXPORT missing.

* Windows!

* Update Code/GraphMol/MolDraw2D/rxn_test1.cpp

Co-authored-by: David Cosgrove <david@cozchemix.co.uk>
Co-authored-by: greg landrum <greg.landrum@gmail.com>
2022-07-21 18:11:33 +02:00
David Cosgrove
4352b38574 Add draw option to force use of wedge information in MolBlock if pres… (#5417)
* Add draw option to force use of wedge information in MolBlock if present.

* Add check_file_hash.

* Move reapplyMolBlockWedging to MolFileStereochem and test case.
Expose to Python as ReapplyMolBlockWedging.

Co-authored-by: David Cosgrove <david@cozchemix.co.uk>
2022-07-11 13:52:58 +02:00
Greg Landrum
6a56f02a84 Fixes #5383 (#5391)
* Fixes #5383

* response to review
this is a better fix
2022-07-05 12:55:33 +02:00
Greg Landrum
8676e3da64 Fixes #5386 and #5389 (#5387) 2022-07-01 06:36:26 +02:00
David Cosgrove
b7c9a8b3b7 Add class info for wavy bonds in SVGs. (#5358)
Co-authored-by: David Cosgrove <david@cozchemix.co.uk>
2022-06-13 11:16:51 +02:00