* start to add some human-readable regression-test like examples for RGD
* small examples from JMedChem
* add helper viewer
* make that generate actual JSON
* use JSON of full output for tests
move JSON generation to RGroupUtils.h
* switch to using JSON from files
* add test notebook
* add jupyter testing to the code
* add nbval to linux test env
* add notebook tests to mac and windows too
* add toJSON for columns too
* - allow defining a specific path to Cairo libraries and headers
- link against Xau library if needed
* changes in response to review
* removed the libXau bit as it is not needed
* avoid that if CMAKE_BINARY_DIR==CMAKE_SOURCE_DIR (e.g., conda builds)
export.h is overwritten at each incremental build causing the whole
RDKit to be rebult every time
* use existing CMake function so we don't have to maintain our own
with cmake 3.17.2 the original code produced the following warning:
"The package name passed to `find_package_handle_standard_args` (INCHI) does
not match the name of the calling package (Inchi). This can lead to
problems in calling code that expects `find_package` result variables
(e.g., `_FOUND`) to follow a certain pattern."
* clean up in testDatastructs
* avoid jump on unassigned mem in rxns
* set valgrind error exit code
* update suppressions
* clean up RDValue in testDict
* don't leak mol if parsing Maestro file fails
* don't leak mol if parsing PDB block fails
* cleanup leftover rxns in testReaction
* cleanup mol if CX extensions cannot be parsed
* cleanup leftover mols in smiTest1
* cleanup leftover mols in moldraw2DTest1
* cleanup leftover mols in testSubstructMatch
* make testEnumeration go easier on valgrind
* reduce R counts
* change minimal cmake version to a consistent 3.5
* progress towards a cleanup
* get the basic python deps working
* two more libs
* another round of changes
all tests pass at this point
* next round of changes
all tests pass at this point
* close to done
all tests pass
* very close
* almost done
* shift the RDBoost dependencies around a bit
* remove an extraneous python linkage
this is trying to get the mac builds working again
* Only link to python if it was built shared (#3091)
* change in response to review
Co-Authored-By: Ric <ricrogz@users.noreply.github.com>
* move that suppression of the maybe-uninitialized warning to BoostStartInclude.h
Co-authored-by: Brian Kelley <fustigator@gmail.com>
Co-authored-by: Ric <ricrogz@users.noreply.github.com>
* remove all of the "from __future__" imports
* remove the first batch of rdkit.six imports/uses
* next step of rdkit.six removal
* removing xrange, range, and some maps
* next round of removals
* next round of cleanups
* fix inchi test
* last bits of "from rdkit.six" are gone
* and the last of the six stuff is gone
* strange importlib problem
* do not use new on loggers
* del pointers in testDistGeom
* Update Dict hasNonPOD status on bulk update
* delete new Dicts in memtest1.cpp
* fixes in MolSuppliers and testFMCS
* PeriodicTable singleton as unique_ptr
* fix EEM_arrays leak
* fix leaks in testPBF
* fix ParamCollection leak in test UFF
* fix leaks in MMFF
* clear prop dict before read in in pickler
* fix leaks in testFreeSASA
* fix leaks in test3D
* modernize Dict.h & SmilesParse.cpp
* fix leaks in testQuery
* fix leaks in testCrystalFF
* fix leaks in cxsmilesTest
* fix leaks in Catalog & mol cat test
* fix leaks in ShapeUtils & tests
* fix leaks in testSubgraphs1
* fix leaks testFingerprintGenerators
* fix leaks in Catalog/FilterCatalog
* fix leaks in graphmolqueryTest
* these changes reduce bison parse leaks
* fixed leaks in testChirality.cpp
* fix leaks + 2 tests in testMolWriter
* fix 4m leaks in substructLibraryTest
* small improvements to molTautomerTest; still leaks
* fix leaks in testRGroupDecomp
* fix leaks in test; parser still leaks
* fix leaks in itertest
* fix 4m leaks in testDepictor
* fixes in smatest; still leaking due to parser
* fixes in testSLNParse; still leaking due to parser
* flex/bison: always add atoms with ownership; smarts error cleanup
* fix leaks in testReaction
* fix leaks in testSubstructMatch
* fix leaks in resMolSupplierTest
* fix leaks in testChemTransforms + bug in ChemTransforms
* fix leaks in testPickler
* fix leaks in testMolTransform
* fix leaks in testFragCatalog
* fix leak in testSLNParse. Still leaks due to Smiles
* fixed most leaks in testMolSupplier
* pre bison fix
* fix some atom & bond parse problems; others still fail
* bison smiles & smarts, atoms & bonds more or less fixed
* fix leaks in molopstest.cpp
* fix leaks in testFingerprints, MACCS.cpp & AtomPairs.cpp
* fix leaks in moldraw2Dtest1
* fix leaks in testDescriptors
* fix leaks in testInchi
* fix leaks in testUFFForceFieldHelpers
* fix leaks in hanoiTest & new_canon.h
* fix leaks in testMMFFForceField
* fix leaks in graphmolTest1
* fix leaks in testMMFFForceFieldHelpers
* fix leaks in testDistGeomHelpers
* fix leaks in testMolAlign
* initialize occupancy & temp facto with default values
* fix leak in TautomerTransform
* updated suppressions
* fix testStructChecker
* fix logging & py tests
* fix TautomerTransform class/struct issue
* remove misplaced delete in testSLNParse
* deinit in testAvalonLib1
* fix Avalon-triggered(?) bug in StructChecker/Pattern.cpp
* fix random testMolWriter/Supplier fails
- diversify output file names to avoid clashing.
- unify Writers close/destruct behavior.
- flushing/closing in tests.
* use reset in FFs Params.cpp
* comments on testMMFFForceField
* unrequired 'if's added to mol suppliers
* correct cast in FilterCatalog.h
* use unique_ptr in MACCS Patterns
* remove unrequred if in new_canon
* update & move suppressions
The curl file download fallback option was not saving files as
the correct filename. Instead, it used the -O option, which
saved the files using the remote's name for the file! This
was problematic for files downloaded using specification of git
sha.
* Fixes#1454; still needs a bit more thinking though
* forgot the necessary version bump
* review related cleanup and a fix to allow the SWIG wrappers to be built
* apply (manually) #1807 from @bp-kelley to modern_cxx branch and fix (hopefully) a windows problem
* another windows problem
* another windows problem
* windows now builds locally
* update link targets
* New syntax to import Qt5 dependency in MolDraw2D
* In QTDemo, not necessary to import Qt explicitly because it is automatically imported through target MolDraw2D
* improve import of Cairo dependency
* Remove explicit linking of Cairo in C++ examples
* Use imported targets for Boost
* Using imported CMake targets for Eigen
* Use imported targets for Threads
* Simplify sample CMakeLists
* Remove duplication
* a couple small changes for travis
* typo
* update toolchain to trusty
* switch to requiring at least boost 1.56
* typo
* update boost dependency to pull in the build that has more libraries
* meaningless commit to trigger travis
* switch to ust libc++
* install libc++
* check abi
* try the other one; disable py27 for the moment to speed things up
* switch to c++11, that seems necessary with the conda boost builds at the moment
* re-enable python2.7
* update .gitignore
* foundation for 3D descriptors
move PBF into core
* cleanup work
* a bit more cleanup
* move the principal moments calc to MolTransforms
* cleanup
* cleanups
* add caching of the principal moments and values
* do not include the 3D descriptors in MolDescriptors.h
* the properties are computed
* add PMI descriptors and tests
* add tests for NPR descriptors
* return 0 when the largest PMI is zero
* PMI edge case tests
* NPR edge case tests
* PBF edge case tests
* PBF edge case tests
* more edge cases
* add a few more 3d descriptors
* add defns to docs
* tests for the new descriptors
* add versions to new descriptors
* add 3d descriptors to python wrapper
* add eigen support to the travis build
* try to get non-windows builds working
* remove computeCovarianceMatrix() from java wrapper
* make pmi property names "private"
* - this should fix the problem with "Inchi" being hardcoded into PostgreSQL
* - moved the InChI check code out of the main CMakeLists.txt
into FindInchi.cmake