// // Copyright (C) 2022 Greg Landrum and other RDKit contributors // // @@ All Rights Reserved @@ // This file is part of the RDKit. // The contents are covered by the terms of the BSD license // which is included in the file license.txt, found at the root // of the RDKit source tree. // #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include using namespace RDKit; TEST_CASE("chirality and canonicalization") { SECTION("basics") { auto mol = "F[C@](O)(Cl)C[C@](F)(O)Cl"_smiles; REQUIRE(mol); bool cleanIt = true; bool force = true; MolOps::assignStereochemistry(*mol, cleanIt, force); CIPLabeler::assignCIPLabels(*mol); std::string cip; CHECK(mol->getAtomWithIdx(1)->getPropIfPresent(common_properties::_CIPCode, cip)); CHECK(cip == "S"); CHECK(mol->getAtomWithIdx(5)->getPropIfPresent(common_properties::_CIPCode, cip)); CHECK(cip == "R"); std::vector ranks; bool breakTies = false; Canon::rankMolAtoms(*mol, ranks, breakTies); CHECK(ranks[1] > ranks[5]); mol->getAtomWithIdx(1)->clearProp(common_properties::_CIPCode); mol->getAtomWithIdx(5)->clearProp(common_properties::_CIPCode); Canon::rankMolAtoms(*mol, ranks, breakTies); CHECK(ranks[1] > ranks[5]); } SECTION("same") { auto mol = "F[C@](O)(Cl)C[C@](O)(F)Cl"_smiles; REQUIRE(mol); bool cleanIt = true; bool force = true; MolOps::assignStereochemistry(*mol, cleanIt, force); CIPLabeler::assignCIPLabels(*mol); std::string cip; CHECK(mol->getAtomWithIdx(1)->getPropIfPresent(common_properties::_CIPCode, cip)); CHECK(cip == "S"); CHECK(mol->getAtomWithIdx(5)->getPropIfPresent(common_properties::_CIPCode, cip)); CHECK(cip == "S"); std::vector ranks; bool breakTies = false; Canon::rankMolAtoms(*mol, ranks, breakTies); CHECK(ranks[1] == ranks[5]); mol->getAtomWithIdx(1)->clearProp(common_properties::_CIPCode); mol->getAtomWithIdx(5)->clearProp(common_properties::_CIPCode); Canon::rankMolAtoms(*mol, ranks, breakTies); CHECK(ranks[1] == ranks[5]); } SECTION("dependent") { auto mol = "F[C@](O)(Cl)[C@](F)(O)[C@](F)(O)Cl"_smiles; REQUIRE(mol); bool cleanIt = true; bool force = true; MolOps::assignStereochemistry(*mol, cleanIt, force); CIPLabeler::assignCIPLabels(*mol); std::string cip; CHECK(mol->getAtomWithIdx(1)->getPropIfPresent(common_properties::_CIPCode, cip)); CHECK(cip == "S"); CHECK(mol->getAtomWithIdx(7)->getPropIfPresent(common_properties::_CIPCode, cip)); CHECK(cip == "R"); CHECK(mol->getAtomWithIdx(4)->getPropIfPresent(common_properties::_CIPCode, cip)); CHECK(cip == "r"); std::vector ranks; bool breakTies = false; Canon::rankMolAtoms(*mol, ranks, breakTies); CHECK(ranks[1] > ranks[7]); mol->getAtomWithIdx(1)->clearProp(common_properties::_CIPCode); mol->getAtomWithIdx(4)->clearProp(common_properties::_CIPCode); mol->getAtomWithIdx(7)->clearProp(common_properties::_CIPCode); Canon::rankMolAtoms(*mol, ranks, breakTies); CHECK(ranks[1] > ranks[7]); } SECTION("dependent non-chiral") { auto mol = "F[C@](O)(Cl)[C@](F)(O)[C@](O)(F)Cl"_smiles; REQUIRE(mol); bool cleanIt = false; bool force = true; mol->getAtomWithIdx(4)->setChiralTag(Atom::ChiralType::CHI_TETRAHEDRAL_CCW); MolOps::assignStereochemistry(*mol, cleanIt, force); CIPLabeler::assignCIPLabels(*mol); std::string cip; CHECK(mol->getAtomWithIdx(1)->getPropIfPresent(common_properties::_CIPCode, cip)); CHECK(cip == "S"); CHECK(mol->getAtomWithIdx(7)->getPropIfPresent(common_properties::_CIPCode, cip)); CHECK(cip == "S"); std::vector ranks; bool breakTies = false; Canon::rankMolAtoms(*mol, ranks, breakTies); CHECK(ranks[1] == ranks[7]); mol->getAtomWithIdx(1)->clearProp(common_properties::_CIPCode); mol->getAtomWithIdx(7)->clearProp(common_properties::_CIPCode); Canon::rankMolAtoms(*mol, ranks, breakTies); CHECK(ranks[1] == ranks[7]); } SECTION("swap parity") { auto mol = "F[C@](O)(Cl)C[C@@](O)(Cl)F"_smiles; REQUIRE(mol); bool cleanIt = false; bool force = true; MolOps::assignStereochemistry(*mol, cleanIt, force); CIPLabeler::assignCIPLabels(*mol); std::string cip; CHECK(mol->getAtomWithIdx(1)->getPropIfPresent(common_properties::_CIPCode, cip)); CHECK(cip == "S"); CHECK(mol->getAtomWithIdx(5)->getPropIfPresent(common_properties::_CIPCode, cip)); CHECK(cip == "S"); std::vector ranks; bool breakTies = false; Canon::rankMolAtoms(*mol, ranks, breakTies); CHECK(ranks[1] == ranks[5]); mol->getAtomWithIdx(1)->clearProp(common_properties::_CIPCode); mol->getAtomWithIdx(5)->clearProp(common_properties::_CIPCode); Canon::rankMolAtoms(*mol, ranks, breakTies); CHECK(ranks[1] == ranks[5]); } } TEST_CASE("double bond stereo and canonicalization") { SECTION("basics") { auto mol = "CC=C(F)C(B)C(F)=CC"_smiles; REQUIRE(mol); mol->getBondWithIdx(1)->setStereoAtoms(0, 4); mol->getBondWithIdx(1)->setStereo(Bond::BondStereo::STEREOTRANS); mol->getBondWithIdx(7)->setStereoAtoms(4, 9); mol->getBondWithIdx(7)->setStereo(Bond::BondStereo::STEREOCIS); bool breakTies = false; std::vector ranks; Canon::rankMolAtoms(*mol, ranks, breakTies); mol->getBondWithIdx(1)->setStereo(Bond::BondStereo::STEREOCIS); mol->getBondWithIdx(7)->setStereo(Bond::BondStereo::STEREOTRANS); std::vector ranks2; Canon::rankMolAtoms(*mol, ranks2, breakTies); CHECK(ranks[0] == ranks2[9]); CHECK(ranks[1] == ranks2[8]); CHECK(ranks[2] == ranks2[6]); CHECK(ranks[3] == ranks2[7]); CHECK(ranks[4] == ranks2[4]); CHECK(ranks[5] == ranks2[5]); // same as previous example, different controlling atoms mol->getBondWithIdx(7)->setStereoAtoms(7, 9); mol->getBondWithIdx(7)->setStereo(Bond::BondStereo::STEREOCIS); std::vector ranks3; Canon::rankMolAtoms(*mol, ranks3, breakTies); CHECK(ranks2 == ranks3); } SECTION("STEREOANY is higher priority than STEREONONE") { auto mol = "CC=C(F)C(B)C(F)=CC"_smiles; REQUIRE(mol); mol->getBondWithIdx(7)->setStereoAtoms(4, 9); mol->getBondWithIdx(7)->setStereo(Bond::BondStereo::STEREOANY); bool breakTies = false; std::vector ranks; Canon::rankMolAtoms(*mol, ranks, breakTies); CHECK(ranks[0] < ranks[9]); } } TEST_CASE("enhanced stereo canonicalization") { SECTION("simple chiral tags") { std::vector> tests = { {"C[C@H](F)Cl |&1:1|", "C[C@@H](F)Cl |&1:1|"}, {"C[C@H](F)Cl |o1:1|", "C[C@@H](F)Cl |o1:1|"}, }; for (const auto &[smi1, smi2] : tests) { INFO(smi1 + " : " + smi2); std::unique_ptr mol1{SmilesToMol(smi1)}; REQUIRE(mol1); std::unique_ptr mol2{SmilesToMol(smi2)}; REQUIRE(mol2); Canon::canonicalizeEnhancedStereo(*mol1); Canon::canonicalizeEnhancedStereo(*mol2); CHECK(mol1->getAtomWithIdx(1)->getChiralTag() == mol2->getAtomWithIdx(1)->getChiralTag()); } } SECTION("abs groups are not modified") { std::vector> tests = { {"C[C@H](F)Cl |a:1|", "C[C@@H](F)Cl |a:1|"}, }; for (const auto &[smi1, smi2] : tests) { INFO(smi1 + " : " + smi2); std::unique_ptr mol1{SmilesToMol(smi1)}; REQUIRE(mol1); std::unique_ptr mol2{SmilesToMol(smi2)}; REQUIRE(mol2); Canon::canonicalizeEnhancedStereo(*mol1); Canon::canonicalizeEnhancedStereo(*mol2); CHECK(mol1->getAtomWithIdx(1)->getChiralTag() != mol2->getAtomWithIdx(1)->getChiralTag()); } } SECTION("relative chiral tags") { std::vector> tests = { {"C[C@H](F)[C@H](Br)O |&1:1,3|", "C[C@@H](F)[C@@H](Br)O |&1:1,3|"}, {"C[C@H](F)[C@@H](Br)O |&1:1,3|", "C[C@@H](F)[C@H](Br)O |&1:1,3|"}, {"O[C@H](Br)[C@H](F)C |&1:1,3|", "O[C@@H](Br)[C@@H](F)C |&1:1,3|"}, {"O[C@H](Br)[C@@H](F)C |&1:1,3|", "O[C@@H](Br)[C@H](F)C |&1:1,3|"}, }; for (const auto &[smi1, smi2] : tests) { INFO(smi1 + " : " + smi2); std::unique_ptr mol1{SmilesToMol(smi1)}; REQUIRE(mol1); std::unique_ptr mol2{SmilesToMol(smi2)}; REQUIRE(mol2); Canon::canonicalizeEnhancedStereo(*mol1); Canon::canonicalizeEnhancedStereo(*mol2); CHECK(mol1->getAtomWithIdx(1)->getChiralTag() == mol2->getAtomWithIdx(1)->getChiralTag()); CHECK(mol1->getAtomWithIdx(3)->getChiralTag() == mol2->getAtomWithIdx(3)->getChiralTag()); } } SECTION("multiple groups") { std::vector> tests = { {"C[C@H](F)[C@H](Br)O |&1:1,o2:3|", "C[C@@H](F)[C@@H](Br)O |&1:1,o2:3|"}, {"C[C@H](F)[C@H](Br)O |&1:1,o2:3|", "C[C@@H](F)[C@@H](Br)O |o1:3,&1:1|"}, }; for (const auto &[smi1, smi2] : tests) { INFO(smi1 + " : " + smi2); std::unique_ptr mol1{SmilesToMol(smi1)}; REQUIRE(mol1); std::unique_ptr mol2{SmilesToMol(smi2)}; REQUIRE(mol2); Canon::canonicalizeEnhancedStereo(*mol1); Canon::canonicalizeEnhancedStereo(*mol2); CHECK(mol1->getAtomWithIdx(1)->getChiralTag() == mol2->getAtomWithIdx(1)->getChiralTag()); CHECK(mol1->getAtomWithIdx(3)->getChiralTag() == mol2->getAtomWithIdx(3)->getChiralTag()); } } } TEST_CASE("chiralRandomTest") { SECTION("chiralRandomTest") { std::vector tests = { "CNC(=O)[C@@H](NC(=O)[C@H](OCc1cc(F)ccc1F)[C@@H](O)[C@@H](O)[C@H](OCc1cc(F)ccc1F)C(=O)N[C@H](C(=O)NC)C(C)C)C(C)C |o1:19,23,&1:8,37|", "CNC(=O)C(NC(=O)[C@H](OCc1ccccc1)[C@@H](O)[C@@H](O)[C@H](OCc1ccccc1)C(=O)NC(C(=O)NC)[C@@H](C)O)[C@H](C)O o1:38,41,&1:17,21|", "CCC(=O)NC[C@H]1CN(c2cc(F)c(N3C[C@H]4[C@H](N)[C@H]4C3)c(F)c2)C(=O)O1 |o1:16,17,&1:6,19|", "Cc1cc(O)c([C@@]2(C)CC[C@@H]3C[C@@]32C)cc1-c1cc([C@]2(C)CC[C@H]3C[C@@]32C)c(O)cc1C |o1:6,23,&1:19,25|", "C[N+]12CC[C@@]34c5ccccc5N5[C@@H]6OCC=C7C[N+]8(C)CC[C@]9%10c%11ccccc%11N([C@@H]%11OCC=C(C1)[C@H](C[C@@H]32)[C@@H]%11[C@H]54)[C@H]9[C@H]6[C@H]7C[C@@H]%108.[Cl-].[Cl-] |o1:42,45,&1:22,41|", "Cl.Oc1ccc2c3c1O[C@H]1c4[nH]c5c(c4C[C@@]4(O)[C@@H](C2)N(CC2CC2)CC[C@]314)C[C@]1(O)[C@H]2Cc3ccc(O)c4c3[C@]1(CCN2CC1CC1)[C@H]5O4 |o1:29,40,&1:16,48|", "O=C1NC(=O)c2c1c1c3ccccc3n3c1c1c2c2ccccc2n1[C@@H]1[C@H](O)[C@H](O)[C@H](O)[C@H]3N1Cc1ccccc1 |o1:26,32,&1:25,30|", "CC1=C(N2C=CC=C2[C@H](C)Cl)C(C)CCC1 |(2.679,0.4142,;1.3509,1.181,;0.0229,0.4141,;0.0229,-1.1195,;1.2645,-2.0302,;0.7901,-3.4813,;-0.7446,-3.4813,;-1.219,-2.0302,;-2.679,-1.5609,;-3.0039,-0.0556,;-3.8202,-2.595,;-1.3054,1.1809,;-2.6335,0.4141,;-1.3054,2.7145,;0.0229,3.4813,;1.3509,2.7146,),wD:2.11,wU:8.10,&1:8|", "O=C(CCCc1ccccc1)OC[C@H]1C[C@@H]2O[C@H]1[C@@H]1[C@H]2C(=O)OC1=O |a:18,19,o1:13,15,17|", "CC1=CC[C@H]2[C@H](C1)c1c(O)cc(C=C3C4CC5CC(C4)CC3C5)cc1OC2(C)C |&1:4,5|", "O=C(O)C(F)(F)F.O=C(O)[C@@]1(N(CCn2cnc3ncncc32)S(=O)(=O)c2ccc(-c3ccc(Cl)cc3)cc2)C[C@H]1c1ccccc1 |o1:10,40|", "CCCCNC1N[C@H](CO)[C@@H](O)[C@@H](O)[C@H](CO)N1 |a:12,&2:10,&1:7,14|", "CCCCNC1N[C@H](CO)[C@@H](O)[C@@H](O)[C@H](CO)N1 |a:10,12,&1:7,14|", "CCCCNC1N[C@H](CO)C(O)[C@@H](O)[C@H](CO)N1 |a:12,&1:7,14|", "CCNC(=O)c1ccc(/C(=C2/C[C@H]3CC[C@@H](C2)N3CCc2ccccc2)c2ccccc2)cc1 |&1:12,15|", "C[C@H](O)[C@@H](C)[C@H](C)[C@H](C)O |&1:1,&2:3,5,&3:7|", "C[C@@H](Cl)C[C@H](C)Cl |a:1,4,|", "C[C@H](Cl)C[C@@H](C)Cl |a:1,4,|", "N[C@H]1CC[C@@H](O)CC1 |a:1,4|", "N[C@H]1CC[C@@H](O)CC1 |a:1,4|", "N[C@H]1CC[C@@H](O)CC1 |a:1,4|", "N[C@H]1CC[C@@H](O)CC1 |a:1,4|", "N[C@H]1CC[C@@H](O)CC1 |a:1,4|", "C[C@H]1CC[C@H](CC1)C1CC(CC(C1)[C@@H]1CC[C@H](C)CC1)[C@@H]1CC[C@H](C)CC1 |o1:23,o2:20,o3:13,o4:16,o5: ,&6:1|", "C[C@H]1CC[C@H](CC1)C1CC(CC(C1)[C@@H]1CC[C@H](C)CC1)[C@@H]1CC[C@H](C)CC1 |o1:23,o2:20,o3:13,o4:16,o5:4,o6:1|", "C[C@H]1CC[C@@H](C[C@@H]2CC[C@H](C)CC2)CC1 |a:9,o1:6,&1:4,&2:1|", "C[C@H]1CC[C@@H](C[C@@H]2CC[C@H](C)CC2)CC1 |o1:6,o2:1,9,o3:4|", "C[C@H]1CC[C@@H](C[C@@H]2CC[C@H](C)CC2)CC1 |o1:6,o2:1,9,o3:4|", "N[C@H]1CC[C@@H](O)CC1", "N[C@H]1CC[C@@H](O)CC1 |o2:1,4|", "N[C@H]1CC[C@@H](O)CC1 |&2:1,4|", "N[C@H]1CC[C@@H](O)CC1 |a:1,4|", // no enhanced stereo "CC(C)[C@H]1CCCCN1C(=O)[C@H]1CC[C@@H](C)CC1", // enhance stereo abs,abs,abs "CC(C)[C@H]1CCCCN1C(=O)[C@H]1CC[C@@H](C)CC1 |a:3,11,14|", // abs, abs, or and abs, or abs "CC(C)[C@H]1CCCCN1C(=O)[C@H]1CC[C@@H](C)CC1 |a:3,11,o1:14|", "CC(C)[C@H]1CCCCN1C(=O)[C@H]1CC[C@@H](C)CC1 |a:3,11,o1:14|", "CC(C)[C@H]1CCCCN1C(=O)[C@H]1CC[C@@H](C)CC1 |a:3,11,o1:14|", "CC(C)[C@H]1CCCCN1C(=O)[C@H]1CC[C@@H](C)CC1 |a:3,11,&1:14|", "CC(C)[C@H]1CCCCN1C(=O)[C@H]1CC[C@@H](C)CC1 |a:3,11,&1:14|", "CC(C)[C@H]1CCCCN1C(=O)[C@H]1CC[C@@H](C)CC1 |a:3,11,&1:14|", }; UseLegacyStereoPerceptionFixture reset_stereo_perception{false}; for (const auto &smi1 : tests) { INFO(smi1); SmilesParserParams rps; rps.sanitize = true; rps.removeHs = false; std::unique_ptr mol1{SmilesToMol(smi1, rps)}; REQUIRE(mol1); std::vector idxV(mol1->getNumAtoms()); for (unsigned int i = 0; i < mol1->getNumAtoms(); ++i) { idxV[i] = i; } std::string smiExpected = ""; auto randomGen = std::mt19937(0xf00d); for (auto i = 0; i < 100; ++i) { std::vector nVect(idxV); if (i > 0) { std::shuffle(nVect.begin(), nVect.end(), randomGen); } std::unique_ptr nmol{MolOps::renumberAtoms(*mol1, nVect)}; RDKit::canonicalizeStereoGroups(nmol); auto outSmi1 = MolToCXSmiles(*nmol); if (smiExpected == "") { smiExpected = outSmi1; } else { CHECK(outSmi1 == smiExpected); } } } } } TEST_CASE("pseudoTestCanonFailure") { SECTION("canonFailure") { UseLegacyStereoPerceptionFixture reset_stereo_perception{false}; std::string smi1 = "C[C@H]1CC[C@@H](C[C@@H]2CC[C@H](C)CC2)CC1 |&1:4,&2:1|"; SmilesParserParams rps; rps.sanitize = true; rps.removeHs = false; std::unique_ptr mol1{SmilesToMol(smi1, rps)}; REQUIRE(mol1); std::vector idxV(mol1->getNumAtoms()); for (unsigned int i = 0; i < mol1->getNumAtoms(); ++i) { idxV[i] = i; } auto randomGen = std::mt19937(0xf00d); std::vector nVect(idxV); std::shuffle(nVect.begin(), nVect.end(), randomGen); std::unique_ptr nmol{MolOps::renumberAtoms(*mol1, nVect)}; RDKit::canonicalizeStereoGroups(mol1); RDKit::canonicalizeStereoGroups(nmol); SmilesWriteParams wp; wp.canonical = false; auto outSmi1Check = MolToCXSmiles(*mol1, wp); auto outSmi1Check2 = MolToCXSmiles(*nmol, wp); CHECK(outSmi1Check == outSmi1Check2); wp.canonical = true; outSmi1Check = MolToCXSmiles(*mol1, wp); outSmi1Check2 = MolToCXSmiles(*nmol, wp); CHECK(outSmi1Check == outSmi1Check2); } } TEST_CASE("pseudoTest1") { SECTION("pseudoTest1") { std::vector> tests = { {"CC1=C(N2C=CC=C2[C@H](C)Cl)C(C)CCC1 |(2.679,0.4142,;1.3509,1.181,;0.0229,0.4141,;0.0229,-1.1195,;1.2645,-2.0302,;0.7901,-3.4813,;-0.7446,-3.4813,;-1.219,-2.0302,;-2.679,-1.5609,;-3.0039,-0.0556,;-3.8202,-2.595,;-1.3054,1.1809,;-2.6335,0.4141,;-1.3054,2.7145,;0.0229,3.4813,;1.3509,2.7146,),wD:2.11,wU:8.10,&1:8|", "CC1=C(N2C=CC=C2[C@H](C)Cl)C(C)CCC1 |(2.679,0.4142,;1.3509,1.181,;0.0229,0.4141,;0.0229,-1.1195,;1.2645,-2.0302,;0.7901,-3.4813,;-0.7446,-3.4813,;-1.219,-2.0302,;-2.679,-1.5609,;-3.0039,-0.0556,;-3.8202,-2.595,;-1.3054,1.1809,;-2.6335,0.4141,;-1.3054,2.7145,;0.0229,3.4813,;1.3509,2.7146,),wD:2.11,wU:8.10,a:2,&1:8|", "CC1=C(n2cccc2[C@H](C)Cl)C(C)CCC1 |(2.679,0.4142,;1.3509,1.181,;0.0229,0.4141,;0.0229,-1.1195,;1.2645,-2.0302,;0.7901,-3.4813,;-0.7446,-3.4813,;-1.219,-2.0302,;-2.679,-1.5609,;-3.0039,-0.0556,;-3.8202,-2.595,;-1.3054,1.1809,;-2.6335,0.4141,;-1.3054,2.7145,;0.0229,3.4813,;1.3509,2.7146,),wD:8.9,2.11,a:2,&1:8|"}, {"O=C(CCCc1ccccc1)OC[C@H]1C[C@@H]2O[C@H]1[C@@H]1[C@H]2C(=O)OC1=O |a:18,19,o1:13,15,17|", "O=C(CCCc1ccccc1)OC[C@@H]1C[C@H]2O[C@@H]1[C@@H]1[C@H]2C(=O)OC1=O |a:18,19,o1:13,15,17|", "O=C(CCCc1ccccc1)OC[C@@H]1C[C@H]2O[C@@H]1[C@H]1C(=O)OC(=O)[C@H]12 |a:18,24,o1:13,15,17|"}, {"CC1=CC[C@H]2[C@H](C1)c1c(O)cc(C=C3C4CC5CC(C4)CC3C5)cc1OC2(C)C |&1:4,5|", "CC1=CC[C@@H]2[C@@H](C1)c1c(O)cc(C=C3C4CC5CC(C4)CC3C5)cc1OC2(C)C |&1:4,5|", "CC1=CC[C@H]2[C@H](C1)c1c(O)cc(C=C3C4CC5CC(C4)CC3C5)cc1OC2(C)C |&1:4,5|"}, {"O=C(O)C(F)(F)F.O=C(O)[C@@]1(N(CCn2cnc3ncncc32)S(=O)(=O)c2ccc(-c3ccc(Cl)cc3)cc2)C[C@H]1c1ccccc1 |o1:10,40|", "O=C(O)[C@@]1(N(CCn2cnc3ncncc32)S(=O)(=O)c2ccc(-c3ccc(Cl)cc3)cc2)C[C@H]1c1ccccc1.O=C(O)C(F)(F)F |o1:3,33|", "O=C(O)C(F)(F)F.O=C(O)[C@@]1(N(CCn2cnc3ncncc32)S(=O)(=O)c2ccc(-c3ccc(Cl)cc3)cc2)C[C@H]1c1ccccc1 |o1:10,40|"}, {"CCCCNC1N[C@H](CO)[C@@H](O)[C@@H](O)[C@H](CO)N1 |a:12,&2:10,&1:7,14|", "CCCCNC1N[C@@H](CO)[C@H](O)[C@H](O)[C@@H](CO)N1 |a:7,14,&1:10,&2:12|", "CCCCNC1N[C@@H](CO)[C@H](O)[C@H](O)[C@@H](CO)N1 |a:7,14,&1:10,&2:12|"}, {"CCCCNC1N[C@H](CO)[C@@H](O)[C@@H](O)[C@H](CO)N1 |a:10,12,&1:7,14|", "CCCCNC1N[C@@H](CO)[C@@H](O)[C@@H](O)[C@@H](CO)N1 |a:10,12,&1:7,14|", "CCCCNC1N[C@@H](CO)[C@H](O)[C@H](O)[C@@H](CO)N1 |a:7,14,&1:10,12|"}, {"CCCCNC1N[C@H](CO)C(O)[C@@H](O)[C@H](CO)N1 |a:12,&1:7,14|", "CCCCNC1N[C@@H](CO)C(O)[C@@H](O)[C@@H](CO)N1 |a:12,&1:7,14|", "CCCCNC1N[C@H](CO)C(O)[C@@H](O)[C@H](CO)N1 |a:12,&1:7,14|"}, {"CCNC(=O)c1ccc(/C(=C2/C[C@H]3CC[C@@H](C2)N3CCc2ccccc2)c2ccccc2)cc1 |&1:12,15|", "CCNC(=O)c1ccc(\\C(=C2/C[C@@H]3CC[C@H](C2)N3CCc2ccccc2)c2ccccc2)cc1 |&1:12,15|", "CCNC(=O)c1ccc(/C(=C2/C[C@H]3CC[C@@H](C2)N3CCc2ccccc2)c2ccccc2)cc1"}, {"C[C@H](O)[C@@H](C)[C@H](C)[C@H](C)O |&1:1,&2:3,5,&3:7|", "C[C@H](O)[C@H](C)[C@@H](C)[C@H](C)O |&1:1,&2:3,5,&3:7|", "C[C@H](O)[C@H](C)[C@@H](C)[C@H](C)O |&1:1,&2:3,5,&3:7|"}, {"C[C@@H](Cl)C[C@H](C)Cl |a:1,4,|", "C[C@@H](Cl)C[C@H](C)Cl |o1:1,4,|", "C[C@H](Cl)C[C@@H](C)Cl"}, {"C[C@H](Cl)C[C@@H](C)Cl |a:1,4,|", "C[C@@H](Cl)C[C@H](C)Cl |&1:1,4,|", "C[C@H](Cl)C[C@@H](C)Cl"}, {"N[C@H]1CC[C@@H](O)CC1 |a:1,4|", "N[C@H]1CC[C@@H](O)CC1 |o1:1,4|", "N[C@H]1CC[C@@H](O)CC1"}, {"N[C@H]1CC[C@@H](O)CC1 |a:1,4|", "N[C@H]1CC[C@@H](O)CC1 |&1:1,4|", "N[C@H]1CC[C@@H](O)CC1"}, {"N[C@H]1CC[C@@H](O)CC1 |a:1,4|", "N[C@@H]1CC[C@H](O)CC1 |a:1,4|", "N[C@H]1CC[C@@H](O)CC1"}, {"N[C@H]1CC[C@@H](O)CC1 |a:1,4|", "N[C@@H]1CC[C@H](O)CC1 |o1:1,4|", "N[C@H]1CC[C@@H](O)CC1"}, {"N[C@H]1CC[C@@H](O)CC1 |a:1,4|", "N[C@@H]1CC[C@H](O)CC1 |&1:1,4|", "N[C@H]1CC[C@@H](O)CC1"}, // {"C[C@H]1C[C@@H](C)C[C@@H](C)C1 |o1:1,o2:6,o3:3|", // "C[C@@H]1C[C@H](C)C[C@@H](C)C1 |a:3,o1:6,o3:1|", // "CC1CC(C)CC(C)C1"}, // this excercises a bug in the new canon - // these // // are ring stereo atoms but the chiral // markers // // are removed! {"C[C@H]1CC[C@H](CC1)C1CC(CC(C1)[C@@H]1CC[C@H](C)CC1)[C@@H]1CC[C@H](C)CC1 |o1:23,o2:20,o3:13,o4:16,o5:4,&6:1|", "C[C@H]1CC[C@@H](CC1)C1CC(CC(C1)[C@H]1CC[C@H](C)CC1)[C@H]1CC[C@H](C)CC1 |a:1,13,20,o2:4,o6:16,&4:23|", "C[C@H]1CC[C@@H](C2CC([C@H]3CC[C@@H](C)CC3)CC([C@H]3CC[C@@H](C)CC3)C2)CC1 |a:4,8,17,o1:1,o2:11,&1:20|"}, {"C[C@H]1CC[C@H](CC1)C1CC(CC(C1)[C@@H]1CC[C@H](C)CC1)[C@@H]1CC[C@H](C)CC1 |o1:23,o2:20,o3:13,o4:16,o5:4,o6:1|", "C[C@H]1CC[C@@H](CC1)C1CC(CC(C1)[C@H]1CC[C@H](C)CC1)[C@H]1CC[C@H](C)CC1 |a:4,13,23,o2:20,o4:16,o6:1|", "C[C@H]1CC[C@@H](C2CC([C@H]3CC[C@@H](C)CC3)CC([C@H]3CC[C@@H](C)CC3)C2)CC1 |a:4,8,17,o1:1,o2:11,o3:20|"}, {"C[C@H]1CC[C@@H](C[C@@H]2CC[C@H](C)CC2)CC1 |a:9,o1:6,&1:4,&2:1|", "C[C@H]1CC[C@H](C[C@H]2CC[C@H](C)CC2)CC1 |a:4,9,&1:6,o2:1|", "C[C@H]1CC[C@@H](C[C@H]2CC[C@@H](C)CC2)CC1 |a:4,6,o1:1,&1:9|"}, {"C[C@H]1CC[C@@H](C[C@@H]2CC[C@H](C)CC2)CC1 |o1:6,o2:1,9,o3:4|", "C[C@H]1CC[C@H](C[C@H]2CC[C@H](C)CC2)CC1 |o1:6,o2:1,9,o3:4|", "C[C@H]1CC[C@@H](C[C@H]2CC[C@@H](C)CC2)CC1 |a:4,6,o1:1,o2:9|"}, {"C[C@H]1CC[C@@H](C[C@@H]2CC[C@H](C)CC2)CC1 |o1:6,o2:1,9,o3:4|", "C[C@H]1CC[C@H](C[C@H]2CC[C@H](C)CC2)CC1 |a:4,9,o1:6,o2:1|", "C[C@H]1CC[C@@H](C[C@H]2CC[C@@H](C)CC2)CC1 |a:4,6,o1:1,o2:9|"}, {"N[C@H]1CC[C@@H](O)CC1", "N[C@@H]1CC[C@H](O)CC1", "N[C@H]1CC[C@@H](O)CC1"}, {"N[C@H]1CC[C@@H](O)CC1 |o2:1,4|", "N[C@@H]1CC[C@H](O)CC1 |o2:1,4|", "N[C@H]1CC[C@@H](O)CC1"}, {"N[C@H]1CC[C@@H](O)CC1 |&2:1,4|", "N[C@@H]1CC[C@H](O)CC1 |&2:1,4|", "N[C@H]1CC[C@@H](O)CC1"}, {"N[C@H]1CC[C@@H](O)CC1 |a:1,4|", "N[C@@H]1CC[C@H](O)CC1 |a:1,4|", "N[C@H]1CC[C@@H](O)CC1"}, // no enhanced stereo {"CC(C)[C@H]1CCCCN1C(=O)[C@H]1CC[C@@H](C)CC1", "CC(C)[C@H]1CCCCN1C(=O)[C@@H]1CC[C@H](C)CC1", "CC(C)[C@H]1CCCCN1C(=O)[C@H]1CC[C@@H](C)CC1"}, // enhance stereo abs,abs,abs {"CC(C)[C@H]1CCCCN1C(=O)[C@H]1CC[C@@H](C)CC1 |a:3,11,14|", "CC(C)[C@H]1CCCCN1C(=O)[C@@H]1CC[C@H](C)CC1 |a:3,11,14|", "CC(C)[C@H]1CCCCN1C(=O)[C@H]1CC[C@@H](C)CC1"}, // abs, abs, or and abs, or abs {"CC(C)[C@H]1CCCCN1C(=O)[C@H]1CC[C@@H](C)CC1 |a:3,11,o1:14|", "CC(C)[C@H]1CCCCN1C(=O)[C@H]1CC[C@H](C)CC1 |a:3,11,o1:14|", "CC(C)[C@H]1CCCCN1C(=O)[C@H]1CC[C@H](C)CC1 |a:3,11,o1:14|"}, {"CC(C)[C@H]1CCCCN1C(=O)[C@H]1CC[C@@H](C)CC1 |a:3,11,o1:14|", "CC(C)[C@H]1CCCCN1C(=O)[C@H]1CC[C@H](C)CC1 |a:3,14,o1:11|", "CC(C)[C@H]1CCCCN1C(=O)[C@H]1CC[C@H](C)CC1 |a:3,11,o1:14|"}, {"CC(C)[C@H]1CCCCN1C(=O)[C@H]1CC[C@@H](C)CC1 |a:3,11,o1:14|", "CC(C)[C@H]1CCCCN1C(=O)[C@H]1CC[C@@H](C)CC1 |a:3,o1:11,o2:14|", "CC(C)[C@H]1CCCCN1C(=O)[C@H]1CC[C@H](C)CC1 |a:3,11,o1:14|"}, {"CC(C)[C@H]1CCCCN1C(=O)[C@H]1CC[C@@H](C)CC1 |a:3,11,&1:14|", "CC(C)[C@H]1CCCCN1C(=O)[C@H]1CC[C@H](C)CC1 |a:3,11,&1:14|", "CC(C)[C@H]1CCCCN1C(=O)[C@H]1CC[C@H](C)CC1 |a:3,11,&1:14|"}, {"CC(C)[C@H]1CCCCN1C(=O)[C@H]1CC[C@@H](C)CC1 |a:3,11,&1:14|", "CC(C)[C@H]1CCCCN1C(=O)[C@H]1CC[C@H](C)CC1 |a:3,14,&1:11|", "CC(C)[C@H]1CCCCN1C(=O)[C@H]1CC[C@H](C)CC1 |a:3,11,&1:14|"}, {"CC(C)[C@H]1CCCCN1C(=O)[C@H]1CC[C@@H](C)CC1 |a:3,11,&1:14|", "CC(C)[C@H]1CCCCN1C(=O)[C@H]1CC[C@@H](C)CC1 |a:3,&1:11,&2:14|", "CC(C)[C@H]1CCCCN1C(=O)[C@H]1CC[C@H](C)CC1 |a:3,11,&1:14|"}, }; UseLegacyStereoPerceptionFixture reset_stereo_perception{false}; for (const auto &[smi1, smi2, smiExpected] : tests) { INFO(smi1 + " : " + smi2 + " : " + smiExpected); SmilesParserParams rps; rps.sanitize = true; rps.removeHs = false; std::unique_ptr mol1{SmilesToMol(smi1, rps)}; REQUIRE(mol1); std::unique_ptr mol2{SmilesToMol(smi2, rps)}; REQUIRE(mol2); std::vector idxV(mol1->getNumAtoms()); for (unsigned int i = 0; i < mol1->getNumAtoms(); ++i) { idxV[i] = i; } RDKit::canonicalizeStereoGroups(mol2); auto outSmi2 = MolToCXSmiles(*mol2); REQUIRE(outSmi2 == smiExpected); auto randomGen = std::mt19937(0xf00d); for (auto i = 0; i < 100; ++i) { INFO("i: " << i); std::vector nVect(idxV); std::shuffle(nVect.begin(), nVect.end(), randomGen); std::unique_ptr nmol{MolOps::renumberAtoms(*mol1, nVect)}; RDKit::canonicalizeStereoGroups(nmol); auto outSmi1 = MolToCXSmiles(*nmol); CHECK(outSmi1 == outSmi2); CHECK(outSmi1 == smiExpected); } } } SECTION("pseudoTestFails") { std::vector tests = { "CNC(=O)[C@@H](NC(=O)[C@H](OCc1cc(F)ccc1F)[C@@H](O)[C@@H](O)[C@H](OCc1cc(F)ccc1F)C(=O)N[C@H](C(=O)NC)C(C)C)C(C)C |o1:19,23,&1:8,37|", "CNC(=O)C(NC(=O)[C@H](OCc1ccccc1)[C@@H](O)[C@@H](O)[C@H](OCc1ccccc1)C(=O)NC(C(=O)NC)[C@@H](C)O)[C@H](C)O |o1:38,41,&1:17,21|", "CCC(=O)NC[C@H]1CN(c2cc(F)c(N3C[C@H]4[C@H](N)[C@H]4C3)c(F)c2)C(=O)O1 |o1:16,17,&1:6,19|", "Cc1cc(O)c([C@@]2(C)CC[C@@H]3C[C@@]32C)cc1-c1cc([C@]2(C)CC[C@H]3C[C@@]32C)c(O)cc1C |o1:6,23,&1:19,25|", "C[N+]12CC[C@@]34c5ccccc5N5[C@@H]6OCC=C7C[N+]8(C)CC[C@]9%10c%11ccccc%11N([C@@H]%11OCC=C(C1)[C@H](C[C@@H]32)[C@@H]%11[C@H]54)[C@H]9[C@H]6[C@H]7C[C@@H]%108.[Cl-].[Cl-] |o1:42,45,&1:22,41|", "Cl.Oc1ccc2c3c1O[C@H]1c4[nH]c5c(c4C[C@@]4(O)[C@@H](C2)N(CC2CC2)CC[C@]314)C[C@]1(O)[C@H]2Cc3ccc(O)c4c3[C@]1(CCN2CC1CC1)[C@H]5O4 |o1:29,40,&1:16,48|", "O=C1NC(=O)c2c1c1c3ccccc3n3c1c1c2c2ccccc2n1[C@@H]1[C@H](O)[C@H](O)[C@H](O)[C@H]3N1Cc1ccccc1 |o1:26,32,&1:25,30|", }; UseLegacyStereoPerceptionFixture reset_stereo_perception{false}; for (const auto &smi1 : tests) { INFO(smi1); SmilesParserParams rps; rps.sanitize = true; rps.removeHs = false; std::unique_ptr mol1{SmilesToMol(smi1, rps)}; REQUIRE(mol1); std::vector idxV(mol1->getNumAtoms()); for (unsigned int i = 0; i < mol1->getNumAtoms(); ++i) { idxV[i] = i; } for (auto i = 0; i < 100; ++i) { std::vector nVect(idxV); std::shuffle(nVect.begin(), nVect.end(), std::mt19937(0xf00d)); std::unique_ptr nmol{MolOps::renumberAtoms(*mol1, nVect)}; RDKit::canonicalizeStereoGroups(nmol); auto outSmi1 = MolToCXSmiles(*nmol); CHECK(outSmi1 == smi1); } } } } TEST_CASE("using enhanced stereo in rankMolAtoms") { SECTION("basics: different ranks") { std::vector smis{ "C[C@H](F)[C@@H](F)C |a:1|", "C[C@H](F)[C@@H](F)C |&1:1|" "C[C@H](F)[C@@H](F)C |o1:1|", "C[C@H](F)[C@@H](F)C |o1:1,a:3|", "C[C@H](F)[C@@H](F)C |o1:1,&:3|", "C[C@H](F)[C@@H](F)C |a:1,&2:3|", }; for (auto &smi : smis) { INFO(smi); std::unique_ptr mol{SmilesToMol(smi)}; REQUIRE(mol); bool breakTies = false; std::vector atomRanks; Canon::rankMolAtoms(*mol, atomRanks, breakTies); CHECK(atomRanks[1] != atomRanks[3]); } } SECTION("basics: same ranks") { std::vector smis{ "C[C@H](F)[C@@H](F)C |o1:1,o2:3|", "C[C@H](F)[C@@H](F)C |&1:1,&2:3|", "C[C@H](F)[C@@H](F)C |a:1,a:3|", }; for (auto &smi : smis) { INFO(smi); std::unique_ptr mol{SmilesToMol(smi)}; REQUIRE(mol); bool breakTies = false; std::vector atomRanks; Canon::rankMolAtoms(*mol, atomRanks, breakTies); CHECK(atomRanks[1] == atomRanks[3]); } } SECTION("more complex, include group membership") { auto m1 = "C[C@@H]1CC(C[C@@H](C)[C@@H](C)O)C[C@H](C)C1 |o1:1,7,o2:5,11|"_smiles; REQUIRE(m1); std::vector atomRanks; bool breakTies = false; Canon::rankMolAtoms(*m1, atomRanks, breakTies); CHECK(atomRanks[11] > atomRanks[1]); auto m2 = "C[C@H](O)[C@H](C)CC1C[C@H](C)C[C@@H](C)C1 |o1:1,8;o2:3,11|"_smiles; REQUIRE(m2); Canon::rankMolAtoms(*m2, atomRanks, breakTies); CHECK(atomRanks[11] > atomRanks[8]); } } TEST_CASE("more enhanced stereo canonicalization") { // FIX: add tests for ring stereo in an s group SECTION("case 1") { auto m1 = "C[C@@H](O)[C@H](C)[C@@H](C)[C@@H](C)F |a:3,&1:1,7,&2:5,r|"_smiles; REQUIRE(m1); auto m2 = "C[C@H](O)[C@H](C)[C@@H](C)[C@H](C)F |a:3,&1:1,7,&2:5,r|"_smiles; REQUIRE(m2); Canon::canonicalizeEnhancedStereo(*m1); Canon::canonicalizeEnhancedStereo(*m2); CHECK(MolToCXSmiles(*m1) == MolToCXSmiles(*m2)); } SECTION("case 2") { auto m1 = "C[C@@H](O)[C@H](C)[C@@H](C)[C@@H](C)O |&3:3,5,o1:7,&2:1,r|"_smiles; REQUIRE(m1); auto m2 = "C[C@@H](O)[C@H](C)[C@@H](C)[C@@H](C)O |&3:3,5,&2:7,o1:1,r|"_smiles; REQUIRE(m2); Canon::canonicalizeEnhancedStereo(*m1); Canon::canonicalizeEnhancedStereo(*m2); CHECK(MolToCXSmiles(*m1) == MolToCXSmiles(*m2)); } SECTION("case 3") { auto m1 = "C[C@@H](O)[C@H](C)[C@@H](C)[C@@H](C)O |&8:3,5,o1:7,&7:1,r|"_smiles; REQUIRE(m1); auto m2 = "C[C@@H](O)[C@H](C)[C@@H](C)[C@@H](C)O |&3:3,5,&2:7,o1:1,r|"_smiles; REQUIRE(m2); Canon::canonicalizeEnhancedStereo(*m1); Canon::canonicalizeEnhancedStereo(*m2); CHECK(MolToCXSmiles(*m1) == MolToCXSmiles(*m2)); } SECTION("case 4") { auto m1 = "C[C@@H](O)[C@H](C)[C@@H](C)[C@@H](C)O |&8:3,5,o1:7,&7:1,r|"_smiles; REQUIRE(m1); auto m2 = "C[C@@H](O)[C@H](C)[C@@H](C)[C@@H](C)O |&3:3,5,&2:7,o1:1,r|"_smiles; REQUIRE(m2); CHECK(MolToCXSmiles(*m1) == MolToCXSmiles(*m2)); } SECTION("case 5") { auto m1 = "C[C@@H](O)[C@H](C)[C@@H](C)[C@@H](C)O |&8:3,5,o1:7,&7:1,r|"_smiles; REQUIRE(m1); auto m2 = "C[C@@H](O)[C@H](C)[C@@H](C)[C@@H](C)O |&3:3,5,&2:7,o1:1,r|"_smiles; REQUIRE(m2); forwardStereoGroupIds(*m1); forwardStereoGroupIds(*m2); auto cx1 = MolToCXSmiles(*m1); auto cx2 = MolToCXSmiles(*m2); CHECK(cx1 == "C[C@H](O)[C@H](C)[C@@H](C)[C@H](C)O |o1:1,&7:7,&8:3,5|"); CHECK(cx2 == "C[C@H](O)[C@H](C)[C@@H](C)[C@H](C)O |o1:1,&2:7,&3:3,5|"); } SECTION("case 5a") { std::unique_ptr m1 = "C[C@@H](O)[C@H](C)[C@@H](C)[C@@H](C)O |&8:3,5,o1:7,&7:1,r|"_smiles; REQUIRE(m1); std::unique_ptr m2 = "C[C@@H](O)[C@H](C)[C@@H](C)[C@@H](C)O |&3:3,5,&2:7,o1:1,r|"_smiles; REQUIRE(m2); forwardStereoGroupIds(*m1); forwardStereoGroupIds(*m2); RDKit::canonicalizeStereoGroups(m1); RDKit::canonicalizeStereoGroups(m2); auto cx1 = MolToCXSmiles(*m1); auto cx2 = MolToCXSmiles(*m2); CHECK(cx1 == "C[C@H](O)[C@H](C)[C@@H](C)[C@H](C)O |o1:1,&1:3,5,&2:7|"); CHECK(cx2 == "C[C@H](O)[C@H](C)[C@@H](C)[C@H](C)O |o1:1,&1:3,5,&2:7|"); } SECTION("case 6") { auto m1 = "C[C@@H](O)[C@H](C)[C@@H](C)[C@@H](C)O |&8:3,5,o1:7,&7:1,r|"_smiles; REQUIRE(m1); auto m2 = "C[C@@H](O)[C@H](C)[C@@H](C)[C@@H](C)O |&3:3,5,&2:7,o1:1,r|"_smiles; REQUIRE(m2); forwardStereoGroupIds(*m1); forwardStereoGroupIds(*m2); // Canonicalization resets the Stereo Group IDs Canon::canonicalizeEnhancedStereo(*m1); Canon::canonicalizeEnhancedStereo(*m2); CHECK(MolToCXSmiles(*m1) == MolToCXSmiles(*m2)); // "read" ids are also reset! forwardStereoGroupIds(*m1); forwardStereoGroupIds(*m2); CHECK(MolToCXSmiles(*m1) == MolToCXSmiles(*m2)); } } TEST_CASE("ensure unused features are not used") { SECTION("isotopes") { auto mol = "[13CH3]OC"_smiles; REQUIRE(mol); std::vector ranks; bool breakTies = false; bool includeChirality = true; bool includeIsotopes = true; Canon::rankMolAtoms(*mol, ranks, breakTies, includeChirality, includeIsotopes); CHECK(ranks[0] != ranks[2]); includeIsotopes = false; Canon::rankMolAtoms(*mol, ranks, breakTies, includeChirality, includeIsotopes); CHECK(ranks[0] == ranks[2]); } SECTION("chirality") { auto mol = "F[C@H](Cl)OC(F)Cl"_smiles; REQUIRE(mol); std::vector ranks; bool breakTies = false; bool includeChirality = true; bool includeIsotopes = true; Canon::rankMolAtoms(*mol, ranks, breakTies, includeChirality, includeIsotopes); CHECK(ranks[1] != ranks[4]); includeChirality = false; Canon::rankMolAtoms(*mol, ranks, breakTies, includeChirality, includeIsotopes); CHECK(ranks[1] == ranks[4]); } SECTION("chirality and stereogroups") { auto mol = "F[C@H](Cl)O[C@H](F)Cl |o1:1|"_smiles; REQUIRE(mol); std::vector ranks; bool breakTies = false; bool includeChirality = true; bool includeIsotopes = true; Canon::rankMolAtoms(*mol, ranks, breakTies, includeChirality, includeIsotopes); CHECK(ranks[1] != ranks[4]); includeChirality = false; Canon::rankMolAtoms(*mol, ranks, breakTies, includeChirality, includeIsotopes); CHECK(ranks[1] == ranks[4]); } } TEST_CASE( "GitHub Issue #6633: Pre-condition violation in canonicalization of dative bond adjacent to double bond", "[bug][canonicalization]") { auto mb = R"CTAB( 3D 0 0 0 0 0 999 V3000 M V30 BEGIN CTAB M V30 COUNTS 16 16 0 0 0 M V30 BEGIN ATOM M V30 1 C -2.0033 -1.4133 -0.0473 0 M V30 2 C -2.9101 -0.3985 -0.2677 0 M V30 3 O -2.7092 0.8645 -0.2504 0 M V30 4 Ir -0.9429 1.8106 0.2184 0 M V30 5 N 0.0151 -0.0816 0.3618 0 M V30 6 C 1.4929 -0.0477 0.5631 0 M V30 7 C -0.6236 -1.2309 0.2291 0 M V30 8 C -4.3730 -0.7437 -0.5877 0 M V30 9 H -2.3752 -2.4232 -0.1048 0 M V30 10 H 1.8628 -0.9806 0.9803 0 M V30 11 H 1.6928 0.7152 1.3165 0 M V30 12 H 2.0044 0.1878 -0.3701 0 M V30 13 H -4.9409 0.1756 -0.7308 0 M V30 14 H -4.4149 -1.3416 -1.4982 0 M V30 15 H -4.8022 -1.3104 0.2386 0 M V30 16 H 0.0202 -2.0891 0.3538 0 M V30 END ATOM M V30 BEGIN BOND M V30 1 1 1 7 M V30 2 2 1 2 M V30 3 1 1 9 M V30 4 1 2 3 M V30 5 1 2 8 M V30 6 1 3 4 M V30 7 9 5 4 M V30 8 1 5 6 M V30 9 2 5 7 M V30 10 1 6 10 M V30 11 1 6 11 M V30 12 1 6 12 M V30 13 1 7 16 M V30 14 1 8 13 M V30 15 1 8 14 M V30 16 1 8 15 M V30 END BOND M V30 END CTAB M END)CTAB"; auto countStereoBonds = [](const auto &mol) { unsigned num_stereo_bonds = 0; for (const auto bond : mol.bonds()) { if (bond->getBondType() == Bond::BondType::DOUBLE && bond->getStereo() != Bond::BondStereo::STEREONONE) { ++num_stereo_bonds; } } return num_stereo_bonds; }; auto sanitize = true; auto removeHs = false; std::unique_ptr mol(MolBlockToMol(mb, sanitize, removeHs)); REQUIRE(mol); REQUIRE(mol->getNumAtoms() == 16); REQUIRE(countStereoBonds(*mol) == 2); CHECK_NOTHROW(MolToSmiles(*mol)); CHECK(countStereoBonds(*mol) == 2); } TEST_CASE("atom mapping in canonicalization") { SECTION("basics") { auto m = "[F:1]C([F:2])O"_smiles; REQUIRE(m); std::vector ranks; bool breakTies = false; bool includeChirality = true; bool includeIsotopes = true; bool includeAtomMaps = true; Canon::rankMolAtoms(*m, ranks, breakTies, includeChirality, includeIsotopes, includeAtomMaps); CHECK(ranks[0] != ranks[2]); includeAtomMaps = false; Canon::rankMolAtoms(*m, ranks, breakTies, includeChirality, includeIsotopes, includeAtomMaps); CHECK(ranks[0] == ranks[2]); } } TEST_CASE( "GitHub Issue #7023: \"Inconsistent state\" when manually sanitizing and assigning stereo when using the new stereo algorithm", "[bug]") { UseLegacyStereoPerceptionFixture reset_stereo_perception{false}; const auto molb = R"CTAB(" RDKit 2D 0 0 0 0 0 0 0 0 0 0999 V3000 M V30 BEGIN CTAB M V30 COUNTS 40 47 0 0 1 M V30 BEGIN ATOM M V30 1 C -1.412000 -2.520800 0.000000 0 M V30 2 N -2.236600 -2.495700 0.000000 0 M V30 3 N -3.801500 -2.612400 0.000000 0 M V30 4 C -4.626200 -2.587400 0.000000 0 M V30 5 C -4.904800 -3.363900 0.000000 0 M V30 6 C -5.696800 -3.595000 0.000000 0 M V30 7 C -4.966800 -0.807100 0.000000 0 M V30 8 N -4.155000 -0.660100 0.000000 0 M V30 9 C -4.044000 0.157400 0.000000 0 M V30 10 C -3.039200 0.506000 0.000000 0 M V30 11 C -2.237800 0.310100 0.000000 0 M V30 12 N -2.176500 -0.512600 0.000000 0 M V30 13 C -1.375100 -0.708600 0.000000 0 M V30 14 C -0.941100 -0.006900 0.000000 0 M V30 15 C -0.118400 0.054400 0.000000 0 M V30 16 C -1.474300 0.622600 0.000000 0 M V30 17 C -0.910300 1.224700 0.000000 0 M V30 18 C -1.697100 1.417000 0.000000 0 M V30 19 C -5.077900 -1.624600 0.000000 0 M V30 20 C -5.893400 -1.749400 0.000000 0 M V30 21 C -1.133400 -1.744200 0.000000 0 M V30 22 C -0.309800 -1.791700 0.000000 0 M V30 23 C -2.515200 -3.272300 0.000000 0 M V30 24 C -3.570500 -3.404400 0.000000 0 M V30 25 C -3.278900 -4.176100 0.000000 0 M V30 26 C 0.225100 -3.058100 0.000000 0 M V30 27 C -0.404400 -3.591300 0.000000 0 M V30 28 C -1.181000 -3.312700 0.000000 0 M V30 29 C -1.076700 -4.131100 0.000000 0 M V30 30 Co -0.633100 -1.614100 0.000000 0 CHG=1 VAL=6 M V30 31 C -4.787100 0.515600 0.000000 0 M V30 32 C -4.934100 1.327400 0.000000 0 M V30 33 C -1.862800 -3.777200 0.000000 0 M V30 34 C -1.887800 -4.601800 0.000000 0 M V30 35 C -4.252300 -3.868900 0.000000 0 M V30 36 C -4.678900 -4.575000 0.000000 0 M V30 37 C -3.869300 -4.599600 0.000000 0 M V30 38 C -5.357500 -0.080500 0.000000 0 M V30 39 C -6.124200 -0.385000 0.000000 0 M V30 40 C -6.015200 0.417600 0.000000 0 M V30 END ATOM M V30 BEGIN BOND M V30 1 2 21 1 M V30 2 1 1 2 M V30 3 1 28 1 M V30 4 1 23 2 CFG=3 M V30 5 1 2 30 M V30 6 1 23 33 M V30 7 1 23 24 M V30 8 1 33 28 M V30 9 1 24 3 M V30 10 1 24 35 M V30 11 2 3 4 M V30 12 1 5 4 M V30 13 1 4 19 M V30 14 1 5 6 CFG=3 M V30 15 1 35 5 M V30 16 2 19 7 M V30 17 1 7 8 M V30 18 1 38 7 M V30 19 2 8 9 M V30 20 1 9 10 M V30 21 1 31 9 M V30 22 2 10 11 M V30 23 1 11 12 M V30 24 1 11 16 M V30 25 2 12 13 M V30 26 1 14 13 M V30 27 1 14 15 CFG=3 M V30 28 1 14 16 M V30 29 1 16 17 M V30 30 1 16 18 M V30 31 1 31 38 M V30 32 9 8 30 M V30 33 9 3 30 M V30 34 9 12 30 M V30 35 1 19 20 M V30 36 1 21 22 M V30 37 1 24 25 CFG=3 M V30 38 1 27 26 M V30 39 1 28 27 M V30 40 1 28 29 CFG=1 M V30 41 1 21 13 M V30 42 1 31 32 CFG=3 M V30 43 1 33 34 CFG=1 M V30 44 1 35 36 M V30 45 1 35 37 M V30 46 1 38 39 M V30 47 1 38 40 M V30 END BOND M V30 END CTAB M END )CTAB"; bool sanitize = false; bool removeHs = false; std::unique_ptr m(MolBlockToMol(molb, sanitize, removeHs)); MolOps::sanitizeMol(*m); MolOps::assignStereochemistry(*m); // This should not throw an invariant violation auto smiles = MolToSmiles(*m); CHECK( smiles == (R"SMI(CC[C@@]1(C)/C2=C(C)/C3=[N]4->[CoH2+]56[N]2[C@H]([C@@H]1C)[C@]1(C)[N]->5=C(/C)SMI" R"SMI((C)=C2[N]->6=C(/C=C4/C(C)(C)[C@@H]3C)[C@@H](C)C\2(C)C)[C@@H](C)C1(C)C)SMI")); } TEST_CASE("chiral presence and ranking") { SECTION("basics") { auto mol = "OC(F)C([C@H](F)O)[C@@H](F)O"_smiles; REQUIRE(mol); std::vector ranks; bool breakTies = false; // default: all three centers are different Canon::rankMolAtoms(*mol, ranks, breakTies); CHECK(ranks[1] != ranks[4]); CHECK(ranks[1] != ranks[7]); CHECK(ranks[4] != ranks[7]); // if we don't include chirality, the ranks should be the same bool includeChirality = false; Canon::rankMolAtoms(*mol, ranks, breakTies, includeChirality); CHECK(ranks[1] == ranks[4]); CHECK(ranks[1] == ranks[7]); // if we include chiral presence, 4 and 7 are the same, but 1 is // different includeChirality = false; bool includeChiralPresence = true; bool includeIsotopes = true; bool includeAtomMaps = true; const bool includeStereoGroups = includeChirality; const bool useNonStereoRanks = false; Canon::rankMolAtoms(*mol, ranks, breakTies, includeChirality, includeIsotopes, includeAtomMaps, includeChiralPresence, includeStereoGroups, useNonStereoRanks); CHECK(ranks[1] != ranks[4]); CHECK(ranks[1] != ranks[7]); CHECK(ranks[4] == ranks[7]); } } TEST_CASE("meso impact on atom ranking") { SECTION("basics") { { auto m = "C1[C@H](O)C[C@@H]1[C@H](F)[C@@H]1C[C@H](O)C1"_smiles; REQUIRE(m); std::vector ranks; bool breakTies = false; Canon::rankMolAtoms(*m, ranks, breakTies); CHECK(ranks[4] == ranks[7]); } { auto m = "C1[C@H](O)C[C@@H]1[C@H](F)[C@@H]1C[C@@H](O)C1"_smiles; REQUIRE(m); std::vector ranks; bool breakTies = false; Canon::rankMolAtoms(*m, ranks, breakTies); CHECK(ranks[4] != ranks[7]); } { auto m = "C[C@@H](Cl)C1[C@H](C)Cl.C[C@@H](Cl)C2[C@H](C)Cl.[C@H]12F"_smiles; REQUIRE(m); std::vector ranks; bool breakTies = false; Canon::rankMolAtoms(*m, ranks, breakTies); CHECK(ranks[3] == ranks[10]); } { auto m = "C[C@@H](Cl)C1[C@@H](C)Cl.C[C@@H](Cl)C2[C@H](C)Cl.[C@H]12F"_smiles; REQUIRE(m); std::vector ranks; bool breakTies = false; Canon::rankMolAtoms(*m, ranks, breakTies); CHECK(ranks[3] != ranks[10]); } } } TEST_CASE("allow disabling ring stereo in ranking") { UseLegacyStereoPerceptionFixture reset_stereo_perception(false); std::string smi = "C[C@@H]1CC[C@@H](C)CC1"; auto m = v2::SmilesParse::MolFromSmiles(smi); REQUIRE(m); bool breakTies = false; bool includeChirality = true; bool includeIsotopes = true; bool includeAtomMaps = true; bool includeChiralPresence = false; bool includeStereoGroups = true; bool useNonStereoRanks = false; bool includeRingStereo = true; std::vector res1; Canon::rankMolAtoms(*m, res1, breakTies, includeChirality, includeIsotopes, includeAtomMaps, includeChiralPresence, includeStereoGroups, useNonStereoRanks, includeRingStereo); CHECK(res1.size() == m->getNumAtoms()); CHECK(res1[2] != res1[7]); CHECK(res1[2] == res1[3]); CHECK(res1[3] != res1[6]); CHECK(res1[6] == res1[7]); includeRingStereo = false; Canon::rankMolAtoms(*m, res1, breakTies, includeChirality, includeIsotopes, includeAtomMaps, includeChiralPresence, includeStereoGroups, useNonStereoRanks, includeRingStereo); CHECK(res1.size() == m->getNumAtoms()); CHECK(res1[2] == res1[7]); CHECK(res1[2] == res1[3]); CHECK(res1[3] == res1[6]); CHECK(res1[6] == res1[7]); } TEST_CASE( "attempt to fix incompatible directions in double bond canonicalization") { // This doesn't always work, but I have found these cases to be interesting // pubchem 145302638 constexpr const char *mb1 = R"ctab(145302638 RDKit 2D 0 0 0 0 0 0 0 0 0 0999 V3000 M V30 BEGIN CTAB M V30 COUNTS 53 60 0 0 0 M V30 BEGIN ATOM M V30 1 N 8.658800 1.073800 0.000000 0 M V30 2 N 5.658800 1.085400 0.000000 0 M V30 3 N 2.000000 4.557700 0.000000 0 M V30 4 C 11.731300 2.816000 0.000000 0 M V30 5 C 12.231300 1.950000 0.000000 0 M V30 6 C 12.231300 3.682000 0.000000 0 M V30 7 C 13.231300 1.950000 0.000000 0 M V30 8 C 13.231300 3.682000 0.000000 0 M V30 9 C 13.731300 2.816000 0.000000 0 M V30 10 C 10.689800 2.832100 0.000000 0 M V30 11 C 10.162100 1.934000 0.000000 0 M V30 12 C 11.724500 1.040000 0.000000 0 M V30 13 C 11.696700 4.576000 0.000000 0 M V30 14 C 13.738200 1.040000 0.000000 0 M V30 15 C 13.766000 4.576000 0.000000 0 M V30 16 C 14.772900 2.832100 0.000000 0 M V30 17 C 10.682900 1.032000 0.000000 0 M V30 18 C 9.162100 1.937900 0.000000 0 M V30 19 C 12.210500 5.482000 0.000000 0 M V30 20 C 14.779800 1.032000 0.000000 0 M V30 21 C 13.252200 5.482000 0.000000 0 M V30 22 C 15.300600 1.934000 0.000000 0 M V30 23 C 7.658800 1.077700 0.000000 0 M V30 24 C 7.155400 0.213600 0.000000 0 M V30 25 C 7.148800 -1.518500 0.000000 0 M V30 26 C 7.645400 -2.386400 0.000000 0 M V30 27 C 7.652100 -0.654400 0.000000 0 M V30 28 C 7.638700 -4.118500 0.000000 0 M V30 29 C 6.155400 0.217400 0.000000 0 M V30 30 C 7.142100 -3.250500 0.000000 0 M V30 31 C 8.638700 -4.122300 0.000000 0 M V30 32 C 7.162100 1.945600 0.000000 0 M V30 33 C 6.148800 -1.514600 0.000000 0 M V30 34 C 8.645400 -2.390300 0.000000 0 M V30 35 C 5.652100 -0.646700 0.000000 0 M V30 36 C 9.142100 -3.258200 0.000000 0 M V30 37 C 7.100600 -5.010300 0.000000 0 M V30 38 C 9.169900 -5.018300 0.000000 0 M V30 39 C 6.162100 1.949500 0.000000 0 M V30 40 C 7.611000 -5.918400 0.000000 0 M V30 41 C 8.652600 -5.922400 0.000000 0 M V30 42 C 5.665500 2.817400 0.000000 0 M V30 43 C 6.277300 3.608400 0.000000 0 M V30 44 C 4.673500 2.690700 0.000000 0 M V30 45 C 5.898200 4.533800 0.000000 0 M V30 46 C 3.882500 3.302500 0.000000 0 M V30 47 C 4.790800 0.588700 0.000000 0 M V30 48 C 4.907200 4.668100 0.000000 0 M V30 49 C 2.957200 2.923400 0.000000 0 M V30 50 C 3.981900 4.289000 0.000000 0 M V30 51 C 2.166200 3.535200 0.000000 0 M V30 52 C 3.602800 5.214300 0.000000 0 M V30 53 C 2.611800 5.348700 0.000000 0 M V30 END ATOM M V30 BEGIN BOND M V30 1 1 1 18 M V30 2 2 1 23 M V30 3 1 2 39 M V30 4 2 2 47 M V30 5 2 3 51 M V30 6 1 3 53 M V30 7 1 4 5 M V30 8 1 4 6 M V30 9 2 4 10 M V30 10 1 5 7 M V30 11 2 5 12 M V30 12 2 6 8 M V30 13 1 6 13 M V30 14 2 7 9 M V30 15 1 7 14 M V30 16 1 8 9 M V30 17 1 8 15 M V30 18 1 9 16 M V30 19 1 10 11 M V30 20 2 11 17 M V30 21 1 11 18 M V30 22 1 12 17 M V30 23 2 13 19 M V30 24 2 14 20 M V30 25 2 15 21 M V30 26 2 16 22 M V30 27 1 19 21 M V30 28 1 20 22 M V30 29 1 23 24 M V30 30 1 23 32 M V30 31 2 24 27 M V30 32 1 24 29 M V30 33 1 25 26 M V30 34 1 25 27 M V30 35 2 25 33 M V30 36 2 26 30 M V30 37 1 26 34 M V30 38 1 28 30 M V30 39 2 28 31 M V30 40 1 28 37 M V30 41 2 29 35 M V30 42 1 31 36 M V30 43 1 31 38 M V30 44 2 32 39 M V30 45 1 33 35 M V30 46 2 34 36 M V30 47 2 37 40 M V30 48 2 38 41 M V30 49 1 39 42 M V30 50 1 40 41 M V30 51 1 42 43 M V30 52 2 42 44 M V30 53 2 43 45 M V30 54 1 44 46 M V30 55 1 45 48 M V30 56 2 46 49 M V30 57 2 48 50 M V30 58 1 49 51 M V30 59 1 50 52 M V30 60 2 52 53 M V30 END BOND M V30 END CTAB M END )ctab"; // pubchem 145302645 constexpr const char *mb2 = R"ctab(145302645 RDKit 2D 0 0 0 0 0 0 0 0 0 0999 V3000 M V30 BEGIN CTAB M V30 COUNTS 45 50 0 0 0 M V30 BEGIN ATOM M V30 1 N 10.607800 1.273000 0.000000 0 M V30 2 N 4.002900 0.307100 0.000000 0 M V30 3 N 9.107800 2.139100 0.000000 0 M V30 4 C 2.742200 0.988000 0.000000 0 M V30 5 C 2.000000 1.718800 0.000000 0 M V30 6 C 3.744100 1.273000 0.000000 0 M V30 7 C 4.002900 2.239000 0.000000 0 M V30 8 C 12.107800 2.139100 0.000000 0 M V30 9 C 2.269600 2.724900 0.000000 0 M V30 10 C 13.607800 3.005100 0.000000 0 M V30 11 C 3.277800 2.986800 0.000000 0 M V30 12 C 13.107800 3.871100 0.000000 0 M V30 13 C 11.607800 1.273000 0.000000 0 M V30 14 C 13.107800 2.139100 0.000000 0 M V30 15 C 11.607800 3.005100 0.000000 0 M V30 16 C 10.607800 -0.459000 0.000000 0 M V30 17 C 10.107800 0.407000 0.000000 0 M V30 18 C 12.107800 3.871100 0.000000 0 M V30 19 C 4.710000 2.946100 0.000000 0 M V30 20 C 14.649300 2.989000 0.000000 0 M V30 21 C 11.607800 -2.191100 0.000000 0 M V30 22 C 13.614600 4.781100 0.000000 0 M V30 23 C 10.107800 -1.325000 0.000000 0 M V30 24 C 11.607800 -0.459000 0.000000 0 M V30 25 C 9.107800 0.407000 0.000000 0 M V30 26 C 10.607800 -2.191100 0.000000 0 M V30 27 C 12.107800 -1.325000 0.000000 0 M V30 28 C 12.107800 -3.057100 0.000000 0 M V30 29 C 15.177000 3.887100 0.000000 0 M V30 30 C 14.656200 4.789100 0.000000 0 M V30 31 C 8.607800 1.273000 0.000000 0 M V30 32 C 5.675900 3.204900 0.000000 0 M V30 33 C 7.607800 1.273000 0.000000 0 M V30 34 C 4.710000 -0.400000 0.000000 0 M V30 35 C 6.641800 2.946100 0.000000 0 M V30 36 C 7.349000 2.239000 0.000000 0 M V30 37 C 13.107800 -3.057100 0.000000 0 M V30 38 C 11.607800 -3.923100 0.000000 0 M V30 39 C 7.349000 0.307100 0.000000 0 M V30 40 C 5.675900 -0.658800 0.000000 0 M V30 41 C 6.641800 -0.400000 0.000000 0 M V30 42 C 13.607800 -3.923100 0.000000 0 M V30 43 C 12.107800 -4.789100 0.000000 0 M V30 44 C 13.107800 -4.789100 0.000000 0 M V30 45 C 9.107800 3.139100 0.000000 0 M V30 END ATOM M V30 BEGIN BOND M V30 1 1 1 13 M V30 2 2 1 17 M V30 3 2 2 6 M V30 4 1 2 34 M V30 5 1 3 31 M V30 6 2 3 45 M V30 7 1 4 5 M V30 8 1 4 6 M V30 9 1 5 9 M V30 10 1 6 7 M V30 11 1 7 11 M V30 12 2 7 19 M V30 13 1 8 13 M V30 14 2 8 14 M V30 15 1 8 15 M V30 16 2 9 11 M V30 17 2 10 12 M V30 18 1 10 14 M V30 19 1 10 20 M V30 20 1 12 18 M V30 21 1 12 22 M V30 22 2 15 18 M V30 23 1 16 17 M V30 24 2 16 23 M V30 25 1 16 24 M V30 26 1 17 25 M V30 27 1 19 32 M V30 28 2 20 29 M V30 29 2 21 26 M V30 30 1 21 27 M V30 31 1 21 28 M V30 32 2 22 30 M V30 33 1 23 26 M V30 34 2 24 27 M V30 35 2 25 31 M V30 36 2 28 37 M V30 37 1 28 38 M V30 38 1 29 30 M V30 39 1 31 33 M V30 40 2 32 35 M V30 41 2 33 36 M V30 42 1 33 39 M V30 43 2 34 40 M V30 44 1 35 36 M V30 45 1 37 42 M V30 46 2 38 43 M V30 47 2 39 41 M V30 48 1 40 41 M V30 49 2 42 44 M V30 50 1 43 44 M V30 END BOND M V30 END CTAB M END )ctab"; auto getBondLabels = [](ROMol &m) { CIPLabeler::assignCIPLabels(m); std::vector labels; for (const auto bond : m.bonds()) { std::string cip; if (bond->getPropIfPresent(common_properties::_CIPCode, cip)) { labels.push_back(cip); } } std::sort(labels.begin(), labels.end()); return labels; }; auto usingLegacyStereo = GENERATE(false, true); for (auto mb : {mb1, mb2}) { auto m = v2::FileParsers::MolFromMolBlock(mb); REQUIRE(m); CAPTURE(m->getProp("_Name"), usingLegacyStereo); auto refLabels = getBondLabels(*m); CHECK(refLabels.size() == 8); auto smi = MolToSmiles(*m); auto m2 = v2::SmilesParse::MolFromSmiles(smi); REQUIRE(m2); auto newLabels = getBondLabels(*m2); CHECK(refLabels == newLabels); } } static void checkSmilesRoundtrip(const std::string &smiles, bool shouldMatch = true) { auto getFeatures = [](ROMol &m) { // enable this for development only (it's SLOW): make the test stricter // by comparing CIP codes instead of just counting features #if 0 CIPLabeler::assignCIPLabels(m); std::vector labels; for (const auto atom : m.atoms()) { std::string tag; std::string cip; if (atom->getPropIfPresent(common_properties::_CIPCode, cip)) { atom->getPropIfPresent(common_properties::atomLabel, tag); labels.push_back(cip + "_" + tag); } } for (const auto bond : m.bonds()) { std::string cip; if (bond->getPropIfPresent(common_properties::_CIPCode, cip)) { auto atom1 = bond->getBeginAtom(); unsigned int idx1 = std::numeric_limits::max(); atom1->getPropIfPresent(common_properties::atomLabel, idx1); auto atom2 = bond->getEndAtom(); unsigned int idx2 = std::numeric_limits::max(); atom2->getPropIfPresent(common_properties::atomLabel, idx2); if (idx1 > idx2) { std::swap(idx1, idx2); } labels.push_back(cip + "_" + std::to_string(idx1) + "_" + std::to_string(idx2)); } } std::sort(labels.begin(), labels.end()); return labels; #else unsigned int nChiralCenters = 0; for (const auto atom : m.atoms()) { if (atom->getChiralTag() != Atom::ChiralType::CHI_UNSPECIFIED) { ++nChiralCenters; } } unsigned int nDoubleBondStereo = 0; for (const auto bond : m.bonds()) { if (bond->getStereo() > Bond::STEREOANY) { ++nDoubleBondStereo; } } return std::make_pair(nChiralCenters, nDoubleBondStereo); #endif }; SmilesWriteParams ps; auto fields = SmilesWrite::CXSmilesFields::CX_ATOM_LABELS; auto getStrings = [&ps, &fields](const ROMol &m) { const auto cxsmiles = MolToCXSmiles(m, ps, fields); auto pos = cxsmiles.find(" "); const std::string smiles(cxsmiles.data(), pos); return std::make_pair(smiles, cxsmiles); }; // pre-canonicalize SMILES: the inputs get outdated when // we make changes to the canonicalization algorithm auto m1 = v2::SmilesParse::MolFromSmiles(smiles); REQUIRE(m1); for (auto atom : m1->atoms()) { atom->setProp(common_properties::atomLabel, atom->getIdx()); } const auto [firstSmiles, firstCxsmiles] = getStrings(*m1); // Get the stereo features after the SMILES roundtrip, // so that assigning labels can't have any influence // on the SMILES const auto refFeatures = getFeatures(*m1); auto m2 = v2::SmilesParse::MolFromSmiles(firstCxsmiles); REQUIRE(m2); const auto [secondSmiles, secondCxsmiles] = getStrings(*m2); if (shouldMatch) { CHECK(firstSmiles == secondSmiles); // If the stereo labels don't match after round-tripping, something is wrong CHECK(refFeatures == getFeatures(*m2)); // Check the second roundtrip too auto m3 = v2::SmilesParse::MolFromSmiles(secondCxsmiles); REQUIRE(m3); CHECK(refFeatures == getFeatures(*m3)); } else { CHECK(firstSmiles != secondSmiles); } } TEST_CASE("Canonicalization issues watch (see GitHub Issue #8775)") { // This is a check about the state of things with canonicalization. // The "samples" below initially come from the list compiled in GitHub // Issue #8775 by bp-kelly. Please update this list when things get // fixed (if they break, please reconsider the changes you are making!). // The comment on each sample is the GitHub issue where the issue was // first reported. const static std::initializer_list> samples = { {R"smi(C/C=C\C=C(/C=C\C)C(/C=C\C)=C/C)smi", true, true}, // #8759 {R"smi(C1=C\CCCCCC/C=C/C=C/1)smi", true, true}, // #8759 {R"smi(O=C=NC1=CC2C3=C(C=C1)C2=C(N=C=O)C=C3)smi", false, false}, // #8721 {R"smi(O=C(c1ccccc1C(=O)N1C(=O)c2ccccc2C1=O)N1C(=O)c2ccccc2C1=O)smi", false, false}, // #8721 {R"smi(O=[N+]([O-])c1cc/c2c(c1)=C(c1ccccc1)/N=c1\ccc([N+](=O)[O-])cc1=C(c1ccccc1)/N=2)smi", true, true}, // #8721 {R"smi(C=Cc1c(C)/c2[n-]c1=C=c1[n-]/c(c(CC)c1C)=C\c1[n-]c3c(c1C)C(=O)[C@H](C(=O)OC)/C3=C1/[NH+]=C(/C=2)[C@@H](C)[C@@H]1CCC(=O)OC/C=C(\C)CCC[C@H](C)CCC[C@H](C)CCCC(C)C.[Mg+2])smi", true, true}, // #8721 {R"smi(CC1=C(/C=C2\C(C)=C3/C(C)=C(/C=C4\C(C)=C5/C(CCC(=O)O)=C(C(C)=C5N4)C=C6\C(CCC(=O)O)=C(C)C(=C6N2)C=C1)N3)C=C(\C=C)C)smi", false, false}, // #8089 {R"smi(COC1=N\C2=CC(=O)c3c(c(O)c(C)c4c3C(=O)C(C)(O/C=C/C(OC)C(C)C(OC(C)=O)C(C)C(O)C(C)C(O)C(C)/C=C\C=C/1C)O4)C2=O)smi", true, true}, // #8089 {R"smi(CC1C2c3cc4/c5c6c7c8c9c%10c6c4c4c3C3=C6c%11c%12c%13c%14c%15c(c9c9c%16c8c(c8/c(c%17c%18c%19c(c(c%11c%11c%19c%19c%17c8c%16c(c%149)c%19c%13%11)C62)C1C%181C[N+](C)(C)C1)=C\C\C=5)C7)C%10C4C31C[N+](C)(C)CC%12%151)smi", true, true}, // #8089 {R"smi(CC1=C\[C@H](C)C[C@@]2(C)CC[C@@H](O2)[C@@]23CC[C@@](C)(C[C@@H](O2)[C@H]2O[C@](C)(CC2=O)[C@@H](O)[C@@H]2CC[C@@]4(CCC[C@H](O4)[C@@H](C)C(=O)O[C@@H]4C[C@@H]([C@@]5(O)OCC[C@@H](C)[C@H]5O)O[C@@H]4/C=C/1)O2)O3)smi", true, true}, // #8089 {R"smi(CC1=C/[C@H]2O[C@@H](C/C=C/C=C/C(=O)O[C@@H]3C[C@@H](/C=C/C/C=C/1)O[C@@H](C/C=C\CCO)[C@]3(C)CO)C[C@H](O)[C@H]2C)smi", true, true}, // #8089 {R"smi(CC(=O)OCC1=C\CC/C(C)=C/CC[C@@]2(C)CC[C@@](C(C)C)(/C=C/1)O2)smi", true, true}, // #8089 {R"smi(CC1=C\C/C=C(\C)CC[C@H]2C(C)(C)[C@@H](\C=C/1)CC[C@]2(C)O)smi", true, true}, // #8089 {R"smi(CC(=O)OCC1=C/[C@@H]2OC(=O)[C@H](C)[C@@]2(O)[C@@H](OC(C)=O)[C@H]2[C@]3(CC[C@H](OC(C)=O)[C@]2(C)[C@@H](OC(=O)COC(=O)CC(C)C)\C=C/1)CO3)smi", true, true}, // #8089 {R"smi(CC(=O)OCC1=C/[C@@H]2OC(=O)[C@H](C)[C@@]2(O)[C@@H](OC(C)=O)[C@H]2[C@]3(CC[C@H](OC(C)=O)[C@]2(C)[C@@H](OC(C)=O)\C=C/1)CO3)smi", true, true}, // #8089 {R"smi(C=Cc1c(C)/c2[nH]/c1=C\C1=N/C(=C\C3=C(C)C4C(=O)N(Cc5cccc(C#Cc6cccc(Nc7ncnc8cc(OCCOC)c(OCCOC)cc78)c6)c5)C(=O)/C(=C5/N=C(/C=2)[C@@H](C)[C@@H]5CCC(=O)OC)C4N3)C(CC)=C1C)smi", true, true}, // #8089 {R"smi(CC1=C\C[C@H](O)/C=C/C(C)=C/[C@@H](NC(=O)[C@H](C)O)[C@]2(C)C(=O)O[C@H](C[C@H](O)/C=C/1)[C@@H](C)C2=O)smi", true, true}, // #8089 {R"smi(CC1=C/[C@H]2O[C@@H](C/C=C/C=C/C(=O)O[C@@H]3C[C@@H](/C=C/C/C=C/1)O[C@@H](C/C=C\C[C@@H](O)C(=O)O)[C@]3(C)CO)C[C@H](O)[C@H]2C)smi", true, true}, // #8089 {R"smi(c1ccc2/c3[nH]/c(c2c1)=N\c1ccc(cc1)-c1nc2cc(ccc2o1)/N=c1/[nH]/c(c2ccccc12)=N/c1ccc2nc(oc2c1)-c1ccc(cc1)/N=3)smi", true, false}, // #8089 {R"smi(c1ccc2/c3[nH]/c(c2c1)=N\c1ccc(cc1)-c1nc2ccc(cc2o1)/N=c1/[nH]/c(c2ccccc12)=N/c1ccc2nc(oc2c1)-c1ccc(cc1)/N=3)smi", true, false}, // #8089 {R"smi(CC1=C/[C@@H](C)C[C@]2(C)CC[C@H](O2)[C@]23CC[C@](C)(C[C@H](O2)[C@@H]2O[C@@](C)(CC2=O)[C@@H](O)[C@H]2CC[C@@]4(CCC[C@@H](O4)[C@H](C)C(=O)O[C@H]4C[C@H]([C@]5(O)OCC[C@H](C)[C@@H]5O)O[C@H]4\C=C/1)O2)O3)smi", true, true}, // #8089 {R"smi(CC1=C/[C@@H](C)C[C@]2(C)CC[C@H](O2)[C@]23CC[C@](C(=O)O)(C[C@H](O2)[C@@H]2O[C@@](C)(CC2=O)[C@@H](O)[C@H]2CC[C@@]4(CCC[C@@H](O4)[C@H](C)C(=O)O[C@H]4C[C@H]([C@]5(O)OCC[C@H](C)[C@@H]5O)O[C@H]4\C=C/1)O2)O3)smi", true, true}, // #8089 {R"smi(CC1=C/[C@@H](C)C[C@]2(C)CC[C@H](O2)[C@]23CC[C@](CO)(C[C@H](O2)[C@@H]2O[C@@](C)(CC2=O)[C@@H](O)[C@H]2CC[C@@]4(CCC[C@@H](O4)[C@H](C)C(=O)O[C@H]4C[C@H]([C@]5(O)OCC[C@H](C)[C@@H]5O)O[C@H]4\C=C/1)O2)O3)smi", true, true}, // #8089 {R"smi(COC(=O)C1=C/c2cc3c(cc2-c2c(cc(OC)c(OC)c2OC)\C=C/1C(=O)OC)OCO3)smi", true, true}, // #8089 {R"smi(N#C[P@@H]/C=C(/P=O)[P@@H]C#N)smi", true, true}, // #8089 {R"smi(C1=C\C/C=C(\C)CC[C@H]2C(C)(C)[C@@H](\C=C/1)CC[C@]2(C)O)smi", true, true}, // #8089 {R"smi([H]/N=C(C=C)\C(/N=C\[O-])=N\[H])smi", false, true}, // #7759 {R"smi([H]N=C(/N=C\[O-])/C(C=C)=N\[H])smi", true, true}, // #7759 {R"smi([H]/N=C(/C=C)C(=N)/N=C\[O-])smi", true, true}, // #7759 {R"smi([C@H]12[C@H]3[C@@H]4[C@H]5[C@@H]([C@H]1N24)N53)smi", false, true}, // #7759 {R"smi([C@H]12[C@H]3[C@H]4[C@@H]5[C@@H]([C@H]1N25)N34)smi", false, true}, // #7759 {R"smi([CH]1C[C@H]2C[C@H](C2)[C@]12CC2)smi", false, true}, // #7759 {R"smi([CH]1O[C@H]2C[C@H](C2)[C@]12CC2)smi", false, true}, // #7759 {R"smi([CH]1O[C@H]2CN(C2)[C@]12CC2)smi", false, true}, // #7759 {R"smi([CH]1[C@H]2C[C@H](C2)[C@]12CCC2)smi", false, true}, // #7759 {R"smi([CH]1[C@H]2C[C@H](C2)[C@@]12COC2)smi", false, true}, // #7759 {R"smi(O=C1[C]2C[C@H](C2)[C@@]12CC2)smi", false, true}, // #7759 {R"smi(O=C1[C@H]2C[C](C2)[C@@]12CC2)smi", false, true}, // #7759 {R"smi(C1[C@H]2[C@@H]3C[C@H]4[C@@H]3[C@@H]1[C@@H]24)smi", false, true}, // #7759 {R"smi(C[C@]12[C@@H]3[C@@H]1C[C@H]1[C@H]2[C@]31C)smi", false, true}, // #7759 {R"smi([O][C@]12C[C@H](C1)[C@@]1(CC1)C2)smi", false, true}, // #7759 {R"smi(O[C@]12[C@@H]3[C@@H]4[CH][C@H]1[C@H]2[C@]34O)smi", false, true}, // #7759 {R"smi([CH2][C@]12C[C@H](C1)[C@]1(CC1)C2)smi", false, true}, // #7759 {R"smi([CH2][C@]12C[C@H](C1)[C@@]1(CC1)O2)smi", false, true}, // #7759 {R"smi([CH2][C@]1(C)[C@H]2[C@@H]3[C@@H](C)[C@H]2[C@@H]31)smi", false, true}, // #7759 {R"smi([CH2][C@]1(C)[C@H]2[C@@H]3[C@H](O)[C@H]2[C@@H]31)smi", false, true}, // #7759 {R"smi(C[C@H]1[C@@H]2[C@@H]3[C@H]1[C@H]2[C@@]31[CH]C1)smi", false, true}, // #7759 {R"smi(O[C@H]1[C@@H]2[C@@H]3[C@H]1[C@H]2[C@@]31[CH]C1)smi", false, true}, // #7759 {R"smi([O][C@H]1[C@@H]2[C@@H]3[C@H]1[C@H]2[C@]31CN1)smi", false, true}, // #7759 {R"smi(O[C@H]1[C@@H]2[C@@H]3[C@H]1[C@H]2[C@]31[CH]N1)smi", false, true}, // #7759 {R"smi(O[C@H]1[C@@H]2[C@@H]3[C@H]1[C@H]2[C@]31C[N]1)smi", false, true}, // #7759 {R"smi([CH2][C@]1(O)[C@H]2[C@@H]3[C@@H](O)[C@H]2[C@@H]31)smi", false, true}, // #7759 {R"smi(C[C@]1([O])[C@H]2[C@@H]3[C@@H](O)[C@H]2[C@@H]31)smi", false, true}, // #7759 {R"smi([CH2][C@H]1[C@@H]2[C@@H]3[C@H]1[C@H]2[C@]31CO1)smi", false, true}, // #7759 {R"smi(C[C@]1(O)[C@@H]2[C@H]3[C@@H]([O])[C@@H]2[C@H]31)smi", false, true}, // #7759 {R"smi(C[C@H]1[C@H]2[C@H]3[C@@H]1[C@@H]2[C@@]31[CH]O1)smi", false, true}, // #7759 {R"smi([O][C@H]1[C@H]2[C@H]3[C@@H]1[C@@H]2[C@@]31CO1)smi", false, true}, // #7759 {R"smi(O[C@H]1[C@@H]2[C@@H]3[C@H]1[C@H]2[C@]31[CH]O1)smi", false, true}, // #7759 {R"smi([CH2][C@]1(O)[C@@H]2[C@H]3[C@H](C)[C@@H]2[C@H]31)smi", false, true}, // #7759 {R"smi(C[C@H]1[C@H]2[C@H]3[C@@H]1[C@@H]2[C@]3(C)[O])smi", false, true}, // #7759 {R"smi([CH2][C@H]1[C@@H]2[C@@H]3[C@H]1[C@H]2[C@@]3(C)O)smi", false, true}, // #7759 {R"smi([O][C@H]1[C@H]2C[C@H](C2)[C@@]12CC2)smi", false, true}, // #7759 {R"smi(O[C]1[C@H]2C[C@H](C2)[C@@]12CC2)smi", false, true}, // #7759 {R"smi([CH2][C@H]1[C@H]2C[C@H](C2)[C@@]12CC2)smi", false, true}, // #7759 {R"smi(O[C@H]1[C]2C[C@H](C2)[C@]12CC2)smi", false, true}, // #7759 {R"smi(C[C]1[C@H]2C[C@H](C2)[C@@]12CC2)smi", false, true}, // #7759 {R"smi(C[C@H]1[C]2C[C@H](C2)[C@]12CC2)smi", false, true}, // #7759 {R"smi(O[C@H]1[C@H]2C[C](C2)[C@@]12CC2)smi", false, true}, // #7759 {R"smi(C[C@H]1[C@H]2C[C](C2)[C@@]12CC2)smi", false, true}, // #7759 {R"smi(C[C@]12[C@@H]3[C@@H]1[CH-][C@H]1[C@H]2[C@]31C)smi", false, true}, // #7759 {R"smi(C[C@]12C[C@H](C1)[N@+]1(CC1)C2)smi", false, true}, // #7759 {R"smi(C[C@H]1[C@H]2C[C-](C2)[C@@]12CC2)smi", false, true}, // #7759 {R"smi([CH]1[C@H]2C[C@H](C2)[C@]12CC2)smi", false, true}, // #7759 {R"smi([CH]1N2C[C@H](C2)O[C@]12CC2)smi", false, true}, // #7759 {R"smi([C]1=C[C@H]2C[C@H](C2)[C@@]12CC2)smi", false, true}, // #7759 {R"smi([CH-]1O[C@H]2CN(C2)[C@]12CC2)smi", false, true}, // #7759 {R"smi([CH-]1C[C@H]2C[C@H](C2)[C@]12CC2)smi", false, true}, // #7759 {R"smi([CH-]1O[C@H]2C[C@H](C2)[C@]12CC2)smi", false, true}, // #7759 {R"smi([CH-]1[C@H]2C[C@H](C2)[C@]12CCC2)smi", false, true}, // #7759 {R"smi([CH-]1[C@H]2C[C@H](C2)[C@@]12COC2)smi", false, true}, // #7759 {R"smi([O-]C1=C2C[C@H](C2)[C@@]12CC2)smi", false, true}, // #7759 {R"smi(O=C1[C@H]2C[C-](C2)[C@@]12CC2)smi", false, true}, // #7759 {R"smi([O-][C@]12C[C@H](C1)[C@@]1(CC1)C2)smi", false, true}, // #7759 {R"smi([CH2-][C@]12C[C@H](C1)[C@]1(CC1)C2)smi", false, true}, // #7759 {R"smi(O[C@H]1[C-]2C[C@H](C2)[C@@]12CC2)smi", false, true}, // #7759 {R"smi([CH2-][C@H]1[C@H]2C[C@H](C2)[C@]12CC2)smi", false, true}, // #7759 {R"smi([O-][C@H]1[C@H]2C[C@H](C2)[C@@]12CC2)smi", false, true}, // #7759 {R"smi(O[C-]1[C@H]2C[C@H](C2)[C@]12CC2)smi", false, true}, // #7759 {R"smi(O[C@H]1[C@H]2C[C-](C2)[C@@]12CC2)smi", false, true}, // #7759 {R"smi(C[C-]1[C@H]2C[C@H](C2)[C@]12CC2)smi", false, true}, // #7759 {R"smi(C[C@H]1[C-]2C[C@H](C2)[C@@]12CC2)smi", false, true}, // #7759 {R"smi([CH-]1[C@H]2C[C@H](C2)[C@]12CC2)smi", false, true}, // #7759 {R"smi([C-]1=C[C@H]2C[C@H](C2)[C@@]12CC2)smi", false, true}, // #7759 {R"smi([CH-]1N2C[C@H](C2)O[C@]12CC2)smi", false, true}, // #7759 {R"smi(C1=[O+][C@H]2C[C@H](C2)[C@]12CC2)smi", false, true}, // #7759 {R"smi(C1=[O+][C@H]2CN(C2)[C@]12CC2)smi", false, true}, // #7759 {R"smi([CH+]1[C@H]2C[C@H](C2)[C@]12CCC2)smi", false, true}, // #7759 {R"smi([CH+]1[C@H]2C[C@H](C2)[C@@]12COC2)smi", false, true}, // #7759 {R"smi(C[C@]12[C@@H]3[C@@H]1[CH][C@H]1[C@H]2[C@]31C)smi", false, true}, // #7759 {R"smi(C[C+]1[C@H]2C[C@H](C2)[C@]12CC2)smi", false, true}, // #7759 {R"smi([H]/[O+]=C1/[C@H]2C[C@H](C2)[C@]12CC2)smi", false, true}, // #7759 {R"smi([CH+]1[C@H]2C[C@H](C2)[C@]12CC2)smi", false, true}, // #7759 {R"smi(C1[C@H]2O[C@@H]3C[C@H]4[C@@H]3[C@@H]1[C@@H]24)smi", false, true}, // #7759 {R"smi(O=C1N2[C@H]3[C@@H]2[C@@H]2[C@H]3N12)smi", false, false}, // #7759 {R"smi(O1[C@H]2[C@@H]3O[C@H]4[C@@H]3[C@@H]1[C@@H]24)smi", false, true}, // #7759 {R"smi(O=C1[C@H]2C[C@H](C2)[C@@]12CC2)smi", false, true}, // #7759 {R"smi(O=C1[C@H]2CN(C2)[C@@]12CC2)smi", false, true}, // #7759 {R"smi(O[C@]12C[C@H](C1)[C@]1(CC1)C2)smi", false, true}, // #7759 {R"smi(O[C@]12[C@@H]3[C@@H]4O[C@H]1[C@H]2[C@]34O)smi", false, true}, // #7759 {R"smi(C[C@]12C[C@H](C1)[C@@]1(CC1)O2)smi", false, true}, // #7759 {R"smi(C[C@]1(O)[C@H]2[C@@H]3[C@@H](O)[C@H]2[C@@H]31)smi", false, true}, // #7759 {R"smi(C[C@H]1[C@@H]2[C@@H]3[C@H]1[C@H]2[C@@]3(C)O)smi", false, true}, // #7759 {R"smi(O[C@H]1[C@@H]2[C@@H]3[C@H]1[C@H]2[C@]31CN1)smi", false, true}, // #7759 {R"smi(C[C@H]1[C@H]2C[C@H](C2)[C@]12CC2)smi", false, true}, // #7759 {R"smi(C[C@]12[C@@H]3[C@@H]4O[C@H]1[C@H]2[C@]34C)smi", false, true}, // #7759 {R"smi(O[C@H]1[C@H]2C[C@H](C2)[C@]12CC2)smi", false, true}, // #7759 {R"smi(N[C@]1(C(=O)O)[C@@H]2C[C@H]3C[C@@H](C2)C[C@H]1C3)smi", false, true}, // #8862 {R"smi(C/C=C1/C(=C\Cl)/C(=C\F)/C(=C\N)/C/1=C\O)smi", true, true}, // #8965 {R"smi(C1(=C/O)\C(=C/N)\C(=C/C)\C(=C/O)\C(=C/N)\C\1=C/C)smi", true, false}, // #8965 {R"smi(C1(=C/O)\C(=C/N)\C(=C/C)\C(=C/F)\C(=C/N)\C(=C/O)\C(=C/C)\C\1=C/F)smi", true, false}, // #8965 {R"smi(C/C/1=C/CC\2CCO/C2=C/C=C1/C=O)smi", true, true}, // pubchem 101176040 {R"smi(CCCSNC1=C(C(=C(C=C1)F)C(=O)/C/2=C/NCN/C=C(\C=C2/C)/C3=CC=C(C=C3)C=O)F)smi", true, true}, // pubchem 144212312 {R"smi(CC(=O)/N=C1\\C=C(N)C=CC1=N/N=c1\\ccccn1O)smi", true, true}, // pubchem 9561953 {R"smi(C/C=P(=C/O)/P(=C\O)=C/C)smi", true, true}, {R"smi(C=C/C(N)=N\C(\C(C)=C/C=C(C)\C=C/C)=C(/C)CCC)smi", true, true}, // pubchem 163248361 {R"smi([H]/N=I/P(=N/[H])=N/[H])smi", true, true}, // pubchem 58298200 {R"smi([H]/N=N/N=N/N=N/N=N/N=N/N=N/N=N/N=N/N=N/N=N/N=N/N=N/N=N/N=N/P()smi" R"smi(=N\N=N\N=N\N=N\N=N\N=N\N=N\N=N\N=N\N=N\N=N\N=N\N=N\N=N\N)=N\N=N)smi" R"smi(\N=N\N=N\N=N\N=N\N=N\N=N\N=N\N=N\N=N\N=N\N=N\N=N\N)smi", true, true}, // pubchem 59092755 {R"smi(C/C=C(C(\C(C)=N\C=C\CC)=C(\C)N1CCN(C(=O)OC2(C)CC2)C(C)C1)/C(F)F)smi", true, true}, // pubchem 168185575 {R"smi(C=NC(=C(\F)Cc1nc(N)cc2ccccc12)/C(=C\C(=C)Cl)C(=N\CO)/N1CCNCC1)smi", true, true}, // pubchem 153584538 {R"smi(C=C1C(=C/C)/C(=C\C)C(=C)C1C)smi", true, true}, // pubchem 144493365 }; const auto &[smiles, legacyState, modernState] = GENERATE_REF(values(samples)); auto usingLegacyStereo = GENERATE(false, true); CAPTURE(smiles, usingLegacyStereo); UseLegacyStereoPerceptionFixture useLegacy(usingLegacyStereo); auto shouldMatch = usingLegacyStereo ? legacyState : modernState; checkSmilesRoundtrip(smiles, shouldMatch); }