Files
rdkit/Code/GraphMol/RGroupDecomposition/RGroupDecomp.cpp
Brian Kelley 015fed1e67 rgroup speedup (#3279)
* First part of restructuring rgroup decomposition classes

* Add docs

* Cache often calculated values and simplfy lookups

* Fix accidentally deleted code

* Merge doc changes

* Remove unused timing code

* Remove unused header

* Remove redundant doc string

* Fix chrono issues

* Response to review

Co-authored-by: Brian Kelley <bkelley@relaytx.com>
2020-07-12 06:56:15 +02:00

454 lines
16 KiB
C++

// Copyright (c) 2017, Novartis Institutes for BioMedical Research Inc.
// All rights reserved.
//
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
//
// * Redistributions of source code must retain the above copyright
// notice, this list of conditions and the following disclaimer.
// * Redistributions in binary form must reproduce the above
// copyright notice, this list of conditions and the following
// disclaimer in the documentation and/or other materials provided
// with the distribution.
// * Neither the name of Novartis Institutes for BioMedical Research Inc.
// nor the names of its contributors may be used to endorse or promote
// products derived from this software without specific prior written
// permission.
//
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
//
#include "RGroupDecomp.h"
#include "RGroupDecompData.h"
#include <GraphMol/RDKitBase.h>
#include <GraphMol/Substruct/SubstructMatch.h>
#include <GraphMol/SmilesParse/SmilesWrite.h>
#include <GraphMol/SmilesParse/SmartsWrite.h>
#include <GraphMol/SmilesParse/SmilesParse.h>
#include <GraphMol/ChemTransforms/ChemTransforms.h>
#include <GraphMol/FMCS/FMCS.h>
#include <boost/scoped_ptr.hpp>
#include <boost/dynamic_bitset.hpp>
#include <set>
#include <utility>
#include <vector>
// #define DEBUG
namespace RDKit {
// Attachment Points
// labeled cores => isotopes
// atom mappings
// atom indices => use -1 - atom index, range is [-1, ...., -num_atoms]
const std::string RLABEL = "tempRlabel";
const std::string SIDECHAIN_RLABELS = "sideChainRlabels";
const std::string done = "RLABEL_PROCESSED";
namespace {
void ADD_MATCH(R_DECOMP &match, int rlabel) {
if (match.find(rlabel) == match.end()) {
match[rlabel] = boost::make_shared<RGroupData>();
}
}
}
RGroupDecomposition::RGroupDecomposition(
const ROMol &inputCore, const RGroupDecompositionParameters &params)
: data(new RGroupDecompData(inputCore, params)) {}
RGroupDecomposition::RGroupDecomposition(
const std::vector<ROMOL_SPTR> &cores,
const RGroupDecompositionParameters &params)
: data(new RGroupDecompData(cores, params)) {}
RGroupDecomposition::~RGroupDecomposition() { delete data; }
int RGroupDecomposition::add(const ROMol &inmol) {
// get the sidechains if possible
// Add hs for better symmetrization
RWMol mol(inmol);
bool explicitOnly = false;
bool addCoords = true;
MolOps::addHs(mol, explicitOnly, addCoords);
int core_idx = 0;
const RWMol *core = nullptr;
std::vector<MatchVectType> tmatches;
// Find the first matching core.
for (std::map<int, RWMol>::const_iterator coreIt = data->cores.begin();
coreIt != data->cores.end(); ++coreIt) {
{
const bool uniquify = false;
const bool recursionPossible = false;
const bool useChirality = true;
SubstructMatch(mol, coreIt->second, tmatches, uniquify, recursionPossible,
useChirality);
}
if (data->params.onlyMatchAtRGroups) {
// First find all the core atoms that have user
// label and but their indices into core_atoms_with_user_labels
std::set<int> core_atoms_with_user_labels;
for (auto atom : coreIt->second.atoms()) {
if (atom->hasProp(RLABEL)) {
core_atoms_with_user_labels.insert(atom->getIdx());
}
}
std::vector<MatchVectType> tmatches_filtered;
for (auto &mv : tmatches) {
bool passes_filter = true;
boost::dynamic_bitset<> target_match_indices(mol.getNumAtoms());
for (auto &match : mv) {
target_match_indices[match.second] = 1;
}
for (auto &match : mv) {
const Atom *atm = mol.getAtomWithIdx(match.second);
// is this a labelled rgroup or not?
if (core_atoms_with_user_labels.find(match.first) ==
core_atoms_with_user_labels.end()) {
// nope... if any neighbor is not part of the substructure
// make sure we are a hydrogen, otherwise, skip the match
for (const auto &nbri :
boost::make_iterator_range(mol.getAtomNeighbors(atm))) {
const auto &nbr = mol[nbri];
if (nbr->getAtomicNum() != 1 &&
!target_match_indices[nbr->getIdx()]) {
passes_filter = false;
break;
}
}
}
if (!passes_filter) {
break;
}
}
if (passes_filter) {
tmatches_filtered.push_back(mv);
}
}
tmatches = tmatches_filtered;
}
if (!tmatches.size()) {
continue;
} else {
if (tmatches.size() > 1) {
if (data->params.matchingStrategy == NoSymmetrization) {
tmatches.resize(1);
} else if (data->matches.size() == 0) {
// Greedy strategy just grabs the first match and
// takes the best matches from the rest
if (data->params.matchingStrategy == Greedy) {
tmatches.resize(1);
}
}
}
core = &coreIt->second;
core_idx = coreIt->first;
break;
}
}
if (core == nullptr) {
return -1;
}
// strategies
// ==========
// Exhaustive - saves all matches and optimizes later exhaustive
// May never finish due to combinatorial complexity
// Greedy - matches to *FIRST* available match
// GreedyChunks - default - process every N chunks
// Should probably scan all mols first to find match with
// smallest number of matches...
size_t size = data->matches.size();
std::vector<RGroupMatch> potentialMatches;
for (auto &tmatche : tmatches) {
boost::scoped_ptr<ROMol> tMol;
{
const bool replaceDummies = false;
const bool labelByIndex = true;
const bool requireDummyMatch = false;
tMol.reset(replaceCore(mol, *core, tmatche, replaceDummies, labelByIndex,
requireDummyMatch));
}
if (tMol) {
R_DECOMP match;
// rlabel rgroups
MOL_SPTR_VECT fragments = MolOps::getMolFrags(*tMol, false);
for (size_t i = 0; i < fragments.size(); ++i) {
std::vector<int> attachments;
boost::shared_ptr<ROMol> &newMol = fragments[i];
newMol->setProp<int>("core", core_idx);
newMol->setProp<int>("idx", size);
newMol->setProp<int>("frag_idx", i);
for (ROMol::AtomIterator atIt = newMol->beginAtoms();
atIt != newMol->endAtoms(); ++atIt) {
Atom *tmp = *atIt;
unsigned int elno = tmp->getAtomicNum();
if (elno == 0) {
unsigned int index =
tmp->getIsotope(); // this is the index into the core
// it messes up when there are multiple ?
int rlabel;
if (core->getAtomWithIdx(index)->getPropIfPresent(RLABEL, rlabel)) {
std::vector<int> rlabelsOnSideChain;
tmp->getPropIfPresent(SIDECHAIN_RLABELS, rlabelsOnSideChain);
rlabelsOnSideChain.push_back(rlabel);
tmp->setProp(SIDECHAIN_RLABELS, rlabelsOnSideChain);
data->labels.insert(rlabel); // keep track of all labels used
attachments.push_back(rlabel);
}
}
}
if (attachments.size() > 0) {
// reject multiple attachments?
// what to do with labelled cores ?
std::string newCoreSmi = MolToSmiles(*newMol, true);
for (size_t attach_idx = 0; attach_idx < attachments.size();
++attach_idx) {
int rlabel = attachments[attach_idx];
ADD_MATCH(match, rlabel);
match[rlabel]->add(newMol, attachments);
}
} else {
// special case, only one fragment
if (fragments.size() == 1) { // need to make a new core
// remove the sidechains
RWMol newCore(mol);
for (MatchVectType::const_iterator mvit = tmatche.begin();
mvit != tmatche.end(); ++mvit) {
const Atom *coreAtm = core->getAtomWithIdx(mvit->first);
Atom *newCoreAtm = newCore.getAtomWithIdx(mvit->second);
int rlabel;
if (coreAtm->getPropIfPresent(RLABEL, rlabel)) {
newCoreAtm->setProp<int>(RLABEL, rlabel);
}
newCoreAtm->setProp<bool>("keep", true);
}
for (int aIdx = newCore.getNumAtoms() - 1; aIdx >= 0; --aIdx) {
Atom *atom = newCore.getAtomWithIdx(aIdx);
if (!atom->hasProp("keep")) {
newCore.removeAtom(atom);
}
}
if (newCore.getNumAtoms()) {
std::string newCoreSmi = MolToSmiles(newCore, true);
// add a new core if possible
auto newcore = data->newCores.find(newCoreSmi);
int core_idx = 0;
if (newcore == data->newCores.end()) {
core_idx = data->newCores[newCoreSmi] = data->newCoreLabel--;
data->cores[core_idx] = newCore;
return add(inmol);
}
}
}
}
}
if (match.size()) {
potentialMatches.emplace_back(core_idx, match);
}
}
}
if (potentialMatches.size() == 0) {
BOOST_LOG(rdWarningLog)
<< "No attachment points in side chains" << std::endl;
return -1;
}
size_t N = 1;
for (auto &matche : data->matches) {
size_t sz = matche.size();
N *= sz;
}
// oops, exponential is a pain
if (N * potentialMatches.size() > 100000) {
data->permutation = std::vector<size_t>(data->matches.size(), 0);
data->process(true);
}
data->matches.push_back(potentialMatches);
data->permutation = std::vector<size_t>(data->matches.size(), 0);
if (size) {
if (data->params.matchingStrategy & Greedy ||
(data->params.matchingStrategy & GreedyChunks && size > 1 &&
size % data->params.chunkSize == 0)) {
data->process(true);
}
}
return data->matches.size() - 1;
}
bool RGroupDecomposition::process() {
try {
const bool prune = true;
const bool finalize = true;
return data->process(prune, finalize);
} catch (...) {
return false;
}
}
std::vector<std::string> RGroupDecomposition::getRGroupLabels() const {
// this is a bit of a cheat
RGroupColumns cols = getRGroupsAsColumns();
std::vector<std::string> labels;
for (auto it : cols) {
labels.push_back(it.first);
}
std::sort(labels.begin(), labels.end());
return labels;
}
RGroupRows RGroupDecomposition::getRGroupsAsRows() const {
std::vector<RGroupMatch> permutation = data->GetCurrentBestPermutation();
RGroupRows groups;
int molidx = 0;
for (auto it = permutation.begin(); it != permutation.end(); ++it, ++molidx) {
// make a new rgroup entry
groups.push_back(RGroupRow());
RGroupRow &out_rgroups = groups.back();
out_rgroups["Core"] = data->labelledCores[it->core_idx];
R_DECOMP &in_rgroups = it->rgroups;
for (R_DECOMP::const_iterator rgroup = in_rgroups.begin();
rgroup != in_rgroups.end(); ++rgroup) {
std::map<int, int>::const_iterator realLabel =
data->finalRlabelMapping.find(rgroup->first);
CHECK_INVARIANT(realLabel != data->finalRlabelMapping.end(),
"unprocessed rlabel, please call process() first.");
out_rgroups[std::string("R") + std::to_string(realLabel->second)] =
rgroup->second->combinedMol;
}
}
return groups;
}
//! return rgroups in column order group[attachment_point][molidx] = ROMol
RGroupColumns RGroupDecomposition::getRGroupsAsColumns() const {
std::vector<RGroupMatch> permutation = data->GetCurrentBestPermutation();
RGroupColumns groups;
// collect the list of all possible RGroups:
std::map<int, size_t> rgrp_pos_map;
unsigned int ridx = 0;
for (const auto rl : data->finalRlabelMapping) {
rgrp_pos_map[rl.second] = ridx++;
}
unsigned int molidx = 0;
for (auto it = permutation.begin(); it != permutation.end(); ++it, ++molidx) {
boost::dynamic_bitset<> Rs_seen(rgrp_pos_map.size());
R_DECOMP &in_rgroups = it->rgroups;
groups["Core"].push_back(data->labelledCores[it->core_idx]);
for (R_DECOMP::const_iterator rgroup = in_rgroups.begin();
rgroup != in_rgroups.end(); ++rgroup) {
std::map<int, int>::const_iterator realLabel =
data->finalRlabelMapping.find(rgroup->first);
CHECK_INVARIANT(realLabel != data->finalRlabelMapping.end(),
"unprocessed rlabel, please call process() first.");
CHECK_INVARIANT(rgroup->second->combinedMol->hasProp(done),
"Not done! Call process()");
Rs_seen.set(rgrp_pos_map[realLabel->second]);
std::string r = std::string("R") + std::to_string(realLabel->second);
RGroupColumn &col = groups[r];
if (molidx && col.size() < (size_t)(molidx - 1)) {
col.resize(molidx - 1);
}
col.push_back(rgroup->second->combinedMol);
}
// add empty entries to columns where this molecule didn't appear
for (const auto rpr : rgrp_pos_map) {
if (!Rs_seen[rpr.second]) {
std::string r = std::string("R") + std::to_string(rpr.first);
groups[r].push_back(boost::make_shared<RWMol>());
}
}
}
return groups;
}
const RGroupDecompositionParameters &RGroupDecomposition::params() const {
return data->params;
}
namespace {
std::vector<unsigned int> Decomp(RGroupDecomposition &decomp,
const std::vector<ROMOL_SPTR> &mols) {
auto t0 = std::chrono::steady_clock::now();
std::vector<unsigned int> unmatched;
for (size_t i = 0; i < mols.size(); ++i) {
int v = decomp.add(*mols[i].get());
if (v == -1) {
unmatched.push_back(i);
}
checkForTimeout(t0, decomp.params().timeout);
}
decomp.process();
return unmatched;
}
} // namespace
unsigned int RGroupDecompose(const std::vector<ROMOL_SPTR> &cores,
const std::vector<ROMOL_SPTR> &mols,
RGroupRows &rows,
std::vector<unsigned int> *unmatchedIndices,
const RGroupDecompositionParameters &options) {
RGroupDecomposition decomp(cores, options);
std::vector<unsigned int> unmatched = Decomp(decomp, mols);
if (unmatchedIndices) {
*unmatchedIndices = unmatched;
}
rows = decomp.getRGroupsAsRows();
return mols.size() - unmatched.size();
}
unsigned int RGroupDecompose(const std::vector<ROMOL_SPTR> &cores,
const std::vector<ROMOL_SPTR> &mols,
RGroupColumns &columns,
std::vector<unsigned int> *unmatchedIndices,
const RGroupDecompositionParameters &options) {
RGroupDecomposition decomp(cores, options);
std::vector<unsigned int> unmatched = Decomp(decomp, mols);
if (unmatchedIndices) {
*unmatchedIndices = unmatched;
}
columns = decomp.getRGroupsAsColumns();
return mols.size() - unmatched.size();
}
} // namespace RDKit