David Cosgrove
42782d31cf
Change IUPAC metal->non-metal single bonds to dative ( #6038 )
...
* Change atom to metal bonds from single to dative if appropriate.
* Pedantic change whilst I was in the area.
* Reinstate all tests, leave in debugging writes to see failing tests.
* Re-did it. Failing tests now pass.
* Move any positive charge from the non-metal to the metal.
Fix expected test results.
* Write dative bond to JSON.
* Bump currentRDKitJSONVersion to 11, but allow parser to still read 10.
* Only move 1 unit of charge at a time from non-metal to metal.
* Greg's hack to not do it for O+ and N+ etc.
Explicitly exclude H, He, F, Ne from dative bonds.
Fix tests.
* Update expected PostGres json version to 11.
* suggestions for PR
* Correct comment.
---------
Co-authored-by: David Cosgrove <david@cozchemix.co.uk >
Co-authored-by: greg landrum <greg.landrum@gmail.com >
2023-02-06 04:37:32 +01:00
..
2022-11-01 04:14:26 +01:00
2021-10-20 04:25:27 +02:00
2023-01-28 04:47:46 +01:00
2023-02-02 05:00:47 +01:00
2022-12-09 05:28:38 +01:00
2023-01-24 18:16:26 +01:00
2022-05-17 04:39:33 +02:00
2023-01-14 08:54:30 -05:00
2023-01-11 09:43:05 +01:00
2023-02-01 04:31:45 +01:00
2023-02-06 04:37:32 +01:00
2023-01-24 18:16:26 +01:00
2023-02-01 04:29:22 +01:00
2022-11-01 04:14:26 +01:00
2023-01-25 12:15:04 +01:00
2023-01-24 18:16:26 +01:00
2022-05-17 04:39:33 +02:00
2019-10-10 20:18:43 +09:00
2022-10-31 06:43:57 +01:00
2022-10-04 05:04:28 +02:00
2023-01-24 18:16:26 +01:00
2022-11-01 04:14:26 +01:00
2023-02-05 08:14:56 +01:00
2023-01-28 04:47:46 +01:00
2023-01-11 09:32:54 -05:00
2023-02-06 04:37:32 +01:00
2023-02-06 04:37:32 +01:00
2022-03-10 06:55:18 +01:00
2021-10-20 04:25:27 +02:00
2021-10-20 04:25:27 +02:00
2023-01-20 15:01:45 +01:00
2023-01-24 18:16:26 +01:00
2021-10-20 04:25:27 +02:00
2022-03-10 08:00:10 +01:00
2023-02-02 05:05:11 +01:00
2022-12-16 16:01:19 +01:00
2022-12-16 16:01:19 +01:00
2023-01-30 17:18:22 +01:00
2023-01-24 18:16:26 +01:00
2023-01-24 18:16:26 +01:00
2023-01-30 23:24:00 -05:00
2019-10-10 20:18:43 +09:00
2021-10-20 04:25:27 +02:00
2023-02-06 04:37:32 +01:00
2022-11-01 04:14:26 +01:00
2021-12-13 14:15:26 +01:00
2022-11-01 04:14:26 +01:00
2022-12-28 20:10:13 +00:00
2022-07-11 13:55:35 +02:00
2022-11-25 04:50:36 +01:00
2022-09-06 14:35:29 +02:00
2021-10-20 04:25:27 +02:00
2021-06-08 07:57:51 +02:00
2021-09-26 07:45:06 +02:00
2022-03-17 04:56:34 +01:00
2021-10-20 04:25:27 +02:00
2021-06-08 07:57:51 +02:00
2020-05-04 10:40:57 +02:00
2022-12-16 16:01:19 +01:00
2022-12-16 16:01:19 +01:00
2021-12-13 14:15:26 +01:00
2022-07-13 05:40:23 +02:00
2023-01-26 19:26:19 +01:00
2023-02-06 04:37:32 +01:00
2023-01-20 15:00:32 +01:00
2021-08-24 05:10:06 +02:00
2022-10-04 05:04:28 +02:00
2022-09-06 12:53:02 +02:00
2022-10-06 05:46:08 +02:00
2020-01-25 14:19:32 +01:00
2022-03-10 08:00:10 +01:00
2022-05-20 09:07:16 +02:00
2020-01-25 14:19:32 +01:00
2019-01-22 17:45:03 +01:00
2023-01-11 09:32:54 -05:00
2023-01-26 19:26:19 +01:00
2021-10-20 04:25:27 +02:00
2018-07-25 09:14:17 +02:00
2021-10-20 04:25:27 +02:00
2020-05-04 10:40:57 +02:00
2022-09-13 14:49:45 +02:00
2021-09-26 07:45:06 +02:00
2021-10-20 04:25:27 +02:00
2022-03-10 08:00:10 +01:00
2023-02-06 04:37:32 +01:00
2023-02-06 04:37:32 +01:00
2022-03-17 04:53:17 +01:00
2023-01-30 23:24:00 -05:00
2022-10-06 16:45:14 +02:00
2021-09-28 13:40:43 -04:00
2021-09-28 13:40:43 -04:00
2022-09-06 12:53:02 +02:00
2022-09-06 12:53:02 +02:00
2022-05-20 09:07:16 +02:00
2022-07-11 11:20:03 +02:00
2022-09-06 14:35:29 +02:00
2020-01-25 14:19:32 +01:00
2022-03-17 04:56:34 +01:00
2021-07-09 15:06:54 +02:00
2022-03-10 08:00:10 +01:00
2023-01-07 05:13:00 +01:00
2022-07-11 11:20:03 +02:00
2021-10-20 04:25:27 +02:00
2018-09-26 15:44:23 +02:00
2018-07-25 09:14:17 +02:00
2019-10-10 20:18:43 +09:00
2021-04-23 16:45:54 -04:00
2022-10-28 19:47:06 +02:00
2022-11-01 04:14:26 +01:00
2020-09-02 04:51:20 +02:00
2023-01-11 09:32:54 -05:00
2022-07-11 13:55:35 +02:00
2019-12-31 06:43:27 +01:00
2023-01-31 17:30:34 +01:00
2023-01-20 15:00:32 +01:00
2022-02-06 05:06:38 +01:00
2022-07-11 13:55:35 +02:00
2021-07-01 05:18:56 +02:00
2020-05-04 10:40:57 +02:00
2022-09-06 13:03:08 +02:00
2022-09-06 13:03:08 +02:00
2022-09-06 13:03:08 +02:00
2022-09-06 13:03:08 +02:00
2020-09-17 08:16:43 +02:00
2020-01-25 14:19:32 +01:00
2022-07-13 05:40:23 +02:00
2021-09-26 07:45:06 +02:00
2022-05-07 11:11:53 +02:00
2021-10-20 04:25:27 +02:00
2022-07-07 11:05:18 +02:00
2019-03-06 20:43:49 -05:00