Files
rdkit/Code/RDGeneral/catch_dict.cpp
Greg Landrum 3aab2653cd Fixes #9068: raise a ValueError when trying to set properties with empty names (#9085)
* Fixes #9068

* fix a problem with empty labels in s-group parsing

* fix empty column names in smiles suppliers

* add the check to setPODVal()

---------

Co-authored-by: = <=>
2026-02-09 05:58:25 +01:00

95 lines
2.9 KiB
C++

//
// Copyright (C) 2021-2026 Greg Landrum
//
// @@ All Rights Reserved @@
// This file is part of the RDKit.
// The contents are covered by the terms of the BSD license
// which is included in the file license.txt, found at the root
// of the RDKit source tree.
//
#include <string>
#include <catch2/catch_all.hpp>
#include "Dict.h"
#include "RDProps.h"
#include "Exceptions.h"
using namespace std::string_literals;
TEST_CASE("Dict move semantics") {
RDKit::Dict d1;
d1.setVal("foo"s, 1);
d1.setVal("bar"s, "yep");
SECTION("move constructor") {
CHECK(d1.hasVal("foo"s));
CHECK(d1.hasVal("bar"s));
CHECK(d1.getVal<std::string>("bar"s) == "yep"s);
auto d2 = std::move(d1);
CHECK(d2.hasVal("foo"s));
CHECK(d2.hasVal("bar"s));
CHECK(d2.getVal<std::string>("bar"s) == "yep"s);
CHECK(!d1.hasVal("foo"s));
CHECK(!d1.hasVal("bar"s));
}
SECTION("move assignment") {
CHECK(d1.hasVal("foo"s));
CHECK(d1.hasVal("bar"s));
CHECK(d1.getVal<std::string>("bar"s) == "yep"s);
RDKit::Dict d2;
d2 = std::move(d1);
CHECK(d2.hasVal("foo"s));
CHECK(d2.hasVal("bar"s));
CHECK(d2.getVal<std::string>("bar"s) == "yep"s);
CHECK(!d1.hasVal("foo"s));
CHECK(!d1.hasVal("bar"s));
}
}
TEST_CASE("RDProps move semantics") {
RDKit::RDProps d1;
d1.setProp("foo"s, 1);
d1.setProp("bar"s, "yep");
SECTION("move constructor") {
CHECK(d1.hasProp("foo"s));
CHECK(d1.hasProp("bar"s));
CHECK(d1.getProp<std::string>("bar"s) == "yep"s);
auto d2 = std::move(d1);
CHECK(d2.hasProp("foo"s));
CHECK(d2.hasProp("bar"s));
CHECK(d2.getProp<std::string>("bar"s) == "yep"s);
CHECK(!d1.hasProp("foo"s));
CHECK(!d1.hasProp("bar"s));
}
SECTION("move assignment") {
CHECK(d1.hasProp("foo"s));
CHECK(d1.hasProp("bar"s));
CHECK(d1.getProp<std::string>("bar"s) == "yep"s);
RDKit::RDProps d2;
d2 = std::move(d1);
CHECK(d2.hasProp("foo"s));
CHECK(d2.hasProp("bar"s));
CHECK(d2.getProp<std::string>("bar"s) == "yep"s);
CHECK(!d1.hasProp("foo"s));
CHECK(!d1.hasProp("bar"s));
}
}
TEST_CASE("github #9068: properties with empty names") {
RDKit::RDProps props;
SECTION("setProp with empty key") {
CHECK_THROWS_AS(props.setProp("", 1), ValueErrorException);
}
SECTION("getProp with empty key") {
CHECK_THROWS_AS(props.getProp<int>(""), KeyErrorException);
}
SECTION("hasProp with empty key") { CHECK(!props.hasProp("")); }
SECTION("clearProp with empty key") { CHECK_NOTHROW(props.clearProp("")); }
}
TEST_CASE("github #9068: dicts with empty keys") {
RDKit::Dict dict;
SECTION("setVal with empty key") {
CHECK_THROWS_AS(dict.setVal("", 1), ValueErrorException);
}
SECTION("getVal with empty key") {
CHECK_THROWS_AS(dict.getVal<int>(""), KeyErrorException);
}
SECTION("hasVal with empty key") { CHECK(!dict.hasVal("")); }
SECTION("clearVal with empty key") { CHECK_NOTHROW(dict.clearVal("")); }
}