Paolo Tosco
7aa42e3fd9
Fixes MMFF94 aromaticity perception and ChemicalForceFields.MMFFHasAllMoleculeParams() ( #1007 )
...
* - calcImplicitValence() and setNumExplicitHs() are now called after
all aromaticity flags have been set
* - ChemicalForceFields.MMFFHasAllMoleculeParams() now operates on a copy of the molecule
such that atom and bond aromaticity are not altered by the check
- test11 was added to GraphMol/ForceFieldHelpers/Wrap/testHelpers.py to check
for the two bugs fixed by this PR
* - modified the prototype of MMFFHasAllMoleculeParams() to take a const ROMol&
and make a copy of that within the function body
- removed unnecessary imports from testHelpers.py
- replaced EmbedMolecule() with a quicker test
* - WIP
* - now the issue seems to be properly fixed, as the implicit valence
made explicit does not sum up anymore to the already explicit valence
2016-08-06 05:21:48 +02:00
..
2015-11-14 14:58:11 +01:00
2016-07-27 10:22:13 -04:00
2016-03-29 16:56:15 +02:00
2016-05-20 05:23:12 +01:00
2016-06-22 16:50:22 +02:00
2016-08-02 06:07:47 +02:00
2016-08-02 14:41:08 +02:00
2016-05-31 13:23:21 -04:00
2016-04-23 11:53:13 -04:00
2016-06-25 09:12:40 +02:00
2016-08-06 05:21:48 +02:00
2016-03-01 06:36:54 +01:00
2006-05-06 22:20:08 +00:00
2016-06-25 09:12:40 +02:00
2016-03-30 14:55:53 -04:00
2016-03-01 06:36:54 +01:00
2016-03-01 06:36:54 +01:00
2016-07-25 17:28:41 -04:00
2015-11-14 14:58:11 +01:00
2016-02-13 14:58:35 +01:00
2016-02-21 21:24:56 +00:00
2016-03-01 06:36:54 +01:00
2016-03-01 06:36:54 +01:00
2015-11-28 06:49:34 +01:00
2016-03-30 13:44:21 +02:00
2016-06-24 14:20:47 +02:00
2015-11-14 14:58:11 +01:00
2015-12-13 17:18:36 +01:00
2016-05-09 19:05:15 +01:00
2006-05-06 22:20:08 +00:00
2016-07-20 22:51:01 -04:00
2016-07-26 13:17:41 -04:00
2016-07-27 04:49:55 +02:00
2016-06-29 05:09:30 +02:00
2016-06-17 17:48:20 -04:00
2016-05-29 17:04:21 +01:00
2016-05-29 17:04:21 +01:00
2016-02-16 15:38:02 +01:00
2016-02-16 15:38:02 +01:00
2015-11-14 14:58:11 +01:00
2015-11-14 14:58:11 +01:00
2016-05-29 17:04:21 +01:00
2016-05-29 17:04:21 +01:00
2015-11-14 14:58:11 +01:00
2015-11-14 14:58:11 +01:00
2015-11-14 14:58:11 +01:00
2016-05-29 17:04:21 +01:00
2015-11-14 14:58:11 +01:00
2016-03-13 04:21:36 -07:00
2015-11-14 14:58:11 +01:00
2016-05-11 19:37:09 +01:00
2015-11-14 14:58:11 +01:00
2015-11-29 20:33:09 -05:00
2015-11-14 14:58:11 +01:00
2015-11-14 14:58:11 +01:00
2015-11-14 14:58:11 +01:00
2015-11-29 17:52:27 -05:00
2015-11-14 14:58:11 +01:00
2015-11-14 14:58:11 +01:00
2015-11-14 14:58:11 +01:00
2015-11-14 14:58:11 +01:00
2016-08-05 07:57:20 -04:00
2016-02-09 09:21:48 +02:00
2015-11-14 14:58:11 +01:00
2016-05-29 17:04:21 +01:00
2016-04-01 07:54:32 +02:00
2016-06-29 05:09:30 +02:00
2016-08-05 07:57:20 -04:00
2015-12-22 07:18:35 +01:00
2015-11-14 14:58:11 +01:00
2015-11-14 14:58:11 +01:00
2016-05-29 17:04:21 +01:00
2016-03-30 13:09:59 +02:00
2016-05-30 19:58:39 -04:00
2016-05-30 19:58:39 -04:00
2015-11-14 14:58:11 +01:00
2015-11-14 14:58:11 +01:00
2016-05-29 17:04:21 +01:00
2015-11-14 14:58:11 +01:00
2015-11-14 14:58:11 +01:00
2016-06-22 13:49:15 -04:00
2015-11-14 14:58:11 +01:00
2010-09-26 17:04:37 +00:00
2015-11-14 14:58:11 +01:00
2006-05-06 22:20:08 +00:00
2015-11-14 14:58:11 +01:00
2015-11-14 14:58:11 +01:00
2015-12-16 17:33:22 +00:00
2015-12-16 17:33:22 +00:00
2015-11-29 17:52:27 -05:00
2015-11-14 14:58:11 +01:00
2015-11-14 14:58:11 +01:00
2016-05-29 17:04:21 +01:00
2016-05-29 17:04:21 +01:00
2016-06-20 16:40:33 +01:00
2016-06-14 07:47:15 +02:00
2015-11-14 14:58:11 +01:00
2015-11-14 14:58:11 +01:00
2016-05-30 19:58:39 -04:00
2009-10-31 05:24:15 +00:00
2015-11-14 14:58:11 +01:00
2016-03-09 05:05:33 +01:00
2015-12-23 05:31:37 +01:00
2014-09-11 23:49:45 +02:00