pub_soft/rdkit
3
0
Fork 0
mirror of https://github.com/rdkit/rdkit.git synced 2026-06-04 21:54:27 +08:00
Code Issues Packages Projects Releases Wiki Activity
Files
8884e6e6ef174db7658a0240acb7b57c5f5ef920
rdkit/Code/GraphMol/catch_graphmol.cpp
John Mayfield 0b37f0f65d Improved handling of SP/TB/OH reording in SMILES/SMARTS. (#6777) 
* Improved handling of SP/TB/OH reording in SMILES/SMARTS.

- add a getMaxNbors(tag) utility function to avoid repeated logic in multiple places
- tweak getChiralPermutation() for handling implicit/missing ligands (uses -1), allow inverse lookup
- use the tweaked chiral ordering in the reading/writing from SMILES

* clang-format run

* Reviewer requested changes.
- curly braces on all if conditions
- null check raw pointers with precondition.

* Correct additional test case introduced in the last year
2024-11-28 07:11:51 +01:00

4737 lines
150 KiB
C++
Raw Blame History

//
// Copyright (C) 2018-2024 Greg Landrum and other RDKit contributors
//
// @@ All Rights Reserved @@
// This file is part of the RDKit.
// The contents are covered by the terms of the BSD license
// which is included in the file license.txt, found at the root
// of the RDKit source tree.
//
#include <catch2/catch_all.hpp>
#include <algorithm>
#include <limits>
#include <fstream>
#include <random>
#include <string>
#include <boost/format.hpp>
#include <GraphMol/RDKitBase.h>
#include <GraphMol/new_canon.h>
#include <GraphMol/RDKitQueries.h>
#include <GraphMol/QueryOps.h>
#include <GraphMol/Chirality.h>
#include <GraphMol/MonomerInfo.h>
#include <GraphMol/MolPickler.h>
#include <GraphMol/FileParsers/FileParsers.h>
#include <GraphMol/FileParsers/SequenceParsers.h>
#include <GraphMol/SmilesParse/SmilesParse.h>
#include <GraphMol/SmilesParse/SmilesWrite.h>
#include <GraphMol/SmilesParse/SmartsWrite.h>
#include <GraphMol/test_fixtures.h>
using namespace RDKit;
#if 1
TEST_CASE("SMILES Parsing works", "[molops]") {
std::unique_ptr<RWMol> mol(SmilesToMol("C1CC1"));
REQUIRE(mol);
REQUIRE(mol->getNumAtoms() == 3);
}
TEST_CASE("Sanitization tests", "[molops]") {
std::unique_ptr<RWMol> mol(SmilesToMol("C1=CC=CC=C1Cc2ccccc2", false, false));
REQUIRE(mol);
REQUIRE(mol->getNumAtoms() == 13);
SECTION("properties") {
mol->updatePropertyCache();
CHECK(mol->getAtomWithIdx(0)->getTotalNumHs() == 1);
CHECK(!mol->getAtomWithIdx(0)->getIsAromatic());
CHECK(mol->getAtomWithIdx(10)->getIsAromatic());
SECTION("aromaticity") {
unsigned int opThatFailed;
MolOps::sanitizeMol(*mol, opThatFailed, MolOps::SANITIZE_SETAROMATICITY);
// mol->debugMol(std::cerr);
CHECK(mol->getAtomWithIdx(10)->getIsAromatic());
// blocked by #1730
// CHECK(mol->getAtomWithIdx(0)->getIsAromatic());
}
SECTION("kekulize") {
unsigned int opThatFailed;
MolOps::sanitizeMol(*mol, opThatFailed, MolOps::SANITIZE_KEKULIZE);
CHECK(!mol->getAtomWithIdx(0)->getIsAromatic());
CHECK(!mol->getAtomWithIdx(10)->getIsAromatic());
}
}
}
TEST_CASE("Github #2062", "[bug][molops]") {
SmilesParserParams ps;
ps.removeHs = false;
ps.sanitize = true;
std::unique_ptr<RWMol> mol(SmilesToMol("[C:1][C:2]([H:3])([H])[O:4][H]", ps));
REQUIRE(mol);
CHECK(mol->getNumAtoms() == 6);
mol->getAtomWithIdx(1)->setProp("intProp", 42);
MolOps::mergeQueryHs(*mol);
CHECK(mol->getNumAtoms() == 3);
SECTION("basics") { CHECK(mol->getAtomWithIdx(1)->getAtomMapNum() == 2); }
SECTION("other props") {
REQUIRE(mol->getAtomWithIdx(1)->hasProp("intProp"));
CHECK(mol->getAtomWithIdx(1)->getProp<int>("intProp") == 42);
}
}
TEST_CASE("Github #2086", "[bug][molops]") {
SECTION("reported version") {
auto mol = "C1CCCC1"_smiles;
REQUIRE(mol);
MolOps::addHs(*mol);
REQUIRE(mol->getNumAtoms() == 15);
mol->removeBond(4, 13);
MolOps::removeHs(*mol);
REQUIRE(mol->getNumAtoms() == 6);
}
}
TEST_CASE("github #299", "[bug][molops][SSSR]") {
SECTION("simplified") {
auto mol =
"C13%13%14.C124%18.C25%13%15.C368%17.C4679.C75%10%17.C8%11%14%16.C9%11%12%18.C%10%12%15%16"_smiles;
REQUIRE(mol);
REQUIRE(mol->getNumAtoms() == 9);
}
SECTION("old example from molopstest") {
auto mol = "C123C45C11C44C55C22C33C14C523"_smiles;
REQUIRE(mol);
REQUIRE(mol->getNumAtoms() == 9);
}
SECTION("carborane") {
std::unique_ptr<RWMol> mol(
SmilesToMol("[B]1234[B]567[B]118[B]229[B]33%10[B]454[B]656[B]711[B]822["
"C]933[B]%1045[C]6123",
0, false));
REQUIRE(mol);
CHECK(mol->getNumAtoms() == 12);
mol->updatePropertyCache(false);
MolOps::findSSSR(*mol);
REQUIRE(mol->getRingInfo()->isInitialized());
}
SECTION("original report from ChEbI") {
std::string pathName = getenv("RDBASE");
pathName += "/Code/GraphMol/test_data/";
std::unique_ptr<RWMol> mol(
MolFileToMol(pathName + "ChEBI_50252.mol", false));
REQUIRE(mol);
CHECK(mol->getNumAtoms() == 80);
mol->updatePropertyCache(false);
MolOps::findSSSR(*mol);
REQUIRE(mol->getRingInfo()->isInitialized());
}
}
TEST_CASE("github #2224", "[bug][molops][removeHs][query]") {
SECTION("the original report") {
std::string pathName = getenv("RDBASE");
pathName += "/Code/GraphMol/test_data/";
std::unique_ptr<RWMol> mol(MolFileToMol(pathName + "github2224_1.mol"));
REQUIRE(mol);
REQUIRE(mol->getNumAtoms() == 7);
}
SECTION("basics") {
SmilesParserParams ps;
ps.removeHs = false;
ps.sanitize = true;
std::unique_ptr<ROMol> mol(SmilesToMol("C[H]", ps));
REQUIRE(mol);
REQUIRE(mol->getNumAtoms() == 2);
{ // The H without a query is removed
std::unique_ptr<ROMol> m2(MolOps::removeHs(*mol));
CHECK(m2->getNumAtoms() == 1);
}
{ // but if we add a query feature it's not removed
RWMol m2(*mol);
auto *qa = new QueryAtom(1);
m2.replaceAtom(1, qa);
m2.getAtomWithIdx(1)->setAtomicNum(1);
MolOps::removeHs(m2);
CHECK(m2.getNumAtoms() == 2);
delete qa;
}
}
}
TEST_CASE(
"github #2268: Recognize N in three-membered rings as potentially chiral",
"[bug][stereo]") {
SECTION("basics: N in a 3 ring") {
const auto mol = "C[N@]1CC1C"_smiles;
REQUIRE(mol);
CHECK(mol->getAtomWithIdx(1)->getChiralTag() != Atom::CHI_UNSPECIFIED);
}
SECTION("basics: N in a 4 ring") {
const auto mol = "C[N@]1CCC1C"_smiles;
REQUIRE(mol);
CHECK(mol->getAtomWithIdx(1)->getChiralTag() == Atom::CHI_UNSPECIFIED);
}
SECTION("the original molecule") {
std::string mb = R"CTAB(
Mrv1810 02131915062D
18 20 0 0 1 0 999 V2000
-0.7207 -1.3415 0.0000 N 0 0 1 0 0 0 0 0 0 0 0 0
-0.0583 -0.8416 0.0000 C 0 0 2 0 0 0 0 0 0 0 0 0
-0.0083 -1.7540 0.0000 O 0 0 0 0 0 0 0 0 0 0 0 0
-1.3956 -0.8666 0.0000 C 0 0 2 0 0 0 0 0 0 0 0 0
-0.3250 -0.0667 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
-2.1955 -0.6499 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
-1.1499 -0.0792 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
0.6541 -0.4292 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
-2.7830 -1.2291 0.0000 O 0 0 0 0 0 0 0 0 0 0 0 0
-1.6081 -1.6623 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
-2.4080 0.1500 0.0000 O 0 0 0 0 0 0 0 0 0 0 0 0
1.3665 -0.8374 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
0.6416 0.3958 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
-3.1996 0.3708 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
-3.4121 1.1624 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
1.3498 0.8207 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
2.0790 -0.4167 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
2.0665 0.4083 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
2 1 1 0 0 0 0
1 3 1 1 0 0 0
4 1 1 0 0 0 0
5 2 1 0 0 0 0
4 6 1 0 0 0 0
7 4 1 0 0 0 0
2 8 1 6 0 0 0
9 6 2 0 0 0 0
4 10 1 1 0 0 0
11 6 1 0 0 0 0
12 8 2 0 0 0 0
13 8 1 0 0 0 0
14 11 1 0 0 0 0
15 14 1 0 0 0 0
16 13 2 0 0 0 0
17 12 1 0 0 0 0
18 16 1 0 0 0 0
2 3 1 0 0 0 0
5 7 1 0 0 0 0
17 18 2 0 0 0 0
M END
)CTAB";
std::unique_ptr<ROMol> mol(MolBlockToMol(mb));
REQUIRE(mol);
CHECK(mol->getAtomWithIdx(0)->getChiralTag() != Atom::CHI_UNSPECIFIED);
}
}
TEST_CASE("github #2244", "[bug][molops][stereo]") {
SECTION("the original report") {
auto mol = "CC=CC=CC"_smiles;
REQUIRE(mol);
MolOps::findPotentialStereoBonds(*mol, true);
CHECK(mol->getBondWithIdx(1)->getStereo() == Bond::STEREOANY);
CHECK(mol->getBondWithIdx(3)->getStereo() == Bond::STEREOANY);
mol->getBondWithIdx(3)->setStereo(Bond::STEREONONE);
MolOps::findPotentialStereoBonds(*mol, true);
CHECK(mol->getBondWithIdx(1)->getStereo() == Bond::STEREOANY);
CHECK(mol->getBondWithIdx(3)->getStereo() == Bond::STEREOANY);
}
}
TEST_CASE(
"github #2258: heterocycles with exocyclic bonds not failing valence check",
"[bug][molops]") {
SECTION("the original report") {
std::vector<std::string> smiles = {"C=n1ccnc1", "C#n1ccnc1"};
for (auto smi : smiles) {
CHECK_THROWS_AS(SmilesToMol(smi), MolSanitizeException);
}
}
}
TEST_CASE("github #908: AddHs() using 3D coordinates with 2D conformations",
"[bug][molops]") {
SECTION("basics: single atom mols") {
std::vector<std::string> smiles = {"Cl", "O", "N", "C"};
for (auto smi : smiles) {
// std::cerr << smi << std::endl;
std::unique_ptr<RWMol> mol(SmilesToMol(smi));
REQUIRE(mol);
auto conf = new Conformer(1);
conf->set3D(false);
conf->setAtomPos(0, RDGeom::Point3D(0, 0, 0));
mol->addConformer(conf, true);
bool explicitOnly = false;
bool addCoords = true;
MolOps::addHs(*mol, explicitOnly, addCoords);
for (size_t i = 0; i < mol->getNumAtoms(); ++i) {
// std::cerr << " " << i << " " << conf->getAtomPos(i) << std::endl;
CHECK(conf->getAtomPos(i).z == 0.0);
}
}
}
}
TEST_CASE(
"github #2437: Canon::rankMolAtoms results in crossed double bonds in "
"rings",
"[bug][molops]") {
SECTION("underlying problem") {
std::string molb = R"CTAB(testmol
Mrv1824 05081910082D
4 4 0 0 0 0 999 V2000
6.9312 -8.6277 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
6.9312 -9.4527 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
7.7562 -8.6277 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
7.7562 -9.4527 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
1 2 1 0 0 0 0
1 3 1 0 0 0 0
3 4 1 0 0 0 0
2 4 2 0 0 0 0
M END
)CTAB";
bool sanitize = false;
bool removeHs = false;
std::unique_ptr<RWMol> mol(MolBlockToMol(molb, sanitize, removeHs));
REQUIRE(mol);
mol->updatePropertyCache();
CHECK(mol->getBondWithIdx(3)->getBondType() == Bond::BondType::DOUBLE);
CHECK(mol->getBondWithIdx(3)->getBondDir() == Bond::BondDir::NONE);
std::vector<unsigned int> ranks;
CHECK(mol->getRingInfo()->isInitialized());
Canon::rankMolAtoms(*mol, ranks);
}
SECTION("as discovered") {
std::string molb = R"CTAB(testmol
Mrv1824 05081910082D
4 4 0 0 0 0 999 V2000
6.9312 -9.4527 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
7.7562 -8.6277 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
7.7562 -9.4527 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
6.9312 -8.6277 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
1 2 1 0 0 0 0
1 3 1 0 0 0 0
3 4 1 0 0 0 0
2 4 2 0 0 0 0
M END
)CTAB";
bool sanitize = false;
bool removeHs = false;
std::unique_ptr<RWMol> mol(MolBlockToMol(molb, sanitize, removeHs));
REQUIRE(mol);
mol->updatePropertyCache();
CHECK(mol->getBondWithIdx(3)->getBondType() == Bond::BondType::DOUBLE);
CHECK(mol->getBondWithIdx(3)->getBondDir() == Bond::BondDir::NONE);
auto nmb = MolToMolBlock(*mol);
CHECK(nmb.find("2 4 2 3") == std::string::npos);
CHECK(nmb.find("2 4 2 0") != std::string::npos);
std::vector<unsigned int> ranks;
Canon::rankMolAtoms(*mol, ranks);
nmb = MolToMolBlock(*mol);
CHECK(nmb.find("2 4 2 3") == std::string::npos);
CHECK(nmb.find("2 4 2 0") != std::string::npos);
}
}
TEST_CASE(
"github #2423: Incorrect assignment of explicit Hs to Al+3 read from mol "
"block",
"[bug][molops]") {
SECTION("basics: single atom mols") {
std::string mb = R"CTAB(2300
-OEChem-01301907122D
1 0 0 0 0 0 0 0 0999 V2000
-66.7000 999.0000 0.0000 Al 0 1 0 0 0 0 0 0 0 0 0 0
M CHG 1 1 3
M END)CTAB";
std::unique_ptr<ROMol> mol(MolBlockToMol(mb));
REQUIRE(mol);
CHECK(mol->getAtomWithIdx(0)->getFormalCharge() == 3);
CHECK(mol->getAtomWithIdx(0)->getTotalNumHs() == 0);
}
}
TEST_CASE("Specialized exceptions for sanitization errors", "[molops]") {
SECTION("AtomValenceException") {
std::vector<std::pair<std::string, unsigned int>> smiles = {
{"C=n1ccnc1", 1}, {"CCO(C)C", 2}};
for (auto pr : smiles) {
CHECK_THROWS_AS(SmilesToMol(pr.first), AtomValenceException);
try {
auto m = SmilesToMol(pr.first);
RDUNUSED_PARAM(m);
} catch (const AtomValenceException &e) {
CHECK(e.getType() == "AtomValenceException");
CHECK(e.getAtomIdx() == pr.second);
}
}
}
SECTION("AtomKekulizeException") {
std::vector<std::pair<std::string, unsigned int>> smiles = {
{"CCcc", 2},
};
for (auto pr : smiles) {
CHECK_THROWS_AS(SmilesToMol(pr.first), AtomKekulizeException);
try {
auto m = SmilesToMol(pr.first);
RDUNUSED_PARAM(m);
} catch (const AtomKekulizeException &e) {
CHECK(e.getType() == "AtomKekulizeException");
CHECK(e.getAtomIdx() == pr.second);
}
}
}
SECTION("KekulizeException") {
std::vector<std::pair<std::string, std::vector<unsigned int>>> smiles = {
{"c1cccc1", {0, 1, 2, 3, 4}},
{"Cc1cc1", {1, 2, 3}},
{"C1:c:CC1", {0, 1, 2}}};
for (auto pr : smiles) {
CHECK_THROWS_AS(SmilesToMol(pr.first), KekulizeException);
try {
auto m = SmilesToMol(pr.first);
RDUNUSED_PARAM(m);
} catch (const KekulizeException &e) {
CHECK(e.getType() == "KekulizeException");
CHECK(e.getAtomIndices() == pr.second);
}
}
}
}
TEST_CASE("detectChemistryProblems", "[molops]") {
SECTION("Basics") {
SmilesParserParams ps;
ps.sanitize = false;
auto m = std::unique_ptr<ROMol>(SmilesToMol("CO(C)CFCc1cc1", ps));
REQUIRE(m);
auto res = MolOps::detectChemistryProblems(*m);
REQUIRE(res.size() == 3);
CHECK(res[0]->getType() == "AtomValenceException");
REQUIRE(dynamic_cast<AtomValenceException *>(res[0].get()));
CHECK(dynamic_cast<AtomSanitizeException *>(res[0].get())->getAtomIdx() ==
1);
CHECK(res[1]->getType() == "AtomValenceException");
REQUIRE(dynamic_cast<AtomSanitizeException *>(res[1].get()));
CHECK(dynamic_cast<AtomSanitizeException *>(res[1].get())->getAtomIdx() ==
4);
CHECK(res[2]->getType() == "KekulizeException");
REQUIRE(dynamic_cast<KekulizeException *>(res[2].get()));
CHECK(dynamic_cast<KekulizeException *>(res[2].get())->getAtomIndices() ==
std::vector<unsigned int>({6, 7, 8}));
}
SECTION("No problems") {
SmilesParserParams ps;
ps.sanitize = false;
auto m = std::unique_ptr<ROMol>(SmilesToMol("c1ccccc1", ps));
REQUIRE(m);
auto res = MolOps::detectChemistryProblems(*m);
REQUIRE(res.size() == 0);
}
}
TEST_CASE(
"github #2606: Bad valence corrections on Pb, Sn"
"[bug][molops]") {
SECTION("basics-Pb") {
std::string mb = R"CTAB(
Mrv1810 08141905562D
5 0 0 0 0 0 999 V2000
-3.6316 -0.4737 0.0000 Pb 0 0 0 0 0 0 0 0 0 0 0 0
-3.6541 0.3609 0.0000 O 0 5 0 0 0 0 0 0 0 0 0 0
-2.4586 -0.5188 0.0000 O 0 5 0 0 0 0 0 0 0 0 0 0
-3.6992 -1.5338 0.0000 O 0 5 0 0 0 0 0 0 0 0 0 0
-4.5789 -0.4286 0.0000 O 0 5 0 0 0 0 0 0 0 0 0 0
M CHG 5 1 4 2 -1 3 -1 4 -1 5 -1
M END
)CTAB";
std::unique_ptr<ROMol> mol(MolBlockToMol(mb));
REQUIRE(mol);
CHECK(mol->getAtomWithIdx(0)->getFormalCharge() == 4);
CHECK(mol->getAtomWithIdx(0)->getTotalNumHs() == 0);
}
SECTION("basics-Sn") {
std::string mb = R"CTAB(
Mrv1810 08141905562D
5 0 0 0 0 0 999 V2000
-3.6316 -0.4737 0.0000 Sn 0 0 0 0 0 0 0 0 0 0 0 0
-3.6541 0.3609 0.0000 O 0 5 0 0 0 0 0 0 0 0 0 0
-2.4586 -0.5188 0.0000 O 0 5 0 0 0 0 0 0 0 0 0 0
-3.6992 -1.5338 0.0000 O 0 5 0 0 0 0 0 0 0 0 0 0
-4.5789 -0.4286 0.0000 O 0 5 0 0 0 0 0 0 0 0 0 0
M CHG 5 1 4 2 -1 3 -1 4 -1 5 -1
M END
)CTAB";
std::unique_ptr<ROMol> mol(MolBlockToMol(mb));
REQUIRE(mol);
CHECK(mol->getAtomWithIdx(0)->getFormalCharge() == 4);
CHECK(mol->getAtomWithIdx(0)->getTotalNumHs() == 0);
}
SECTION("basics-Ge") {
std::string mb = R"CTAB(
Mrv1810 08141905562D
5 0 0 0 0 0 999 V2000
-3.6316 -0.4737 0.0000 Ge 0 0 0 0 0 0 0 0 0 0 0 0
-3.6541 0.3609 0.0000 O 0 5 0 0 0 0 0 0 0 0 0 0
-2.4586 -0.5188 0.0000 O 0 5 0 0 0 0 0 0 0 0 0 0
-3.6992 -1.5338 0.0000 O 0 5 0 0 0 0 0 0 0 0 0 0
-4.5789 -0.4286 0.0000 O 0 5 0 0 0 0 0 0 0 0 0 0
M CHG 5 1 4 2 -1 3 -1 4 -1 5 -1
M END
)CTAB";
std::unique_ptr<ROMol> mol(MolBlockToMol(mb));
REQUIRE(mol);
CHECK(mol->getAtomWithIdx(0)->getFormalCharge() == 4);
CHECK(mol->getAtomWithIdx(0)->getTotalNumHs() == 0);
}
}
TEST_CASE(
"github #2607: Pb, Sn should support valence 2"
"[bug][molops]") {
SECTION("basics-Pb") {
std::string mb = R"CTAB(
Mrv1810 08141905562D
3 0 0 0 0 0 999 V2000
-3.6316 -0.4737 0.0000 Pb 0 0 0 0 0 0 0 0 0 0 0 0
-3.6541 0.3609 0.0000 O 0 5 0 0 0 0 0 0 0 0 0 0
-2.4586 -0.5188 0.0000 O 0 5 0 0 0 0 0 0 0 0 0 0
M CHG 3 1 2 2 -1 3 -1
M END
)CTAB";
std::unique_ptr<ROMol> mol(MolBlockToMol(mb));
REQUIRE(mol);
CHECK(mol->getAtomWithIdx(0)->getFormalCharge() == 2);
CHECK(mol->getAtomWithIdx(0)->getTotalNumHs() == 0);
}
SECTION("basics-Sn") {
std::string mb = R"CTAB(
Mrv1810 08141905562D
3 0 0 0 0 0 999 V2000
-3.6316 -0.4737 0.0000 Sn 0 0 0 0 0 0 0 0 0 0 0 0
-3.6541 0.3609 0.0000 O 0 5 0 0 0 0 0 0 0 0 0 0
-2.4586 -0.5188 0.0000 O 0 5 0 0 0 0 0 0 0 0 0 0
M CHG 3 1 2 2 -1 3 -1
M END
)CTAB";
std::unique_ptr<ROMol> mol(MolBlockToMol(mb));
REQUIRE(mol);
CHECK(mol->getAtomWithIdx(0)->getFormalCharge() == 2);
CHECK(mol->getAtomWithIdx(0)->getTotalNumHs() == 0);
}
}
TEST_CASE(
"github #2649: Allenes read from mol blocks have crossed bonds assigned"
"[bug][stereochemistry]") {
SECTION("basics") {
std::string mb = R"CTAB(mol
Mrv1824 09191901002D
6 5 0 0 0 0 999 V2000
-1.6986 -7.4294 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
-2.2522 -6.8245 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
-1.1438 -8.0357 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
-2.8095 -6.2156 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
-0.3374 -7.8470 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
-3.6162 -6.3886 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
1 3 2 0 0 0 0
2 1 2 0 0 0 0
3 5 1 0 0 0 0
4 2 2 0 0 0 0
6 4 1 0 0 0 0
M END)CTAB";
std::unique_ptr<ROMol> mol(MolBlockToMol(mb));
REQUIRE(mol);
CHECK(mol->getBondWithIdx(0)->getStereo() == Bond::STEREONONE);
CHECK(mol->getBondWithIdx(1)->getStereo() == Bond::STEREONONE);
CHECK(mol->getBondWithIdx(3)->getStereo() == Bond::STEREONONE);
auto outmolb = MolToMolBlock(*mol);
// std::cerr<<outmolb<<std::endl;
CHECK(outmolb.find("1 3 2 0") != std::string::npos);
CHECK(outmolb.find("2 1 2 0") != std::string::npos);
CHECK(outmolb.find("4 2 2 0") != std::string::npos);
}
}
TEST_CASE(
"GitHub 2712: setBondStereoFromDirections() returning incorrect results"
"[stereochemistry]") {
SECTION("basics 1a") {
std::string mb = R"CTAB(
Mrv1810 10141909562D
4 3 0 0 0 0 999 V2000
3.3412 -2.9968 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
2.5162 -2.9968 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
2.1037 -3.7112 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
3.7537 -2.2823 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
1 2 2 0 0 0 0
2 3 1 0 0 0 0
1 4 1 0 0 0 0
M END
)CTAB";
bool sanitize = false;
std::unique_ptr<ROMol> mol(MolBlockToMol(mb, sanitize));
REQUIRE(mol);
CHECK(mol->getBondWithIdx(0)->getBondType() == Bond::DOUBLE);
CHECK(mol->getBondWithIdx(0)->getStereo() == Bond::STEREONONE);
MolOps::setBondStereoFromDirections(*mol);
CHECK(mol->getBondWithIdx(0)->getStereo() == Bond::STEREOTRANS);
}
SECTION("basics 1b") {
std::string mb = R"CTAB(
Mrv1810 10141909562D
4 3 0 0 0 0 999 V2000
3.3412 -2.9968 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
2.5162 -2.9968 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
2.1037 -3.7112 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
3.7537 -2.2823 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
1 2 2 0 0 0 0
2 3 1 0 0 0 0
4 1 1 0 0 0 0
M END
)CTAB";
bool sanitize = false;
std::unique_ptr<ROMol> mol(MolBlockToMol(mb, sanitize));
REQUIRE(mol);
CHECK(mol->getBondWithIdx(0)->getBondType() == Bond::DOUBLE);
CHECK(mol->getBondWithIdx(0)->getStereo() == Bond::STEREONONE);
MolOps::setBondStereoFromDirections(*mol);
CHECK(mol->getBondWithIdx(0)->getStereo() == Bond::STEREOTRANS);
}
SECTION("basics 2a") {
std::string mb = R"CTAB(
Mrv1810 10141909582D
4 3 0 0 0 0 999 V2000
3.4745 -5.2424 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
2.6495 -5.2424 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
2.2370 -5.9569 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
3.8870 -5.9569 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
1 2 2 0 0 0 0
2 3 1 0 0 0 0
1 4 1 0 0 0 0
M END
)CTAB";
bool sanitize = false;
std::unique_ptr<ROMol> mol(MolBlockToMol(mb, sanitize));
REQUIRE(mol);
CHECK(mol->getBondWithIdx(0)->getBondType() == Bond::DOUBLE);
CHECK(mol->getBondWithIdx(0)->getStereo() == Bond::STEREONONE);
MolOps::setBondStereoFromDirections(*mol);
CHECK(mol->getBondWithIdx(0)->getStereo() == Bond::STEREOCIS);
}
SECTION("basics 2b") {
std::string mb = R"CTAB(
Mrv1810 10141909582D
4 3 0 0 0 0 999 V2000
3.4745 -5.2424 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
2.6495 -5.2424 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
2.2370 -5.9569 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
3.8870 -5.9569 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
1 2 2 0 0 0 0
2 3 1 0 0 0 0
4 1 1 0 0 0 0
M END
)CTAB";
bool sanitize = false;
std::unique_ptr<ROMol> mol(MolBlockToMol(mb, sanitize));
REQUIRE(mol);
CHECK(mol->getBondWithIdx(0)->getBondType() == Bond::DOUBLE);
CHECK(mol->getBondWithIdx(0)->getStereo() == Bond::STEREONONE);
MolOps::setBondStereoFromDirections(*mol);
CHECK(mol->getBondWithIdx(0)->getStereo() == Bond::STEREOCIS);
}
}
TEST_CASE("removeHs screwing up double bond stereo", "[bug][removeHs]") {
SECTION("example1") {
std::string molblock = R"CTAB(molblock = """
SciTegic12221702182D
47 51 0 0 0 0 999 V2000
0.2962 6.2611 0.0000 C 0 0
-3.9004 4.4820 0.0000 C 0 0
1.4195 5.2670 0.0000 C 0 0
-3.8201 -7.4431 0.0000 C 0 0
-4.9433 -6.4490 0.0000 C 0 0
-2.3975 -6.9674 0.0000 C 0 0
3.5921 -3.5947 0.0000 C 0 0
-3.1475 2.3700 0.0000 C 0 0
2.1695 -4.0705 0.0000 C 0 0
-2.0242 1.3759 0.0000 C 0 0
-4.6440 -4.9792 0.0000 C 0 0
2.7681 -1.1308 0.0000 C 0 0
-5.8626 1.1332 0.0000 C 0 0
3.0674 0.3391 0.0000 C 0 0
3.6660 3.2787 0.0000 C 0 0
8.1591 -0.6978 0.0000 C 0 0
7.3351 1.7662 0.0000 C 0 0
-6.3876 3.5028 0.0000 C 0 0
-0.6756 -5.0219 0.0000 C 0 0
7.0358 0.2964 0.0000 C 0 0
3.8914 -2.1249 0.0000 C 0 0
-2.0982 -5.4976 0.0000 C 0 0
-4.5701 1.8943 0.0000 C 0 0 1 0 0 0
-6.9859 2.1273 0.0000 C 0 0 1 0 0 0
4.4900 0.8148 0.0000 C 0 0
1.3455 -1.6065 0.0000 C 0 0
4.7893 2.2846 0.0000 C 0 0
1.9442 1.3332 0.0000 C 0 0
1.0462 -3.0763 0.0000 C 0 0
2.2435 2.8030 0.0000 C 0 0
-0.6017 1.8516 0.0000 C 0 0
5.6132 -0.1794 0.0000 C 0 0
0.2223 -0.6124 0.0000 Cl 0 0
9.2823 -1.6919 0.0000 N 0 0
-3.2215 -4.5035 0.0000 N 0 0
6.2119 2.7603 0.0000 N 0 0
5.3139 -1.6492 0.0000 N 0 0
0.5216 0.8575 0.0000 N 0 0
-4.8945 3.3588 0.0000 N 0 0
-8.2913 2.8662 0.0000 O 0 0
-0.3024 3.3214 0.0000 O 0 0
1.1202 3.7971 0.0000 O 0 0
-0.3763 -3.5520 0.0000 O 0 0
-2.8482 3.8398 0.0000 H 0 0
-2.3235 -0.0940 0.0000 H 0 0
-3.9483 0.5292 0.0000 H 0 0
-7.8572 0.9063 0.0000 H 0 0
1 3 1 0
2 39 1 0
3 42 1 0
4 5 2 0
4 6 1 0
5 11 1 0
6 22 2 0
7 9 2 0
7 21 1 0
8 44 1 0
8 10 2 0
8 23 1 0
9 29 1 0
10 45 1 0
10 31 1 0
11 35 2 0
12 21 2 0
12 26 1 0
13 23 1 0
13 24 1 0
14 25 2 0
14 28 1 0
15 27 2 0
15 30 1 0
16 20 1 0
16 34 3 0
17 20 2 0
17 36 1 0
18 24 1 0
18 39 1 0
19 22 1 0
19 43 1 0
20 32 1 0
21 37 1 0
22 35 1 0
23 46 1 6
23 39 1 0
24 47 1 1
24 40 1 0
25 27 1 0
25 32 1 0
26 29 2 0
26 33 1 0
27 36 1 0
28 30 2 0
28 38 1 0
29 43 1 0
30 42 1 0
31 38 2 0
31 41 1 0
32 37 2 3
M END
"""
)CTAB";
bool sanitize = false;
bool removeHs = false;
std::unique_ptr<RWMol> m(MolBlockToMol(molblock, sanitize, removeHs));
REQUIRE(m);
m->updatePropertyCache();
MolOps::setBondStereoFromDirections(*m);
CHECK(m->getBondWithIdx(10)->getBondType() == Bond::DOUBLE);
CHECK(m->getBondWithIdx(10)->getStereo() == Bond::STEREOTRANS);
REQUIRE(m->getBondWithIdx(10)->getStereoAtoms().size() == 2);
CHECK(m->getBondWithIdx(10)->getStereoAtoms()[0] == 43);
CHECK(m->getBondWithIdx(10)->getStereoAtoms()[1] == 44);
MolOps::removeHs(*m); // implicitOnly,updateExplicitCount,sanitize);
// m->debugMol(std::cerr);
CHECK(m->getBondWithIdx(9)->getBondType() == Bond::DOUBLE);
CHECK(m->getBondWithIdx(9)->getStereo() == Bond::STEREOTRANS);
REQUIRE(m->getBondWithIdx(9)->getStereoAtoms().size() == 2);
CHECK(m->getBondWithIdx(9)->getStereoAtoms()[0] == 22);
CHECK(m->getBondWithIdx(9)->getStereoAtoms()[1] == 30);
}
}
TEST_CASE("setDoubleBondNeighborDirections()", "[stereochemistry][bug]") {
SECTION("basics cis") {
auto m = "CC=CC"_smiles;
REQUIRE(m);
m->getBondWithIdx(1)->getStereoAtoms() = {0, 3};
m->getBondWithIdx(1)->setStereo(Bond::STEREOCIS);
MolOps::setDoubleBondNeighborDirections(*m);
CHECK(m->getBondWithIdx(0)->getBondDir() == Bond::ENDUPRIGHT);
CHECK(m->getBondWithIdx(2)->getBondDir() == Bond::ENDDOWNRIGHT);
CHECK(MolToSmiles(*m) == "C/C=C\\C");
}
SECTION("basics trans") {
auto m = "CC=CC"_smiles;
REQUIRE(m);
m->getBondWithIdx(1)->getStereoAtoms() = {0, 3};
m->getBondWithIdx(1)->setStereo(Bond::STEREOTRANS);
MolOps::setDoubleBondNeighborDirections(*m);
CHECK(m->getBondWithIdx(0)->getBondDir() == Bond::ENDUPRIGHT);
CHECK(m->getBondWithIdx(2)->getBondDir() == Bond::ENDUPRIGHT);
CHECK(MolToSmiles(*m) == "C/C=C/C");
}
SECTION("swap (Github #3322)") {
auto m = "CC=CC"_smiles;
REQUIRE(m);
m->getBondWithIdx(1)->getStereoAtoms() = {0, 3};
m->getBondWithIdx(1)->setStereo(Bond::STEREOTRANS);
MolOps::setDoubleBondNeighborDirections(*m);
CHECK(m->getBondWithIdx(0)->getBondDir() == Bond::ENDUPRIGHT);
CHECK(m->getBondWithIdx(2)->getBondDir() == Bond::ENDUPRIGHT);
CHECK(MolToSmiles(*m) == "C/C=C/C");
m->clearComputedProps();
m->getBondWithIdx(1)->getStereoAtoms() = {0, 3};
m->getBondWithIdx(1)->setStereo(Bond::STEREOCIS);
MolOps::setDoubleBondNeighborDirections(*m);
CHECK(m->getBondWithIdx(0)->getBondDir() == Bond::ENDUPRIGHT);
CHECK(m->getBondWithIdx(2)->getBondDir() == Bond::ENDDOWNRIGHT);
CHECK(MolToSmiles(*m) == "C/C=C\\C");
}
}
TEST_CASE("github #2782: addHs() fails on atoms with 'bad' valences", "[bug]") {
SECTION("basics") {
SmilesParserParams ps;
ps.sanitize = false;
std::unique_ptr<RWMol> m(
static_cast<RWMol *>(SmilesToMol("C=C1=CC=CC=C1", ps)));
REQUIRE(m);
bool strict = false;
m->updatePropertyCache(strict);
CHECK(m->getNumAtoms() == 7);
MolOps::addHs(*m);
CHECK(m->getNumAtoms() == 14);
// this doesn't change the fact that there's still a bad valence present:
CHECK_THROWS_AS(m->updatePropertyCache(), AtomValenceException);
}
}
TEST_CASE(
"Github #2784: Element symbol lookup for some transuranics returns "
"incorrect results",
"[transuranics][bug]") {
auto pt = PeriodicTable::getTable();
SECTION("number to symbol") {
std::vector<std::pair<unsigned int, std::string>> data = {
{113, "Nh"}, {114, "Fl"}, {115, "Mc"},
{116, "Lv"}, {117, "Ts"}, {118, "Og"}};
for (const auto &pr : data) {
CHECK(pt->getElementSymbol(pr.first) == pr.second);
}
}
SECTION("symbol to number") {
std::vector<std::pair<int, std::string>> data = {
{113, "Nh"}, {114, "Fl"}, {115, "Mc"}, {116, "Lv"},
{117, "Ts"}, {118, "Og"}, {113, "Uut"}, {115, "Uup"}};
for (const auto &pr : data) {
CHECK(pt->getAtomicNumber(pr.second) == pr.first);
}
}
}
TEST_CASE("github #2775", "[valence][bug]") {
SECTION("basics") {
std::string molblock = R"CTAB(bismuth citrate
Mrv1810 11111908592D
14 12 0 0 0 0 999 V2000
7.4050 -0.5957 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
6.6906 -1.0082 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
5.9761 -0.5957 0.0000 O 0 0 0 0 0 0 0 0 0 0 0 0
6.6906 -1.8332 0.0000 O 0 5 0 0 0 0 0 0 0 0 0 0
7.4050 0.2293 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
6.5800 0.2293 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
6.1675 0.9438 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
6.5800 1.6583 0.0000 O 0 0 0 0 0 0 0 0 0 0 0 0
5.3425 0.9438 0.0000 O 0 5 0 0 0 0 0 0 0 0 0 0
8.2300 0.2293 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
8.6425 -0.4851 0.0000 O 0 0 0 0 0 0 0 0 0 0 0 0
8.6425 0.9438 0.0000 O 0 5 0 0 0 0 0 0 0 0 0 0
7.4050 1.0543 0.0000 O 0 0 0 0 0 0 0 0 0 0 0 0
4.5175 0.9438 0.0000 Bi 0 1 0 0 0 0 0 0 0 0 0 0
1 2 1 0 0 0 0
2 3 2 0 0 0 0
2 4 1 0 0 0 0
1 5 1 0 0 0 0
5 6 1 0 0 0 0
6 7 1 0 0 0 0
7 8 2 0 0 0 0
7 9 1 0 0 0 0
5 10 1 0 0 0 0
10 11 2 0 0 0 0
10 12 1 0 0 0 0
5 13 1 0 0 0 0
M CHG 4 4 -1 9 -1 12 -1 14 3
M END
)CTAB";
std::unique_ptr<RWMol> m(MolBlockToMol(molblock));
REQUIRE(m);
CHECK(m->getAtomWithIdx(13)->getSymbol() == "Bi");
CHECK(m->getAtomWithIdx(13)->getNumImplicitHs() == 0);
}
}
TEST_CASE("RemoveHsParameters", "[molops]") {
SmilesParserParams smilesPs;
smilesPs.removeHs = false;
SECTION("H-H") {
std::unique_ptr<RWMol> m{SmilesToMol("[H][H].[H]O[H]", smilesPs)};
REQUIRE(m);
CHECK(m->getNumAtoms() == 5);
{
RWMol cp(*m);
MolOps::removeHs(cp);
CHECK(cp.getNumAtoms() == 3);
}
{
MolOps::RemoveHsParameters ps;
RWMol cp(*m);
MolOps::removeHs(cp, ps);
CHECK(cp.getNumAtoms() == 3);
}
{
MolOps::RemoveHsParameters ps;
ps.removeOnlyHNeighbors = true;
RWMol cp(*m);
MolOps::removeHs(cp, ps);
CHECK(cp.getNumAtoms() == 1);
}
}
SECTION("dummies") {
std::unique_ptr<RWMol> m{SmilesToMol("[H][*]O[H]", smilesPs)};
REQUIRE(m);
CHECK(m->getNumAtoms() == 4);
{
RWMol cp(*m);
MolOps::removeHs(cp);
CHECK(cp.getNumAtoms() == 3);
}
{
MolOps::RemoveHsParameters ps;
RWMol cp(*m);
MolOps::removeHs(cp, ps);
CHECK(cp.getNumAtoms() == 3);
}
{
MolOps::RemoveHsParameters ps;
ps.removeDummyNeighbors = true;
RWMol cp(*m);
MolOps::removeHs(cp, ps);
CHECK(cp.getNumAtoms() == 2);
}
}
SECTION("chiralHs") {
std::unique_ptr<RWMol> m{SmilesToMol("[C@]12([H])CCC1CO2", smilesPs)};
REQUIRE(m);
CHECK(m->getNumAtoms() == 7);
// artificial wedging since we don't have a conformer
m->getBondBetweenAtoms(0, 1)->setBondDir(Bond::BEGINWEDGE);
{
RWMol cp(*m);
MolOps::removeHs(cp);
CHECK(cp.getNumAtoms() == 6);
}
{
MolOps::RemoveHsParameters ps;
RWMol cp(*m);
MolOps::removeHs(cp, ps);
CHECK(cp.getNumAtoms() == 6);
}
{
MolOps::RemoveHsParameters ps;
ps.removeWithWedgedBond = false;
RWMol cp(*m);
MolOps::removeHs(cp, ps);
CHECK(cp.getNumAtoms() == 7);
}
}
SECTION("degree zero") {
std::unique_ptr<RWMol> m{SmilesToMol("[F-].[H+]", smilesPs)};
REQUIRE(m);
CHECK(m->getNumAtoms() == 2);
{
RWMol cp(*m);
MolOps::removeHs(cp);
CHECK(cp.getNumAtoms() == 2);
}
{
MolOps::RemoveHsParameters ps;
RWMol cp(*m);
MolOps::removeHs(cp, ps);
CHECK(cp.getNumAtoms() == 2);
}
{
MolOps::RemoveHsParameters ps;
ps.removeDegreeZero = true;
RWMol cp(*m);
MolOps::removeHs(cp, ps);
CHECK(cp.getNumAtoms() == 1);
}
}
SECTION("isotopes") {
std::unique_ptr<RWMol> m{SmilesToMol("F[2H]", smilesPs)};
REQUIRE(m);
CHECK(m->getNumAtoms() == 2);
{
RWMol cp(*m);
MolOps::removeHs(cp);
CHECK(cp.getNumAtoms() == 2);
}
{
MolOps::RemoveHsParameters ps;
RWMol cp(*m);
MolOps::removeHs(cp, ps);
CHECK(cp.getNumAtoms() == 2);
}
{
MolOps::RemoveHsParameters ps;
ps.removeIsotopes = true;
RWMol cp(*m);
MolOps::removeHs(cp, ps);
CHECK(cp.getNumAtoms() == 1);
}
}
SECTION("defining bond stereo") {
std::unique_ptr<RWMol> m{SmilesToMol("F/C=N/[H]", smilesPs)};
REQUIRE(m);
CHECK(m->getNumAtoms() == 4);
{
RWMol cp(*m);
MolOps::removeHs(cp);
CHECK(cp.getNumAtoms() == 4);
}
{
MolOps::RemoveHsParameters ps;
RWMol cp(*m);
MolOps::removeHs(cp, ps);
CHECK(cp.getNumAtoms() == 4);
}
{
MolOps::RemoveHsParameters ps;
ps.removeDefiningBondStereo = true;
RWMol cp(*m);
MolOps::removeHs(cp, ps);
CHECK(cp.getNumAtoms() == 3);
}
}
SECTION("Query atoms") {
std::unique_ptr<RWMol> m{SmartsToMol("O[#1]")};
REQUIRE(m);
CHECK(m->getNumAtoms() == 2);
{
RWMol cp(*m);
MolOps::removeHs(cp);
CHECK(cp.getNumAtoms() == 2);
}
{
MolOps::RemoveHsParameters ps;
RWMol cp(*m);
MolOps::removeHs(cp, ps);
CHECK(cp.getNumAtoms() == 2);
}
{
MolOps::RemoveHsParameters ps;
ps.removeWithQuery = true;
RWMol cp(*m);
MolOps::removeHs(cp, ps);
CHECK(cp.getNumAtoms() == 1);
}
}
SECTION("higher degree") {
// this is a silly example
std::unique_ptr<RWMol> m{SmilesToMol("F[H-]F", smilesPs)};
REQUIRE(m);
CHECK(m->getNumAtoms() == 3);
{
RWMol cp(*m);
MolOps::removeHs(cp);
CHECK(cp.getNumAtoms() == 3);
}
{
MolOps::RemoveHsParameters ps;
RWMol cp(*m);
MolOps::removeHs(cp, ps);
CHECK(cp.getNumAtoms() == 3);
}
{
MolOps::RemoveHsParameters ps;
ps.removeHigherDegrees = true;
RWMol cp(*m);
MolOps::removeHs(cp, ps);
CHECK(cp.getNumAtoms() == 2);
}
}
SECTION("mapped Hs") {
std::unique_ptr<RWMol> m{SmilesToMol("[H:1]O[H]", smilesPs)};
REQUIRE(m);
CHECK(m->getNumAtoms() == 3);
{
RWMol cp(*m);
MolOps::removeHs(cp);
CHECK(cp.getNumAtoms() == 1);
}
{
MolOps::RemoveHsParameters ps;
ps.removeMapped = false;
RWMol cp(*m);
MolOps::removeHs(cp, ps);
CHECK(cp.getNumAtoms() == 2);
}
}
SECTION("allHs") {
std::unique_ptr<RWMol> m{SmilesToMol(
"[C@]12([H])CCC1CO2.[H+].F[H-]F.[H][H].[H]*.F/C=C/[H]", smilesPs)};
REQUIRE(m);
// artificial wedging since we don't have a conformer
m->getBondBetweenAtoms(0, 1)->setBondDir(Bond::BEGINWEDGE);
RWMol cp(*m);
MolOps::removeAllHs(cp);
for (auto atom : cp.atoms()) {
CHECK(atom->getAtomicNum() != 1);
}
}
SECTION("allHs2") {
std::unique_ptr<ROMol> m{SmilesToMol(
"[C@]12([H])CCC1CO2.[H+].F[H-]F.[H][H].[H]*.F/C=C/[H]", smilesPs)};
REQUIRE(m);
// artificial wedging since we don't have a conformer
m->getBondBetweenAtoms(0, 1)->setBondDir(Bond::BEGINWEDGE);
std::unique_ptr<ROMol> cp{MolOps::removeAllHs(*m)};
for (auto atom : cp->atoms()) {
CHECK(atom->getAtomicNum() != 1);
}
}
}
#endif
TEST_CASE("github #2895: acepentalene aromaticity perception ",
"[molops][bug][aromaticity]") {
SECTION("acepentalene") {
std::unique_ptr<RWMol> m{SmilesToMol("C1=CC2=CC=C3C2=C1C=C3")};
REQUIRE(m);
auto smi = MolToSmiles(*m);
CHECK(smi == "C1=CC2=C3C1=CC=C3C=C2");
}
}
TEST_CASE("github #3256: fused ring aromaticity perception",
"[molops][bug][aromaticity]") {
SECTION("nitrogen only central ring") {
auto mol = "C1=CN2C3=CC=CN3C3=CC=CN3C2=C1"_smiles;
REQUIRE(mol);
for (const auto b : mol->bonds()) {
CHECK(b->getBondType() == Bond::AROMATIC);
}
auto smi = MolToSmiles(*mol);
CHECK(smi == "c1cc2n(c1)c1cccn1c1cccn21");
}
}
TEST_CASE("phosphine and arsine chirality", "[Chirality]") {
SECTION("chiral center recognized") {
auto mol1 = "C[P@](C1CCCC1)C1=CC=CC=C1"_smiles;
auto mol2 = "C[As@](C1CCCC1)C1=CC=CC=C1"_smiles;
REQUIRE(mol1);
REQUIRE(mol2);
CHECK(mol1->getAtomWithIdx(1)->getChiralTag() != Atom::CHI_UNSPECIFIED);
CHECK(mol2->getAtomWithIdx(1)->getChiralTag() != Atom::CHI_UNSPECIFIED);
}
SECTION("chiral center selective") {
auto mol1 = "C[P@](C)C1CCCCC1"_smiles;
auto mol2 = "C[As@](C)C1CCCCC1"_smiles;
REQUIRE(mol1);
REQUIRE(mol2);
CHECK(mol1->getAtomWithIdx(1)->getChiralTag() == Atom::CHI_UNSPECIFIED);
CHECK(mol2->getAtomWithIdx(1)->getChiralTag() == Atom::CHI_UNSPECIFIED);
}
SECTION("chiral center specific: P") {
auto mol1 = "C[P@](C1CCCC1)C1=CC=CC=C1"_smiles;
auto mol2 = "C[P@@](C1CCCC1)C1=CC=CC=C1"_smiles;
REQUIRE(mol1);
REQUIRE(mol2);
CHECK(MolToSmiles(*mol1) != MolToSmiles(*mol2));
}
SECTION("chiral center specific: As") {
auto mol1 = "C[As@](C1CCCC1)C1=CC=CC=C1"_smiles;
auto mol2 = "C[As@@](C1CCCC1)C1=CC=CC=C1"_smiles;
REQUIRE(mol1);
REQUIRE(mol2);
CHECK(MolToSmiles(*mol1) != MolToSmiles(*mol2));
}
SECTION("chiral center, implicit H: P") {
auto mol1 = "C[P@H]C1CCCCC1"_smiles;
auto mol2 = "C[P@@H]C1CCCCC1"_smiles;
REQUIRE(mol1);
REQUIRE(mol2);
CHECK(mol1->getAtomWithIdx(1)->getChiralTag() != Atom::CHI_UNSPECIFIED);
CHECK(mol1->getAtomWithIdx(1)->getChiralTag() != Atom::CHI_UNSPECIFIED);
}
SECTION("chiral center, implicit H: As") {
auto mol1 = "C[As@H]C1CCCCC1"_smiles;
auto mol2 = "C[As@@H]C1CCCCC1"_smiles;
REQUIRE(mol1);
REQUIRE(mol2);
CHECK(mol1->getAtomWithIdx(1)->getChiralTag() != Atom::CHI_UNSPECIFIED);
CHECK(mol1->getAtomWithIdx(1)->getChiralTag() != Atom::CHI_UNSPECIFIED);
}
SECTION("chiral center specific, implicit H: P") {
auto mol1 = "C[P@H]C1CCCCC1"_smiles;
auto mol2 = "C[P@@H]C1CCCCC1"_smiles;
REQUIRE(mol1);
REQUIRE(mol2);
CHECK(MolToSmiles(*mol1) != MolToSmiles(*mol2));
}
SECTION("chiral center specific, implicit H: As") {
auto mol1 = "C[As@H]C1CCCCC1"_smiles;
auto mol2 = "C[As@@H]C1CCCCC1"_smiles;
REQUIRE(mol1);
REQUIRE(mol2);
CHECK(MolToSmiles(*mol1) != MolToSmiles(*mol2));
}
}
TEST_CASE("github #2890", "[bug][molops][stereo]") {
auto mol = "CC=CC"_smiles;
REQUIRE(mol);
auto bond = mol->getBondWithIdx(1);
bond->setStereo(Bond::STEREOANY);
REQUIRE(bond->getStereoAtoms().empty());
MolOps::findPotentialStereoBonds(*mol);
CHECK(bond->getStereo() == Bond::STEREOANY);
CHECK(bond->getStereoAtoms().size() == 2);
}
TEST_CASE("github #3150 MolOps::removeHs removes hydrides", "[bug][molops]") {
SmilesParserParams smilesPs;
smilesPs.removeHs = false;
SECTION("Hydride ion remove Hydrides false") {
std::unique_ptr<RWMol> m{SmilesToMol("[H-]", smilesPs)};
REQUIRE(m);
MolOps::RemoveHsParameters ps;
ps.removeHydrides = false;
RWMol cp(*m);
MolOps::removeHs(cp, ps);
// H atom not removed in this case because by default H atoms with degree 0
// are not removed
CHECK(cp.getNumAtoms() == 1);
CHECK(MolOps::getFormalCharge(cp) == -1);
}
SECTION("Hydride ion remove Hydrides true") {
std::unique_ptr<RWMol> m{SmilesToMol("[H-]", smilesPs)};
REQUIRE(m);
MolOps::RemoveHsParameters ps;
ps.removeHydrides = true;
RWMol cp(*m);
MolOps::removeHs(cp, ps);
// H atom not removed in this case because by default H atoms with degree 0
// are not removed
CHECK(cp.getNumAtoms() == 1);
CHECK(MolOps::getFormalCharge(cp) == -1);
}
SECTION("Water") {
std::unique_ptr<RWMol> m{SmilesToMol("[OH+][H-]", smilesPs)};
REQUIRE(m);
MolOps::RemoveHsParameters ps;
ps.removeHydrides = false;
RWMol cp(*m);
MolOps::removeHs(cp, ps);
CHECK(cp.getNumAtoms() == 2);
CHECK(MolOps::getFormalCharge(cp) == 0);
}
SECTION("Water remove Hydrides true") {
std::unique_ptr<RWMol> m{SmilesToMol("[OH+][H-]", smilesPs)};
REQUIRE(m);
MolOps::RemoveHsParameters ps;
ps.removeHydrides = true;
RWMol cp(*m);
MolOps::removeHs(cp, ps);
CHECK(cp.getNumAtoms() == 1);
CHECK(MolOps::getFormalCharge(cp) == 1);
}
SECTION("Iron Hydride") {
std::unique_ptr<RWMol> m{SmilesToMol("[Fe+2]<-[H-]", smilesPs)};
REQUIRE(m);
MolOps::RemoveHsParameters ps;
ps.removeHydrides = false;
RWMol cp(*m);
MolOps::removeHs(cp, ps);
CHECK(cp.getNumAtoms() == 2);
CHECK(MolOps::getFormalCharge(cp) == 1);
}
SECTION("Iron Hydride remove Hydrides") {
std::unique_ptr<RWMol> m{SmilesToMol("[Fe+2]<-[H-]", smilesPs)};
REQUIRE(m);
MolOps::RemoveHsParameters ps;
ps.removeHydrides = true;
RWMol cp(*m);
MolOps::removeHs(cp, ps);
CHECK(cp.getNumAtoms() == 1);
CHECK(MolOps::getFormalCharge(cp) == 2);
}
SECTION("Ferrous Hydroxide") {
std::unique_ptr<RWMol> m{SmilesToMol("[Fe+2]<-[OH-]", smilesPs)};
REQUIRE(m);
MolOps::RemoveHsParameters ps;
ps.removeHydrides = false;
RWMol cp(*m);
MolOps::removeHs(cp, ps);
CHECK(cp.getNumAtoms() == 2);
CHECK(MolOps::getFormalCharge(cp) == 1);
}
SECTION("Ferrous Hydroxide remove Hydrides") {
std::unique_ptr<RWMol> m{SmilesToMol("[Fe+2]<-[OH-]", smilesPs)};
REQUIRE(m);
MolOps::RemoveHsParameters ps;
ps.removeHydrides = true;
RWMol cp(*m);
MolOps::removeHs(cp, ps);
CHECK(cp.getNumAtoms() == 2);
CHECK(MolOps::getFormalCharge(cp) == 1);
}
SECTION("Remove All Hs in Hydrides Ferrous Hydride") {
std::unique_ptr<RWMol> m{SmilesToMol("[Fe+2]<-[H-]", smilesPs)};
REQUIRE(m);
RWMol cp(*m);
MolOps::removeAllHs(cp);
CHECK(cp.getNumAtoms() == 1);
CHECK(MolOps::getFormalCharge(cp) == 2);
}
SECTION("Remove All Hs in Hydrides Water") {
std::unique_ptr<RWMol> m{SmilesToMol("[OH+][H-]", smilesPs)};
REQUIRE(m);
RWMol cp(*m);
MolOps::removeAllHs(cp);
CHECK(cp.getNumAtoms() == 1);
CHECK(MolOps::getFormalCharge(cp) == 1);
}
}
TEST_CASE("hybridization of unknown atom types", "[bug][molops]") {
SECTION("Basics") {
auto m = "[U][U][U]"_smiles;
REQUIRE(m);
CHECK(m->getAtomWithIdx(0)->getHybridization() ==
Atom::HybridizationType::S);
CHECK(m->getAtomWithIdx(1)->getHybridization() ==
Atom::HybridizationType::SP);
CHECK(m->getAtomWithIdx(2)->getHybridization() ==
Atom::HybridizationType::S);
}
SECTION("comprehensive") {
std::string smiles = "F";
for (unsigned int i = 89; i <= 118; ++i) {
smiles += (boost::format("[#%d]") % i).str();
}
smiles += "F";
std::unique_ptr<ROMol> m(SmilesToMol(smiles));
REQUIRE(m);
for (auto i = 1u; i < m->getNumAtoms() - 1; ++i) {
CHECK(m->getAtomWithIdx(i)->getHybridization() ==
Atom::HybridizationType::SP);
}
}
}
TEST_CASE("Github #3470: Hydrogen is incorrectly identified as an early atom",
"[bug][chemistry]") {
SECTION("Basics") {
RWMol m;
m.addAtom(new Atom(1), true, true);
m.getAtomWithIdx(0)->setFormalCharge(-1);
m.updatePropertyCache();
CHECK(m.getAtomWithIdx(0)->getNumImplicitHs() == 0);
m.getAtomWithIdx(0)->setFormalCharge(1);
m.updatePropertyCache();
CHECK(m.getAtomWithIdx(0)->getNumImplicitHs() == 0);
m.getAtomWithIdx(0)->setFormalCharge(0);
m.updatePropertyCache();
CHECK(m.getAtomWithIdx(0)->getNumImplicitHs() == 1);
// make sure we still generate errors for stupid stuff
m.getAtomWithIdx(0)->setFormalCharge(-2);
CHECK_THROWS_AS(m.updatePropertyCache(), AtomValenceException);
CHECK(m.getAtomWithIdx(0)->getNumImplicitHs() == 1);
}
SECTION("confirm with SMILES") {
RWMol m;
bool updateLabel = false;
bool takeOwnership = true;
m.addAtom(new Atom(1), updateLabel, takeOwnership);
m.getAtomWithIdx(0)->setFormalCharge(-1);
m.updatePropertyCache();
CHECK(MolToSmiles(m) == "[H-]");
m.getAtomWithIdx(0)->setFormalCharge(+1);
m.updatePropertyCache();
CHECK(MolToSmiles(m) == "[H+]");
m.getAtomWithIdx(0)->setFormalCharge(0);
m.updatePropertyCache();
CHECK(MolToSmiles(m) == "[HH]"); // ugly, but I think [H] would be worse
}
}
TEST_CASE("Additional oxidation states", "[chemistry]") {
SECTION("Basics") {
std::vector<std::string> smiles = {"F[Po](F)(F)(F)", "F[Po](F)(F)(F)(F)F",
"F[Xe](F)(F)(F)", "F[Xe](F)(F)(F)(F)F",
"F[I](F)F", "F[I](F)(F)(F)F",
"F[At](F)F", "F[At](F)(F)(F)F"};
for (const auto &smi : smiles) {
std::unique_ptr<ROMol> m(SmilesToMol(smi));
REQUIRE(m);
CHECK(m->getAtomWithIdx(1)->getNumRadicalElectrons() == 0);
}
}
}
TEST_CASE("Github #3805: radicals on [He]", "[chemistry]") {
SECTION("Basics") {
{
auto m = "[He]"_smiles;
REQUIRE(m);
CHECK(m->getAtomWithIdx(0)->getNumRadicalElectrons() == 0);
CHECK(m->getAtomWithIdx(0)->getTotalNumHs() == 0);
}
{
auto m = "[Ne]"_smiles;
REQUIRE(m);
CHECK(m->getAtomWithIdx(0)->getNumRadicalElectrons() == 0);
CHECK(m->getAtomWithIdx(0)->getTotalNumHs() == 0);
}
}
SECTION("Basics") {
{
auto m = "[He+]"_smiles;
REQUIRE(m);
CHECK(m->getAtomWithIdx(0)->getNumRadicalElectrons() == 1);
CHECK(m->getAtomWithIdx(0)->getTotalNumHs() == 0);
}
{
auto m = "[Ne+]"_smiles;
REQUIRE(m);
CHECK(m->getAtomWithIdx(0)->getNumRadicalElectrons() == 1);
CHECK(m->getAtomWithIdx(0)->getTotalNumHs() == 0);
}
}
}
TEST_CASE("needsHs function", "[chemistry]") {
SECTION("basics") {
const auto m = "CC"_smiles;
REQUIRE(m);
CHECK(MolOps::needsHs(*m));
// add a single H:
bool updateLabel = false;
bool takeOwnership = true;
m->addAtom(new Atom(1), updateLabel, takeOwnership);
m->addBond(0, 2, Bond::BondType::SINGLE);
MolOps::sanitizeMol(*m);
CHECK(MolOps::needsHs(*m));
// now add all the Hs:
MolOps::addHs(*m);
CHECK(!MolOps::needsHs(*m));
}
SECTION("radical") {
const auto m = "[O][O]"_smiles;
REQUIRE(m);
CHECK(!MolOps::needsHs(*m));
}
SECTION("none needed") {
const auto m = "FF"_smiles;
REQUIRE(m);
CHECK(!MolOps::needsHs(*m));
}
}
TEST_CASE(
"github #3330: incorrect number of radicals electrons calculated for "
"metals",
"[chemistry][metals]") {
SECTION("basics") {
std::vector<std::pair<std::string, unsigned int>> data = {
{"[Mn+2]", 1},
{"[Mn+1]", 0},
{"[Mn]", 1},
{"[Mn-1]", 0},
{"[C]", 4},
{"[C+1]", 3},
{"[C-1]", 3},
// this next set are from #7122
{"[Fe]", 0},
{"[Fe+1]", 1},
{"[Fe]C", 0},
{"[Nb](I)(I)(I)(I)I", 0},
{"[Zn+]C1=CC=CC=C1", 0}};
for (const auto &pr : data) {
std::unique_ptr<ROMol> m(SmilesToMol(pr.first));
REQUIRE(m);
CHECK(m->getAtomWithIdx(0)->getNumRadicalElectrons() == pr.second);
}
}
}
TEST_CASE("github #3879: bad H coordinates on fused rings", "[addhs]") {
SECTION("reported") {
auto m = R"CTAB(
RDKit 2D
0 0 0 0 0 0 0 0 0 0999 V3000
M V30 BEGIN CTAB
M V30 COUNTS 9 10 0 0 0
M V30 BEGIN ATOM
M V30 1 C 1.500000 2.598076 0.000000 0
M V30 2 N 0.750000 1.299038 0.000000 0
M V30 3 C 1.500000 -0.000000 0.000000 0
M V30 4 C 0.750000 -1.299038 0.000000 0
M V30 5 C 0.382772 -0.562069 0.000000 0
M V30 6 C -0.295379 0.612525 0.000000 0
M V30 7 C -0.750000 1.299038 0.000000 0
M V30 8 C -1.500000 0.000000 0.000000 0
M V30 9 O -0.750000 -1.299038 0.000000 0
M V30 END ATOM
M V30 BEGIN BOND
M V30 1 1 1 2
M V30 2 1 2 3
M V30 3 1 4 3 CFG=3
M V30 4 1 4 5
M V30 5 1 5 6
M V30 6 1 7 6 CFG=3
M V30 7 1 7 8
M V30 8 1 8 9
M V30 9 1 7 2
M V30 10 1 9 4
M V30 END BOND
M V30 END CTAB
M END)CTAB"_ctab;
REQUIRE(m);
bool explicitOnly = false;
bool addCoords = true;
UINT_VECT onlyOnAtoms = {3, 6};
MolOps::addHs(*m, explicitOnly, addCoords, &onlyOnAtoms);
const auto &conf = m->getConformer();
// check that the H atoms bisect the angle correctly
{
REQUIRE(m->getAtomWithIdx(9)->getAtomicNum() == 1);
REQUIRE(m->getBondBetweenAtoms(9, 3));
REQUIRE(m->getBondBetweenAtoms(3, 4));
REQUIRE(m->getBondBetweenAtoms(3, 2));
REQUIRE(m->getBondBetweenAtoms(3, 8));
auto v1 = conf.getAtomPos(9) - conf.getAtomPos(3);
auto v2 = conf.getAtomPos(4) - conf.getAtomPos(3);
auto v3 = conf.getAtomPos(2) - conf.getAtomPos(3);
auto v4 = conf.getAtomPos(8) - conf.getAtomPos(3);
CHECK(v1.angleTo(v3) < v1.angleTo(v2));
CHECK(v1.angleTo(v4) < v1.angleTo(v2));
CHECK(fabs(v1.angleTo(v3) - v1.angleTo(v4)) < 1e-4);
CHECK(v1.dotProduct(v3) < -1e-4);
CHECK(v1.dotProduct(v4) < -1e-4);
}
{
REQUIRE(m->getAtomWithIdx(10)->getAtomicNum() == 1);
REQUIRE(m->getBondBetweenAtoms(10, 6));
REQUIRE(m->getBondBetweenAtoms(5, 6));
REQUIRE(m->getBondBetweenAtoms(6, 1));
REQUIRE(m->getBondBetweenAtoms(6, 7));
auto v1 = conf.getAtomPos(10) - conf.getAtomPos(6);
auto v2 = conf.getAtomPos(5) - conf.getAtomPos(6);
auto v3 = conf.getAtomPos(1) - conf.getAtomPos(6);
auto v4 = conf.getAtomPos(7) - conf.getAtomPos(6);
CHECK(v1.angleTo(v3) < v1.angleTo(v2));
CHECK(v1.angleTo(v4) < v1.angleTo(v2));
CHECK(fabs(v1.angleTo(v3) - v1.angleTo(v4)) < 1e-4);
CHECK(v1.dotProduct(v3) < -1e-4);
CHECK(v1.dotProduct(v4) < -1e-4);
}
}
SECTION("non-chiral version") {
auto m = R"CTAB(
RDKit 2D
0 0 0 0 0 0 0 0 0 0999 V3000
M V30 BEGIN CTAB
M V30 COUNTS 9 10 0 0 0
M V30 BEGIN ATOM
M V30 1 C 1.500000 2.598076 0.000000 0
M V30 2 N 0.750000 1.299038 0.000000 0
M V30 3 C 1.500000 -0.000000 0.000000 0
M V30 4 C 0.750000 -1.299038 0.000000 0
M V30 5 C 0.382772 -0.562069 0.000000 0
M V30 6 C -0.295379 0.612525 0.000000 0
M V30 7 C -0.750000 1.299038 0.000000 0
M V30 8 C -1.500000 0.000000 0.000000 0
M V30 9 O -0.750000 -1.299038 0.000000 0
M V30 END ATOM
M V30 BEGIN BOND
M V30 1 1 1 2
M V30 2 1 2 3
M V30 3 1 4 3
M V30 4 1 4 5
M V30 5 1 5 6
M V30 6 1 7 6
M V30 7 1 7 8
M V30 8 1 8 9
M V30 9 1 7 2
M V30 10 1 9 4
M V30 END BOND
M V30 END CTAB
M END)CTAB"_ctab;
REQUIRE(m);
bool explicitOnly = false;
bool addCoords = true;
UINT_VECT onlyOnAtoms = {3, 6};
MolOps::addHs(*m, explicitOnly, addCoords, &onlyOnAtoms);
const auto &conf = m->getConformer();
{
REQUIRE(m->getAtomWithIdx(9)->getAtomicNum() == 1);
REQUIRE(m->getBondBetweenAtoms(9, 3));
REQUIRE(m->getBondBetweenAtoms(3, 4));
REQUIRE(m->getBondBetweenAtoms(3, 2));
REQUIRE(m->getBondBetweenAtoms(3, 8));
auto v1 = conf.getAtomPos(9) - conf.getAtomPos(3);
auto v2 = conf.getAtomPos(4) - conf.getAtomPos(3);
auto v3 = conf.getAtomPos(2) - conf.getAtomPos(3);
auto v4 = conf.getAtomPos(8) - conf.getAtomPos(3);
CHECK(v1.angleTo(v3) < v1.angleTo(v2));
CHECK(v1.angleTo(v4) < v1.angleTo(v2));
CHECK(fabs(v1.angleTo(v3) - v1.angleTo(v4)) < 1e-4);
CHECK(v1.dotProduct(v3) < -1e-4);
CHECK(v1.dotProduct(v4) < -1e-4);
}
{
REQUIRE(m->getAtomWithIdx(10)->getAtomicNum() == 1);
REQUIRE(m->getBondBetweenAtoms(10, 6));
REQUIRE(m->getBondBetweenAtoms(5, 6));
REQUIRE(m->getBondBetweenAtoms(6, 1));
REQUIRE(m->getBondBetweenAtoms(6, 7));
auto v1 = conf.getAtomPos(10) - conf.getAtomPos(6);
auto v2 = conf.getAtomPos(5) - conf.getAtomPos(6);
auto v3 = conf.getAtomPos(1) - conf.getAtomPos(6);
auto v4 = conf.getAtomPos(7) - conf.getAtomPos(6);
CHECK(v1.angleTo(v3) < v1.angleTo(v2));
CHECK(v1.angleTo(v4) < v1.angleTo(v2));
CHECK(fabs(v1.angleTo(v3) - v1.angleTo(v4)) < 1e-4);
CHECK(v1.dotProduct(v3) < -1e-4);
CHECK(v1.dotProduct(v4) < -1e-4);
}
}
SECTION("a simpler system") {
auto m = R"CTAB(
Mrv2014 03092106042D
0 0 0 0 0 999 V3000
M V30 BEGIN CTAB
M V30 COUNTS 5 6 0 0 0
M V30 BEGIN ATOM
M V30 1 C -4.3533 6.6867 0 0
M V30 2 C -4.3533 5.1467 0 0 CFG=1
M V30 3 O -2.8133 6.6867 0 0
M V30 4 C -2.8133 5.1467 0 0 CFG=1
M V30 5 C -3.5833 3.813 0 0
M V30 END ATOM
M V30 BEGIN BOND
M V30 1 1 1 3
M V30 2 1 2 4
M V30 3 1 3 4
M V30 4 1 2 5
M V30 5 1 4 5 CFG=1
M V30 6 1 2 1 CFG=1
M V30 END BOND
M V30 END CTAB
M END
)CTAB"_ctab;
bool explicitOnly = false;
bool addCoords = true;
UINT_VECT onlyOnAtoms = {3, 1};
MolOps::addHs(*m, explicitOnly, addCoords, &onlyOnAtoms);
const auto &conf = m->getConformer();
{
REQUIRE(m->getAtomWithIdx(5)->getAtomicNum() == 1);
REQUIRE(m->getBondBetweenAtoms(5, 1));
REQUIRE(m->getBondBetweenAtoms(1, 3));
REQUIRE(m->getBondBetweenAtoms(1, 0));
REQUIRE(m->getBondBetweenAtoms(1, 4));
auto v1 = conf.getAtomPos(5) - conf.getAtomPos(1);
auto v2 = conf.getAtomPos(3) - conf.getAtomPos(1);
auto v3 = conf.getAtomPos(0) - conf.getAtomPos(1);
auto v4 = conf.getAtomPos(4) - conf.getAtomPos(1);
CHECK(v1.angleTo(v3) < v1.angleTo(v2));
CHECK(v1.angleTo(v4) < v1.angleTo(v2));
CHECK(fabs(v1.angleTo(v3) - v1.angleTo(v4)) < 1e-4);
CHECK(v1.dotProduct(v3) < -1e-4);
CHECK(v1.dotProduct(v4) < -1e-4);
}
}
SECTION("#3932: followup from #3879") {
auto m = R"CTAB(
RDKit 2D
21 22 0 0 0 0 0 0 0 0999 V2000
-6.9959 0.0617 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
-5.5212 0.3365 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
-5.0219 1.7509 0.0000 O 0 0 0 0 0 0 0 0 0 0 0 0
-4.5460 -0.8032 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
-3.0713 -0.5284 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
-2.0961 -1.6681 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
-0.6214 -1.3933 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
0.2270 -0.1562 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
1.4640 -1.0046 0.0000 N 0 0 0 0 0 0 0 0 0 0 0 0
2.6531 -0.0903 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
4.0918 -0.5150 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
5.1788 0.5186 0.0000 O 0 0 0 0 0 0 0 0 0 0 0 0
4.4434 -1.9732 0.0000 O 0 0 0 0 0 0 0 0 0 0 0 0
2.1510 1.3231 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
3.6092 1.6747 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
1.9538 2.8101 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
0.6516 1.2824 0.0000 S 0 0 0 0 0 0 0 0 0 0 0 0
0.7678 2.7779 0.0000 O 0 0 0 0 0 0 0 0 0 0 0 0
-0.8236 1.5543 0.0000 O 0 0 0 0 0 0 0 0 0 0 0 0
0.6156 -2.2417 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0
0.8904 -3.7163 0.0000 O 0 0 0 0 0 0 0 0 0 0 0 0
1 2 1 0
2 3 2 0
2 4 1 0
4 5 2 0
5 6 1 0
6 7 1 0
8 7 1 6
8 9 1 0
9 10 1 0
10 11 1 6
11 12 2 0
11 13 1 0
10 14 1 0
14 15 1 0
14 16 1 0
14 17 1 0
17 18 2 0
17 19 2 0
9 20 1 0
20 21 2 0
20 7 1 0
17 8 1 0
M END)CTAB"_ctab;
REQUIRE(m);
bool explicitOnly = false;
bool addCoords = true;
UINT_VECT onlyOnAtoms = {7};
MolOps::addHs(*m, explicitOnly, addCoords, &onlyOnAtoms);
const auto &conf = m->getConformer();
{
REQUIRE(m->getAtomWithIdx(21)->getAtomicNum() == 1);
REQUIRE(m->getBondBetweenAtoms(21, 7));
REQUIRE(m->getBondBetweenAtoms(7, 8));
REQUIRE(m->getBondBetweenAtoms(7, 16));
REQUIRE(m->getBondBetweenAtoms(7, 6));
auto v1 = conf.getAtomPos(21) - conf.getAtomPos(7);
auto v2 = conf.getAtomPos(6) - conf.getAtomPos(7);
auto v3 = conf.getAtomPos(16) - conf.getAtomPos(7);
auto v4 = conf.getAtomPos(8) - conf.getAtomPos(7);
CHECK(v1.angleTo(v2) < v1.angleTo(v4));
CHECK(v1.angleTo(v3) < v1.angleTo(v4));
CHECK(fabs(v1.angleTo(v2) - v1.angleTo(v3)) < 1e-4);
}
}
}
TEST_CASE("batch edits", "[editing]") {
SECTION("removeAtom") {
auto m = "C1CCCO1"_smiles;
REQUIRE(m);
m->beginBatchEdit();
m->removeAtom(2);
m->removeAtom(3);
m->commitBatchEdit();
CHECK(MolToSmiles(*m) == "CCO");
}
SECTION("removeAtom + removeBond") {
auto m = "C1CCCO1"_smiles;
REQUIRE(m);
m->beginBatchEdit();
m->removeAtom(3);
m->removeBond(4, 0);
m->commitBatchEdit();
CHECK(MolToSmiles(*m) == "CCC.O");
}
SECTION("rollback") {
auto m = "C1CCCO1"_smiles;
REQUIRE(m);
m->beginBatchEdit();
m->removeAtom(2);
m->removeAtom(3);
m->rollbackBatchEdit();
CHECK(MolToSmiles(*m) == "C1CCOC1");
}
SECTION("adding atoms while in a batch") {
auto m = "CCCO"_smiles;
REQUIRE(m);
m->beginBatchEdit();
m->removeAtom(2);
bool updateLabel = false;
bool takeOwnership = true;
m->addAtom(new Atom(7), updateLabel, takeOwnership);
m->removeAtom(1);
m->commitBatchEdit();
CHECK(MolToSmiles(*m) == "C.N.O");
}
SECTION("removing added atoms while in a batch") {
auto m = "CCCO"_smiles;
REQUIRE(m);
m->beginBatchEdit();
m->removeAtom(2);
bool updateLabel = false;
bool takeOwnership = true;
m->addAtom(new Atom(7), updateLabel, takeOwnership);
m->removeAtom(4);
m->commitBatchEdit();
CHECK(MolToSmiles(*m) == "CC.O");
}
SECTION("adding bonds while in a batch") {
auto m = "CCCO"_smiles;
REQUIRE(m);
m->beginBatchEdit();
m->removeBond(2, 3);
m->addBond(0, 3, Bond::BondType::SINGLE);
m->commitBatchEdit();
CHECK(MolToSmiles(*m) == "CCCO");
}
SECTION("removing added bonds while in a batch") {
auto m = "CCCO"_smiles;
REQUIRE(m);
m->beginBatchEdit();
m->addBond(0, 3, Bond::BondType::SINGLE);
m->removeBond(2, 3);
m->removeBond(0, 3);
m->commitBatchEdit();
CHECK(MolToSmiles(*m) == "CCC.O");
}
SECTION("some details") {
auto m = "CCCO"_smiles;
REQUIRE(m);
m->beginBatchEdit();
CHECK_THROWS_AS(m->beginBatchEdit(), ValueErrorException);
m->removeAtom(0U);
// copying includes the edit status:
RWMol m2(*m);
CHECK_THROWS_AS(m2.beginBatchEdit(), ValueErrorException);
// without a commit, the mols haven't changed
CHECK(MolToSmiles(*m) == "CCCO");
CHECK(MolToSmiles(m2) == "CCCO");
m->commitBatchEdit();
CHECK(MolToSmiles(*m) == "CCO");
m2.commitBatchEdit();
CHECK(MolToSmiles(m2) == "CCO");
}
}
TEST_CASE("github #4122: segfaults in commitBatchEdit()", "[editing][bug]") {
SECTION("as reported, no atoms") {
RWMol m;
m.beginBatchEdit();
m.addAtom();
m.commitBatchEdit();
}
SECTION("no bonds") {
auto m = "C.C"_smiles;
m->beginBatchEdit();
m->addBond(0, 1, Bond::BondType::SINGLE);
m->commitBatchEdit();
}
SECTION("after add atom") {
auto m = "CC"_smiles;
m->beginBatchEdit();
m->addAtom(6);
m->removeAtom(0u);
m->addAtom(6);
m->commitBatchEdit();
}
SECTION("remove a just-added atom") {
auto m = "CC"_smiles;
m->beginBatchEdit();
m->addAtom(6);
m->removeAtom(2);
m->commitBatchEdit();
}
}
TEST_CASE("github #3912: cannot draw atom lists from SMARTS", "[query][bug]") {
SECTION("original") {
auto m = "C(-[N,O])-[#7,#8]"_smarts;
REQUIRE(m);
CHECK(isAtomListQuery(m->getAtomWithIdx(1)));
CHECK(isAtomListQuery(m->getAtomWithIdx(2)));
std::vector<int> vals;
getAtomListQueryVals(m->getAtomWithIdx(2)->getQuery(), vals);
CHECK(vals == std::vector<int>{7, 8});
vals.clear();
getAtomListQueryVals(m->getAtomWithIdx(1)->getQuery(), vals);
CHECK(vals == std::vector<int>{7, 8});
}
}
TEST_CASE("github #4496: cannot draw aromatic atom lists from SMARTS",
"[query][bug]") {
SECTION("original") {
auto m = "[c,n]1[c,n][c,n][c,n][c,n][c,n]1"_smarts;
REQUIRE(m);
std::vector<int> expected({6, 7});
for (const auto a : m->atoms()) {
CHECK(isAtomListQuery(a));
std::vector<int> vals;
getAtomListQueryVals(a->getQuery(), vals);
CHECK(vals == expected);
}
}
}
TEST_CASE("bridgehead queries", "[query]") {
SECTION("basics") {
{
auto m = "CC12CCN(CC1)C2"_smiles;
REQUIRE(m);
for (const auto atom : m->atoms()) {
auto test = queryIsAtomBridgehead(atom);
if (atom->getIdx() == 1 || atom->getIdx() == 4) {
CHECK(test == 1);
} else {
CHECK(test == 0);
}
}
}
{
auto m = "CC12CCC(C)(CC1)CC2"_smiles;
REQUIRE(m);
for (const auto atom : m->atoms()) {
auto test = queryIsAtomBridgehead(atom);
if (atom->getIdx() == 1 || atom->getIdx() == 4) {
CHECK(test == 1);
} else {
CHECK(test == 0);
}
}
}
{ // no bridgehead
auto m = "C1CCC2CCCCC2C1"_smiles;
REQUIRE(m);
for (const auto atom : m->atoms()) {
auto test = queryIsAtomBridgehead(atom);
CHECK(test == 0);
}
}
}
SECTION("Github #6049") {
auto m = "C1C=CC=C2CCCCC3CC(C3)N21"_smiles;
REQUIRE(m);
CHECK(!queryIsAtomBridgehead(m->getAtomWithIdx(13)));
CHECK(!queryIsAtomBridgehead(m->getAtomWithIdx(4)));
CHECK(queryIsAtomBridgehead(m->getAtomWithIdx(11)));
CHECK(queryIsAtomBridgehead(m->getAtomWithIdx(9)));
}
}
TEST_CASE("replaceAtom/Bond should not screw up bookmarks", "[RWMol]") {
SECTION("atom basics") {
auto m = "CCC"_smiles;
REQUIRE(m);
m->setAtomBookmark(m->getAtomWithIdx(2), 1);
auto origAt2 = m->getAtomWithIdx(2);
CHECK(m->getUniqueAtomWithBookmark(1) == origAt2);
Atom O(8);
m->replaceAtom(2, &O);
auto at2 = m->getAtomWithIdx(2);
CHECK(at2 != origAt2);
CHECK(m->getUniqueAtomWithBookmark(1) == at2);
}
SECTION("bond basics") {
auto m = "CCCC"_smiles;
REQUIRE(m);
m->setBondBookmark(m->getBondWithIdx(2), 1);
auto origB2 = m->getBondWithIdx(2);
CHECK(m->getUniqueBondWithBookmark(1) == origB2);
Bond single(Bond::BondType::SINGLE);
m->replaceBond(2, &single);
auto b2 = m->getBondWithIdx(2);
CHECK(b2 != origB2);
CHECK(m->getUniqueBondWithBookmark(1) == b2);
}
}
TEST_CASE("github #4071: StereoGroups not preserved by RenumberAtoms()",
"[molops]") {
SECTION("basics") {
auto mol =
"C[C@@H](O)[C@H](C)[C@@H](C)[C@@H](C)O |&3:3,o1:7,&1:1,&2:5,r|"_smiles;
REQUIRE(mol);
REQUIRE(mol->getStereoGroups().size() == 4);
std::vector<unsigned int> aindices(mol->getNumAtoms());
std::iota(aindices.begin(), aindices.end(), 0);
std::reverse(aindices.begin(), aindices.end());
std::unique_ptr<ROMol> nmol(MolOps::renumberAtoms(*mol, aindices));
REQUIRE(nmol);
CHECK(nmol->getStereoGroups().size() == 4);
for (size_t i = 0; i < nmol->getStereoGroups().size(); ++i) {
CHECK(nmol->getStereoGroups()[i].getGroupType() ==
mol->getStereoGroups()[i].getGroupType());
}
CHECK(MolToCXSmiles(*nmol) ==
"C[C@H](O)[C@H](C)[C@H](C)[C@H](C)O |o1:1,&1:3,&2:5,&3:7|");
}
}
TEST_CASE("github #4127: SEGV in ROMol::getAtomDegree if atom is not in graph",
"[graphmol]") {
// also includes tests for some related edge cases found as part of that bug
// fix
Atom atom(6);
RWMol mol1;
auto mol2 = "CCC"_smiles;
SECTION("getAtomDegree") {
CHECK_THROWS_AS(mol1.getAtomDegree(nullptr), Invar::Invariant);
CHECK_THROWS_AS(mol1.getAtomDegree(&atom), Invar::Invariant);
CHECK_THROWS_AS(mol1.getAtomDegree(mol2->getAtomWithIdx(0)),
Invar::Invariant);
}
SECTION("getAtomNeighbors") {
CHECK_THROWS_AS(mol1.getAtomNeighbors(nullptr), Invar::Invariant);
CHECK_THROWS_AS(mol1.getAtomNeighbors(&atom), Invar::Invariant);
CHECK_THROWS_AS(mol1.getAtomNeighbors(mol2->getAtomWithIdx(0)),
Invar::Invariant);
}
SECTION("getAtomBonds") {
CHECK_THROWS_AS(mol1.getAtomBonds(nullptr), Invar::Invariant);
CHECK_THROWS_AS(mol1.getAtomBonds(&atom), Invar::Invariant);
CHECK_THROWS_AS(mol1.getAtomBonds(mol2->getAtomWithIdx(0)),
Invar::Invariant);
}
SECTION("addAtom from another molecule") {
RWMol mol1cp(mol1);
CHECK_THROWS_AS(mol1cp.addAtom(nullptr), Invar::Invariant);
bool updateLabel = false;
bool takeOwnership = true;
CHECK_THROWS_AS(
mol1cp.addAtom(mol2->getAtomWithIdx(0), updateLabel, takeOwnership),
Invar::Invariant);
takeOwnership = false;
CHECK(mol1cp.addAtom(mol2->getAtomWithIdx(0), updateLabel, takeOwnership) ==
0);
}
SECTION("addBond from another molecule") {
auto mol3 = "C.C.C"_smiles;
bool takeOwnership = true;
CHECK_THROWS_AS(mol3->addBond(mol2->getBondWithIdx(0), takeOwnership),
Invar::Invariant);
takeOwnership = false;
CHECK(mol3->addBond(mol2->getBondWithIdx(0), takeOwnership) == 1);
}
}
TEST_CASE(
"github #4128: SEGV from unsigned integer overflow in "
"Conformer::setAtomPos",
"[graphmol]") {
Conformer conf;
RDGeom::Point3D pt(0, 0, 0);
CHECK_THROWS_AS(conf.setAtomPos(std::numeric_limits<unsigned>::max(), pt),
ValueErrorException);
}
TEST_CASE("KekulizeFragment", "[graphmol]") {
SECTION("basics") {
auto mol = "CCc1ccccc1"_smiles;
REQUIRE(mol);
boost::dynamic_bitset<> atomsInPlay(mol->getNumAtoms());
for (auto aidx : std::vector<size_t>{0, 1, 2, 3}) {
atomsInPlay.set(aidx);
}
boost::dynamic_bitset<> bondsInPlay(mol->getNumBonds());
for (auto bidx : std::vector<size_t>{0, 1, 2}) {
bondsInPlay.set(bidx);
}
MolOps::details::KekulizeFragment(*mol, atomsInPlay, bondsInPlay);
CHECK(!mol->getAtomWithIdx(2)->getIsAromatic());
CHECK(mol->getAtomWithIdx(4)->getIsAromatic());
CHECK(!mol->getBondWithIdx(2)->getIsAromatic());
// at the moment that bond still has an aromatic bond order, which isn't
// optimal, but that will have to wait until we add a feature to allow
// kekulization of conjugated chains.
CHECK(mol->getBondWithIdx(2)->getBondType() == Bond::AROMATIC);
CHECK(mol->getBondWithIdx(4)->getIsAromatic());
}
}
TEST_CASE(
"github #4266: fallback ring finding failing on molecules with multiple "
"fragments",
"[graphmol]") {
SECTION("case1") {
auto m = "C123C45C16C21C34C561.c1ccccc1"_smiles;
REQUIRE(m);
ROMol m2(*m);
m2.getRingInfo()->reset();
MolOps::fastFindRings(m2);
CHECK(m->getRingInfo()->numRings() == m2.getRingInfo()->numRings());
}
SECTION("case2") {
auto m = "c1ccccc1.C123C45C16C21C34C561"_smiles;
REQUIRE(m);
ROMol m2(*m);
m2.getRingInfo()->reset();
MolOps::fastFindRings(m2);
CHECK(m->getRingInfo()->numRings() == m2.getRingInfo()->numRings());
}
}
TEST_CASE("QueryBond valence contribs") {
{
auto m = "CO"_smarts;
REQUIRE(m);
CHECK(m->getBondWithIdx(0)->getValenceContrib(m->getAtomWithIdx(0)) == 0.0);
CHECK(m->getBondWithIdx(0)->getValenceContrib(m->getAtomWithIdx(1)) == 0.0);
}
{
auto m = "C-O"_smarts;
REQUIRE(m);
CHECK(m->getBondWithIdx(0)->getValenceContrib(m->getAtomWithIdx(0)) == 1.0);
CHECK(m->getBondWithIdx(0)->getValenceContrib(m->getAtomWithIdx(1)) == 1.0);
}
}
TEST_CASE(
"github #4311: unreasonable calculation of implicit valence for atoms with "
"query bonds",
"[graphmol]") {
SECTION("basics") {
auto m = "C-,=O"_smarts;
REQUIRE(m);
m->updatePropertyCache();
CHECK(m->getAtomWithIdx(0)->getTotalNumHs() == 0);
CHECK(m->getAtomWithIdx(1)->getTotalNumHs() == 0);
CHECK(MolToSmiles(*m) == "CO");
CHECK(MolToSmarts(*m) == "C-,=O");
}
}
TEST_CASE("atom copy ctor") {
auto m = "CO"_smiles;
REQUIRE(m);
for (const auto atom : m->atoms()) {
Atom cp(*atom);
CHECK(cp.getAtomicNum() == atom->getAtomicNum());
CHECK(!cp.hasOwningMol());
}
}
TEST_CASE("bond copy ctor") {
auto m = "COC"_smiles;
REQUIRE(m);
for (const auto bond : m->bonds()) {
Bond cp(*bond);
CHECK(cp.getBondType() == bond->getBondType());
CHECK(!cp.hasOwningMol());
}
}
TEST_CASE("valence edge") {
{ // this is, of course, absurd:
auto m = "[H-2]"_smiles;
REQUIRE(m);
m->getAtomWithIdx(0)->setNoImplicit(false);
m->updatePropertyCache(false);
CHECK(m->getAtomWithIdx(0)->getFormalCharge() == -2);
CHECK(m->getAtomWithIdx(0)->getImplicitValence() == 0);
}
{
SmilesParserParams ps;
ps.sanitize = false;
std::unique_ptr<RWMol> m{SmilesToMol("CFC", ps)};
REQUIRE(m);
CHECK_THROWS_AS(m->getAtomWithIdx(1)->calcImplicitValence(true),
AtomValenceException);
}
}
TEST_CASE("SetQuery on normal atoms") {
auto m = "CC"_smiles;
REQUIRE(m);
auto qry = makeAtomAliphaticQuery();
CHECK_THROWS_AS(m->getAtomWithIdx(0)->setQuery(qry), std::runtime_error);
CHECK_THROWS_AS(m->getAtomWithIdx(0)->expandQuery(qry), std::runtime_error);
delete qry;
}
TEST_CASE("SetQuery on normal bonds") {
auto m = "CC"_smiles;
REQUIRE(m);
auto qry = makeBondOrderEqualsQuery(Bond::BondType::SINGLE);
CHECK_THROWS_AS(m->getBondWithIdx(0)->setQuery(qry), std::runtime_error);
CHECK_THROWS_AS(m->getBondWithIdx(0)->expandQuery(qry), std::runtime_error);
delete qry;
}
TEST_CASE("additional atom props") {
auto m = "CC"_smiles;
REQUIRE(m);
auto atom = m->getAtomWithIdx(0);
{
CHECK(!atom->hasProp(common_properties::_MolFileRLabel));
setAtomRLabel(atom, 1);
CHECK(atom->hasProp(common_properties::_MolFileRLabel));
setAtomRLabel(atom, 0);
CHECK(!atom->hasProp(common_properties::_MolFileRLabel));
}
{
CHECK(!atom->hasProp(common_properties::molFileAlias));
setAtomAlias(atom, "foo");
CHECK(atom->hasProp(common_properties::molFileAlias));
setAtomAlias(atom, "");
CHECK(!atom->hasProp(common_properties::molFileAlias));
}
{
CHECK(!atom->hasProp(common_properties::molFileValue));
setAtomValue(atom, "foo");
CHECK(atom->hasProp(common_properties::molFileValue));
setAtomValue(atom, "");
CHECK(!atom->hasProp(common_properties::molFileValue));
}
{
CHECK(!atom->hasProp(common_properties::_supplementalSmilesLabel));
setSupplementalSmilesLabel(atom, "foo");
CHECK(atom->hasProp(common_properties::_supplementalSmilesLabel));
setSupplementalSmilesLabel(atom, "");
CHECK(!atom->hasProp(common_properties::_supplementalSmilesLabel));
}
}
TEST_CASE("getBondTypeAsDouble()") {
SECTION("plain") {
std::vector<std::pair<Bond::BondType, double>> vals{
{Bond::BondType::IONIC, 0},
{Bond::BondType::ZERO, 0},
{Bond::BondType::SINGLE, 1},
{Bond::BondType::DOUBLE, 2},
{Bond::BondType::TRIPLE, 3},
{Bond::BondType::QUADRUPLE, 4},
{Bond::BondType::QUINTUPLE, 5},
{Bond::BondType::HEXTUPLE, 6},
{Bond::BondType::ONEANDAHALF, 1.5},
{Bond::BondType::TWOANDAHALF, 2.5},
{Bond::BondType::THREEANDAHALF, 3.5},
{Bond::BondType::FOURANDAHALF, 4.5},
{Bond::BondType::FIVEANDAHALF, 5.5},
{Bond::BondType::AROMATIC, 1.5},
{Bond::BondType::DATIVEONE, 1.0},
{Bond::BondType::DATIVE, 1.0},
{Bond::BondType::HYDROGEN, 0}
};
for (const auto &pr : vals) {
Bond bnd(pr.first);
CHECK(bnd.getBondType() == pr.first);
CHECK(bnd.getBondTypeAsDouble() == pr.second);
}
}
SECTION("twice") {
std::vector<std::pair<Bond::BondType, std::uint8_t>> vals{
{Bond::BondType::IONIC, 0}, {Bond::BondType::ZERO, 0},
{Bond::BondType::SINGLE, 2}, {Bond::BondType::DOUBLE, 4},
{Bond::BondType::TRIPLE, 6}, {Bond::BondType::QUADRUPLE, 8},
{Bond::BondType::QUINTUPLE, 10}, {Bond::BondType::HEXTUPLE, 12},
{Bond::BondType::ONEANDAHALF, 3}, {Bond::BondType::TWOANDAHALF, 5},
{Bond::BondType::THREEANDAHALF, 7}, {Bond::BondType::FOURANDAHALF, 9},
{Bond::BondType::FIVEANDAHALF, 11}, {Bond::BondType::AROMATIC, 3},
{Bond::BondType::DATIVEONE, 2}, {Bond::BondType::DATIVE, 2},
{Bond::BondType::HYDROGEN, 0}
};
for (const auto &pr : vals) {
Bond bnd(pr.first);
CHECK(bnd.getBondType() == pr.first);
CHECK(getTwiceBondType(bnd) == pr.second);
}
}
}
TEST_CASE("getValenceContrib()") {
const auto m = "CO->[Fe]"_smiles;
REQUIRE(m);
CHECK(m->getBondWithIdx(1)->getValenceContrib(m->getAtomWithIdx(0)) == 0);
CHECK(m->getBondWithIdx(1)->getValenceContrib(m->getAtomWithIdx(1)) == 0);
CHECK(m->getBondWithIdx(1)->getValenceContrib(m->getAtomWithIdx(2)) == 1);
}
TEST_CASE("conformer details") {
const auto m = "CC"_smiles;
REQUIRE(m);
Conformer *conf = new Conformer(m->getNumAtoms());
CHECK(!conf->hasOwningMol());
m->addConformer(conf);
CHECK(conf->hasOwningMol());
auto cid = conf->getId();
*conf = *conf;
CHECK(conf->hasOwningMol());
CHECK(conf->getId() == cid);
}
#if !defined(_WIN32) || !defined(RDKIT_DYN_LINK)
namespace RDKit {
namespace Canon {
namespace details {
bool atomHasFourthValence(const Atom *atom);
bool hasSingleHQuery(const Atom::QUERYATOM_QUERY *q);
} // namespace details
void switchBondDir(Bond *bond);
} // namespace Canon
} // namespace RDKit
TEST_CASE("canon details") {
SECTION("h queries") {
std::vector<std::pair<std::string, bool>> examples{
{"C[CHD3](F)Cl", true}, {"C[CD3H](F)Cl", true},
{"C[CH3D](F)Cl", false}, {"C[CDH3](F)Cl", false},
{"C[CDR4H](F)Cl", true},
};
for (const auto &pr : examples) {
std::unique_ptr<RWMol> m{SmartsToMol(pr.first)};
REQUIRE(m);
CHECK(RDKit::Canon::details::hasSingleHQuery(
m->getAtomWithIdx(1)->getQuery()) == pr.second);
CHECK(RDKit::Canon::details::atomHasFourthValence(m->getAtomWithIdx(1)) ==
pr.second);
// artificial, but causes atomHasFourthValence to always return true
m->getAtomWithIdx(1)->setNumExplicitHs(1);
CHECK(RDKit::Canon::details::atomHasFourthValence(m->getAtomWithIdx(1)));
}
}
}
TEST_CASE("switchBondDir") {
auto m = "C/C=C/C"_smiles;
REQUIRE(m);
auto bond = m->getBondWithIdx(0);
CHECK(bond->getBondDir() == Bond::BondDir::ENDUPRIGHT);
Canon::switchBondDir(bond);
CHECK(bond->getBondDir() == Bond::BondDir::ENDDOWNRIGHT);
bond->setBondDir(Bond::BondDir::UNKNOWN);
Canon::switchBondDir(bond);
CHECK(bond->getBondDir() == Bond::BondDir::UNKNOWN);
}
#endif
TEST_CASE("allow 5 valent N/P/As to kekulize", "[kekulization]") {
std::vector<std::pair<std::string, std::string>> tests = {
{"O=n1ccccc1", "O=N1=CC=CC=C1"},
{"O=p1ccccc1", "O=P1=CC=CC=C1"},
{"O=[as]1ccccc1", "O=[As]1=CC=CC=C1"}};
SmilesParserParams ps;
ps.sanitize = false;
SECTION("kekulization") {
for (const auto &pr : tests) {
INFO(pr.first);
std::unique_ptr<RWMol> m{SmilesToMol(pr.first, ps)};
REQUIRE(m);
m->updatePropertyCache(false);
MolOps::Kekulize(*m);
CHECK(MolToSmiles(*m) == pr.second);
}
}
SECTION("sanitization") {
for (const auto &pr : tests) {
INFO(pr.first);
std::unique_ptr<RWMol> m{SmilesToMol(pr.first, ps)};
REQUIRE(m);
m->updatePropertyCache(false);
unsigned int failed;
unsigned int flags = MolOps::SanitizeFlags::SANITIZE_ALL ^
MolOps::SanitizeFlags::SANITIZE_CLEANUP ^
MolOps::SanitizeFlags::SANITIZE_PROPERTIES;
MolOps::sanitizeMol(*m, failed, flags);
CHECK(!failed);
CHECK(MolToSmiles(*m) == pr.second);
}
}
}
TEST_CASE("KekulizeIfPossible") {
SECTION("basics: molecules with failures") {
std::vector<std::string> smis = {
"c1cccn1",
"c1ccccc1-c1cccn1",
};
for (const auto &smi : smis) {
SmilesParserParams ps;
ps.sanitize = false;
std::unique_ptr<RWMol> m{SmilesToMol(smi, ps)};
REQUIRE(m);
m->updatePropertyCache(false);
// confirm that we normally fail:
{
RWMol m2(*m);
CHECK_THROWS_AS(MolOps::Kekulize(m2), MolSanitizeException);
}
{
RWMol m2(*m);
CHECK(!MolOps::KekulizeIfPossible(m2));
for (unsigned i = 0; i < m2.getNumAtoms(); ++i) {
CHECK(m2.getAtomWithIdx(i)->getIsAromatic() ==
m->getAtomWithIdx(i)->getIsAromatic());
}
for (unsigned i = 0; i < m2.getNumBonds(); ++i) {
CHECK(m2.getBondWithIdx(i)->getIsAromatic() ==
m->getBondWithIdx(i)->getIsAromatic());
CHECK(m2.getBondWithIdx(i)->getBondType() ==
m->getBondWithIdx(i)->getBondType());
}
}
}
}
SECTION("basics: molecules without failures") {
std::vector<std::string> smis = {"c1ccc[nH]1", "c1ccccc1"};
for (const auto &smi : smis) {
SmilesParserParams ps;
ps.sanitize = false;
std::unique_ptr<RWMol> m{SmilesToMol(smi, ps)};
REQUIRE(m);
m->updatePropertyCache(false);
{
RWMol m2(*m);
MolOps::Kekulize(m2);
RWMol m3(*m);
CHECK(MolOps::KekulizeIfPossible(m3));
for (unsigned i = 0; i < m2.getNumAtoms(); ++i) {
CHECK(m2.getAtomWithIdx(i)->getIsAromatic() ==
m3.getAtomWithIdx(i)->getIsAromatic());
}
for (unsigned i = 0; i < m2.getNumBonds(); ++i) {
CHECK(m2.getBondWithIdx(i)->getIsAromatic() ==
m3.getBondWithIdx(i)->getIsAromatic());
CHECK(m2.getBondWithIdx(i)->getBondType() ==
m3.getBondWithIdx(i)->getBondType());
}
}
}
}
}
TEST_CASE("Github #4535: operator<< for AtomPDBResidue", "[PDB]") {
SECTION("basics") {
bool sanitize = true;
int flavor = 0;
std::unique_ptr<RWMol> mol(SequenceToMol("KY", sanitize, flavor));
REQUIRE(mol);
REQUIRE(mol->getAtomWithIdx(0)->getMonomerInfo());
auto res = static_cast<AtomPDBResidueInfo *>(
mol->getAtomWithIdx(0)->getMonomerInfo());
REQUIRE(res);
std::stringstream oss;
oss << *res << std::endl;
res = static_cast<AtomPDBResidueInfo *>(
mol->getAtomWithIdx(mol->getNumAtoms() - 1)->getMonomerInfo());
REQUIRE(res);
oss << *res << std::endl;
auto tgt = R"FOO(1 N LYS A 1
22 OXT TYR A 2
)FOO";
CHECK(oss.str() == tgt);
}
}
TEST_CASE("isAromaticAtom") {
SECTION("basics") {
SmilesParserParams ps;
ps.sanitize = false;
std::unique_ptr<RWMol> mol(SmilesToMol("C:C:C", ps));
REQUIRE(mol);
CHECK(!mol->getAtomWithIdx(0)->getIsAromatic());
CHECK(mol->getBondWithIdx(0)->getIsAromatic());
CHECK(isAromaticAtom(*mol->getAtomWithIdx(0)));
}
}
TEST_CASE(
"Github #4785: aromatic bonds no longer set aromatic flags on atoms") {
SECTION("basics1") {
auto m = "C1:C:C:C:1"_smiles;
REQUIRE(m);
CHECK(MolToSmiles(*m) == "C1=CC=C1");
}
SECTION("basics2") {
auto m = "C1:C:C:C:C:C:1"_smiles;
REQUIRE(m);
CHECK(MolToSmiles(*m) == "c1ccccc1");
}
SECTION("can still get kekulization errors") {
CHECK_THROWS_AS(SmilesToMol("C1:C:C:C:C:1"), KekulizeException);
}
}
namespace {
void check_dest(RWMol *m1, const ROMol &m2) {
CHECK(m2.getNumAtoms() == 8);
CHECK(m2.getNumBonds() == 7);
for (const auto atom : m2.atoms()) {
CHECK(&atom->getOwningMol() == &m2);
CHECK(&atom->getOwningMol() != m1);
}
for (const auto bond : m2.bonds()) {
CHECK(&bond->getOwningMol() == &m2);
CHECK(&bond->getOwningMol() != m1);
}
CHECK(m2.getStereoGroups().size() == 2);
CHECK(m2.getStereoGroups()[0].getAtoms().size() == 2);
CHECK(m2.getStereoGroups()[0].getAtoms()[0]->getIdx() == 1);
CHECK(m2.getStereoGroups()[0].getAtoms()[1]->getIdx() == 5);
CHECK(m2.getStereoGroups()[1].getAtoms().size() == 1);
CHECK(m2.getStereoGroups()[1].getAtoms()[0]->getIdx() == 3);
const auto &sgs = getSubstanceGroups(m2);
CHECK(sgs.size() == 1);
CHECK(sgs[0].getAtoms().size() == 1);
CHECK(sgs[0].getAtoms()[0] == 4);
// check the state of m1:
CHECK(m1->getNumAtoms() == 0);
CHECK(m1->getNumBonds() == 0);
CHECK(m1->getPropList().empty());
CHECK(m1->getDict().getData().empty());
CHECK(m1->getStereoGroups().empty());
CHECK(getSubstanceGroups(*m1).empty());
CHECK(m1->getRingInfo() == nullptr);
// make sure we can still do something with m1:
*m1 = m2;
CHECK(!m1->getDict().getData().empty());
CHECK(m1->getNumAtoms() == 8);
CHECK(m1->getNumBonds() == 7);
CHECK(m1->getRingInfo() != nullptr);
CHECK(m1->getRingInfo()->isInitialized() ==
m2.getRingInfo()->isInitialized());
}
} // namespace
TEST_CASE("moves") {
auto m1 =
"C[C@H](O)[C@H](F)[C@@H](C)F |o2:1,5,&1:3,SgD:4:atom_data:foo::::|"_smiles;
REQUIRE(m1);
CHECK(m1->getStereoGroups().size() == 2);
m1->setProp("foo", 1u);
SECTION("molecule move") {
ROMol m2 = std::move(*m1);
check_dest(m1.get(), m2);
}
SECTION("molecule move-assign") {
ROMol m2;
m2 = std::move(*m1);
check_dest(m1.get(), m2);
}
}
TEST_CASE("query moves") {
auto m1 =
"C[C@H](O)[C@H](F)[C@@H](C)O |o2:1,5,&1:3,SgD:4:atom_data:foo::::|"_smarts;
REQUIRE(m1);
CHECK(m1->getStereoGroups().size() == 2);
m1->setProp("foo", 1u);
SECTION("molecule move") {
ROMol m2 = std::move(*m1);
check_dest(m1.get(), m2);
}
SECTION("molecule move-assign") {
ROMol m2;
m2 = std::move(*m1);
check_dest(m1.get(), m2);
}
}
TEST_CASE("moves with conformer") {
auto m1 = R"CTAB(
Mrv2108 01192209042D
0 0 0 0 0 999 V3000
M V30 BEGIN CTAB
M V30 COUNTS 8 7 1 0 0
M V30 BEGIN ATOM
M V30 1 C 2.31 4.001 0 0
M V30 2 C 1.54 2.6674 0 0 CFG=2
M V30 3 O -0 2.6674 0 0
M V30 4 C 2.31 1.3337 0 0 CFG=1
M V30 5 F 3.85 1.3337 0 0
M V30 6 C 1.54 0 0 0 CFG=2
M V30 7 F 2.31 -1.3337 0 0
M V30 8 O 0 0 0 0
M V30 END ATOM
M V30 BEGIN BOND
M V30 1 1 2 1
M V30 2 1 2 3 CFG=3
M V30 3 1 4 2
M V30 4 1 4 5 CFG=1
M V30 5 1 4 6
M V30 6 1 6 7
M V30 7 1 6 8 CFG=3
M V30 END BOND
M V30 BEGIN SGROUP
M V30 1 DAT 0 ATOMS=(1 5) FIELDNAME=atom_data -
M V30 FIELDDISP=" 4.6200 0.5637 DA ALL 0 0" FIELDDATA=foo
M V30 END SGROUP
M V30 BEGIN COLLECTION
M V30 MDLV30/STEREL2 ATOMS=(2 2 6)
M V30 MDLV30/STERAC1 ATOMS=(1 4)
M V30 END COLLECTION
M V30 END CTAB
M END
)CTAB"_ctab;
REQUIRE(m1);
CHECK(m1->getStereoGroups().size() == 2);
m1->setProp("foo", 1u);
SECTION("molecule move") {
ROMol m2 = std::move(*m1);
check_dest(m1.get(), m2);
}
SECTION("molecule move-assign") {
ROMol m2;
m2 = std::move(*m1);
check_dest(m1.get(), m2);
}
}
TEST_CASE("Github #5055") {
SECTION("as reported") {
auto m =
"CC1(C)NC(=O)CN2C=C(C[C@H](C(=O)NC)NC(=O)CN3CCN(C(=O)[C@H]4Cc5c([nH]c6ccccc56)CN4C(=O)CN4CN(c5ccccc5)C5(CCN(CC5)C1=O)C4=O)[C@@H](Cc1ccccc1)C3=O)[N-][NH2+]2"_smiles;
REQUIRE(m);
}
}
TEST_CASE("Iterators") {
auto m = "CCCCCCC=N"_smiles;
REQUIRE(m);
SECTION("Atom Iterator") {
auto atoms = m->atoms();
auto n_atom = std::find_if(atoms.begin(), atoms.end(), [](const auto &a) {
return a->getAtomicNum() == 7;
});
REQUIRE(n_atom != atoms.end());
CHECK((*n_atom)->getIdx() == 7);
}
SECTION("Atom Neighbor Iterator") {
auto nbrs = m->atomNeighbors(m->getAtomWithIdx(6));
auto n_atom = std::find_if(nbrs.begin(), nbrs.end(), [](const auto &a) {
return a->getAtomicNum() == 7;
});
REQUIRE(n_atom != nbrs.end());
CHECK((*n_atom)->getIdx() == 7);
}
SECTION("Bond Iterator") {
auto bonds = m->bonds();
auto dbl_bnd = std::find_if(bonds.begin(), bonds.end(), [](const auto &b) {
return b->getBondType() == Bond::DOUBLE;
});
REQUIRE(dbl_bnd != bonds.end());
CHECK((*dbl_bnd)->getIdx() == 6);
}
SECTION("Atom Bond Iterator") {
auto nbr_bonds = m->atomBonds(m->getAtomWithIdx(6));
auto dbl_bnd = std::find_if(
nbr_bonds.begin(), nbr_bonds.end(),
[](const auto &b) { return b->getBondType() == Bond::DOUBLE; });
REQUIRE(dbl_bnd != nbr_bonds.end());
CHECK((*dbl_bnd)->getIdx() == 6);
}
}
TEST_CASE("general hybridization") {
auto m = "CS(=O)(=O)C"_smiles;
REQUIRE(m);
CHECK(m->getAtomWithIdx(0)->getHybridization() ==
Atom::HybridizationType::SP3);
CHECK(m->getAtomWithIdx(1)->getHybridization() ==
Atom::HybridizationType::SP3);
CHECK(m->getAtomWithIdx(4)->getHybridization() ==
Atom::HybridizationType::SP3);
}
TEST_CASE("metal hybridization") {
SECTION("square planar") {
{
auto m = "F[U@SP](F)(F)F"_smiles;
REQUIRE(m);
CHECK(m->getAtomWithIdx(1)->getHybridization() ==
Atom::HybridizationType::SP2D);
}
{
auto m = "F[U@SP](F)F"_smiles;
REQUIRE(m);
CHECK(m->getAtomWithIdx(1)->getHybridization() ==
Atom::HybridizationType::SP2D);
}
{
auto m = "F[U@SP](F)(F)F"_smiles;
REQUIRE(m);
CHECK(m->getAtomWithIdx(1)->getHybridization() ==
Atom::HybridizationType::SP2D);
}
{
auto m = "F[U@TH](F)(F)F"_smiles;
REQUIRE(m);
CHECK(m->getAtomWithIdx(1)->getHybridization() ==
Atom::HybridizationType::SP3);
}
}
SECTION("octahedral") {
{
auto m = "F[S@OH](F)(F)(F)(F)F"_smiles;
REQUIRE(m);
CHECK(m->getAtomWithIdx(1)->getHybridization() ==
Atom::HybridizationType::SP3D2);
}
{
auto m = "F[P@OH](F)(F)(F)F"_smiles;
REQUIRE(m);
CHECK(m->getAtomWithIdx(1)->getHybridization() ==
Atom::HybridizationType::SP3D2);
}
{
auto m = "F[P](F)(F)(F)F"_smiles;
REQUIRE(m);
CHECK(m->getAtomWithIdx(1)->getHybridization() ==
Atom::HybridizationType::SP3D);
}
}
}
TEST_CASE(
"github #5462: Invalid number of radical electrons calculated for [Pr+4]") {
SECTION("as reported") {
auto m = "[Pr+4]"_smiles;
REQUIRE(m);
CHECK(m->getAtomWithIdx(0)->getNumRadicalElectrons() == 0);
}
SECTION("also reported") {
auto m = "[U+5]"_smiles;
REQUIRE(m);
CHECK(m->getAtomWithIdx(0)->getNumRadicalElectrons() == 0);
}
SECTION("extreme") {
auto m = "[Fe+30]"_smiles;
REQUIRE(m);
CHECK(m->getAtomWithIdx(0)->getNumRadicalElectrons() == 0);
}
}
TEST_CASE(
"github #5505: Running kekulization on mols with query bonds will either fail or return incorrect results") {
SECTION("as reported") {
auto m = "[#6]-c1cccc(-[#6])c1"_smarts;
REQUIRE(m);
REQUIRE(m->getBondWithIdx(2)->hasQuery());
REQUIRE(m->getBondWithIdx(2)->getBondType() == Bond::BondType::AROMATIC);
MolOps::Kekulize(*m);
REQUIRE(m->getBondWithIdx(2)->hasQuery());
REQUIRE(m->getBondWithIdx(2)->getBondType() == Bond::BondType::AROMATIC);
}
SECTION("partial kekulization works") {
auto m1 = "c1ccccc1"_smiles;
REQUIRE(m1);
auto m2 = "c1ccccc1"_smarts;
REQUIRE(m2);
m1->insertMol(*m2);
MolOps::findSSSR(*m1);
REQUIRE(!m1->getBondWithIdx(1)->hasQuery());
REQUIRE(m1->getBondWithIdx(1)->getBondType() == Bond::BondType::AROMATIC);
REQUIRE(m1->getBondWithIdx(6)->hasQuery());
REQUIRE(m1->getBondWithIdx(6)->getBondType() == Bond::BondType::AROMATIC);
MolOps::Kekulize(*m1);
REQUIRE(!m1->getBondWithIdx(1)->hasQuery());
REQUIRE(m1->getBondWithIdx(1)->getBondType() != Bond::BondType::AROMATIC);
REQUIRE(m1->getBondWithIdx(6)->hasQuery());
REQUIRE(m1->getBondWithIdx(6)->getBondType() == Bond::BondType::AROMATIC);
}
SECTION("kekulization with non-bond-type queries works") {
auto m1 = "c1ccccc1"_smiles;
REQUIRE(m1);
QueryBond qbond;
qbond.setBondType(Bond::BondType::AROMATIC);
qbond.setIsAromatic(true);
qbond.setQuery(makeBondIsInRingQuery());
m1->replaceBond(0, &qbond);
REQUIRE(m1->getBondWithIdx(0)->hasQuery());
REQUIRE(m1->getBondWithIdx(0)->getBondType() == Bond::BondType::AROMATIC);
MolOps::Kekulize(*m1);
REQUIRE(m1->getBondWithIdx(0)->hasQuery());
REQUIRE(m1->getBondWithIdx(0)->getBondType() != Bond::BondType::AROMATIC);
}
SECTION("make sure single-atom molecules and mols without rings still fail") {
std::vector<std::string> expectedFailures = {"p", "c:c"};
for (const auto &smi : expectedFailures) {
INFO(smi);
CHECK_THROWS_AS(SmilesToMol(smi), MolSanitizeException);
}
}
}
TEST_CASE("extended valences for alkali earths") {
SECTION("valence of 2") {
// make sure the valence of two works
std::vector<std::pair<std::string, unsigned int>> cases{
{"C[Be]", 1}, {"C[Mg]", 1}, {"C[Ca]", 1}, {"C[Sr]", 1},
{"C[Ba]", 1}, {"C[Ra]", 1}, {"C[Be]C", 0}, {"C[Mg]C", 0},
{"C[Ca]C", 0}, {"C[Sr]C", 0}, {"C[Ba]C", 0}, {"C[Ra]C", 0}};
for (const auto &pr : cases) {
INFO(pr.first);
std::unique_ptr<RWMol> m{SmilesToMol(pr.first)};
REQUIRE(m);
m->getAtomWithIdx(1)->setNoImplicit(false);
m->getAtomWithIdx(1)->setNumRadicalElectrons(0);
MolOps::sanitizeMol(*m);
CHECK(m->getAtomWithIdx(1)->getTotalNumHs() == pr.second);
}
}
SECTION("higher valence") {
// make sure the valence of two works
std::vector<std::pair<std::string, unsigned int>> cases{{"C[Mg](C)C", 0},
{"C[Ca](C)C", 0},
{"C[Sr](C)C", 0},
{"C[Ba](C)C", 0},
{"C[Ra](C)C", 0}};
for (const auto &pr : cases) {
INFO(pr.first);
std::unique_ptr<RWMol> m{SmilesToMol(pr.first)};
REQUIRE(m);
m->getAtomWithIdx(1)->setNoImplicit(false);
m->getAtomWithIdx(1)->setNumRadicalElectrons(0);
MolOps::sanitizeMol(*m);
CHECK(m->getAtomWithIdx(1)->getTotalNumHs() == pr.second);
}
}
SECTION("everybody loves grignards") {
auto m = "CC(C)O[Mg](Cl)(<-O1CCCC1)<-O1CCCC1"_smiles;
REQUIRE(m);
}
}
TEST_CASE("Github #5849: aromatic tag allows bad valences to pass") {
SECTION("basics") {
std::vector<std::string> smis = {
"Cc1(C)=NCCCC1", // one bogus aromatic atom
};
for (const auto &smi : smis) {
INFO(smi);
CHECK_THROWS_AS(SmilesToMol(smi), AtomValenceException);
}
}
SECTION("as reported") {
std::vector<std::string> smis = {
"c1c(ccc2NC(CN=c(c21)(C)C)=O)O",
"c1c(c2n(C(NC(Oc2cc1)C)c1c[nH]cn1)=O)O",
"c1c2C(c4c(cc(c(C(=O)O)c4)O)O)Oc(c2c(c(O)c1O)O)(=O)O",
"c12C(CN(C)C)CCCCN=c(c2cc2c1cc[nH]c2)(C)C"};
for (const auto &smi : smis) {
INFO(smi);
CHECK_THROWS_AS(SmilesToMol(smi), MolSanitizeException);
}
}
SECTION("edge cases atoms") {
std::vector<std::string> smis = {
"c1c(ccc2NC(CN=c(c21)=C)=O)O", // exocyclic double bond
"c1c(ccc2NC(Cn=c(c21)(C)C)=O)O", // even more bogus aromatic atoms
"c1c(ccc2NC(CN=c(c21)(:c)C)=O)O", // even more bogus aromatic atoms
};
for (const auto &smi : smis) {
INFO(smi);
CHECK_THROWS_AS(SmilesToMol(smi), AtomValenceException);
}
}
SECTION("edge cases kekulization") {
std::vector<std::string> smis = {
"c12ccccc1=NCCC2", // adjacent to an actual aromatic ring
"Cc1(C)=NCCCc1", // two bogus aromatic atoms
"Cc1(C)nCCCC=1", // two bogus aromatic atoms
"Cc1(C)nCCCc1", // three bogus aromatic atoms
"Cc:1(C):nCCCc:1", // three bogus aromatic atoms
};
for (const auto &smi : smis) {
INFO(smi);
CHECK_THROWS_AS(SmilesToMol(smi), KekulizeException);
}
}
}
TEST_CASE("Stop caching ring finding results") {
SECTION("basics") {
auto m = "C1C2CC1CCC2"_smiles;
REQUIRE(m);
// symmetrized result
CHECK(m->getRingInfo()->numRings() == 3);
auto rcount = MolOps::findSSSR(*m);
CHECK(rcount == 2);
CHECK(m->getRingInfo()->numRings() == 2);
rcount = MolOps::symmetrizeSSSR(*m);
CHECK(rcount == 3);
CHECK(m->getRingInfo()->numRings() == 3);
MolOps::fastFindRings(*m);
CHECK(m->getRingInfo()->numRings() == 2);
}
}
TEST_CASE("molecules with more than 255 rings produce a bad pickle") {
std::string pathName = getenv("RDBASE");
pathName += "/Code/GraphMol/test_data/";
bool sanitize = false;
std::unique_ptr<RWMol> mol(
MolFileToMol(pathName + "mol_with_pickle_error.mol", sanitize));
REQUIRE(mol);
mol->updatePropertyCache(false);
unsigned int opThatFailed = 0;
MolOps::sanitizeMol(*mol, opThatFailed,
MolOps::SanitizeFlags::SANITIZE_ALL ^
MolOps::SanitizeFlags::SANITIZE_PROPERTIES ^
MolOps::SANITIZE_KEKULIZE);
CHECK(mol->getRingInfo()->numRings() > 300);
std::string pkl;
MolPickler::pickleMol(*mol, pkl);
RWMol nMol(pkl);
CHECK(nMol.getRingInfo()->numRings() == mol->getRingInfo()->numRings());
}
TEST_CASE("molecules with single bond to metal atom use dative instead") {
// Change heme coordination from single bond to dative.
// Test mols are CHEBI:26355, CHEBI:60344, CHEBI:17627. 26355 should be
// changed (Github 6019) the other two should not be.
// Counting from 1, 4th mol is one that gave other problems during testing.
std::vector<std::pair<std::string, std::string>> test_vals{
{"CC1=C(CCC(O)=O)C2=[N]3C1=Cc1c(C)c(C=C)c4C=C5C(C)=C(C=C)C6=[N]5[Fe]3(n14)n1c(=C6)c(C)c(CCC(O)=O)c1=C2",
"C=CC1=C(C)C2=Cc3c(C=C)c(C)c4n3[Fe]35<-N2=C1C=c1c(C)c(CCC(=O)O)c(n13)=CC1=N->5C(=C4)C(C)=C1CCC(=O)O"},
{"CC1=C(CCC([O-])=O)C2=[N+]3C1=Cc1c(C)c(C=C)c4C=C5C(C)=C(C=C)C6=[N+]5[Fe--]3(n14)n1c(=C6)c(C)c(CCC([O-])=O)c1=C2",
"C=CC1=C(C)C2=Cc3c(C=C)c(C)c4n3[Fe-2]35n6c(c(C)c(CCC(=O)[O-])c6=CC6=[N+]3C(=C4)C(C)=C6CCC(=O)[O-])=CC1=[N+]25"},
{"CC1=C(CCC(O)=O)C2=[N+]3C1=Cc1c(C)c(C=C)c4C=C5C(C)=C(C=C)C6=[N+]5[Fe--]3(n14)n1c(=C6)c(C)c(CCC(O)=O)c1=C2",
"C=CC1=C(C)C2=Cc3c(C=C)c(C)c4n3[Fe-2]35n6c(c(C)c(CCC(=O)O)c6=CC6=[N+]3C(=C4)C(C)=C6CCC(=O)O)=CC1=[N+]25"},
{"CCC1=[O+][Cu]2([O+]=C(CC)C1)[O+]=C(CC)CC(CC)=[O+]2",
"CCC1=[O+][Cu]2([O+]=C(CC)C1)[O+]=C(CC)CC(CC)=[O+]2"}};
for (size_t i = 0; i < test_vals.size(); ++i) {
INFO(test_vals[i].first);
RWMOL_SPTR m(RDKit::SmilesToMol(test_vals[i].first));
CHECK(MolToSmiles(*m) == test_vals[i].second);
}
// make sure we can call cleanupOrganometallics() on non-sanitized molecules
for (size_t i = 0; i < test_vals.size(); ++i) {
INFO(test_vals[i].first);
bool sanitize = false;
RWMOL_SPTR m(RDKit::SmilesToMol(test_vals[i].first, 0, sanitize));
MolOps::cleanUpOrganometallics(*m);
CHECK(MolToSmiles(*m) == test_vals[i].second);
}
}
TEST_CASE(
"cleanUpOrganometallics should produce canonical output. cf PR6292") {
std::vector<std::pair<std::string, std::string>> test_vals{
{"F[Pd](Cl)(Cl1)Cl[Pd]1(Cl)Cl", "F[Pd]1(Cl)<-Cl[Pd](Cl)(Cl)<-Cl1"},
{"F[Pt]1(F)[35Cl][Pt]([Cl]1)(F)Br", "F[Pt]1(Br)<-Cl[Pt](F)(F)<-[35Cl]1"},
};
for (size_t j = 0; j < test_vals.size(); ++j) {
std::string &smi = test_vals[j].first;
std::string &canon_smi = test_vals[j].second;
RWMOL_SPTR m(RDKit::SmilesToMol(smi));
CHECK(MolToSmiles(*m) == canon_smi);
// scramble the order and check
std::vector<unsigned int> atomInds(m->getNumAtoms(), 0);
std::iota(atomInds.begin(), atomInds.end(), 0);
std::random_device rd;
std::mt19937 g(rd());
for (int i = 0; i < 100; ++i) {
SmilesParserParams ps;
ps.sanitize = false;
std::unique_ptr<ROMol> mol(RDKit::SmilesToMol(smi, ps));
std::shuffle(atomInds.begin(), atomInds.end(), g);
std::unique_ptr<ROMol> randmol(MolOps::renumberAtoms(*mol, atomInds));
std::unique_ptr<RWMol> rwrandmol(new RWMol(*randmol));
MolOps::sanitizeMol(*rwrandmol);
CHECK(MolToSmiles(*rwrandmol) == canon_smi);
}
}
}
TEST_CASE("github #6100: bonds to dummy atoms considered as dative") {
SECTION("as reported") {
auto m = "C[O](C)*"_smiles;
REQUIRE(!m);
}
}
TEST_CASE("github #4642: Enhanced Stereo is lost when using GetMolFrags") {
SECTION("as reported") {
auto m = "CCCC.C[C@H](F)C[C@H](O)Cl |o1:5,o2:8|"_smiles;
REQUIRE(m);
auto frags = MolOps::getMolFrags(*m);
REQUIRE(frags.size() == 2);
CHECK(frags[0]->getStereoGroups().empty());
CHECK(frags[1]->getStereoGroups().size() == 2);
}
SECTION("each fragment has groups") {
auto m = "CC[C@@H](C)O.C[C@H](F)C[C@H](O)Cl |o1:6,o2:9,o3:2|"_smiles;
REQUIRE(m);
auto frags = MolOps::getMolFrags(*m);
REQUIRE(frags.size() == 2);
CHECK(frags[0]->getStereoGroups().size() == 1);
CHECK(frags[1]->getStereoGroups().size() == 2);
}
SECTION("group split between fragments") {
auto m = "CC[C@@H](C)O.C[C@H](F)C[C@H](O)Cl |o1:2,6,o2:9|"_smiles;
REQUIRE(m);
auto frags = MolOps::getMolFrags(*m);
REQUIRE(frags.size() == 2);
CHECK(frags[0]->getStereoGroups().size() == 1);
CHECK(frags[1]->getStereoGroups().size() == 2);
CHECK(frags[0]->getAtomWithIdx(2)->getChiralTag() !=
Atom::ChiralType::CHI_UNSPECIFIED);
CHECK(frags[1]->getAtomWithIdx(1)->getChiralTag() !=
Atom::ChiralType::CHI_UNSPECIFIED);
CHECK(frags[1]->getAtomWithIdx(4)->getChiralTag() !=
Atom::ChiralType::CHI_UNSPECIFIED);
}
}
TEST_CASE(
"Github #6119: No warning when merging explicit H query atoms with no bonds",
"[bug][molops]") {
SECTION("Zero degree AtomOr Query") {
std::unique_ptr<RWMol> m{SmartsToMol("[#6,#1]")};
REQUIRE(m);
std::stringstream ss;
rdWarningLog->SetTee(ss);
MolOps::mergeQueryHs(*m);
rdWarningLog->ClearTee();
CHECK(
ss.str().find(
"WARNING: merging explicit H queries involved in ORs is not supported. "
"This query will not be merged") != std::string::npos);
}
SECTION("One degree AtomOr Query") {
std::unique_ptr<RWMol> m{SmartsToMol("C[#6,#1]")};
REQUIRE(m);
std::stringstream ss;
rdWarningLog->SetTee(ss);
MolOps::mergeQueryHs(*m);
rdWarningLog->ClearTee();
CHECK(
ss.str().find(
"WARNING: merging explicit H queries involved in ORs is not supported. "
"This query will not be merged") != std::string::npos);
}
SECTION("Atoms that are not H") {
std::unique_ptr<RWMol> m{SmartsToMol("C[#6,#7]")};
REQUIRE(m);
std::stringstream ss;
rdWarningLog->SetTee(ss);
MolOps::mergeQueryHs(*m);
rdWarningLog->ClearTee();
CHECK(
ss.str().find(
"WARNING: merging explicit H queries involved in ORs is not supported. "
"This query will not be merged") == std::string::npos);
}
}
TEST_CASE("Remove atom updates bond ENDPTS prop") {
auto m = R"CTAB(ferrocene-ish
RDKit 2D
0 0 0 0 0 0 0 0 0 0999 V3000
M V30 BEGIN CTAB
M V30 COUNTS 15 14 0 0 0
M V30 BEGIN ATOM
M V30 1 C 0.619616 1.206807 0.000000 0 CHG=-1
M V30 2 C 0.211483 1.768553 0.000000 0
M V30 3 C -1.283936 1.861329 0.000000 0
M V30 4 C -1.796429 1.358429 0.000000 0
M V30 5 C -0.634726 0.966480 0.000000 0
M V30 6 C 0.654379 -1.415344 0.000000 0 CHG=-1
M V30 7 C 0.249886 -0.858607 0.000000 0
M V30 8 C -1.232145 -0.766661 0.000000 0
M V30 9 C -1.740121 -1.265073 0.000000 0
M V30 10 C -0.580425 -1.662922 0.000000 0
M V30 11 C 1.759743 0.755930 0.000000 0
M V30 12 C 1.796429 -1.861329 0.000000 0
M V30 13 Fe -0.554442 0.032137 0.000000 0 VAL=2
M V30 14 * -0.601210 1.478619 0.000000 0
M V30 15 * -0.537835 -1.172363 0.000000 0
M V30 END ATOM
M V30 BEGIN BOND
M V30 1 1 1 5
M V30 2 2 4 5
M V30 3 1 4 3
M V30 4 2 2 3
M V30 5 1 1 2
M V30 6 1 6 10
M V30 7 2 9 10
M V30 8 1 9 8
M V30 9 2 7 8
M V30 10 1 6 7
M V30 11 1 1 11
M V30 12 1 6 12
M V30 13 9 14 13 ENDPTS=(5 1 2 3 4 5) ATTACH=ANY
M V30 14 9 15 13 ENDPTS=(5 9 10 7 8 6) ATTACH=ANY
M V30 END BOND
M V30 END CTAB
M END
)CTAB"_ctab;
REQUIRE(m);
std::string sprop;
auto bond = m->getBondWithIdx(12U);
CHECK(bond->getPropIfPresent(RDKit::common_properties::_MolFileBondEndPts,
sprop));
CHECK(std::string("(5 1 2 3 4 5)") == sprop);
m->removeAtom(2U);
bond = m->getBondWithIdx(10U);
CHECK(bond->getPropIfPresent(RDKit::common_properties::_MolFileBondEndPts,
sprop));
CHECK(std::string("(4 1 2 3 4)") == sprop);
m->removeAtom(0U);
m->removeAtom(0U);
m->removeAtom(0U);
m->removeAtom(0U);
CHECK(!bond->getPropIfPresent(RDKit::common_properties::_MolFileBondEndPts,
sprop));
CHECK(!bond->getPropIfPresent(RDKit::common_properties::_MolFileBondAttach,
sprop));
// the original bond should now have index 6
CHECK(bond->getIdx() == 6);
// the other dative bond is now attached to different atom indices
bond = m->getBondWithIdx(7U);
CHECK(bond->getPropIfPresent(RDKit::common_properties::_MolFileBondEndPts,
sprop));
CHECK(std::string("(5 4 5 2 3 1)") == sprop);
// remove atom 5 (6 in the file - the final methyl off the first
// methyl-cyclopentadiene ring
m->removeAtom(5U);
CHECK(bond->getPropIfPresent(RDKit::common_properties::_MolFileBondEndPts,
sprop));
CHECK(std::string("(5 4 5 2 3 1)") == sprop);
}
TEST_CASE("github #6237: Correctly placing hydrogens based on Chiral Tag") {
SECTION("Clockwise") { // Chiral Tag (CW) Agrees with CIPCode ('R')
std::string mb = R"CTAB(testmol
CT1066645023
5 4 0 0 1 0 0 0 0 0999 V2000
0.0021 -0.0041 0.0020 Br 0 0 0 0 0 0 0 0 0 0 0 0
1.6669 2.5858 0.0000 Cl 0 0 0 0 0 0 0 0 0 0 0 0
-0.7012 2.4252 -1.1206 F 0 0 0 0 0 0 0 0 0 0 0 0
-0.0246 1.9617 0.0128 C 0 0 0 0 0 0 0 0 0 0 0 0
-0.5348 2.3132 0.9096 H 0 0 0 0 0 0 0 0 0 0 0 0
1 4 1 0 0 0 0
2 4 1 0 0 0 0
3 4 1 0 0 0 0
4 5 1 0 0 0 0
M END
)CTAB";
std::unique_ptr<ROMol> mol(MolBlockToMol(mb));
REQUIRE(mol);
bool explicitOnly = false;
bool addCoords = true;
std::unique_ptr<ROMol> m{MolOps::addHs(*mol, explicitOnly, addCoords)};
REQUIRE(m->getNumAtoms() == 5);
const auto &conf = m->getConformer();
// Hydrogen will always be in the last position
const RDGeom::Point3D HPos = conf.getAtomPos(4);
// Ensure the hydrogen is placed on the same side of the carbon as it was
// originally.
const RDGeom::Point3D targetPos = RDGeom::Point3D(-.5384, 2.3132, 0.9096);
const auto distToTarget = HPos - targetPos;
CHECK(distToTarget.lengthSq() < 0.1);
}
SECTION("Counterclockwise") { // Chiral Tag (CCW) Different from CIPCode (R)
// due to different ordering of atoms
std::string mb = R"CTAB(testmol
CT1066645023
5 4 0 0 1 0 0 0 0 0999 V2000
1.6669 2.5858 0.0000 Cl 0 0 0 0 0 0 0 0 0 0 0 0
0.0021 -0.0041 0.0020 Br 0 0 0 0 0 0 0 0 0 0 0 0
-0.5348 2.3132 0.9096 H 0 0 0 0 0 0 0 0 0 0 0 0
-0.0246 1.9617 0.0128 C 0 0 0 0 0 0 0 0 0 0 0 0
-0.7012 2.4252 -1.1206 F 0 0 0 0 0 0 0 0 0 0 0 0
1 4 1 0 0 0 0
2 4 1 0 0 0 0
3 4 1 0 0 0 0
4 5 1 0 0 0 0
M END
)CTAB";
std::unique_ptr<ROMol> mol(MolBlockToMol(mb));
REQUIRE(mol);
bool explicitOnly = false;
bool addCoords = true;
std::unique_ptr<ROMol> m{MolOps::addHs(*mol, explicitOnly, addCoords)};
REQUIRE(m->getNumAtoms() == 5);
const auto &conf = m->getConformer();
// Hydrogen will always be in the last position
const RDGeom::Point3D HPos = conf.getAtomPos(4);
// Ensure the hydrogen is placed on the same side of the carbon as it was
// originally.
const RDGeom::Point3D targetPos = RDGeom::Point3D(-.5384, 2.3132, 0.9096);
const auto distToTarget = HPos - targetPos;
CHECK(distToTarget.lengthSq() < 0.1);
}
}
TEST_CASE(
"GitHub Issue #6437 Removing Hs on a pyrrol-like structure throws kekulization error",
"[bug][molops][removeHs]") {
auto run_test = [](const std::string &mb,
const std::string &reference_smiles) {
bool sanitize = true; // aromatization is key in triggering the issue
bool removeHs = false;
std::unique_ptr<RWMol> mol(MolBlockToMol(mb, sanitize, removeHs));
REQUIRE(mol);
MolOps::removeHs(*mol);
REQUIRE_NOTHROW(MolOps::Kekulize(*mol));
MolOps::sanitizeMol(*mol);
auto smiles = MolToSmiles(*mol);
CHECK(smiles == reference_smiles);
REQUIRE_NOTHROW(mol.reset(SmilesToMol(smiles)));
};
SECTION("original issue") {
const std::string mb = R"CTAB(
RDKit 3D
0 0 0 0 0 0 0 0 0 0999 V3000
M V30 BEGIN CTAB
M V30 COUNTS 21 23 0 0 1
M V30 BEGIN ATOM
M V30 1 C -2.860897 0.790642 -0.873026 0 CHG=-1
M V30 2 C -2.892815 1.449062 0.345481 0
M V30 3 N -1.696600 1.269967 0.996982 0 CHG=1
M V30 4 C -0.879551 0.492797 0.203823 0
M V30 5 C -1.573299 0.166246 -0.987870 0
M V30 6 C 0.442583 0.044533 0.450671 0
M V30 7 C 1.074625 -0.756491 -0.540699 0
M V30 8 C 0.374093 -1.078083 -1.728707 0
M V30 9 C -0.929617 -0.625959 -1.953003 0
M V30 10 C 2.393185 -1.188970 -0.266871 0
M V30 11 N 3.077189 -0.890802 0.863186 0
M V30 12 C 2.450112 -0.125881 1.790360 0
M V30 13 C 1.151414 0.363643 1.640805 0
M V30 14 H -3.670927 0.767620 -1.587024 0
M V30 15 H -3.671872 2.035677 0.809804 0
M V30 16 H 0.862037 -1.686990 -2.476160 0
M V30 17 H -1.436100 -0.889168 -2.869956 0
M V30 18 H 2.914471 -1.799551 -0.989817 0
M V30 19 H 3.016681 0.097751 2.682259 0
M V30 20 H 0.694206 0.970092 2.408942 0
M V30 21 H -1.498216 1.663637 1.905533 0
M V30 END ATOM
M V30 BEGIN BOND
M V30 1 1 2 1
M V30 2 2 3 2
M V30 3 1 4 3
M V30 4 1 5 1
M V30 5 2 5 4
M V30 6 1 6 4
M V30 7 2 7 6
M V30 8 1 8 7
M V30 9 1 9 5
M V30 10 2 9 8
M V30 11 1 10 7
M V30 12 2 11 10
M V30 13 1 12 11
M V30 14 1 13 6
M V30 15 2 13 12
M V30 16 1 14 1
M V30 17 1 15 2
M V30 18 1 16 8
M V30 19 1 17 9
M V30 20 1 18 10
M V30 21 1 19 12
M V30 22 1 20 13
M V30 23 1 21 3
M V30 END BOND
M V30 END CTAB
M END
)CTAB";
const std::string reference_smiles = "c1cc2c(ccc3[cH-]c[nH+]c32)cn1";
run_test(mb, reference_smiles);
}
SECTION("pyrrole") {
const std::string mb = R"CTAB(
RDKit 3D
0 0 0 0 0 0 0 0 0 0999 V3000
M V30 BEGIN CTAB
M V30 COUNTS 10 10 0 0 1
M V30 BEGIN ATOM
M V30 1 C 3.080550 -0.830350 2.955935 0
M V30 2 C 1.665136 -0.838141 2.947220 0
M V30 3 C 1.247504 0.474081 2.948961 0
M V30 4 N 2.361202 1.272855 2.958419 0
M V30 5 C 3.483658 0.486391 2.962730 0
M V30 6 H 2.355611 2.284759 2.961704 0
M V30 7 H 1.020283 -1.707337 2.940409 0
M V30 8 H 0.256169 0.906820 2.944294 0
M V30 9 H 3.734967 -1.692394 2.957125 0
M V30 10 H 4.470152 0.930015 2.970242 0
M V30 END ATOM
M V30 BEGIN BOND
M V30 1 1 2 1
M V30 2 2 3 2
M V30 3 1 4 3
M V30 4 2 5 1
M V30 5 1 5 4
M V30 6 1 6 4
M V30 7 1 7 2
M V30 8 1 8 3
M V30 9 1 9 1
M V30 10 1 10 5
M V30 END BOND
M V30 END CTAB
M END
)CTAB";
const std::string reference_smiles = "c1cc[nH]c1";
run_test(mb, reference_smiles);
}
SECTION("pseudo-pyrrole") {
const std::string mb = R"CTAB(
RDKit 3D
0 0 0 0 0 0 0 0 0 0999 V3000
M V30 BEGIN CTAB
M V30 COUNTS 10 10 0 0 1
M V30 BEGIN ATOM
M V30 1 C 3.080550 -0.830350 2.955935 0
M V30 2 C 1.665136 -0.838141 2.947220 0
M V30 3 C 1.247504 0.474081 2.948961 0
M V30 4 C 2.361202 1.272855 2.958419 0 CHG=-1
M V30 5 C 3.483658 0.486391 2.962730 0
M V30 6 H 2.355611 2.284759 2.961704 0
M V30 7 H 1.020283 -1.707337 2.940409 0
M V30 8 H 0.256169 0.906820 2.944294 0
M V30 9 H 3.734967 -1.692394 2.957125 0
M V30 10 H 4.470152 0.930015 2.970242 0
M V30 END ATOM
M V30 BEGIN BOND
M V30 1 1 2 1
M V30 2 2 3 2
M V30 3 1 4 3
M V30 4 2 5 1
M V30 5 1 5 4
M V30 6 1 6 4
M V30 7 1 7 2
M V30 8 1 8 3
M V30 9 1 9 1
M V30 10 1 10 5
M V30 END BOND
M V30 END CTAB
M END
)CTAB";
const std::string reference_smiles = "c1cc[cH-]c1";
run_test(mb, reference_smiles);
}
}
TEST_CASE(
"GitHub Issue #6681: ROMol move constructor and assignment do not update SubstanceGroup ownership",
"[bug]") {
auto m = "CCCCCC[NH3+] |SgD:6:lambda max:230:=:nm::|"_smiles;
REQUIRE(m);
REQUIRE(m->getNumAtoms() == 7);
REQUIRE(getSubstanceGroups(*m).size() == 1);
SECTION("ROMol move constructor") {
ROMol mol(std::move(*m));
REQUIRE(mol.getNumAtoms() == 7);
auto sgs = getSubstanceGroups(mol);
REQUIRE(sgs.size() == 1);
CHECK(&sgs[0].getOwningMol() == &mol);
}
SECTION("ROMol move assignment") {
ROMol mol;
mol = std::move(*m);
REQUIRE(mol.getNumAtoms() == 7);
auto sgs = getSubstanceGroups(mol);
REQUIRE(sgs.size() == 1);
CHECK(&sgs[0].getOwningMol() == &mol);
}
}
TEST_CASE("ROMol hasQuery") {
SECTION("check false Mol.hasQuery") {
std::unique_ptr<ROMol> mol{SmilesToMol("CCO")};
REQUIRE(!mol->hasQuery());
}
SECTION("check true Mol.hasQuery because Atom") {
std::unique_ptr<ROMol> mol{SmartsToMol("[#6][#6][#8]")};
REQUIRE(mol->hasQuery());
}
SECTION("check true Mol.hashQuery because Bond") {
std::unique_ptr<ROMol> mol{SmilesToMol("CC~O")};
REQUIRE(mol->hasQuery());
}
}
TEST_CASE(
"Github Issue #6944: With new stereo, removing H from an Imine double bond does not remove bond stereo",
"[bug][molops]") {
// This issue only happens with the new stereo perception,
// since the legacy one does not support stereo on imine bonds
UseLegacyStereoPerceptionFixture use_new_stereo_perception{false};
auto m = "[H]/N=C(/C)O"_smiles;
REQUIRE(m);
REQUIRE(m->getNumAtoms() == 5);
auto bnd = m->getBondWithIdx(1);
REQUIRE(bnd->getBondType() == Bond::BondType::DOUBLE);
REQUIRE(bnd->getStereo() == Bond::BondStereo::STEREOTRANS);
REQUIRE(bnd->getStereoAtoms().size() == 2);
MolOps::removeAllHs(*m);
REQUIRE(m->getNumAtoms() == 4);
bnd = m->getBondWithIdx(0);
REQUIRE(bnd->getBondType() == Bond::BondType::DOUBLE);
CHECK(bnd->getStereo() == Bond::BondStereo::STEREONONE);
CHECK(bnd->getStereoAtoms().empty());
}
TEST_CASE(
"github #7044: canonicalization error when allenes have specified stereo") {
SECTION("basics") {
auto m = "CC=C=CC"_smiles;
REQUIRE(m);
m->getBondWithIdx(2)->setStereoAtoms(1, 4);
m->getBondWithIdx(2)->setStereo(Bond::STEREOCIS);
auto smi = MolToSmiles(*m);
CHECK(smi == "CC=C=CC");
}
}
TEST_CASE(
"Github Issue #7128: ReplaceBond may cause valence issues in specific edge cases",
"[bug][RWMol]") {
auto m = R"CTAB(
RDKit 2D
0 0 0 0 0 0 0 0 0 0999 V3000
M V30 BEGIN CTAB
M V30 COUNTS 4 3 0 0 0
M V30 BEGIN ATOM
M V30 1 C 1.787879 0.909091 0.000000 0
M V30 2 C 3.287879 0.909091 0.000000 0
M V30 3 N 1.037879 2.208129 0.000000 0
M V30 4 O 1.037879 -0.389947 0.000000 0
M V30 END ATOM
M V30 BEGIN BOND
M V30 1 1 1 2 CFG=3
M V30 2 1 1 3
M V30 3 1 1 4
M V30 END BOND
M V30 END CTAB
M END
$$$$
)CTAB"_ctab;
REQUIRE(m);
// This bond was a dashed bond (dash is removed when parity is resolved)
auto bond = m->getBondWithIdx(0);
int bond_dir = 0;
REQUIRE(bond->getPropIfPresent("_MolFileBondCfg", bond_dir) == true);
REQUIRE(bond_dir == 3); // dashed bond
auto begin_atom = bond->getBeginAtom();
REQUIRE(begin_atom->getNumExplicitHs() == 1);
REQUIRE(begin_atom->getTotalValence() == 4);
auto end_atom = bond->getEndAtom();
REQUIRE(end_atom->getNumExplicitHs() == 0);
REQUIRE(end_atom->getTotalValence() == 4);
bool strict_valences = false;
SECTION("replace with a double bond") {
auto b = Bond(Bond::BondType::DOUBLE);
m->replaceBond(1, &b);
m->updatePropertyCache(strict_valences);
CHECK(begin_atom->getNumExplicitHs() == 0);
CHECK(begin_atom->getTotalValence() == 4);
CHECK(end_atom->getNumExplicitHs() == 0);
CHECK(end_atom->getTotalValence() == 4);
}
SECTION("replace with a triple bond") {
auto b = Bond(Bond::BondType::TRIPLE);
m->replaceBond(1, &b);
m->updatePropertyCache(strict_valences);
CHECK(begin_atom->getNumExplicitHs() == 0);
CHECK(begin_atom->getTotalValence() == 5); // Yeah, this is expected
CHECK(end_atom->getNumExplicitHs() == 0);
CHECK(end_atom->getTotalValence() == 4);
}
SECTION("replace with a dative bond") {
auto b = Bond(Bond::BondType::DATIVE);
m->replaceBond(1, &b);
m->updatePropertyCache(strict_valences);
CHECK(begin_atom->getNumExplicitHs() == 1);
CHECK(begin_atom->getTotalValence() == 4);
CHECK(end_atom->getNumExplicitHs() == 0);
CHECK(end_atom->getTotalValence() == 4);
}
}
TEST_CASE(
"GitHub Issue #7131: Adding Wedge/Dash bond neighboring a stereo double bond causes a Precondition Violation",
"[stereochemistry][bug]") {
auto m = R"CTAB(
RDKit 2D
0 0 0 0 0 0 0 0 0 0999 V3000
M V30 BEGIN CTAB
M V30 COUNTS 6 5 0 0 0
M V30 BEGIN ATOM
M V30 1 C -6.942857 2.885714 0.000000 0
M V30 2 C -5.705678 2.171429 0.000000 0
M V30 3 C -5.705678 0.742857 0.000000 0
M V30 4 C -4.468499 0.028571 0.000000 0
M V30 5 N -4.468499 2.885714 0.000000 0
M V30 6 N -6.942857 0.028571 0.000000 0
M V30 END ATOM
M V30 BEGIN BOND
M V30 1 1 1 2
M V30 2 2 2 3
M V30 3 1 3 4
M V30 4 1 2 5
M V30 5 1 3 6
M V30 END BOND
M V30 END CTAB
M END
$$$$)CTAB"_ctab;
REQUIRE(m);
auto b = m->getBondWithIdx(0);
b->setBondDir(Bond::BondDir::BEGINDASH);
MolOps::setDoubleBondNeighborDirections(*m);
CHECK(b->getBondDir() == Bond::BondDir::BEGINDASH);
}
TEST_CASE("expand and remove AttachmentPoints") {
SECTION("basics") {
auto m = "CO"_smiles;
REQUIRE(m);
CHECK(m->getNumAtoms() == 2);
for (bool asQueries : {true, false}) {
for (int val : {1, 2}) {
INFO(val);
RWMol mcp(*m);
mcp.getAtomWithIdx(1)->setProp(common_properties::molAttachPoint, val);
MolOps::expandAttachmentPoints(mcp, asQueries);
CHECK(mcp.getNumAtoms() == 3);
CHECK(
!mcp.getAtomWithIdx(1)->hasProp(common_properties::molAttachPoint));
int value = 0;
CHECK(mcp.getAtomWithIdx(2)->getPropIfPresent(
common_properties::_fromAttachPoint, value));
CHECK(value == val);
CHECK(mcp.getAtomWithIdx(2)->getAtomicNum() == 0);
CHECK(mcp.getAtomWithIdx(2)->hasQuery() == asQueries);
CHECK(MolOps::details::isAttachmentPoint(mcp.getAtomWithIdx(2)));
MolOps::collapseAttachmentPoints(mcp);
CHECK(mcp.getNumAtoms() == 2);
}
{
int val = -1;
INFO(val);
RWMol mcp(*m);
mcp.getAtomWithIdx(1)->setProp(common_properties::molAttachPoint, val);
MolOps::expandAttachmentPoints(mcp, asQueries);
CHECK(mcp.getNumAtoms() == 4);
CHECK(
!mcp.getAtomWithIdx(1)->hasProp(common_properties::molAttachPoint));
int value = 0;
CHECK(mcp.getAtomWithIdx(2)->getPropIfPresent(
common_properties::_fromAttachPoint, value));
CHECK(value == 1);
CHECK(mcp.getAtomWithIdx(2)->hasQuery() == asQueries);
CHECK(MolOps::details::isAttachmentPoint(mcp.getAtomWithIdx(2)));
CHECK(mcp.getAtomWithIdx(3)->getPropIfPresent(
common_properties::_fromAttachPoint, value));
CHECK(value == 2);
CHECK(mcp.getAtomWithIdx(3)->hasQuery() == asQueries);
CHECK(MolOps::details::isAttachmentPoint(mcp.getAtomWithIdx(3)));
MolOps::collapseAttachmentPoints(mcp);
CHECK(mcp.getNumAtoms() == 2);
}
}
{
// bogus values are not expanded
RWMol mcp(*m);
mcp.getAtomWithIdx(1)->setProp(common_properties::molAttachPoint, 4);
MolOps::expandAttachmentPoints(mcp);
CHECK(mcp.getNumAtoms() == 2);
}
}
SECTION("collapse options and edges") {
auto m = "*CO"_smarts;
REQUIRE(m);
CHECK(m->getNumAtoms() == 3);
m->getAtomWithIdx(2)->setProp(common_properties::molAttachPoint, 1);
MolOps::expandAttachmentPoints(*m);
CHECK(m->getNumAtoms() == 4);
{
RWMol mcp(*m);
MolOps::collapseAttachmentPoints(mcp);
CHECK(mcp.getNumAtoms() == 3);
}
{
RWMol mcp(*m);
bool markedOnly = false;
MolOps::collapseAttachmentPoints(mcp, markedOnly);
CHECK(mcp.getNumAtoms() == 2);
}
{
RWMol mcp(*m);
mcp.getAtomWithIdx(0)->setQuery(makeAtomNumQuery(0));
bool markedOnly = false;
MolOps::collapseAttachmentPoints(mcp, markedOnly);
CHECK(mcp.getNumAtoms() == 3);
}
{
RWMol mcp(*m);
mcp.getBondWithIdx(0)->setBondDir(Bond::BondDir::BEGINWEDGE);
bool markedOnly = false;
MolOps::collapseAttachmentPoints(mcp, markedOnly);
CHECK(mcp.getNumAtoms() == 3);
}
{
RWMol mcp(*m);
mcp.addAtom(new Atom(6), false, true);
mcp.addBond(0, 4, Bond::SINGLE);
CHECK(mcp.getNumAtoms() == 5);
bool markedOnly = false;
MolOps::collapseAttachmentPoints(mcp, markedOnly);
CHECK(mcp.getNumAtoms() == 4);
}
/* now a block with mods to the attachment point dummy to make it no
* longer removable */
{
RWMol mcp(*m);
mcp.getAtomWithIdx(3)->setQuery(makeAtomNumQuery(0));
MolOps::collapseAttachmentPoints(mcp);
CHECK(mcp.getNumAtoms() == 4);
}
{
RWMol mcp(*m);
mcp.getBondWithIdx(2)->setBondDir(Bond::BondDir::BEGINWEDGE);
MolOps::collapseAttachmentPoints(mcp);
CHECK(mcp.getNumAtoms() == 4);
}
{
RWMol mcp(*m);
mcp.addAtom(new Atom(6), false, true);
mcp.addBond(3, 4, Bond::SINGLE);
CHECK(mcp.getNumAtoms() == 5);
MolOps::collapseAttachmentPoints(mcp);
CHECK(mcp.getNumAtoms() == 5);
}
}
SECTION("collapse sets the correct property") {
auto m = "*CO"_smarts;
REQUIRE(m);
CHECK(m->getNumAtoms() == 3);
for (int tgt : {1, 2}) {
m->getAtomWithIdx(2)->setProp(common_properties::molAttachPoint, tgt);
CHECK(!MolOps::details::isAttachmentPoint(m->getAtomWithIdx(0)));
CHECK(MolOps::details::isAttachmentPoint(m->getAtomWithIdx(0), false));
MolOps::expandAttachmentPoints(*m);
CHECK(m->getNumAtoms() == 4);
CHECK(MolOps::details::isAttachmentPoint(m->getAtomWithIdx(3)));
MolOps::collapseAttachmentPoints(*m);
CHECK(m->getNumAtoms() == 3);
int value = 0;
CHECK(m->getAtomWithIdx(2)->getPropIfPresent(
common_properties::molAttachPoint, value));
CHECK(value == tgt);
}
{
RWMol mcp(*m);
bool markedOnly = false;
MolOps::collapseAttachmentPoints(mcp, markedOnly);
CHECK(mcp.getNumAtoms() == 2);
int value = 0;
CHECK(mcp.getAtomWithIdx(0)->getPropIfPresent(
common_properties::molAttachPoint, value));
CHECK(value == 1);
}
}
SECTION("collapse two dummies") {
auto m = "*CO"_smarts;
REQUIRE(m);
CHECK(m->getNumAtoms() == 3);
m->getAtomWithIdx(2)->setProp(common_properties::molAttachPoint, -1);
MolOps::expandAttachmentPoints(*m);
CHECK(m->getNumAtoms() == 5);
MolOps::collapseAttachmentPoints(*m);
CHECK(m->getNumAtoms() == 3);
int value = 0;
CHECK(m->getAtomWithIdx(2)->getPropIfPresent(
common_properties::molAttachPoint, value));
CHECK(value == -1);
}
SECTION("invalid attachment points not collapsed") {
auto m = "*CO"_smarts;
REQUIRE(m);
CHECK(m->getNumAtoms() == 3);
{
// this one is ok:
RWMol mcp(*m);
mcp.getAtomWithIdx(0)->setProp(common_properties::_fromAttachPoint, 1);
MolOps::collapseAttachmentPoints(mcp);
CHECK(mcp.getNumAtoms() == 2);
}
{
// not ok:
RWMol mcp(*m);
mcp.getAtomWithIdx(0)->setProp(common_properties::_fromAttachPoint, -1);
MolOps::collapseAttachmentPoints(mcp);
CHECK(mcp.getNumAtoms() == 3);
}
{
// not ok:
RWMol mcp(*m);
mcp.getAtomWithIdx(0)->setProp(common_properties::_fromAttachPoint, 4);
MolOps::collapseAttachmentPoints(mcp);
CHECK(mcp.getNumAtoms() == 3);
}
}
SECTION("from cxsmiles") {
auto mol = "*CC(*)* |$;;;_AP1;_AP2$|"_smiles;
REQUIRE(mol);
CHECK(mol->getNumAtoms() == 5);
{
RWMol molcp(*mol);
bool markedOnly = true;
MolOps::collapseAttachmentPoints(molcp, markedOnly);
CHECK(molcp.getNumAtoms() == 3);
}
{
RWMol molcp(*mol);
bool markedOnly = false;
MolOps::collapseAttachmentPoints(molcp, markedOnly);
CHECK(molcp.getNumAtoms() == 2);
}
}
SECTION("add attachment point") {
auto mol = "CC"_smiles;
REQUIRE(mol);
CHECK(mol->getNumAtoms() == 2);
unsigned int atomIdx = 1;
unsigned int val = 2;
CHECK(MolOps::details::addExplicitAttachmentPoint(*mol, atomIdx, val) == 2);
CHECK(mol->getNumAtoms() == 3);
CHECK(mol->getAtomWithIdx(2)->getAtomicNum() == 0);
CHECK(mol->getBondBetweenAtoms(1, 2));
}
SECTION("isAttachmentPoint edge cases") {
auto mol = "*CC(*)=* |$;;;_AP1;_AP2$|"_smiles;
REQUIRE(mol);
CHECK(mol->getNumAtoms() == 5);
mol->getBondBetweenAtoms(2, 3)->setBondDir(Bond::BondDir::BEGINWEDGE);
CHECK(!MolOps::details::isAttachmentPoint(mol->getAtomWithIdx(0)));
CHECK(MolOps::details::isAttachmentPoint(mol->getAtomWithIdx(0), false));
// marked as an attachment point, but at end of a wedged bond
CHECK(!MolOps::details::isAttachmentPoint(mol->getAtomWithIdx(3)));
// marked as an attachment point, but at end of a double bond
CHECK(!MolOps::details::isAttachmentPoint(mol->getAtomWithIdx(4)));
}
}
TEST_CASE("bond output") {
SECTION("order") {
auto m = "C-C=C-C#N->[Fe]"_smiles;
REQUIRE(m);
std::stringstream ss;
ss << *m->getBondWithIdx(0);
CHECK(ss.str() == "0 0->1 order: 1");
ss.str("");
ss << *m->getBondWithIdx(3);
CHECK(ss.str() == "3 3->4 order: 3 conj?: 1");
ss.str("");
ss << *m->getBondWithIdx(4);
CHECK(ss.str() == "4 4->5 order: D");
ss.str("");
}
SECTION("dir") {
auto m = "CC=CC(F)Cl"_smiles;
REQUIRE(m);
m->getBondWithIdx(1)->setBondDir(Bond::BondDir::EITHERDOUBLE);
m->getBondWithIdx(3)->setBondDir(Bond::BondDir::BEGINDASH);
m->getBondWithIdx(4)->setBondDir(Bond::BondDir::BEGINWEDGE);
std::stringstream ss;
ss << *m->getBondWithIdx(1);
CHECK(ss.str() == "1 1->2 order: 2 dir: x");
ss.str("");
ss << *m->getBondWithIdx(3);
CHECK(ss.str() == "3 3->4 order: 1 dir: dash");
ss.str("");
ss << *m->getBondWithIdx(4);
CHECK(ss.str() == "4 3->5 order: 1 dir: wedge");
ss.str("");
}
SECTION("stereo") {
auto m = "CC=CC(=O)c1cnccc1"_smiles;
REQUIRE(m);
m->getBondWithIdx(1)->setStereoAtoms(0, 3);
m->getBondWithIdx(1)->setStereo(Bond::BondStereo::STEREOCIS);
// this is, of course, silly
m->getBondWithIdx(4)->setStereo(Bond::BondStereo::STEREOATROPCCW);
std::stringstream ss;
ss << *m->getBondWithIdx(1);
CHECK(ss.str() == "1 1->2 order: 2 stereo: CIS ats: (0 3) conj?: 1");
ss.str("");
ss << *m->getBondWithIdx(4);
CHECK(ss.str() == "4 3->5 order: 1 stereo: CCW bonds: (2 3 5 10) conj?: 1");
ss.str("");
}
}
TEST_CASE("atom output") {
SECTION("basics") {
auto m = "[C]c1ccc[nH]1"_smiles;
REQUIRE(m);
std::stringstream ss;
ss << *m->getAtomWithIdx(0);
CHECK(ss.str() == "0 6 C chg: 0 deg: 1 exp: 1 imp: 0 hyb: SP3 rad: 3");
ss.str("");
ss << *m->getAtomWithIdx(2);
CHECK(ss.str() == "2 6 C chg: 0 deg: 2 exp: 3 imp: 1 hyb: SP2 arom?: 1");
ss.str("");
ss << *m->getAtomWithIdx(5);
CHECK(ss.str() == "5 7 N chg: 0 deg: 2 exp: 3 imp: 0 hyb: SP2 arom?: 1");
ss.str("");
}
SECTION("chirality 1") {
auto m = "C[C@H](F)Cl"_smiles;
REQUIRE(m);
std::stringstream ss;
ss << *m->getAtomWithIdx(1);
CHECK(ss.str() ==
"1 6 C chg: 0 deg: 3 exp: 4 imp: 0 hyb: SP3 chi: CCW nbrs:[0 2 3]");
ss.str("");
}
SECTION("chirality 2") {
// same as
// C[Pt@SP2]([H])(F)Cl which is stored internally as
// C[Pt@SP3](F)(Cl)[H]
auto m = "C[Pt@SP2H](F)Cl"_smiles;
REQUIRE(m);
std::stringstream ss;
ss << *m->getAtomWithIdx(1);
CHECK(
ss.str() ==
"1 78 Pt chg: 0 deg: 3 exp: 4 imp: 0 hyb: SP2D chi: SqP(3) nbrs:[0 2 3]");
ss.str("");
}
}
TEST_CASE(
"Github Issue #7064: Copy stereo and substance groups during insertMol",
"[RWMol]") {
// This mols is made up, it probably doesn't make sense at all.
auto m1 = R"CTAB(
Mrv2311 02062417062D
0 0 0 0 0 999 V3000
M V30 BEGIN CTAB
M V30 COUNTS 34 35 1 0 1
M V30 BEGIN ATOM
M V30 1 C 0.004 0.7623 0 0
M V30 2 C 1.0927 1.8587 0 0
M V30 3 N 0.004 2.9396 0 0
M V30 4 C -1.0927 1.8587 0 0
M V30 5 C -1.0927 -0.3187 0 0
M V30 6 N 0.004 -1.4155 0 0
M V30 7 C 1.0927 -0.3187 0 0
M V30 8 C 0.004 -2.9396 0 0
M V30 9 C 2.4264 0.4513 0 0 CFG=2
M V30 10 C 3.7601 -0.3187 0 0 CFG=1
M V30 11 C 5.0937 0.4513 0 0 CFG=2
M V30 12 C 6.4274 -0.3187 0 0 CFG=1
M V30 13 C 7.7611 0.4513 0 0 CFG=2
M V30 14 C 9.0948 -0.3187 0 0
M V30 15 C -2.4264 1.0887 0 0 CFG=2
M V30 16 C -3.7601 1.8587 0 0 CFG=1
M V30 17 C -5.0937 1.0887 0 0 CFG=2
M V30 18 C -6.4274 1.8587 0 0 CFG=1
M V30 19 C -7.7611 1.0887 0 0
M V30 20 O 7.7611 1.9913 0 0
M V30 21 C 6.4274 -1.8587 0 0
M V30 22 C 5.0937 1.9913 0 0
M V30 23 C 3.7601 -1.8587 0 0
M V30 24 C 2.4264 1.9913 0 0
M V30 25 C -2.4264 -0.4513 0 0
M V30 26 C -3.7601 3.3987 0 0
M V30 27 C -5.0937 -0.4513 0 0
M V30 28 O -6.4274 3.3987 0 0
M V30 29 C -1.323 -5.2511 0 0
M V30 30 C -2.8705 -5.2532 0 0
M V30 31 C 0.2093 -5.2568 0 0
M V30 32 C -1.321 -6.7911 0 0
M V30 33 O -1.325 -3.7113 0 0
M V30 34 O 1.327 -3.7079 0 0
M V30 END ATOM
M V30 BEGIN BOND
M V30 1 1 1 2
M V30 2 1 2 3
M V30 3 1 3 4
M V30 4 1 4 1
M V30 5 1 1 5
M V30 6 1 5 6
M V30 7 1 6 7
M V30 8 1 7 1
M V30 9 1 6 8
M V30 10 1 7 9
M V30 11 1 9 10
M V30 12 1 10 11
M V30 13 1 11 12
M V30 14 1 12 13
M V30 15 1 13 14
M V30 16 1 4 15
M V30 17 1 15 16
M V30 18 1 16 17
M V30 19 1 17 18
M V30 20 1 18 19
M V30 21 1 12 21 CFG=1
M V30 22 1 11 22 CFG=1
M V30 23 1 10 23 CFG=1
M V30 24 1 9 24 CFG=1
M V30 25 1 15 25 CFG=1
M V30 26 1 16 26 CFG=1
M V30 27 1 17 27 CFG=1
M V30 28 1 18 28 CFG=1
M V30 29 1 13 20 CFG=1
M V30 30 1 33 29
M V30 31 1 29 30
M V30 32 1 29 31
M V30 33 1 29 32
M V30 34 2 8 34
M V30 35 1 33 8
M V30 END BOND
M V30 BEGIN SGROUP
M V30 1 SUP 0 ATOMS=(7 8 9 10 11 12 13 14) XBONDS=(1 9) BRKXYZ=(9 6.24 -2.9 0 -
M V30 6.24 -2.9 0 0 0 0) CSTATE=(4 9 0 0.82 0) LABEL=Boc SAP=(3 13 6 1)
M V30 END SGROUP
M V30 BEGIN COLLECTION
M V30 MDLV30/STEABS ATOMS=(2 17 18)
M V30 MDLV30/STEREL4 ATOMS=(2 9 10)
M V30 MDLV30/STERAC2 ATOMS=(2 15 16)
M V30 MDLV30/STERAC6 ATOMS=(2 11 12)
M V30 END COLLECTION
M V30 END CTAB
M END
)CTAB"_ctab;
REQUIRE(m1);
const auto numAtoms = m1->getNumAtoms();
const auto numBonds = m1->getNumBonds();
REQUIRE(numAtoms == 34);
REQUIRE(numBonds == 35);
auto m2 = RWMol(*m1);
m2.insertMol(*m1);
REQUIRE(m2.getNumAtoms() == 2 * numAtoms);
REQUIRE(m2.getNumBonds() == 2 * numBonds);
auto checkStereoGroup = [](const std::vector<StereoGroup> &stgs, int stg_idx,
const StereoGroupType type,
const std::vector<unsigned int> &atoms) {
INFO("Checking StereoGroup " << stg_idx);
const auto &stg = stgs[stg_idx];
CHECK(stg.getGroupType() == type);
std::vector<unsigned int> actualAtoms;
for (const auto atom : stg.getAtoms()) {
actualAtoms.push_back(atom->getIdx());
}
CHECK(actualAtoms == atoms);
};
auto checkSubstanceGroup =
[](const std::vector<SubstanceGroup> &sgs, int sg_idx,
const std::vector<unsigned int> &atoms,
const std::vector<unsigned int> &bonds, const unsigned int &cstateBond,
const std::pair<unsigned int, int> &attachPtAtoms) {
INFO("Checking Substance Group " << sg_idx);
const auto &sg = sgs[sg_idx];
CHECK(sg.getProp<std::string>("TYPE") == "SUP");
CHECK(sg.getAtoms() == atoms);
CHECK(sg.getBonds() == bonds);
auto cstates = sg.getCStates();
REQUIRE(cstates.size() == 1);
CHECK(cstates[0].bondIdx == cstateBond);
auto saps = sg.getAttachPoints();
REQUIRE(saps.size() == 1);
CHECK(saps[0].aIdx == attachPtAtoms.first);
CHECK(saps[0].lvIdx == attachPtAtoms.second);
};
// Check that the original Stereo Groups haven't changed
{
const auto stgs1 = m1->getStereoGroups();
REQUIRE(stgs1.size() == 4);
checkStereoGroup(stgs1, 0, StereoGroupType::STEREO_ABSOLUTE, {16, 17});
checkStereoGroup(stgs1, 1, StereoGroupType::STEREO_OR, {8, 9});
checkStereoGroup(stgs1, 2, StereoGroupType::STEREO_AND, {14, 15});
checkStereoGroup(stgs1, 3, StereoGroupType::STEREO_AND, {10, 11});
const auto sgs1 = getSubstanceGroups(*m1);
REQUIRE(sgs1.size() == 1);
checkSubstanceGroup(sgs1, 0, {7, 8, 9, 10, 11, 12, 13}, {8}, 8, {12, 5});
}
// Check that the insertion was successful
{
const auto stgs2 = m2.getStereoGroups();
REQUIRE(stgs2.size() == 7);
checkStereoGroup(stgs2, 0, StereoGroupType::STEREO_OR, {8, 9});
checkStereoGroup(stgs2, 1, StereoGroupType::STEREO_AND, {14, 15});
checkStereoGroup(stgs2, 2, StereoGroupType::STEREO_AND, {10, 11});
checkStereoGroup(stgs2, 3, StereoGroupType::STEREO_OR, {42, 43});
checkStereoGroup(stgs2, 4, StereoGroupType::STEREO_AND, {48, 49});
checkStereoGroup(stgs2, 5, StereoGroupType::STEREO_AND, {44, 45});
checkStereoGroup(stgs2, 6, StereoGroupType::STEREO_ABSOLUTE,
{16, 17, 50, 51});
const auto sgs2 = getSubstanceGroups(m2);
REQUIRE(sgs2.size() == 2);
checkSubstanceGroup(sgs2, 0, {7, 8, 9, 10, 11, 12, 13}, {8}, 8, {12, 5});
checkSubstanceGroup(sgs2, 1, {41, 42, 43, 44, 45, 46, 47}, {43}, 43,
{46, 39});
}
}
TEST_CASE("Github Issue #7782: insertMol should not create an empty STEREO_ABSOLUTE group", "[RWMol]") {
{
auto mol = "C1CC1"_smiles;
REQUIRE(mol);
CHECK(mol->getStereoGroups().empty());
auto other = "C1CNC1"_smiles;
CHECK(other->getStereoGroups().empty());
REQUIRE(other);
mol->insertMol(*other);
CHECK(mol->getStereoGroups().empty());
auto molblock = MolToMolBlock(*mol);
auto molblockV3k = MolToV3KMolBlock(*mol);
CHECK(molblock.find("V2000") != std::string::npos);
CHECK(molblockV3k.find("V3000") != std::string::npos);
CHECK(molblockV3k.find("STEABS ATOMS=(0)") == std::string::npos);
}
{
auto mol = "CC[C@H](C)N |&1:2,r,lp:4:1|"_smiles;
REQUIRE(mol);
CHECK(!mol->getStereoGroups().empty());
auto other = "CC[C@H](C)O |o1:2,r,lp:4:2|"_smiles;
CHECK(!other->getStereoGroups().empty());
REQUIRE(other);
mol->insertMol(*other);
CHECK(!mol->getStereoGroups().empty());
auto molblock = MolToMolBlock(*mol);
CHECK(molblock.find("V2000") == std::string::npos);
CHECK(molblock.find("V3000") != std::string::npos);
CHECK(molblock.find("STERAC1 ATOMS=(1 3)") != std::string::npos);
CHECK(molblock.find("STEREL1 ATOMS=(1 8)") != std::string::npos);
CHECK(molblock.find("STEABS ATOMS=(0)") == std::string::npos);
}
}
TEST_CASE("Hybridization of dative bonded atoms") {
const std::vector<Atom::HybridizationType> ref_hybridizations = {
Atom::HybridizationType::SP3, Atom::HybridizationType::SP3,
Atom::HybridizationType::SP2, Atom::HybridizationType::SP2,
Atom::HybridizationType::SP2, Atom::HybridizationType::SP3D2};
SECTION("Base mol") {
auto m = "CCC(=O)O"_smiles;
REQUIRE(m);
for (unsigned int i = 0; i < m->getNumAtoms(); ++i) {
CHECK(m->getAtomWithIdx(i)->getHybridization() == ref_hybridizations[i]);
}
}
SECTION("Dative bonded") {
auto m = "CCC(=O)O->[Cu]"_smiles;
REQUIRE(m);
auto dBond = m->getBondWithIdx(4);
REQUIRE(dBond->getBondType() == Bond::BondType::DATIVE);
for (unsigned int i = 0; i < m->getNumAtoms(); ++i) {
CHECK(m->getAtomWithIdx(i)->getHybridization() == ref_hybridizations[i]);
}
}
}
TEST_CASE(
"GitHub Issue #7375: DetectChemistryProblems fails with traceback when run on mols coming from aromatic SMARTS",
"[bug][molops]") {
auto m = "c"_smarts;
REQUIRE(m);
auto res = MolOps::detectChemistryProblems(*m);
REQUIRE(res.size() == 1);
CHECK(dynamic_cast<AtomKekulizeException *>(res[0].get()) != nullptr);
CHECK(std::string{"non-ring atom 0 marked aromatic"} == res[0]->what());
}
TEST_CASE("Try not to set wedged bonds as double in the kekulization") {
SECTION("basics") {
auto m = "c1nccc(C)c1-c1c(C)cccc1"_smiles;
REQUIRE(m);
m->getBondBetweenAtoms(7, 8)->setBondDir(Bond::BondDir::BEGINWEDGE);
MolOps::Kekulize(*m);
CHECK(m->getBondBetweenAtoms(7, 8)->getBondType() ==
Bond::BondType::SINGLE);
CHECK(m->getBondBetweenAtoms(7, 13)->getBondType() ==
Bond::BondType::DOUBLE);
}
SECTION("preserve wedged bonds from ctab input") {
// consider two equivalent structures, with the same numbering
// of atoms and bonds, but different arrangement of single and
// double bonds in the aromatic ring that includes a wedged bond.
// verify that in both cases the kekulization results in assigning
// a single bond order to the wedged bonds.
auto mblock1 = R"(
Mrv2311 05242408112D
0 0 0 0 0 999 V3000
M V30 BEGIN CTAB
M V30 COUNTS 14 15 0 0 0
M V30 BEGIN ATOM
M V30 1 C 2.0006 -1.54 0 0
M V30 2 N 2.0006 -3.08 0 0
M V30 3 C 0.6669 -3.85 0 0
M V30 4 C -0.6668 -3.08 0 0
M V30 5 C -0.6668 -1.54 0 0
M V30 6 C -2.0006 -0.77 0 0
M V30 7 C 0.6669 -0.77 0 0
M V30 8 C 0.6669 0.77 0 0
M V30 9 C -0.6668 1.54 0 0
M V30 10 C -2.0006 0.77 0 0
M V30 11 C -0.6668 3.08 0 0
M V30 12 C 0.6669 3.85 0 0
M V30 13 C 2.0006 3.08 0 0
M V30 14 C 2.0006 1.54 0 0
M V30 END ATOM
M V30 BEGIN BOND
M V30 1 2 1 2
M V30 2 1 2 3
M V30 3 2 3 4
M V30 4 1 4 5
M V30 5 1 5 6
M V30 6 2 5 7
M V30 7 1 7 1 CFG=1
M V30 8 1 7 8
M V30 9 2 8 9
M V30 10 1 9 10
M V30 11 1 9 11
M V30 12 2 11 12
M V30 13 1 12 13
M V30 14 2 13 14
M V30 15 1 8 14
M V30 END BOND
M V30 END CTAB
M END
)";
std::unique_ptr<RWMol> m1(MolBlockToMol(mblock1));
REQUIRE(m1);
Chirality::reapplyMolBlockWedging(*m1);
MolOps::Kekulize(*m1);
CHECK(m1->getBondBetweenAtoms(0, 6)->getBondType() ==
Bond::BondType::SINGLE);
CHECK(m1->getBondBetweenAtoms(0, 6)->getBondDir() ==
Bond::BondDir::BEGINWEDGE);
CHECK(m1->getBondBetweenAtoms(4, 6)->getBondType() ==
Bond::BondType::DOUBLE);
auto mblock2 = R"(
Mrv2311 05242408162D
0 0 0 0 0 999 V3000
M V30 BEGIN CTAB
M V30 COUNTS 14 15 0 0 0
M V30 BEGIN ATOM
M V30 1 C 2.0006 -1.54 0 0
M V30 2 N 2.0006 -3.08 0 0
M V30 3 C 0.6669 -3.85 0 0
M V30 4 C -0.6668 -3.08 0 0
M V30 5 C -0.6668 -1.54 0 0
M V30 6 C -2.0006 -0.77 0 0
M V30 7 C 0.6669 -0.77 0 0
M V30 8 C 0.6669 0.77 0 0
M V30 9 C -0.6668 1.54 0 0
M V30 10 C -2.0006 0.77 0 0
M V30 11 C -0.6668 3.08 0 0
M V30 12 C 0.6669 3.85 0 0
M V30 13 C 2.0006 3.08 0 0
M V30 14 C 2.0006 1.54 0 0
M V30 END ATOM
M V30 BEGIN BOND
M V30 1 1 1 2
M V30 2 2 2 3
M V30 3 1 3 4
M V30 4 2 4 5
M V30 5 1 5 6
M V30 6 1 7 5 CFG=3
M V30 7 2 7 1
M V30 8 1 7 8
M V30 9 2 8 9
M V30 10 1 9 10
M V30 11 1 9 11
M V30 12 2 11 12
M V30 13 1 12 13
M V30 14 2 13 14
M V30 15 1 8 14
M V30 END BOND
M V30 END CTAB
M END
)";
std::unique_ptr<RWMol> m2(MolBlockToMol(mblock2));
REQUIRE(m2);
Chirality::reapplyMolBlockWedging(*m2);
MolOps::Kekulize(*m2);
CHECK(m2->getBondBetweenAtoms(0, 6)->getBondType() ==
Bond::BondType::DOUBLE);
CHECK(m2->getBondBetweenAtoms(4, 6)->getBondType() ==
Bond::BondType::SINGLE);
CHECK(m2->getBondBetweenAtoms(4, 6)->getBondDir() ==
Bond::BondDir::BEGINDASH);
}
SECTION("preserve wedged bonds from ctab input - fused rings") {
// consider two equivalent structures, with the same numbering
// of atoms and bonds, but different arrangement of single and
// double bonds in the aromatic ring that includes a wedged bond.
// verify that in both cases the kekulization results in assigning
// a single bond order to the wedged bonds.
//
// similar to the previous test case, but adding fused rings and
// an O atom that wouldn't accept double bonds
auto mblock1 = R"(
Mrv2311 05282412322D
0 0 0 0 0 999 V3000
M V30 BEGIN CTAB
M V30 COUNTS 17 19 0 0 0
M V30 BEGIN ATOM
M V30 1 C -13.0418 12.1443 0 0
M V30 2 C -14.3753 11.3743 0 0
M V30 3 C -14.3753 9.8341 0 0
M V30 4 C -13.0418 9.0641 0 0
M V30 5 C -11.708 9.8341 0 0
M V30 6 C -11.708 11.3743 0 0
M V30 7 C -13.0418 7.5241 0 0
M V30 8 C -10.3744 9.0641 0 0
M V30 9 C -14.3754 6.7541 0 0
M V30 10 C -14.3754 5.2139 0 0
M V30 11 C -13.0419 4.4439 0 0
M V30 12 C -11.7081 5.2138 0 0
M V30 13 C -11.7081 6.754 0 0
M V30 14 C -15.8399 7.2302 0 0
M V30 15 C -16.7452 5.9844 0 0
M V30 16 O -15.8402 4.7385 0 0
M V30 17 C -10.3744 7.524 0 0
M V30 END ATOM
M V30 BEGIN BOND
M V30 1 2 1 2
M V30 2 1 2 3
M V30 3 2 3 4
M V30 4 1 4 5
M V30 5 2 5 6
M V30 6 1 6 1
M V30 7 1 4 7
M V30 8 1 5 8
M V30 9 1 9 10
M V30 10 2 10 11
M V30 11 1 11 12
M V30 12 2 12 13
M V30 13 2 7 9
M V30 14 1 7 13 CFG=1
M V30 15 2 14 15
M V30 16 1 9 14
M V30 17 1 13 17
M V30 18 1 15 16
M V30 19 1 10 16
M V30 END BOND
M V30 END CTAB
M END
)";
std::unique_ptr<RWMol> m1(MolBlockToMol(mblock1));
REQUIRE(m1);
Chirality::reapplyMolBlockWedging(*m1);
MolOps::Kekulize(*m1);
CHECK(m1->getBondBetweenAtoms(6, 12)->getBondType() ==
Bond::BondType::SINGLE);
CHECK(m1->getBondBetweenAtoms(6, 12)->getBondDir() ==
Bond::BondDir::BEGINWEDGE);
CHECK(m1->getBondBetweenAtoms(6, 8)->getBondType() ==
Bond::BondType::DOUBLE);
auto mblock2 = R"(
Mrv2311 05282412342D
0 0 0 0 0 999 V3000
M V30 BEGIN CTAB
M V30 COUNTS 17 19 0 0 0
M V30 BEGIN ATOM
M V30 1 C -13.0418 12.1443 0 0
M V30 2 C -14.3753 11.3743 0 0
M V30 3 C -14.3753 9.8341 0 0
M V30 4 C -13.0418 9.0641 0 0
M V30 5 C -11.708 9.8341 0 0
M V30 6 C -11.708 11.3743 0 0
M V30 7 C -13.0418 7.5241 0 0
M V30 8 C -10.3744 9.0641 0 0
M V30 9 C -14.3754 6.7541 0 0
M V30 10 C -14.3754 5.2139 0 0
M V30 11 C -13.0419 4.4439 0 0
M V30 12 C -11.7081 5.2138 0 0
M V30 13 C -11.7081 6.754 0 0
M V30 14 C -15.8399 7.2302 0 0
M V30 15 C -16.7452 5.9844 0 0
M V30 16 O -15.8402 4.7385 0 0
M V30 17 C -10.3744 7.524 0 0
M V30 END ATOM
M V30 BEGIN BOND
M V30 1 2 1 2
M V30 2 1 2 3
M V30 3 2 3 4
M V30 4 1 4 5
M V30 5 2 5 6
M V30 6 1 6 1
M V30 7 1 4 7
M V30 8 1 5 8
M V30 9 2 9 10
M V30 10 1 10 11
M V30 11 2 11 12
M V30 12 1 12 13
M V30 13 1 7 9 CFG=3
M V30 14 2 7 13
M V30 15 2 14 15
M V30 16 1 9 14
M V30 17 1 13 17
M V30 18 1 15 16
M V30 19 1 10 16
M V30 END BOND
M V30 END CTAB
M END
)";
std::unique_ptr<RWMol> m2(MolBlockToMol(mblock2));
REQUIRE(m2);
Chirality::reapplyMolBlockWedging(*m2);
MolOps::Kekulize(*m2);
CHECK(m2->getBondBetweenAtoms(6, 12)->getBondType() ==
Bond::BondType::DOUBLE);
CHECK(m2->getBondBetweenAtoms(6, 8)->getBondType() ==
Bond::BondType::SINGLE);
CHECK(m2->getBondBetweenAtoms(6, 8)->getBondDir() ==
Bond::BondDir::BEGINDASH);
}
SECTION("bulk") {
std::string pathName = getenv("RDBASE");
pathName += "/Code/GraphMol/FileParsers/test_data/atropisomers/";
std::vector<std::pair<std::string, int>> prs = {
#if 1
{"BMS-986142_atrop8.sdf", 8},
{"Mrtx1719_atrop3.sdf", 21},
{"AtropManyChiralsEnhanced2.sdf", 7},
{"JDQ443_atrop2.sdf", 26},
{"BMS-986142_atrop2.sdf", 8},
{"macrocycle-6-meta-broken-hash.sdf", 14},
{"BMS-986142_3d.sdf", 8},
{"Mrtx1719_atrop2.sdf", 21},
{"Sotorasib_atrop3.sdf", 12},
{"macrocycle-5-meta-Cl-ortho-wedge.sdf", 15},
{"ZM374979_atrop2.sdf", 33},
{"RP-6306_3d.sdf", 3},
{"macrocycle-5-meta-Cl-ortho-hash.sdf", 15},
{"macrocycle-6-meta-hash.sdf", 15},
{"macrocycle-8-ortho-broken-wedge.sdf", 14},
{"RP-6306_atrop2.sdf", 3},
{"Sotorasib_3d.sdf", 12},
{"RP-6306_atrop5.sdf", 3},
{"AtropManyChiralsEnhanced.sdf", 7},
{"RP-6306_atrop4.sdf", 3},
{"BMS-986142_atrop3.sdf", 8},
{"BMS-986142_atrop7.sdf", 8},
{"Sotorasib_atrop1.sdf", 12},
{"Mrtx1719_3d.sdf", 21},
{"Sotorasib_atrop2.sdf", 12},
{"Sotorasib_atrop5.sdf", 12},
{"AtropManyChirals.sdf", 7},
{"BMS-986142_atrop5.sdf", 8},
{"macrocycle-7-meta-Cl-ortho-hash.sdf", 15},
{"RP-6306_atrop1.sdf", 3},
{"BMS-986142_3d_chiral.sdf", 8},
{"Mrtx1719_atrop1.sdf", 21},
{"macrocycle-9-meta-Cl-ortho-wedge.sdf", 15},
{"macrocycle-8-ortho-wedge.sdf", 15},
{"TestMultInSDF.sdf_1.sdf", 33},
{"macrocycle-9-ortho-broken-wedge.sdf", 14},
{"Sotorasib_atrop4.sdf", 12},
{"macrocycle-8-meta-Cl-ortho-hash.sdf", 15},
{"macrocycle-6-meta-Cl-ortho-wedge.sdf", 15},
{"macrocycle-9-ortho-wedge.sdf", 15},
{"BMS-986142_atrop6.sdf", 8},
{"ZM374979_atrop1.sdf", 33},
{"macrocycle-6-meta-Cl-ortho-hash.sdf", 15},
{"macrocycle-6-meta-wedge.sdf", 15},
{"macrocycle-9-meta-Cl-ortho-hash.sdf", 15},
{"BMS-986142_atrop4.sdf", 8},
{"macrocycle-8-meta-Cl-ortho-wedge.sdf", 15},
{"macrocycle-9-ortho-broken-hash.sdf", 14},
{"JDQ443_atrop1.sdf", 26},
{"macrocycle-9-ortho-hash.sdf", 15},
{"macrocycle-7-meta-Cl-ortho-wedge.sdf", 15},
{"ZM374979_atrop3.sdf", 33},
{"BMS-986142_atrop1.sdf", 8},
{"macrocycle-6-meta-broken-wedge.sdf", 14},
{"macrocycle-8-ortho-hash.sdf", 15},
{"RP-6306_atrop3.sdf", 3},
{"macrocycle-8-ortho-broken-hash.sdf", 14},
{"JDQ443_atrop3.sdf", 26},
#endif
{"JDQ443_3d.sdf", 26},
// keep
};
for (const auto &[nm, idx] : prs) {
INFO(nm);
auto m = v2::FileParsers::MolFromMolFile(pathName + nm);
REQUIRE(m);
const auto bnd = m->getBondWithIdx(idx);
REQUIRE((bnd->getStereo() == Bond::BondStereo::STEREOATROPCCW ||
bnd->getStereo() == Bond::BondStereo::STEREOATROPCW));
Chirality::wedgeMolBonds(*m, &m->getConformer());
bool clearAromaticFlags = false;
MolOps::Kekulize(*m, clearAromaticFlags);
// m->debugMol(std::cerr);
Bond *wedgedBond = nullptr;
Bond *dblBond = nullptr;
for (auto atm : {bnd->getBeginAtom(), bnd->getEndAtom()}) {
if (!atm->getIsAromatic()) {
continue;
}
for (auto nbrBnd : m->atomBonds(atm)) {
if (nbrBnd->getBondType() == Bond::BondType::DOUBLE) {
dblBond = nbrBnd;
CHECK(nbrBnd->getBondDir() == Bond::BondDir::NONE);
if (nbrBnd->getBondDir() != Bond::BondDir::NONE) {
m->debugMol(std::cerr);
}
} else if (nbrBnd->getBondDir() != Bond::BondDir::NONE) {
wedgedBond = nbrBnd;
}
}
}
// if we aren't in a five-ring (where the results of kekulize are normally
// fixed), wedge the double bond and flatten the other one
if (wedgedBond && dblBond &&
!m->getRingInfo()->isBondInRingOfSize(dblBond->getIdx(), 5) &&
!m->getRingInfo()->isBondInRingOfSize(wedgedBond->getIdx(), 5)) {
if (wedgedBond->getBondDir() == Bond::BondDir::BEGINWEDGE) {
dblBond->setBondDir(Bond::BondDir::BEGINDASH);
} else {
dblBond->setBondDir(Bond::BondDir::BEGINWEDGE);
}
wedgedBond->setBondDir(Bond::BondDir::NONE);
// re-aromatize:
for (auto bnd : m->bonds()) {
if (bnd->getIsAromatic()) {
bnd->setBondType(Bond::BondType::AROMATIC);
}
// }
// std::cerr << "\n\nbefore kekulize:" << std::endl;
// m->debugMol(std::cerr);
// kekulize again now that we wedged the bonds that were set to double
// before
MolOps::Kekulize(*m, clearAromaticFlags);
// and make sure that those didn't end up double again:
for (auto atm : {bnd->getBeginAtom(), bnd->getEndAtom()}) {
if (!atm->getIsAromatic()) {
continue;
}
for (auto nbrBnd : m->atomBonds(atm)) {
if (nbrBnd->getBondType() == Bond::BondType::DOUBLE) {
CHECK(nbrBnd->getBondDir() == Bond::BondDir::NONE);
if (nbrBnd->getBondDir() != Bond::BondDir::NONE) {
// m->debugMol(std::cerr);
// std::cerr << MolToV3KMolBlock(*m);
}
}
}
}
}
}
}
}
}
TEST_CASE("getMaxAtomicNumber") {
CHECK(PeriodicTable::getTable()->getMaxAtomicNumber() == 118);
}
TEST_CASE("explicit valence handling of transition metals") {
SECTION("basics") {
// some of these examples are quite silly
std::vector<std::string> smileses = {"[Ti]C", "[Ti+2]C", "[Ti+4]C",
"[Ti+5]C"};
for (const auto &smiles : smileses) {
auto m = v2::SmilesParse::MolFromSmiles(smiles);
REQUIRE(m);
CHECK(m->getAtomWithIdx(0)->getExplicitValence() == 1);
CHECK(m->getAtomWithIdx(0)->getImplicitValence() == 0);
}
}
}
TEST_CASE("valence handling of atoms with multiple possible valence states") {
SECTION("basics") {
// some of these examples are quite silly
std::vector<std::pair<std::string, int>> smileses = {
{"C[S-](=O)=O", 5},
{"C[P-2](C)C", 3},
{"C[Se-](=O)=O", 5},
{"C[As-2](C)C", 3},
};
for (const auto &[smiles, val] : smileses) {
INFO(smiles);
auto m = v2::SmilesParse::MolFromSmiles(smiles);
CHECK(m);
CHECK(val == m->getAtomWithIdx(1)->getExplicitValence());
// now try figuring out the implicit valence
m->getAtomWithIdx(1)->setNoImplicit(false);
m->getAtomWithIdx(1)->calcImplicitValence(true); // <- should not throw
CHECK(!m->getAtomWithIdx(1)->hasValenceViolation());
}
}
SECTION("mols which should fail") {
// some of these examples are quite silly
std::vector<std::string> smileses = {
"C[S-2](=O)=O",
"C[P-3](C)(C)(C)C",
"C[Se-2](=O)=O",
"C[As-3](C)(C)(C)C",
};
for (const auto &smiles : smileses) {
INFO(smiles);
v2::SmilesParse::SmilesParserParams ps;
ps.sanitize = false;
auto m = v2::SmilesParse::MolFromSmiles(smiles, ps);
CHECK(m);
m->getAtomWithIdx(1)->setNoImplicit(false);
CHECK(m->getAtomWithIdx(1)->hasValenceViolation());
}
}
}
TEST_CASE(
"testing for valence states which were removed when introducing the isoelectronic valence calculation") {
SECTION("mols which should pass") {
std::vector<std::pair<std::string, unsigned int>> smileses = {
{"F[Si-2](F)(F)(F)(F)F", 0},
{"F[P-](F)(F)(F)(F)F", 0},
{"F[As-](F)(F)(F)(F)F", 0},
};
for (const auto &[smiles, val] : smileses) {
INFO(smiles);
auto m = v2::SmilesParse::MolFromSmiles(smiles);
CHECK(m);
// now try figuring out the implicit valence
m->getAtomWithIdx(1)->setNoImplicit(false);
m->getAtomWithIdx(1)->calcImplicitValence(true); // <- should not throw
CHECK(!m->getAtomWithIdx(1)->hasValenceViolation());
CHECK(m->getAtomWithIdx(1)->getTotalNumHs() == val);
}
}
SECTION("mols which should fail") {
std::vector<std::string> smileses = {
"F[Al](F)(F)(F)(F)F",
"F[Si](F)(F)(F)(F)F",
"F[P](F)(F)(F)(F)(F)F",
"F[As](F)(F)(F)(F)(F)F",
};
for (const auto &smiles : smileses) {
INFO(smiles);
v2::SmilesParse::SmilesParserParams ps;
ps.sanitize = false;
auto m = v2::SmilesParse::MolFromSmiles(smiles, ps);
CHECK(m);
m->getAtomWithIdx(1)->setNoImplicit(false);
CHECK(m->getAtomWithIdx(1)->hasValenceViolation());
}
}
}
TEST_CASE("Valences on Al, Si, P, As, Sb, Bi") {
// tests added by Paolo Tosco in a separate PR
SECTION("Should fail with AtomValenceException") {
std::vector<std::pair<std::string, unsigned int>> smiles = {
{"[Al](Cl)(Cl)(Cl)(Cl)(Cl)Cl", 0}, {"F[Si](F)(F)(F)(F)F", 1},
{"[P](F)(F)(F)(F)(F)F", 0}, {"P(=O)(O)(O)(O)(O)O", 0},
{"F[As](F)(F)(F)(F)F", 1}, {"O[As](=O)(O)(O)(O)O", 1},
{"[Sb](F)(F)(F)(F)(F)F", 0}, {"[Sb](=O)(O)(O)(O)(O)O", 0},
{"F[Bi](F)(F)(F)(F)F", 1}, {"O[Bi](=O)(O)(O)(O)(O)O", 1},
};
for (auto &[smi, idx] : smiles) {
INFO(smi);
CHECK_THROWS_AS(SmilesToMol(smi), AtomValenceException);
try {
ROMOL_SPTR m(SmilesToMol(smi));
RDUNUSED_PARAM(m);
} catch (const AtomValenceException &e) {
CHECK(e.getType() == "AtomValenceException");
CHECK(e.getAtomIdx() == idx);
}
}
}
SECTION("Should not fail") {
std::vector<std::string> smiles = {
"[Al-3](Cl)(Cl)(Cl)(Cl)(Cl)Cl", "F[Si-2](F)(F)(F)(F)F",
"[P-](F)(F)(F)(F)(F)F", "F[As-](F)(F)(F)(F)F",
"F[Sb-](F)(F)(F)(F)F", "[Bi-](F)(F)(F)(F)(F)F",
};
for (auto smi : smiles) {
ROMOL_SPTR m(SmilesToMol(smi));
CHECK(m);
}
}
}
TEST_CASE("Github #7873: monomer info segfaults and mem leaks", "[PDB]") {
SECTION("basics") {
class FakeAtomMonomerInfo : public AtomMonomerInfo {
public:
bool *deleted;
FakeAtomMonomerInfo(bool *was_deleted) : deleted(was_deleted) {
}
virtual ~FakeAtomMonomerInfo() {
*deleted = true;
}
};
bool sanitize = true;
int flavor = 0;
std::unique_ptr<RWMol> mol(SequenceToMol("KY", sanitize, flavor));
REQUIRE(mol);
REQUIRE(mol->getAtomWithIdx(0)->getMonomerInfo());
mol->getAtomWithIdx(0)->setMonomerInfo(nullptr);
CHECK(mol->getAtomWithIdx(0)->getMonomerInfo() == nullptr);
// make sure that the Monomer is delated when setting to nullptr
bool was_deleted = false;
auto res = new FakeAtomMonomerInfo(&was_deleted);
mol->getAtomWithIdx(0)->setMonomerInfo(res);
mol->getAtomWithIdx(0)->setMonomerInfo(nullptr);
CHECK(was_deleted == true);
}
}
Reference in New Issue View Git Blame Copy Permalink