mirror of
https://github.com/rdkit/rdkit.git
synced 2026-06-04 21:54:27 +08:00
54d6a1229c
* add checked iterators * support checked atom and bond iterators the idea here is to allow optional checking that the graph is not being modified while an iterator is active * ignore new member functions --------- Co-authored-by: Ric R <ricrogz@gmail.com>
312 lines
9.5 KiB
C++
312 lines
9.5 KiB
C++
//
|
|
// Copyright (C) 2021 Greg Landrum and other RDKit contributors
|
|
//
|
|
// @@ All Rights Reserved @@
|
|
// This file is part of the RDKit.
|
|
// The contents are covered by the terms of the BSD license
|
|
// which is included in the file license.txt, found at the root
|
|
// of the RDKit source tree.
|
|
//
|
|
|
|
#include <catch2/catch_all.hpp>
|
|
|
|
#include <GraphMol/RDKitBase.h>
|
|
#include <GraphMol/SmilesParse/SmilesParse.h>
|
|
#include <GraphMol/SmilesParse/SmilesWrite.h>
|
|
#include <algorithm>
|
|
#include <ranges>
|
|
#include <filesystem>
|
|
#include <execution>
|
|
|
|
using namespace RDKit;
|
|
|
|
TEST_CASE("mol.atoms()") {
|
|
const auto m = "CC(C)CO"_smiles;
|
|
REQUIRE(m);
|
|
unsigned int ccount = 0;
|
|
for (const auto atom : m->atoms()) {
|
|
if (atom->getAtomicNum() == 6) {
|
|
++ccount;
|
|
}
|
|
}
|
|
CHECK(ccount == 4);
|
|
auto atoms = m->atoms();
|
|
auto hasCarbon = std::any_of(atoms.begin(), atoms.end(), [](const auto atom) {
|
|
return atom->getAtomicNum() == 6;
|
|
});
|
|
CHECK(hasCarbon);
|
|
ccount = std::count_if(atoms.begin(), atoms.end(), [](const auto atom) {
|
|
return atom->getAtomicNum() == 6;
|
|
});
|
|
CHECK(ccount == 4);
|
|
ccount =
|
|
std::count_if(std::begin(atoms), std::end(atoms),
|
|
[](const auto atom) { return atom->getAtomicNum() == 6; });
|
|
CHECK(ccount == 4);
|
|
ccount =
|
|
std::count_if(std::ranges::begin(atoms), std::ranges::end(atoms),
|
|
[](const auto atom) { return atom->getAtomicNum() == 6; });
|
|
CHECK(ccount == 4);
|
|
}
|
|
|
|
TEST_CASE("mol.checkedAtoms()") {
|
|
const auto m = "CC(C)CO"_smiles;
|
|
REQUIRE(m);
|
|
unsigned int ccount = 0;
|
|
for (const auto atom : m->checkedAtoms()) {
|
|
if (atom->getAtomicNum() == 6) {
|
|
++ccount;
|
|
}
|
|
}
|
|
CHECK(ccount == 4);
|
|
{
|
|
RWMol m2(*m);
|
|
auto atoms = m2.checkedAtoms();
|
|
auto beg = atoms.begin();
|
|
m2.removeAtom(m2.getAtomWithIdx(2));
|
|
CHECK_THROWS_AS(*beg, std::runtime_error);
|
|
}
|
|
{
|
|
RWMol m2(*m);
|
|
auto atoms = m2.checkedAtoms();
|
|
auto beg = atoms.begin();
|
|
// with checked atom iterators we can safely delete bonds
|
|
m2.removeBond(1, 2);
|
|
auto at = *beg;
|
|
CHECK(at->getAtomicNum() == 6);
|
|
}
|
|
}
|
|
|
|
TEST_CASE("mol.bonds()") {
|
|
const auto m = "OC(=O)C(=O)O"_smiles;
|
|
REQUIRE(m);
|
|
unsigned int doubleBondCount = 0;
|
|
for (const auto bond : m->bonds()) {
|
|
if (bond->getBondType() == Bond::DOUBLE) {
|
|
++doubleBondCount;
|
|
}
|
|
}
|
|
CHECK(doubleBondCount == 2);
|
|
auto bonds = m->bonds();
|
|
auto hasDoubleBond = std::any_of(
|
|
bonds.begin(), bonds.end(),
|
|
[](const auto bond) { return bond->getBondType() == Bond::DOUBLE; });
|
|
CHECK(hasDoubleBond);
|
|
doubleBondCount = std::count_if(
|
|
bonds.begin(), bonds.end(),
|
|
[](const auto bond) { return bond->getBondType() == Bond::DOUBLE; });
|
|
CHECK(doubleBondCount == 2);
|
|
doubleBondCount = std::count_if(
|
|
std::begin(bonds), std::end(bonds),
|
|
[](const auto bond) { return bond->getBondType() == Bond::DOUBLE; });
|
|
CHECK(doubleBondCount == 2);
|
|
doubleBondCount = std::count_if(
|
|
std::ranges::begin(bonds), std::ranges::end(bonds),
|
|
[](const auto bond) { return bond->getBondType() == Bond::DOUBLE; });
|
|
CHECK(doubleBondCount == 2);
|
|
}
|
|
|
|
TEST_CASE("mol.checkedBonds()") {
|
|
const auto m = "OC(=O)C(=O)O"_smiles;
|
|
REQUIRE(m);
|
|
unsigned int doubleBondCount = 0;
|
|
for (const auto bond : m->checkedBonds()) {
|
|
if (bond->getBondType() == Bond::DOUBLE) {
|
|
++doubleBondCount;
|
|
}
|
|
}
|
|
CHECK(doubleBondCount == 2);
|
|
auto bonds = m->checkedBonds();
|
|
auto beg = bonds.begin();
|
|
m->removeBond(1, 2);
|
|
CHECK_THROWS_AS(*beg, std::runtime_error);
|
|
}
|
|
|
|
TEST_CASE("mol.atomNeighbors()") {
|
|
const auto m = "CC(C)CO"_smiles;
|
|
REQUIRE(m);
|
|
unsigned int count = 0;
|
|
for (const auto atom : m->atomNeighbors(m->getAtomWithIdx(1))) {
|
|
count += atom->getDegree();
|
|
}
|
|
CHECK(count == 4);
|
|
for (auto atom : m->atomNeighbors(m->getAtomWithIdx(1))) {
|
|
atom->setAtomicNum(7);
|
|
}
|
|
MolOps::sanitizeMol(*m);
|
|
CHECK(MolToSmiles(*m) == "NC(N)NO");
|
|
}
|
|
|
|
TEST_CASE("mol.checkedAtomNeighbors()") {
|
|
const auto m = "CC(C)CO"_smiles;
|
|
REQUIRE(m);
|
|
unsigned int count = 0;
|
|
for (const auto atom : m->checkedAtomNeighbors(m->getAtomWithIdx(1))) {
|
|
count += atom->getDegree();
|
|
}
|
|
CHECK(count == 4);
|
|
|
|
{
|
|
RWMol m2(*m);
|
|
auto nbrs = m2.checkedAtomNeighbors(m2.getAtomWithIdx(1));
|
|
auto beg = nbrs.begin();
|
|
m2.removeAtom(m2.getAtomWithIdx(2));
|
|
CHECK_THROWS_AS(*beg, std::runtime_error);
|
|
}
|
|
{
|
|
RWMol m2(*m);
|
|
auto nbrs = m2.checkedAtomNeighbors(m2.getAtomWithIdx(1));
|
|
auto beg = nbrs.begin();
|
|
m2.removeBond(1, 2);
|
|
CHECK_THROWS_AS(*beg, std::runtime_error);
|
|
}
|
|
}
|
|
|
|
TEST_CASE("mol.atomBonds()") {
|
|
const auto m = "CC(=C)CO"_smiles;
|
|
REQUIRE(m);
|
|
double count = 0;
|
|
for (const auto bond : m->atomBonds(m->getAtomWithIdx(1))) {
|
|
count += bond->getBondTypeAsDouble();
|
|
}
|
|
CHECK(count == 4);
|
|
for (auto bond : m->atomBonds(m->getAtomWithIdx(1))) {
|
|
bond->setBondType(Bond::BondType::SINGLE);
|
|
}
|
|
MolOps::sanitizeMol(*m);
|
|
CHECK(MolToSmiles(*m) == "CC(C)CO");
|
|
}
|
|
|
|
TEST_CASE("mol.checkedAtomBonds()") {
|
|
const auto m = "CC(=C)CO"_smiles;
|
|
REQUIRE(m);
|
|
double count = 0;
|
|
for (const auto bond : m->checkedAtomBonds(m->getAtomWithIdx(1))) {
|
|
count += bond->getBondTypeAsDouble();
|
|
}
|
|
CHECK(count == 4);
|
|
{
|
|
RWMol m2(*m);
|
|
auto bonds = m2.checkedAtomBonds(m2.getAtomWithIdx(1));
|
|
auto beg = bonds.begin();
|
|
m2.removeBond(1, 2);
|
|
CHECK_THROWS_AS(*beg, std::runtime_error);
|
|
}
|
|
}
|
|
|
|
TEST_CASE("ranges") {
|
|
const auto m = "CC(C)CO"_smiles;
|
|
REQUIRE(m);
|
|
auto atoms = m->atoms();
|
|
auto bonds = m->bonds();
|
|
CHECK(std::ranges::distance(atoms) == 5);
|
|
CHECK(std::ranges::distance(bonds) == 4);
|
|
{
|
|
std::vector<unsigned int> atomDegrees;
|
|
std::ranges::transform(atoms, std::back_inserter(atomDegrees),
|
|
[](const auto atom) { return atom->getDegree(); });
|
|
CHECK(atomDegrees == std::vector<unsigned int>{1, 3, 1, 2, 1});
|
|
}
|
|
{
|
|
std::vector<unsigned int> atomDegrees;
|
|
std::ranges::transform(atoms | std::views::reverse,
|
|
std::back_inserter(atomDegrees),
|
|
[](const auto atom) { return atom->getDegree(); });
|
|
CHECK(atomDegrees == std::vector<unsigned int>{1, 2, 1, 3, 1});
|
|
}
|
|
}
|
|
|
|
std::filesystem::path relative_to_rdbase(
|
|
const std::filesystem::path &relative) {
|
|
char *rdbase = std::getenv("RDBASE");
|
|
if (!rdbase) {
|
|
throw std::runtime_error("RDBASE environment variable not set");
|
|
}
|
|
std::filesystem::path path(rdbase);
|
|
path /= relative;
|
|
return path;
|
|
}
|
|
|
|
#if 0
|
|
TEST_CASE("benchmarking") {
|
|
auto *rdbase = std::getenv("RDBASE");
|
|
REQUIRE(rdbase);
|
|
auto path =
|
|
std::filesystem::path(rdbase) / "Regress/Data/zinc.leads.500.q.smi";
|
|
REQUIRE(std::filesystem::exists(path));
|
|
auto inf = std::ifstream(path);
|
|
REQUIRE(inf);
|
|
std::vector<std::unique_ptr<RWMol>> mols;
|
|
std::string line;
|
|
while (std::getline(inf, line)) {
|
|
mols.push_back(v2::SmilesParse::MolFromSmiles(line));
|
|
REQUIRE(mols.back());
|
|
}
|
|
double accum = 0;
|
|
auto start = std::chrono::high_resolution_clock::now();
|
|
for (unsigned int iter = 0; iter < 100000; ++iter) {
|
|
for (const auto &m : mols) {
|
|
for (const auto atom : m->atoms()) {
|
|
if (atom->getAtomicNum() == 6) {
|
|
accum += atom->getDegree();
|
|
}
|
|
}
|
|
}
|
|
}
|
|
auto end = std::chrono::high_resolution_clock::now();
|
|
auto duration =
|
|
std::chrono::duration_cast<std::chrono::milliseconds>(end - start);
|
|
std::cerr << "Iterating over " << mols.size() << " molecules took "
|
|
<< duration.count() << " ms" << std::endl;
|
|
CHECK(accum > 0);
|
|
accum = 0.0;
|
|
start = std::chrono::high_resolution_clock::now();
|
|
for (unsigned int iter = 0; iter < 100000; ++iter) {
|
|
for (const auto &m : mols) {
|
|
auto atoms = m->atoms();
|
|
std::ranges::for_each(
|
|
atoms | std::views::filter([](const auto atom) {
|
|
return atom->getAtomicNum() == 6;
|
|
}),
|
|
[&accum](const auto atom) { accum += atom->getDegree(); });
|
|
}
|
|
}
|
|
end = std::chrono::high_resolution_clock::now();
|
|
duration = std::chrono::duration_cast<std::chrono::milliseconds>(end - start);
|
|
std::cerr << "Iterating with ranges over " << mols.size()
|
|
<< " molecules took " << duration.count() << " ms" << std::endl;
|
|
CHECK(accum > 0);
|
|
accum = 0.0;
|
|
start = std::chrono::high_resolution_clock::now();
|
|
for (unsigned int iter = 0; iter < 100000; ++iter) {
|
|
for (const auto &m : mols) {
|
|
auto atoms = m->atoms();
|
|
std::ranges::for_each(
|
|
atoms | std::views::filter([](const auto atom) {
|
|
return atom->getAtomicNum() == 6;
|
|
}) | std::views::reverse,
|
|
[&accum](const auto atom) { accum += atom->getDegree(); });
|
|
}
|
|
}
|
|
end = std::chrono::high_resolution_clock::now();
|
|
duration = std::chrono::duration_cast<std::chrono::milliseconds>(end - start);
|
|
std::cerr << "Iterating with ranges in reverse over " << mols.size()
|
|
<< " molecules took " << duration.count() << " ms" << std::endl;
|
|
CHECK(accum > 0);
|
|
accum = 0.0;
|
|
start = std::chrono::high_resolution_clock::now();
|
|
for (unsigned int iter = 0; iter < 100000; ++iter) {
|
|
for (const auto &m : mols) {
|
|
auto atoms = m->atoms();
|
|
std::for_each(atoms.begin(), atoms.end(), [&accum](const auto atom) {
|
|
if (atom->getAtomicNum() == 6) accum += atom->getDegree();
|
|
});
|
|
}
|
|
}
|
|
end = std::chrono::high_resolution_clock::now();
|
|
duration = std::chrono::duration_cast<std::chrono::milliseconds>(end - start);
|
|
std::cerr << "Iterating with for_each over " << mols.size()
|
|
<< " molecules took " << duration.count() << " ms" << std::endl;
|
|
CHECK(accum > 0);
|
|
}
|
|
#endif
|