mirror of
https://github.com/rdkit/rdkit.git
synced 2026-06-03 21:44:30 +08:00
* When building RDKit as a static library, Ricardo found that the externs aren't being resolved correctly causing a number of bad std::any casts. This is his patch (which we apply in the context of the sketcher build) which moves the definitions up from the types.cpp file, and make them static. * Use inline keyword to avoid duplication overhead; this still allows the use of the static keyword to resolve the issue with static libs https://en.cppreference.com/w/cpp/language/inline.html * static inline doesn't work in my static builds; inline only does though * inline constexpr std::string_view * casting * inline-constexpr * add string_view to python converter * propagate string_view after static types --------- Co-authored-by: Ric <ricrogz@gmail.com> Co-authored-by: Greg Landrum <greg.landrum@gmail.com>