pub_soft/abseil-cpp
3
0
Fork 0
mirror of https://github.com/abseil/abseil-cpp.git synced 2026-06-04 12:07:05 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fixes bug so that %v with modifiers doesn't compile. %v is not intended to work with modifiers because the meaning of modifiers is type-dependent and %v is intended to be used in situations where the type is not important. Please continue using if %s if you require format modifiers.

Browse Source 
PiperOrigin-RevId: 472534916
Change-Id: I5838761b2b40cbc4344077f23d44b1e634e5bae3
This commit is contained in:
Abseil Team
2022-09-06 12:58:40 -07:00
committed by Copybara-Service
parent 60499cf45c
commit d3c00b06b3
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
absl/strings/internal/str_format/checker.h
View File

@@ -212,6 +212,10 @@ class ConvParser {
constexpr ConvParser ParseConversion() const {
char first_char = GetChar(format_, 0);
if (first_char == 'v' && *(format_.data() - 1) != '%') {
return SetError(true);
}
if (is_positional_) {
return VerifyPositional({ConsumeFront(format_), arg_position_},
first_char);

2
absl/strings/str_format_test.cc
View File

@@ -291,8 +291,6 @@ TEST_F(FormatEntryPointTest, FormatStreamed) {
TEST_F(FormatEntryPointTest, FormatStreamedWithV) {
EXPECT_EQ("123", StrFormat("%v", FormatStreamed(123)));
EXPECT_EQ(" 123", StrFormat("%5v", FormatStreamed(123)));
EXPECT_EQ("123 ", StrFormat("%-5v", FormatStreamed(123)));
EXPECT_EQ("X", StrFormat("%v", FormatStreamed(streamed_test::X())));
EXPECT_EQ("123", StrFormat("%v", FormatStreamed(StreamFormat("%d", 123))));
}