pub_soft/rdkit
3
0
Fork 0
mirror of https://github.com/rdkit/rdkit.git synced 2026-06-03 21:44:30 +08:00
Code Issues Packages Projects Releases Wiki Activity

Avoid data race warning in SmilesParse.cpp (#2946)

Browse Source 
* Avoid data race in SmilesParse.cpp

Avoid data race in SmilesParse.cpp for SMILES and SMARTS

* More informative comments

* Fix line width
This commit is contained in:
Steven Kearnes
2020-02-11 19:57:45 -08:00
committed by GitHub
parent ced45aceb4
commit 40b9828fd9
1 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
Code/GraphMol/SmilesParse/SmilesParse.cpp
View File

@@ -347,7 +347,13 @@ Bond *SmilesToBond(const std::string &smiles) {
RWMol *SmilesToMol(const std::string &smiles,
const SmilesParserParams &params) {
yysmiles_debug = params.debugParse;
// Calling SmilesToMol in a multithreaded context is generally safe *unless*
// the value of debugParse is different for different threads. The if
// statement below avoids a TSAN warning in the case where multiple threads
// all use the same value for debugParse.
if (yysmiles_debug != params.debugParse) {
yysmiles_debug = params.debugParse;
}
std::string lsmiles, name, cxPart;
preprocessSmiles(smiles, params, lsmiles, name, cxPart);
@@ -412,7 +418,13 @@ Bond *SmartsToBond(const std::string &smiles) {
RWMol *SmartsToMol(const std::string &smarts, int debugParse, bool mergeHs,
std::map<std::string, std::string> *replacements) {
yysmarts_debug = debugParse;
// Calling SmartsToMol in a multithreaded context is generally safe *unless*
// the value of debugParse is different for different threads. The if
// statement below avoids a TSAN warning in the case where multiple threads
// all use the same value for debugParse.
if (yysmarts_debug != debugParse) {
yysmarts_debug = debugParse;
}
// boost::trim_if(sma,boost::is_any_of(" \t\r\n"));
std::string sma;
RWMol *res;