pub_soft/rdkit
3
0
Fork 0
mirror of https://github.com/rdkit/rdkit.git synced 2026-06-03 21:44:30 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fixes #2839 (#2840)

Browse Source 
* - fixes #2839

* clang format
This commit is contained in:
Paolo Tosco
2019-12-11 15:22:53 +00:00
committed by Greg Landrum
parent c01ccb5d85
commit d714f5128f
1 changed files with 15 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
Code/SimDivPickers/testPickers.cpp
View File

@@ -37,19 +37,30 @@ void testGithub2245() {
BOOST_LOG(rdErrorLog) << "Testing github issue 2245: MinMax Diversity picker "
"seeding shows deterministic / non-random behaviour."
<< std::endl;
const int MAX_ALLOWED_FAILURES = 3;
int maxAllowedFailures;
{
RDPickers::MaxMinPicker pkr;
int poolSz = 1000;
auto picks1 = pkr.lazyPick(dist_on_line, poolSz, 10, RDKit::INT_VECT(), -1);
auto picks2 = pkr.lazyPick(dist_on_line, poolSz, 10, RDKit::INT_VECT(), -1);
TEST_ASSERT(picks1 != picks2);
for (maxAllowedFailures = MAX_ALLOWED_FAILURES; maxAllowedFailures;
--maxAllowedFailures) {
auto picks2 =
pkr.lazyPick(dist_on_line, poolSz, 10, RDKit::INT_VECT(), -1);
if (picks1 != picks2) break;
}
TEST_ASSERT(maxAllowedFailures);
}
{ // make sure the default is also random
RDPickers::MaxMinPicker pkr;
int poolSz = 1000;
auto picks1 = pkr.lazyPick(dist_on_line, poolSz, 10);
auto picks2 = pkr.lazyPick(dist_on_line, poolSz, 10);
TEST_ASSERT(picks1 != picks2);
for (maxAllowedFailures = MAX_ALLOWED_FAILURES; maxAllowedFailures;
--maxAllowedFailures) {
auto picks2 = pkr.lazyPick(dist_on_line, poolSz, 10);
if (picks1 != picks2) break;
}
TEST_ASSERT(maxAllowedFailures);
}
{ // and we're still reproducible when we want to be
RDPickers::MaxMinPicker pkr;