Commit Graph

7414 Commits

Author SHA1 Message Date
greg landrum
b598a27802 update release notes, bump version Release_2023_03_3 2023-08-17 05:58:47 +02:00
Paolo Tosco
320746c4b6 avoid leaking memory in case exceptions are thrown while generating FPs (#6630)
Co-authored-by: ptosco <paolo.tosco@novartis.com>
2023-08-17 05:26:41 +02:00
Paolo Tosco
f56db7ea76 allow building the cartridge against PostgreSQL 16 (#6580) 2023-08-17 05:26:19 +02:00
thomp-j
20a759c8b7 Fix vulnerabilities found by fuzzer. (#6579)
* Fix vulnerabilities found by fuzzer.

* Fix Typo in RWMol.cpp

* Update RWMol.cpp

This is an attempt to double check where the test failure is coming from.

* Update RWMol.cpp

Re-adding changes to test tests.
2023-08-17 05:26:00 +02:00
David Cosgrove
c8e6960e39 Add newline to ConstrainedEmbed docstring. (#6596)
* Add newline to ConstrainedEmbed docstring.

* And another unconnected typo.

---------

Co-authored-by: David Cosgrove <david@cozchemix.co.uk>
2023-08-17 05:24:58 +02:00
David Cosgrove
037f949ba4 Check for very close atoms and act accordingly. (#6583)
Co-authored-by: David Cosgrove <david@cozchemix.co.uk>
2023-08-17 05:24:27 +02:00
Ric
53ac881ab6 fix issue in stereo bonds with only implicit H (#6527) 2023-08-17 05:23:53 +02:00
David Cosgrove
5473a4acf1 Don't call bondNonRing with a 2-label double bond. (#6571) 2023-08-17 05:23:32 +02:00
Paolo Tosco
a4081314fa make sure that molecules are shown as images by PandasTools also when DataFrames are truncated horizontally (#6496)
Co-authored-by: Tosco, Paolo <paolo.tosco@novartis.com>
2023-08-17 05:22:48 +02:00
Gareth Jones
8fac924710 Add MolEnumerator to C# (#6542)
* Include enumerator in C# wrappers

* Add MolBundle to C# and create test
2023-08-17 05:22:12 +02:00
Ric
7d824f5af4 Drop the s_m_color_rgb property from MaeWriter (#6511)
* do not write s_m_color_rgb

* Add tests
2023-08-17 05:21:50 +02:00
Paolo Tosco
3efc070fef update avalontools version to incorporate bug fixes (#6513)
* - fixed a crash in Avalon occurring when an atom idx in the bond table is out of bounds
- removed 0-padding ahead of parsing bond line as it is unnecessary and potentially harmful
- forked Avalon so it can be patched more conveniently

* updated the Avalon pre-relase number and updated the checksum

* updated pre-release number and checksum

* moved the Avalon fork under RDKit organization
updated checksum and release

---------

Co-authored-by: Tosco, Paolo <paolo.tosco@novartis.com>
2023-08-17 05:21:31 +02:00
Greg Landrum
5ad8c9c592 update windows DLL CI build config (#6535)
* get the config of the windows DLL builds to match the main windows builds

* bump boost version

* Update vs_build_dll.yml

* sigh...

* disable python on that build

* add back cairo
2023-08-17 05:20:39 +02:00
Eisuke Kawashima
6c3ec0c8a3 refactor(python): replace deprecated unittest methods (#6304)
https://docs.python.org/3/library/unittest.html#deprecated-aliases
2023-08-17 05:20:15 +02:00
Ric
fbf932f628 Fixes #6505 (#6506)
* add test

* add another test

* Add fix
2023-08-17 05:19:49 +02:00
Ric
a0ef35f91b Fixes #6502 (#6503)
* add a test

* fix

* fix rxnTestCatch
2023-08-17 05:19:09 +02:00
Brian Kelley
539feaa734 Minimal update to fix hang in the legacy stereo checker (#6531)
* Minimal update to fix hang in the legacy stereo checker

* a small amount of cleanup and some refactoring

---------

Co-authored-by: Brian Kelley <bkelley@relaytx.com>
Co-authored-by: greg landrum <greg.landrum@gmail.com>
2023-08-17 05:16:33 +02:00
Greg Landrum
b3988f482b Allow systems like C/C=N/[H] to be stereogenic with the new chirality perception (#6473)
This was raised in discussion #6291 here:
https://github.com/rdkit/rdkit/discussions/6291#discussioncomment-6214078
2023-08-17 05:15:38 +02:00
Riccardo Vianello
0147f5b89e unused targetBondLength argument in the CDXML parser's scaleBonds (#6469)
* fix unused targetBondLength argument in scaleBonds

* Replace literal with named constant in call to scaleBonds

* small fix in response to review
2023-08-17 05:12:58 +02:00
Ric
b5f79e12d5 fix path base key (#6485) 2023-08-17 05:12:20 +02:00
Paolo Tosco
aace794a0e - Add appropriate compiler flags such that MinimalLib builds also when using clang version >=15 (#6490)
- Use the nodejs version bundled with emscripten to run tests since the one in Ubuntu is ancient and does not support recent wasm features

Co-authored-by: Tosco, Paolo <paolo.tosco@novartis.com>
2023-08-17 05:06:20 +02:00
Rachel Walker
455bd46000 Fixed tests that weren't being ran in testDepictor.py (#6486) 2023-08-17 05:05:53 +02:00
Paolo Tosco
cbb65f30b3 Fix a few broken docstrings (#6480)
* - Fix a couple of docstrings that were confusing boost::python
- Python keywords should not be used as parameter names

* changes in response to review

* removed two leftover BOOST_PYTHON_FUNCTION_OVERLOADS

---------

Co-authored-by: Tosco, Paolo <paolo.tosco@novartis.com>
2023-08-17 05:05:29 +02:00
Dan N
289f6a56f7 Fix RWMol::addAtom docstring (#6477)
The docstring claimed that it returned the new number of atoms. It actually returns the index of the new atom.

I think it makes more sense to change the documentation than the behavior, because callers are definitely out there using the current behavior.
2023-08-17 05:04:54 +02:00
Brian Kelley
6d8bb99980 pin numpy to 1.24.3 (#6483)
Co-authored-by: Brian Kelley <bkelley@relaytx.com>
2023-08-17 05:04:12 +02:00
Brian Kelley
4acd7b19e1 Fixes #6465 (#6467)
Co-authored-by: Brian Kelley <bkelley@relaytx.com>
2023-08-17 05:03:46 +02:00
Greg Landrum
b0fdf51d4c Fix a couple CDXML issues (#6463)
* Scale bonds, make the Wedge detection cleaner, add more tests

* Readd comment

* Use document bond length

* Adds roundtrip test through a molblock

* a bit of cleanup

* change expected results for a bogus structure
add a non-ambiguous version of it

* fixes #6462

* document incompatibility

---------

Co-authored-by: Brian Kelley <bkelley@relaytx.com>
2023-08-17 05:02:50 +02:00
Greg Landrum
aaf837069b Update ReleaseNotes.md Release_2023_03_2 2023-06-19 06:48:34 +02:00
greg landrum
5d0782672d version bump, release notes 2023-06-17 06:33:17 +02:00
David Cosgrove
14fac96ddd Fix clash of molecule note with molecule. (Github 6397). (#6444)
Co-authored-by: David Cosgrove <david@cozchemix.co.uk>
2023-06-17 06:22:19 +02:00
Ric
ca0ce8310e Fixes Issue 6437 (#6438)
* Add tests

* fix

* rename function
2023-06-17 06:21:28 +02:00
Ric
a2e7ee903f Fixes #6423 (#6424)
* add one test

* try to wedge a second bond

* comments

* review comments
2023-06-17 06:21:00 +02:00
Greg Landrum
9f40c86ba8 Fixes #6432 (#6433) 2023-06-17 06:20:43 +02:00
Paolo Tosco
759910368d fixes #6416 (#6425)
Co-authored-by: Tosco, Paolo <paolo.tosco@novartis.com>
2023-06-17 06:20:28 +02:00
Greg Landrum
285cd5cfd9 Fixes #6316 (#6387) 2023-06-17 06:20:07 +02:00
Greg Landrum
f7f2cfa168 expose some missing CXSmiles flags to python (#6415) 2023-06-17 06:19:44 +02:00
Greg Landrum
d18a987519 Fixes #6315 (#6414) 2023-06-17 06:19:30 +02:00
Timothy Ngotiaoco
dd47ebb8d4 Fixes #6395: Move string index appropriately with molfiles (#6402)
* Fixes #6395: Move string index appropriately with molfiles

This code gives a fix to issue #6395, where properties lines in molfiles might not be processed correctly when dealing with pairs of values.

* Update tests to reflect molblock parsing changes
2023-06-17 06:19:11 +02:00
Greg Landrum
ef74dad126 expose two missing tags to python (#6372) 2023-06-17 06:18:37 +02:00
Juuso Lehtivarjo
02bb2bc672 Add inlines to ForceFieldHelpers header functions (#6356) 2023-06-17 06:18:20 +02:00
Greg Landrum
d12a44e8bf Fix #6336 (#6389)
* fixes #6336

* apply the same fix to MolDraw2DJS (it is a no-op at the moment, but still)
2023-06-17 06:18:02 +02:00
Greg Landrum
9b3075538d Fixes #5145 (#6379) 2023-06-17 06:17:47 +02:00
Greg Landrum
bddcdcd168 Fixes #6172 (#6388) 2023-06-17 06:17:28 +02:00
Ric
0b7c44638b CMAKE_INSTALL_PREFIX not honored during installation of the Python Files (#6371)
* fix path

* really use schema
2023-06-17 06:17:10 +02:00
Paolo Tosco
727d79be51 straightenDepiction should not consider 0-degree rotations as multiples of 60 (#6367)
* straightenDepiction should not consider 0-degree rotations as multiples of 60

* improved JS straightenDepiction test which was a bit silly

* changes in response to review

---------

Co-authored-by: Tosco, Paolo <paolo.tosco@novartis.com>
2023-06-17 06:16:54 +02:00
Paolo Tosco
7db3ce1b4b - when allowRGroups and allowOptionalAttachments are true, bonds connecting R groups to the scaffold should match single or aromatic (#6306)
- added relevant unit tests

Co-authored-by: Tosco, Paolo <paolo.tosco@novartis.com>
2023-06-17 06:16:38 +02:00
Paolo Tosco
08b48ab0b6 take drawOptions into account when exporting structure to xlsx format (#6341)
Co-authored-by: Tosco, Paolo <paolo.tosco@novartis.com>
2023-06-17 06:16:20 +02:00
Riccardo Vianello
f2c51ce9b6 remove the dependency from the deprecated python distutils module (#6339) 2023-06-17 06:16:03 +02:00
Gareth Jones
ab690b0ba1 Fix swig memory leak (#6346) 2023-06-17 06:15:46 +02:00
Vedran Miletić
9b64429664 Added cstdint include (#6338)
Required for uint64_t, fixes compile error
2023-06-17 06:15:31 +02:00