35 Commits

Author SHA1 Message Date
Eisuke Kawashima
e89c9f656a style: apply readability-braces-around-statements (#8136)
Co-authored-by: Eisuke Kawashima <e-kwsm@users.noreply.github.com>
2026-02-09 12:10:50 +01:00
Paolo Tosco
3542b3ffbb Fixes #8569 (#8588) 2025-07-21 23:45:09 -04:00
Ricardo Rodriguez
1b0a20c372 Fix shifting of a potentially negative number (#8014)
* fix shifting a potentially negative number

* add a test

* fix signed comparison
2024-11-24 06:50:16 +01:00
Greg Landrum
da6cd73168 Run clang-format across everything (#7849)
* run clang-format-18 across Code/*.cpp and Code/*.h

* run clang-format-18 across External
2024-09-26 13:39:02 +02:00
Greg Landrum
69b143edd0 Swap from RDUNUSED_PARAM to unnamed parameters (#4433)
* cleanup

* more cleanup
2021-08-24 17:19:46 -04:00
Ric
703fe5a225 Remove boost::foreach from public headers (#3820)
* remove include from headers

* update implementation files

* completely remove BOOST_FOREACH (#7)

* convert those changes to use auto

* get rid of all usage of BOOST_FOREACH

Co-authored-by: Greg Landrum <greg.landrum@gmail.com>
2021-02-17 14:15:48 +01:00
Greg Landrum
45b9aef28b clang-tidy modernize-use-default-member-init and modernize-use-emplace (#3190)
* run clang-tidy with modernize-use-default-member-init

* results from modernize-use-emplace

* one uniform initialization per line
otherwise SWIG is unhappy

Co-authored-by: Brian Kelley <fustigator@gmail.com>
2020-05-28 09:07:58 +02:00
Greg Landrum
9892f4740b remove usage of auto_ptr (#3188) 2020-05-26 08:45:26 -04:00
Eisuke Kawashima
75f03412ef Modernize deprecated header inclusion (#3137) 2020-05-04 10:40:57 +02:00
Greg Landrum
d41752d558 run clang-tidy with readability-braces-around-statements (#2899)
* run clang-tidy with readability-braces-around-statements
clang-format the results
clean up all the parts that clang-tidy-8 broke

* fix problem on windows
2020-01-25 14:19:32 +01:00
Eisuke Kawashima
5cd27a242f Fix typo (#2862)
* Fix typo

* Reflect the comments

* Fix more typos
2019-12-31 06:43:27 +01:00
Eisuke Kawashima
dc7cc84a0c Fix typo [ci skip] 2019-10-17 17:45:50 +09:00
Noel O'Boyle
213b6317f9 Rename the #define _DEBUG to MMPA_DEBUG as _DEBUG is defined bu MSVC whenever a Debug build is specifed, but that is not the intention here. (#2140) 2018-11-15 07:47:13 +01:00
Greg Landrum
ba12d98ad0 Removes ATOM/BOND_SPTR in boost::graph in favor of raw pointers (#1713)
* Removes ATOM/BOND_SPTR in boost::graph in favor of raw pointers

* Actually delete atoms and bonds...

* RWMol::clear now calls destroy to handle atom/bond deletion

* Changes broken Atom lookup for windows/gcc

* Adds tests for running with valgrind

* Adds test designed for valgrind and molecule deletions

* Removes RNG, actually tests bond deletions

* update swig wrappers

* deal with most recent changes on the main branch
2018-01-07 14:19:47 -05:00
Greg Landrum
1efa8e696e another clang-format run 2017-10-12 06:42:15 +02:00
Greg Landrum
f94e277856 another pass of clang modernize 2017-10-12 06:35:51 +02:00
Greg Landrum
67bc7a647c merge on master; modernization needs to be repeated 2017-09-05 17:09:50 +02:00
Brian Kelley
7c704c14de Adds canonicalization of atom maps (#1521)
* Adds canonicalization of atom maps

* Removes debugging statments and commented out code

* Fixed bad mapping of mmps with no cores (1-cut), remove sanitization
2017-08-12 05:36:09 +02:00
Greg Landrum
c234935b0e fix a typo 2017-04-23 05:46:54 +02:00
Greg Landrum
f6ced134f0 a number of other small changes from manually reviewing the PR 2017-04-22 17:24:57 +02:00
Greg Landrum
915cf08faa run clang-format with c++-11 style over that 2017-04-22 17:19:10 +02:00
Greg Landrum
7c0bb0b743 clang-tidy output 2017-04-22 17:09:24 +02:00
Brian Kelley
ea8d7e68f9 Dev/rdmmpa api update (#1291)
* Adds FragmentMol with minCuts specified

* Adds ability to cut by bond indices as opposed to smarts patterns

* Fixed API (remove maxBondCuts when bonds are sent in)

* Adds bond api test

* Fixes docs

* Small doc change

* Removes cstdint

* Adds ValueError minor bond retrieval optimization

* Removes fragMolHelper4

* Tests ValueError

* py3 fix
2017-02-27 17:08:01 +01:00
Greg Landrum
adbfb5bd8b Fixes #1044 (#1077) 2016-09-23 04:57:27 +02:00
Greg Landrum
cf7ceab383 remove wave of warnings 2016-03-30 13:09:59 +02:00
Riccardo Vianello
d1f206e923 replace std::map::at with std::map::operator[] 2016-01-12 20:53:22 +01:00
Greg Landrum
e08e0d16d8 first pass, using google style 2015-11-14 14:58:11 +01:00
Brian Kelley
39b69b3600 Adds maxCutBonds to MMPA interface to limit combinitorial explosion 2015-11-11 08:02:11 -05:00
Brian Kelley
fe42eb87ef Fixes a memory leak in fragmentMol 2015-11-11 07:23:40 -05:00
Greg Landrum
11f5df5746 Fixes #655 2015-11-02 04:36:50 +01:00
Alexander Savelyev
5be9540e39 mmpa: fix bug with num_of_cuts > 2 case 2015-08-14 14:57:42 +03:00
Alexander Savelyev
18e15956aa fix MMPA bugs for some tests 2015-08-04 14:49:51 +03:00
Alexander Savelyev
e60c4c2b8d mmpa: remove boost_regex dependency at all. Add new test references 2015-06-19 13:55:40 +03:00
Alexander Savelyev
31786455d7 updates to mmpa. reduce number of smiles parsing 2015-06-03 12:14:38 +03:00
Alexander Savelyev
e16d51ed8a mmpa first version was added 2015-05-08 16:47:55 +03:00