mirror of
https://github.com/rdkit/rdkit.git
synced 2026-06-03 21:44:30 +08:00
* SHARED-12256: Add test and change function.
* SHARED-12256: Update to only wrapping changes.
* SHARED-12256: Parameterize tests.
* SHARED-12256: GetPropIfPresent changes.
* Revert "SHARED-12256: GetPropIfPresent changes."
This reverts commit f598f8c161.
* SHARED-12256: Make default the keyword in the boost wrappings.
* SHARED-12256: Overload function instead of using a sentinel.
* SHARED-12256: Extend GetProp changes.
* SHARED-12256: Add entry point for tests and fix tests.
411 lines
14 KiB
C++
411 lines
14 KiB
C++
// Copyright (c) 2015-2018, Novartis Institutes for BioMedical Research Inc.
|
|
// All rights reserved.
|
|
//
|
|
// Redistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are
|
|
// met:
|
|
//
|
|
// * Redistributions of source code must retain the above copyright
|
|
// notice, this list of conditions and the following disclaimer.
|
|
// * Redistributions in binary form must reproduce the above
|
|
// copyright notice, this list of conditions and the following
|
|
// disclaimer in the documentation and/or other materials provided
|
|
// with the distribution.
|
|
// * Neither the name of Novartis Institutes for BioMedical Research Inc.
|
|
// nor the names of its contributors may be used to endorse or promote
|
|
// products derived from this software without specific prior written
|
|
// permission.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
//
|
|
#ifndef RD_WRAPPED_PROPS_H
|
|
#define RD_WRAPPED_PROPS_H
|
|
|
|
#include <RDBoost/python.h>
|
|
#include <RDBoost/pyint_api.h>
|
|
#include <RDBoost/Wrap.h>
|
|
#include <RDGeneral/Dict.h>
|
|
#include <algorithm>
|
|
#include <boost/algorithm/string.hpp>
|
|
|
|
namespace RDKit {
|
|
|
|
template <class T>
|
|
inline const char *GetTypeName() {
|
|
// PRECONDITION(0, "Unregistered c++ type");
|
|
return "unregistered C++ type";
|
|
}
|
|
|
|
template <>
|
|
inline const char *GetTypeName<double>() {
|
|
return "a double value";
|
|
}
|
|
template <>
|
|
inline const char *GetTypeName<int>() {
|
|
return "an integer value";
|
|
}
|
|
template <>
|
|
inline const char *GetTypeName<unsigned int>() {
|
|
return "an unsigned integer value";
|
|
}
|
|
template <>
|
|
inline const char *GetTypeName<bool>() {
|
|
return "a True or False value";
|
|
}
|
|
|
|
template <class T, class U>
|
|
bool AddToDict(const U &ob, boost::python::dict &dict, const std::string &key) {
|
|
T res;
|
|
try {
|
|
if (ob.getPropIfPresent(key, res)) {
|
|
dict[key] = res;
|
|
}
|
|
} catch (std::bad_any_cast &) {
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
const std::string getPropsAsDictDocString =
|
|
"Returns a dictionary populated with properties.\n"
|
|
"When possible, string values will be converted to integers or doubles (trimming if necessary)\n"
|
|
|
|
" n.b. Some properties are not able to be converted to python "
|
|
"types.\n\n"
|
|
" ARGUMENTS:\n"
|
|
" - includePrivate: (optional) toggles inclusion of private "
|
|
"properties in the result set.\n"
|
|
" Defaults to False.\n"
|
|
" - includeComputed: (optional) toggles inclusion of computed "
|
|
"properties in the result set.\n"
|
|
" Defaults to False.\n\n"
|
|
" - autoConvertStrings: (optional) toggles automatic conversion of string "
|
|
"properties to integers or doubles.\n"
|
|
" Defaults to True.\n\n"
|
|
" RETURNS: a dictionary\n";
|
|
|
|
template <class T>
|
|
boost::python::dict GetPropsAsDict(const T &obj, bool includePrivate,
|
|
bool includeComputed,
|
|
bool autoConvertStrings = true) {
|
|
boost::python::dict dict;
|
|
const auto &rd_dict = obj.getDict();
|
|
|
|
STR_VECT keys = obj.getPropList(includePrivate, includeComputed);
|
|
for (const auto &rdvalue : rd_dict) {
|
|
if (std::find(keys.begin(), keys.end(), rdvalue.key) == keys.end()) {
|
|
continue;
|
|
}
|
|
try {
|
|
const auto tag = rdvalue.val.getTag();
|
|
switch (tag) {
|
|
case RDTypeTag::IntTag:
|
|
dict[rdvalue.key] = from_rdvalue<int>(rdvalue.val);
|
|
break;
|
|
case RDTypeTag::DoubleTag:
|
|
dict[rdvalue.key] = from_rdvalue<double>(rdvalue.val);
|
|
break;
|
|
case RDTypeTag::StringTag: {
|
|
auto value = from_rdvalue<std::string>(rdvalue.val);
|
|
if (autoConvertStrings) {
|
|
auto trimVal = value;
|
|
boost::trim(trimVal);
|
|
// Auto convert strings to ints and double if possible
|
|
int ivalue;
|
|
if (boost::conversion::try_lexical_convert(trimVal, ivalue)) {
|
|
dict[rdvalue.key] = ivalue;
|
|
break;
|
|
}
|
|
double dvalue;
|
|
if (boost::conversion::try_lexical_convert(trimVal, dvalue)) {
|
|
dict[rdvalue.key] = dvalue;
|
|
break;
|
|
}
|
|
}
|
|
dict[rdvalue.key] = value;
|
|
} break;
|
|
case RDTypeTag::FloatTag:
|
|
dict[rdvalue.key] = from_rdvalue<float>(rdvalue.val);
|
|
break;
|
|
case RDTypeTag::BoolTag:
|
|
dict[rdvalue.key] = from_rdvalue<bool>(rdvalue.val);
|
|
break;
|
|
case RDTypeTag::UnsignedIntTag:
|
|
dict[rdvalue.key] = from_rdvalue<unsigned int>(rdvalue.val);
|
|
break;
|
|
case RDTypeTag::AnyTag:
|
|
// we skip these for now
|
|
break;
|
|
case RDTypeTag::VecDoubleTag:
|
|
dict[rdvalue.key] = from_rdvalue<std::vector<double>>(rdvalue.val);
|
|
break;
|
|
case RDTypeTag::VecFloatTag:
|
|
dict[rdvalue.key] = from_rdvalue<std::vector<float>>(rdvalue.val);
|
|
break;
|
|
case RDTypeTag::VecIntTag:
|
|
dict[rdvalue.key] = from_rdvalue<std::vector<int>>(rdvalue.val);
|
|
break;
|
|
case RDTypeTag::VecUnsignedIntTag:
|
|
dict[rdvalue.key] =
|
|
from_rdvalue<std::vector<unsigned int>>(rdvalue.val);
|
|
break;
|
|
case RDTypeTag::VecStringTag:
|
|
dict[rdvalue.key] =
|
|
from_rdvalue<std::vector<std::string>>(rdvalue.val);
|
|
break;
|
|
case RDTypeTag::EmptyTag:
|
|
dict[rdvalue.key] = boost::python::object();
|
|
break;
|
|
default:
|
|
std::string message =
|
|
std::string(
|
|
"Unhandled property type encountered for property: ") +
|
|
rdvalue.key;
|
|
UNDER_CONSTRUCTION(message.c_str());
|
|
}
|
|
} catch (std::bad_any_cast &) {
|
|
// C++ datatypes can really be anything, this just captures mislabelled
|
|
// data, it really shouldn't happen
|
|
std::string message =
|
|
std::string("Unhandled type conversion occured for property: ") +
|
|
rdvalue.key;
|
|
UNDER_CONSTRUCTION(message.c_str());
|
|
}
|
|
}
|
|
return dict;
|
|
}
|
|
|
|
static PyObject *rawPy(python::object &&pyobj) {
|
|
Py_INCREF(pyobj.ptr());
|
|
return pyobj.ptr();
|
|
}
|
|
|
|
template <class T>
|
|
PyObject *rawPy(T &&thing) {
|
|
return rawPy(python::object(thing));
|
|
}
|
|
|
|
template <class RDOb, class T>
|
|
PyObject *GetProp(const RDOb *ob, const std::string &key) {
|
|
T res;
|
|
try {
|
|
if (!ob->getPropIfPresent(key, res)) {
|
|
PyErr_SetString(PyExc_KeyError, key.c_str());
|
|
return nullptr;
|
|
}
|
|
} catch (const std::exception &e) {
|
|
auto msg = std::string("key `") + key + "` exists but does not result in " +
|
|
GetTypeName<T>() + " reason: " + e.what();
|
|
PyErr_SetString(PyExc_ValueError, msg.c_str());
|
|
return nullptr;
|
|
}
|
|
return rawPy(std::move(res));
|
|
}
|
|
|
|
template <class RDOb, class T>
|
|
PyObject *GetPropOrDefault(const RDOb *ob, const std::string &key,
|
|
T default_val) {
|
|
T res;
|
|
try {
|
|
if (!ob->getPropIfPresent(key, res)) {
|
|
return rawPy(std::move(default_val));
|
|
}
|
|
} catch (const std::exception &e) {
|
|
auto msg = std::string("key `") + key + "` exists but does not result in " +
|
|
GetTypeName<T>() + " reason: " + e.what();
|
|
PyErr_SetString(PyExc_ValueError, msg.c_str());
|
|
return nullptr;
|
|
}
|
|
return rawPy(std::move(res));
|
|
}
|
|
|
|
template <class RDOb>
|
|
python::object autoConvertString(const RDOb *ob, const std::string &key) {
|
|
int ivalue;
|
|
double dvalue;
|
|
std::string svalue;
|
|
|
|
try {
|
|
if (ob->getPropIfPresent(key, ivalue)) {
|
|
return python::object(ivalue);
|
|
}
|
|
} catch (const std::bad_any_cast &) {}
|
|
|
|
try {
|
|
if (ob->getPropIfPresent(key, dvalue)) {
|
|
return python::object(dvalue);
|
|
}
|
|
} catch (const std::bad_any_cast &) {}
|
|
|
|
if (ob->getPropIfPresent(key, svalue)) {
|
|
return python::object(svalue);
|
|
}
|
|
|
|
return python::object();
|
|
}
|
|
|
|
// nullptr = raise KeyError; non-null = return *default_val_ptr as fallback
|
|
template <class RDOb>
|
|
PyObject *GetPyPropImpl(const RDOb *obj, const std::string &key,
|
|
bool autoConvert, python::object *default_val_ptr) {
|
|
python::object pobj;
|
|
if (!autoConvert) {
|
|
std::string res;
|
|
if (obj->getPropIfPresent(key, res)) {
|
|
return rawPy(res);
|
|
} else if (default_val_ptr && !obj->hasProp(key)) {
|
|
return rawPy(*default_val_ptr);
|
|
} else {
|
|
PyErr_SetString(PyExc_KeyError, key.c_str());
|
|
return nullptr;
|
|
}
|
|
} else {
|
|
const auto &rd_dict = obj->getDict();
|
|
for (const auto &rdvalue : rd_dict) {
|
|
if (rdvalue.key == key) {
|
|
try {
|
|
const auto tag = rdvalue.val.getTag();
|
|
switch (tag) {
|
|
case RDTypeTag::IntTag:
|
|
return rawPy(from_rdvalue<int>(rdvalue.val));
|
|
|
|
case RDTypeTag::DoubleTag:
|
|
return rawPy(from_rdvalue<double>(rdvalue.val));
|
|
|
|
case RDTypeTag::StringTag:
|
|
if (autoConvert) {
|
|
pobj = autoConvertString(obj, rdvalue.key);
|
|
return rawPy(pobj);
|
|
}
|
|
return rawPy(from_rdvalue<std::string>(rdvalue.val));
|
|
case RDTypeTag::FloatTag:
|
|
return rawPy(from_rdvalue<float>(rdvalue.val));
|
|
break;
|
|
case RDTypeTag::BoolTag:
|
|
return rawPy(from_rdvalue<bool>(rdvalue.val));
|
|
break;
|
|
case RDTypeTag::UnsignedIntTag:
|
|
return rawPy(from_rdvalue<unsigned int>(rdvalue.val));
|
|
break;
|
|
case RDTypeTag::AnyTag:
|
|
// we skip these for now
|
|
break;
|
|
case RDTypeTag::VecDoubleTag:
|
|
return rawPy(from_rdvalue<std::vector<double>>(rdvalue.val));
|
|
break;
|
|
case RDTypeTag::VecFloatTag:
|
|
return rawPy(from_rdvalue<std::vector<float>>(rdvalue.val));
|
|
break;
|
|
case RDTypeTag::VecIntTag:
|
|
return rawPy(from_rdvalue<std::vector<int>>(rdvalue.val));
|
|
break;
|
|
case RDTypeTag::VecUnsignedIntTag:
|
|
return rawPy(
|
|
from_rdvalue<std::vector<unsigned int>>(rdvalue.val));
|
|
break;
|
|
case RDTypeTag::VecStringTag:
|
|
return rawPy(from_rdvalue<std::vector<std::string>>(rdvalue.val));
|
|
break;
|
|
case RDTypeTag::EmptyTag:
|
|
return Py_None;
|
|
break;
|
|
default:
|
|
std::string message =
|
|
std::string(
|
|
"Unhandled property type encountered for property: ") +
|
|
rdvalue.key;
|
|
UNDER_CONSTRUCTION(message.c_str());
|
|
return Py_None;
|
|
}
|
|
} catch (std::bad_any_cast &) {
|
|
// C++ datatypes can really be anything, this just captures
|
|
// mislabelled data, it really shouldn't happen
|
|
std::string message =
|
|
std::string("Unhandled type conversion occured for property: ") +
|
|
rdvalue.key;
|
|
UNDER_CONSTRUCTION(message.c_str());
|
|
return Py_None;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
// We reach here only when autoConvert=true and the key was not returned by
|
|
// the loop above. Two cases: (a) key not in dict at all — hasProp is false,
|
|
// return default; (b) key exists as AnyTag (skipped by the loop) — hasProp
|
|
// is true, raise KeyError as the property cannot be converted.
|
|
if (default_val_ptr && !obj->hasProp(key)) {
|
|
return rawPy(*default_val_ptr);
|
|
}
|
|
PyErr_SetString(PyExc_KeyError, key.c_str());
|
|
return nullptr;
|
|
}
|
|
|
|
template <class RDOb>
|
|
PyObject *GetPyProp(const RDOb *obj, const std::string &key, bool autoConvert) {
|
|
return GetPyPropImpl(obj, key, autoConvert, nullptr);
|
|
}
|
|
|
|
template <class RDOb>
|
|
PyObject *GetPyPropOrDefault(const RDOb *obj, const std::string &key,
|
|
bool autoConvert, python::object default_val) {
|
|
return GetPyPropImpl(obj, key, autoConvert, &default_val);
|
|
}
|
|
|
|
// Return policy for functions that directly return a PyObject* and
|
|
// are fully responsible for setting the Python error state.
|
|
struct return_pyobject_passthrough {
|
|
template <class T>
|
|
struct apply {
|
|
struct type {
|
|
static bool convertible() { return true; }
|
|
|
|
PyObject *operator()(PyObject *inner) const { return inner; }
|
|
#ifndef BOOST_PYTHON_NO_PY_SIGNATURES
|
|
PyTypeObject const *get_pytype() const {
|
|
return boost::python::converter::expected_pytype_for_arg<
|
|
T>::get_pytype();
|
|
}
|
|
#endif
|
|
};
|
|
};
|
|
};
|
|
|
|
template <class RDOb>
|
|
int MolHasProp(const RDOb &mol, const std::string &key) {
|
|
int res = mol.hasProp(key);
|
|
// std::cout << "key: " << key << ": " << res << std::endl;
|
|
return res;
|
|
}
|
|
|
|
template <class RDOb, class T>
|
|
void MolSetProp(const RDOb &mol, const std::string &key, const T &val,
|
|
bool computed = false) {
|
|
mol.setProp(key, val, computed);
|
|
}
|
|
|
|
template <class RDOb>
|
|
void MolClearProp(const RDOb &mol, const std::string &key) {
|
|
if (!mol.hasProp(key)) {
|
|
return;
|
|
}
|
|
mol.clearProp(key);
|
|
}
|
|
|
|
template <class RDOb>
|
|
void MolClearComputedProps(const RDOb &mol) {
|
|
mol.clearComputedProps();
|
|
}
|
|
} // namespace RDKit
|
|
|
|
#endif
|