pub_soft/abseil-cpp
3
0
Fork 0
mirror of https://github.com/abseil/abseil-cpp.git synced 2026-06-04 20:14:23 +08:00
Code Issues Packages Projects Releases Wiki Activity

Refactor CombinePiecewiseBuffer test case to (a) call PiecewiseChunkSize() to get the chunk size and (b) use ASSERT for expectation in a loop.

Browse Source 
PiperOrigin-RevId: 744010211
Change-Id: Ic3ebae85b772e66a733e5ad56614d0644412f7d3
This commit is contained in:
Evan Brown
2025-04-04 11:21:59 -07:00
committed by Copybara-Service
parent 7dca9dbe0c
commit b011118c1c
1 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
absl/hash/hash_test.cc
View File

@@ -708,7 +708,9 @@ TEST(HashValueTest, CombinePiecewiseBuffer) {
//
// This test is run on a buffer that is a multiple of the stride size, and one
// that isn't.
for (size_t big_buffer_size : {1024u * 2 + 512u, 1024u * 3}) {
const size_t kChunkSize = absl::hash_internal::PiecewiseChunkSize();
for (size_t big_buffer_size :
{2 * kChunkSize + kChunkSize / 2, 3 * kChunkSize}) {
SCOPED_TRACE(big_buffer_size);
std::string big_buffer;
for (size_t i = 0; i < big_buffer_size; ++i) {
@@ -718,8 +720,15 @@ TEST(HashValueTest, CombinePiecewiseBuffer) {
auto big_buffer_hash = hash(PiecewiseHashTester(big_buffer));
const int possible_breaks = 9;
size_t breaks[possible_breaks] = {1, 512, 1023, 1024, 1025,
1536, 2047, 2048, 2049};
size_t breaks[possible_breaks] = {1,
kChunkSize / 2,
kChunkSize - 1,
kChunkSize,
kChunkSize + 1,
kChunkSize + kChunkSize / 2,
2 * kChunkSize - 1,
2 * kChunkSize,
2 * kChunkSize + 1};
for (unsigned test_mask = 0; test_mask < (1u << possible_breaks);
++test_mask) {
SCOPED_TRACE(test_mask);
@@ -729,7 +738,7 @@ TEST(HashValueTest, CombinePiecewiseBuffer) {
break_locations.insert(breaks[j]);
}
}
EXPECT_EQ(
ASSERT_EQ(
hash(PiecewiseHashTester(big_buffer, std::move(break_locations))),
big_buffer_hash);
}